GitLab

BUG=339912

Review URL: https://codereview.chromium.org/1036913002

Cr-Commit-Position: refs/heads/master@{#322259}

The histogram was used for the 64bit transition. Is it no longer useful.

BUG=

Review URL: https://codereview.chromium.org/1030253003

Cr-Commit-Position: refs/heads/master@{#322258}

To narrow down LowBox/AppContainer launch issue reporting UMA on specific create process error code.

BUG=468922
R=jschuh@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1020863012

Cr-Commit-Position: refs/heads/master@{#322257}

The previous fix to detecting page transition types was wrong, but close
enough to correct that it seemed right when I tested it.  I realized it was
wrong when reviewing some other history-processing code today.

(The only places where it was wrong were places that had the same bits set
or more as PAGE_TRANSITION_TYPED: i.e., PAGE_TRANSITION_AUTO_SUBFRAME,
PAGE_TRANSITION_GENERATED, PAGE_TRANSITION_FORM_SUBMIT, and
PAGE_TRANSITION_KEYWORD.  None of these other page transition types
typically make it into HQP in-memory index, which is I why I didn't notice
the effect of my incorrect fix.)

BUG=369989

Review URL: https://codereview.chromium.org/1030913002

Cr-Commit-Position: refs/heads/master@{#322256}

This simplifies the python closure compiler infrastructure.

R=rothwell@google.com

Review URL: https://codereview.chromium.org/476453002

Cr-Commit-Position: refs/heads/master@{#322255}

For testing background usage of Chrome on android devices.

BUG=

Review URL: https://codereview.chromium.org/1004833003

Cr-Commit-Position: refs/heads/master@{#322254}

Experiments should be set up/defined on the Finch server, not in Chromium
code. Remove the definition.

BUG=441377

Review URL: https://codereview.chromium.org/1024493003

Cr-Commit-Position: refs/heads/master@{#322253}

Also add a new, prettier checkmark asset. (It doesn't appear this is actually used anywhere else, so no other UIs should be affected.)

BUG=none

Review URL: https://codereview.chromium.org/1005603003

Cr-Commit-Position: refs/heads/master@{#322252}

INTERNAL => try again
anything else => permanent failure

BUG=463291

Review URL: https://codereview.chromium.org/1028313006

Cr-Commit-Position: refs/heads/master@{#322251}

BUG=466848

Review URL: https://codereview.chromium.org/1016473003

Cr-Commit-Position: refs/heads/master@{#322250}

BUG=

Review URL: https://codereview.chromium.org/1032553008

Cr-Commit-Position: refs/heads/master@{#322249}

This does not move all of the previously static methods into the interface yet, just those used by WebEncryptedMediaClientImpl. The rest can be migrated as necessary.

This CL also includes a fixes for 457384 and 374751 (containers and codecs must match media type), because it was convenient along with the new interface for checking codec support.

BUG=468912,457384,374751

Review URL: https://codereview.chromium.org/1023863002

Cr-Commit-Position: refs/heads/master@{#322248}

Previously, webpagereplay stores all the stdout & stder of the wpr subprocess to
a fix log file path location. It then parses the log lines to get replay server
port  assignment. When there are multiple telemetry processes running in parallel,
this cause a concurrency problem.

This patch addresses the issue by create a temp location for the log file path.
This is to make sure that different telemetry processes will write & read to different
log files.

BUG=469296

Review URL: https://codereview.chromium.org/1025553008

Cr-Commit-Position: refs/heads/master@{#322247}

To facilitate landing actual QuicServer support in Chromium using
Chromium's MessageLoop and friends.

Merge internal change: 89526581

Review URL: https://codereview.chromium.org/1006193003

Cr-Commit-Position: refs/heads/master@{#322246}

This is a retry CL after making these tests ChromeOS-only tests and disabling them in the official build.
Original CL: https://codereview.chromium.org/1026513005/

In order to avoid future regressions on ChromeOS.

BUG=469235
TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.*

Review URL: https://codereview.chromium.org/1005093004

Cr-Commit-Position: refs/heads/master@{#322245}

This class write the
Net.SocketIdleTimeBeforeNextUse_ReusedSocket
Net.SocketIdleTimeBeforeNextUse_UnusedSocket
Net.SocketInitErrorCodes
Net.SocketRequestTime
Net.SocketType
histograms.

This histograms are all unowned, and have a large cumulative load on user bandwidth and internal google servers.
Are these histograms used at all? It appears they have not been used for some time (based on lack of ownership)

BUG=469288

Review URL: https://codereview.chromium.org/1027693004

Cr-Commit-Position: refs/heads/master@{#322244}

If you are not signed into sync or have unchecked "Autofill" then the option should be hidden.

BUG=468987

Review URL: https://codereview.chromium.org/1020303007

Cr-Commit-Position: refs/heads/master@{#322243}

BUG=NONE
TEST=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/1006373006

Cr-Commit-Position: refs/heads/master@{#322242}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aa09e3e..862b1f1

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1034763003

Cr-Commit-Position: refs/heads/master@{#322241}

BUG=466848

Review URL: https://codereview.chromium.org/1004933003

Cr-Commit-Position: refs/heads/master@{#322240}

Review URL: https://codereview.chromium.org/1032913002

Cr-Commit-Position: refs/heads/master@{#322239}

BUG=466848

Review URL: https://codereview.chromium.org/1032553009

Cr-Commit-Position: refs/heads/master@{#322238}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c5443d75..b09c6a7d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1005693012

Cr-Commit-Position: refs/heads/master@{#322237}

Clean up ClearObsoleteWallpaperPrefs() function. It was used to migrate wallpaper data from a very old version of Chrome (probably M32). It should be safe to remove this function now.

BUG=171694

Review URL: https://codereview.chromium.org/1003363008

Cr-Commit-Position: refs/heads/master@{#322236}

Follow-up to https://codereview.chromium.org/859213006. The DVLOG lines are
unnecessary and CertificateSelected implicitly calls StopObserving.

BUG=none

Review URL: https://codereview.chromium.org/1030233002

Cr-Commit-Position: refs/heads/master@{#322235}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e523d4f..114912d

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1015533017

Cr-Commit-Position: refs/heads/master@{#322234}

Both task_manager_view and task_manager_cocoa define ShowTaskManager(Browser*).
http://crrev.com/987483003 mistakenly causes both to get linked
when building for Mac. This patch undoes that by moving the task
manager files to Cocoa and Views sources. They are no longer inside
enabled_task_manager condition check, but they are still excluded
from Android this way.

BUG=425229

Review URL: https://codereview.chromium.org/1003323005

Cr-Commit-Position: refs/heads/master@{#322233}

Revert of Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1025003002/)

Reason for revert:
Relanding libjingle.gyp update that removes libpeer_target_type references.  The issue on Android has been fixed.

Original issue's description:
> Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1008023002/)
>
> Reason for revert:
> See if this caused errors on Android.
>
> Original issue's description:
> > Clean up libjingle.gyp and remove references to libpeer_target_type.
> > This variable isn't supported any longer.
> >
> > BUG=446865
> >
> > Committed: https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88
> > Cr-Commit-Position: refs/heads/master@{#321371}
>
> TBR=kjellander@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=446865
>
> Committed: https://crrev.com/5e83cd0937a248f3d544800797b0dcbcba6eb13b
> Cr-Commit-Position: refs/heads/master@{#321614}

TBR=kjellander@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446865

Review URL: https://codereview.chromium.org/1007063003

Cr-Commit-Position: refs/heads/master@{#322232}

This saves a cast and makes this code
-fsanitize=cfi-unrelated-cast clean.

BUG=457523
R=danakj@chromium.org,weiliangc@chromium.org

Review URL: https://codereview.chromium.org/1032803002

Cr-Commit-Position: refs/heads/master@{#322231}

BUG=449582
TEST=manual

Review URL: https://codereview.chromium.org/1018523007

Cr-Commit-Position: refs/heads/master@{#322230}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7dd2b95..aa09e3e

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1034713003

Cr-Commit-Position: refs/heads/master@{#322229}

This change was reverted in r322170 due to WebView breakage. The
ApplicationStatus dependency has been made optional, allowing
WebView to opt-out of its use.

Original description: ----------------------------

Currently, when an activity is stopped, we explicitly hide the
foreground Tab. This is problematic, as current hiding semantics
might clear the visual front buffer before the window is hidden.
This in turn causes an unpleasant flickering during activity
transitions, e.g., when backgrounding Chrome or locking the screen.

Wire Activity onPause/onResume notifications to WindowAndroidObservers,
allowing the foreground tab to preserve its front buffer while hiding
its web content. If the tab is explicitly hidden, or the root window
is lost, the front buffer will be cleared as usual.

BUG=462752,434401

Review URL: https://codereview.chromium.org/1001573003

Cr-Commit-Position: refs/heads/master@{#322228}

BUG=470158

Review URL: https://codereview.chromium.org/1031213002

Cr-Commit-Position: refs/heads/master@{#322227}

It is more traditional (and recommended) to have GN targets closer to the source
files it builds.

BUG=432959
TEST=gn gen out-gn && ninja -C out-gn compositor_model_bench
R=sievers@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/1032193002

Cr-Commit-Position: refs/heads/master@{#322226}

Proposed fix is to discard all unsupported representations (Read fractional scales) in the Extension icon image when
the icon is loaded. This ensures that stale caches are invalidated and the correct icons are loaded when the cache is regenerated.

BUG=461958

Review URL: https://codereview.chromium.org/1025513004

Cr-Commit-Position: refs/heads/master@{#322225}

Too flaky.

BUG=468980
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/1034813002

Cr-Commit-Position: refs/heads/master@{#322224}

- Update ProfileAuthData to transfer cookie from sign-in webview;
- Passing back usingSAML flag for auth code authentication and use
  it to set has_auth_cookie flag when SAML is used;
- Update UserCloudPolicyManagerChromeOS to fetch initial policy from
  correct auth request context;
- Enable SAMLPolicyTest for WebView;

BUG=461505

Review URL: https://codereview.chromium.org/1021383002

Cr-Commit-Position: refs/heads/master@{#322223}

This re-enables spellcheck feedback by reverting commit
http://crrev.com/60f701a, because the server is ready to process the
feedback.

BUG=466794

Review URL: https://codereview.chromium.org/1006953003

Cr-Commit-Position: refs/heads/master@{#322222}

BUG=410493

Review URL: https://codereview.chromium.org/993813002

Cr-Commit-Position: refs/heads/master@{#322221}

This makes the CullSet check into an early out instead of
an if-block wrapping a whole function.

It also moves the |visible_| early out to the same place
from PaintCommon(). This hints at combining Paint() and
PaintCommont().

This also moves the |visible_| early out to the other caller
of PaintCommon() which is OnPaintLayer(), and can early
out before doing the solid color clear.

BUG=466426

Review URL: https://codereview.chromium.org/1037513002

Cr-Commit-Position: refs/heads/master@{#322220}