- 20 Mar, 2019 40 commits
-
-
Kent Tamura authored
Also, fix the bug field. NOTRY=true TBR=bsheedy@chromium.org Bug: 941565 Change-Id: Id6f278cc9ca94e906a80949ae5c8d702dfeff0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531899Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#642442}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/8aaab78efcac..bcb4e505d6ff $ git log 8aaab78ef..bcb4e505d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 ariza cff2 subset fuzzer issues (#1619) Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: Ica00c00683c64d43ef4d24387c3ffa4d47dffa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532000Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#642441}
-
Dominik Röttsches authored
Tbr: gab@chromium.org Change-Id: I9b3a7f300c90592ca8a57d13da5ace5b553490fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530776Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#642440}
-
Hayato Ito authored
OlderSiblingShadowRoot no longer makes sense here because it is for multiple shadow roots. Change-Id: I6f3f1404a0b0bf48a548ea8a021871506f591ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531923 Auto-Submit: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#642439}
-
arthursonzogni authored
|opener_feature_state_| was defined in both: * blink::WebLocalFrame * blink::WebRemote This CL moves it into * blink::Frame. This is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1523090 Bug: 936696 Change-Id: I9a55405a211d92f3fe750edf291999f38f1ea7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526279Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642438}
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I59d38e4112def9c1e80ee4c82471c1ca03051e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520466 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642437}
-
David Jean authored
We have a couple of instances when presenting a view controller in isolation, it shows an X at the top left, but should be saying Cancel: Bookmarks: Edit Bookmark, Edit Folder, Move Folder Manual Fallback: Manage Passwords / Credit Cards / Addresses Bug: 943094 Change-Id: I5c7849ca119966b114fb3e6484ef0f8a4d3a620e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529059Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#642436}
-
Nico Weber authored
It never ended up being used for anything, and there are no plans to change that. Bug: 784953 Change-Id: Ie23a70ee120e5045f0cee1dec0a0f7cc1d40c155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529663 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#642435}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: Ic2d1a181a3592262c30b755cf34d3d7bda71f45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527949Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642434}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f36e44456d61..d36afa4e4b3e Created with: gclient setdep -r src-internal@d36afa4e4b3e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I34dcfe7dc5596e9dc0db905a46249465aed36997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531329Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642433}
-
Kunihiko Sakamoto authored
TBR=mark@chromium.org,carlosk@chromium.org,hendrich@chromium.org Bug: 943969 No-Try: True Change-Id: I807346b89306434ed0c0e346402cdcfb6e6a3fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531897Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642432}
-
Dana Fried authored
Still to do: * Apply the correct logic and timing for thumbnail capture (currently still tuned for old NTP functionality). * Compress thumbnail data to a reasonable size. Bug: 928954 Change-Id: I7e5c2630e8e09740b279e3c9db16014546bd833d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526805 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642431}
-
Dana Fried authored
Reduces required space for tab thumbnails from 125K (and as high as 500K on high-DPI monitors) to between 20K and 60K depending on DPI without significant loss of quality. Bug: 928954 Change-Id: Ib32b7ab0b987797927491ad36b77b4b09fd9c769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529739 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#642430}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c60fb3876762..d7d93001ead2 git log c60fb3876762..d7d93001ead2 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df35e382de78..6ce1be5a5a53 (2 commits) Created with: gclient setdep -r src/third_party/skia@d7d93001ead2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I35ae473ea8a6142ddc682a803cec73e1791252d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642429}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary InterpolateLists::Create() in //third_party/blink/renderer/core/animation and make their constructors public, then make the callers use std::make_unique<InterpolateLists> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic3544f8ded2a05f5f5e00a4570317f3e5bad4f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531889Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#642428}
-
Kunihiko Sakamoto authored
TBR=mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Bug: 732103 No-Try: True Change-Id: I76813657fdd1b2351901edae03536fe5cddaef59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531896Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642427}
-
Henrique Ferreiro authored
Change the CSSPropertyID declaration to make it an scoped enum and add static_cast<int> casts where appropriate. Additionally, add definitions for the old enum values so that the conversion of the CSS properties can be performed in another CL. Bug: 936369 Change-Id: I0449e8facaf6580c32c4321b3c61c48367e055cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520674 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#642426}
-
Yutaka Hirano authored
...and stop FrameConsole from inheriting ConsoleLogger. Bug: 914739 Change-Id: I0559d9652ce5eff90d03aaf8dbc32b4b645d04ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522062Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642425}
-
Julie Jeongeun Kim authored
This CL moves web_database.mojom from public/platform/modules to public/mojom/ to gather mojom files to mojom folder and updates paths for web_database.mojom. Bug: 919393 Change-Id: I730b8230193f959db19fc966be1058b9e8d59f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530315Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#642424}
-
Kouhei Ueno authored
We add two tests: - SXG served by appcache should load (this doesn't yet pass in Chromium) - SXG should take precedence when there's content in both appcache+sxg-inner-resp Bug: 940797 Change-Id: Id1463b92f22ab04859ca3f075ca0340225f00694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516533 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#642423}
-
Abhijeet Kandalkar authored
This CL removes unused DEFINE_TYPE_CASTS form canvas_rendering_context_2d.h Bug: 891908 Change-Id: I6c9db6b19912916a98e1241d737c5a41c1bd1047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#642422}
-
Chris Hall authored
Changing some EXPECT_* to ASSERT_* when their failure will guarantee later failures. This removes redundant/dependent errors and helps isolate the actual failure. R=aboxhall,dmazzoni BUG=889370 Change-Id: Icb00ff378ac10948648bb06a7b824532d953fd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520166 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642421}
-
Abhijeet Kandalkar authored
The primary motivation of this CL is to replace ToLayoutScrollbar with To<LayoutScrollbar> and ports other dependent files to refer to a new function name. Bug: 891908 Change-Id: Ieb930ad998dfbd01937f2fc527d3b8cc0bc43da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530494Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#642420}
-
Abhijeet Kandalkar authored
The primary motivation of this CL is to replace ToShapeClipPathOperation with To<ShapeClipPathOperation> and ports other dependent files to refer to a new function name. Bug: 891908 Change-Id: I7525f1a728581f6ada9aa730fd6a2f57deaefa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530495Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#642419}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec795debc5c1..bf564e0beff1 git log ec795debc5c1..bf564e0beff1 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 sadrul@chromium.org tracing: Handle error running vinn. Created with: gclient setdep -r src/third_party/catapult@bf564e0beff1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:942288 TBR=sullivan@chromium.org Change-Id: I085e156c459404e736aff6cf398f6de03dc88e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642418}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37a9294d2eb9..c60fb3876762 git log 37a9294d2eb9..c60fb3876762 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@c60fb3876762 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I6f9f761f7a7aa99380118e4869c6679380f231e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642417}
-
Takashi Toyoshima authored
Some tests in blink_platform_unittests call SetFetchCredentialsMode with kOmit, but it should not be needed. Just the default value, kInclude should work, and the actual default value in the production code. Bug: 742316 Change-Id: Ib215536b0f72daa953c9bb7fad6a931b69e3b29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530491 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642416}
-
Stuart Langley authored
This probably became unusued when we remove analytics support. Change-Id: I6dbc592bf3dfc03e4704780396d3bbe6268a0de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527946Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#642415}
-
Matt Falkenhagen authored
No longer needed following the launch of S13nServiceWorker. This also flattens ServiceWorkerURLJobWrapper into ServiceWorkerNavigationLoaderWrapper. Bug: 926114 Change-Id: I8271efb6bcab601f0b539183d2c50dc182078c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530417Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#642414}
-
Michael Lippautz authored
In the case that user roots are not provided, distances should start at 0. This is the case when full heap snapshots are provided with the gn flag v8_enable_full_heap_snapshots For production builds this flag is always false. V8 CL: https://crrev.com/c/1528994 Bug: 936797 Change-Id: Ifd247a082a4336b59d05f444ba54d281f9eae805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529096Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642413}
-
Timothy Loh authored
This CL changes the Plugin VM app in the launcher to be an internal app, simplifying the launcher integration and making it easy to add shelf integration (although the application id is not finalized yet so that has been omitted). Bug: 940319 Change-Id: Ic760bda32eda8b1f7fab9dc099e6d7770932a258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525704 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642412}
-
Yutaka Hirano authored
Now ResourceFetcher::SetConsoleLogger is gone, so we sets ResourceFetcher::console_logger_ only twice - at the initialization timing and at the detach timing. This CL introduces DetachableConsoleLogger to erase the latter mutation. This allows us to store a ConsoleLogger object in ResourceLoadScheduler. Bug: 914739 Change-Id: Ie9e29a3c92cb26bf20090d5463de9d7a398d230c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522497Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d196c3c607f0..f36e44456d61 Created with: gclient setdep -r src-internal@f36e44456d61 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I1314f2ed6a3953944df9d44191c961dd7e33e625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642410}
-
Kunihiko Sakamoto authored
This reverts commit 0a9cd867. Reason for revert: ShelfViewTest.IconCenteringTest is failing on bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ShelfViewTest.IconCenteringTest https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/21645 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/21646 Original change's description: > CrOS Shelf: Change icon centering strategy > > The main change here is that icons are first centered on the whole > screen, then, when space becomes tighter, they are centered over the > available area on the shelf. > > A few changes to make this work properly: > > * Fix an issue in |GetDimensionOfCenteredShelfItems| which was taking > into account all items, even the ones within overflow, making the > calculations incorrect. > * Another issue was that the code calculating ideal bounds would > assume control buttons (app list, back, overflow) were the same size > as app buttons (56) while they're actually a little smaller (40). > Giving control buttons their "real" size in the layout code allows > for the removal of some overrides at each button class level. > * Split out a small chunk from |CalculateIdealBounds| which is getting > too long. More of that to come in future changes. > * Make the special spacing between the app list button and the first > app icon also there on the other side for more symmetry. > > Also add some extensive test coverage. > > Bug: 891080, 933291 > Change-Id: If4bb69aa6e182cd29c02d467039b5d839d09f493 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512299 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642245} TBR=xiyuan@chromium.org,manucornet@chromium.org Change-Id: I4ad5f95b4c6b2db13e05a6e280e987f25981392b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891080, 933291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531922Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642409}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/core/animation and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I3f5f02b4ae13edecdf08a88e3b5326bf833f817f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531884Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#642408}
-
Matt Menke authored
Previously, it took a bunch of individual parameters, which was getting a bit excessive. Also, CommonConnectJobParams are now created by the HttpNetworkSession. This will hopefully make a couple refactors a bit simpler: * Switching over ProxyResolvingClientSocket to not need its own socket pools (It will need its own CommonConnectJobParams). * Slimming down SocketParams classes by adding more stuff to CommonConnectJobParams (Like the SpdySessionPool and QUIC globals). * Separating the WebSocket and Transport SocketPools. Bug: 921369 Change-Id: I23b9011a9c5b9dafa0eeb1e63f585417ffc0c355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529697 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642407}
-
Leon Han authored
Used features (for UseCounter purposes) of a controller service worker should be considered as part of information of this service worker. To be consistent with this logic, this CL puts them into blink.mojom.ControllerServiceWorkerInfo rather than always passing/accessing them separately like before. BUG=931092 Change-Id: Ic4f99e33b15b367226ea7440941b74422b3a6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527870Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#642406}
-
Noel Gordon authored
Mitigate this issue: make the thread_bundle RunUntilIdle when tearing down these unittests. See crbug.com/943570#c7 for rationale. No-try: true Bug: 943570 Change-Id: Ib8df70054ea9de3d7277da0b49e8885bf103b44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530385Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642405}
-
Julie Jeongeun Kim authored
This is a follow-up CL of [1]. It changes t.step() to t.step_func() from animations/prefixed and address review comments from [1]. [1] https://crrev.com/c/1525789 Bug: 936364 Change-Id: Ica1d58cd903ec8429f0ceac93a3ff3f1e514082b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530358 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#642404}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2894d13a0d9b..37a9294d2eb9 git log 2894d13a0d9b..37a9294d2eb9 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@37a9294d2eb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Idcc39cd22e4d712922a544536d8e4c209d077946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642403}
-