- 02 Oct, 2018 40 commits
-
-
Ted Choc authored
BUG=881659 Change-Id: Ib1ad439d73b7951603a35fb9760d9cec943f0acd Reviewed-on: https://chromium-review.googlesource.com/c/1257666 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596036}
-
Dale Curtis authored
This is only used during building, there's not a good reason to have the sanitizers enabled since it will significantly slow down the actual build process and seems to try to allocation nearly a terabyte of memory at some points. BUG=861418 TEST=none Change-Id: I8d2116fbcee6dff2f1ecc422fbca5ef506fad6dd Reviewed-on: https://chromium-review.googlesource.com/c/1257671Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596035}
-
Jun Mukai authored
HostedAppAshInteractiveUITest.MenuButtonClickable is flaky with SingleProcessMash, and I think it could be the case of unstable mouse location. When mouse move events occur during the test, then the last mouse location could change and then further mouse clicks occur on an unexpected location. UIControlsFactoryOzone can remember the last specified location and can use the remembered location for clicks. This will stabilize the HostedAppAshInteractiveUITest.MenuButtonClickable, and I hope others will get benefits. BUG=890953 TEST=locally interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I3542a5a961dd4e7e8819e924d1d0c170c4dfaff1 Reviewed-on: https://chromium-review.googlesource.com/c/1255607 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596034}
-
Varun Khaneja authored
Bug: 881605 Change-Id: I55eba01698b7504420cd4c3a6e58f01e98cbad25 Reviewed-on: https://chromium-review.googlesource.com/c/1257811Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596033}
-
David Black authored
It was previously assumed that the WebViews owned by ManagedWebContents would not be deleted before the Assistant view hierarchy in ash. As it turns out, this is not always the case as identified by the reproduction steps outlined in the attached bugs. As such, we need to perform clean up safely whether ManagedWebContents WebViews are destroyed before or after Assistant views in ash. Bug: b:116821400, b:116814451 Change-Id: I982b327d45b22bcacef6e07489cb967eb36bcaf1 Reviewed-on: https://chromium-review.googlesource.com/c/1249569Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#596032}
-
David Trainor authored
This includes adding AspectRatioFrameLayout instead of SquareAsyncImageView (more properly handles the requirements of making Views square). This should be removed once we get proper support for ConstraintLayout. BUG=890530 Change-Id: I8a8dc7ae0772785a4cd0e11f555dfde53036a407 Reviewed-on: https://chromium-review.googlesource.com/c/1252332 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596031}
-
Mitsuru Oshima authored
Running CtsAccessibilityTestCases doesn't leave wide frame. Bug: 881672 Test: covered by unit test. Change-Id: Id9f9ee4b9a99b3f0e468458cb970c731a339ba93 Reviewed-on: https://chromium-review.googlesource.com/c/1257146 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596030}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:789139 Change-Id: I0510481873b518b9465e7f7a54c859c666d666c0 Reviewed-on: https://chromium-review.googlesource.com/c/1258249Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596029}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df836ff8f17d..607f907d47b0 git log df836ff8f17d..607f907d47b0 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 tobine@google.com Vulkan: Add 565 configs for Android 2018-10-02 jmadill@chromium.org Optimize resolveLink. Created with: gclient setdep -r src/third_party/angle@607f907d47b0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0ba4ccfaf6f728d8528564895d084bf128dbf5cd Reviewed-on: https://chromium-review.googlesource.com/c/1257712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596028}
-
Mustafa Emre Acer authored
LookalikeUrlNavigationObserver uses DidFinishNavigation event to observer navigations. This event is generated for all frames, so we need a proper check instead of a DCHECK in it. Bug: 889815 Change-Id: I699c32e45cc4f538fec515d22b3e5118d89a3d79 Reviewed-on: https://chromium-review.googlesource.com/c/1258062Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596027}
-
Kevin Marshall authored
The NetworkChangeNotifier is ready to use, now let's actually use it. :) TEST=Exercised change event detection on Ethernet w/Acer Switch 12. Bug: 843443 Change-Id: I23c4ebbcb536dba55ee6b5b86ecdef775f90bd2f Reviewed-on: https://chromium-review.googlesource.com/c/1257548Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#596026}
-
bsheedy authored
Replaces characters that are unsupported by the performance dashboard with underscores in benchmarks that use WebVR and WebXR sample pages. This is so that the name reported on the dashboard can actually be used as a story filter when bisecting. Bug: 881017 Change-Id: Ifae260815a1382ce5dcab9e393ad8b0344ab0f86 Reviewed-on: https://chromium-review.googlesource.com/c/1252848Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596025}
-
Jun Choi authored
This prepares for https://crrev.com/c/1239621 Bug: 877344 Change-Id: Id857841551cf659c14747da36f91b9e848ae9c3e Reviewed-on: https://chromium-review.googlesource.com/c/1247142 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596024}
-
Kyle Milka authored
The declaration and reference of the variable used two different names resulting in a console error, and presumably incorrect behavior. Bug: None Change-Id: I94503c1dfa28b02efaf78f52762554d32672dff5 Reviewed-on: https://chromium-review.googlesource.com/c/1257664Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#596023}
-
Antonio Gomes authored
InitDataReductionProxySettings constructs DataReductionProxyService, which later on is provides data to DataReductionProxyIOData to construct DataReductionProxyConfig. Ultimately, DataReductionProxyConfig constructs WarmupURLFetcher instances. This CL is a preparation CL for [1], where we migrate WarmupURLFetcher from URLFetcher to SimpleURLLoader. In [1], |url loader factory| is mandatory to be non-null. Passing an actual instance at the beginning of the call chain now has no immediate effect, but is harmless too. [1] https://crrev.com/c/1251641 BUG=879777 Change-Id: I5165506e34e31b62a511d02b6e157f3554cc6594 Reviewed-on: https://chromium-review.googlesource.com/c/1256982Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#596022}
-
Eric Roman authored
Bug: 759230 Change-Id: Ic94211a04bc97afd01097b099a42ad7d365f09cc Reviewed-on: https://chromium-review.googlesource.com/c/1244297Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596021}
-
Rouslan Solomakhin authored
Bug: 891371 Change-Id: Iea90f598eac5693b6797efa9ca91cabf7b097326 Reviewed-on: https://chromium-review.googlesource.com/c/1258023 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596020}
-
Douglas Creager authored
This adds test cases that verify that NEL reports are actually generated and uploaded when NEL is activated. We test both when the NEL policy is received through HTTPS response headers, and when they're preloaded in the Cronet experimental options config. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Id00f9095b04471a3adacc58f1fbf72b5c7848503 Reviewed-on: https://chromium-review.googlesource.com/c/1174564 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#596019}
-
sczs authored
-Moves c/b/ui/ntp/recent_tabs to c/b/ui/recent_tabs -Some small renaming. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idd006b4d7872a222aecd2d62b585b1d43ee42b89 Reviewed-on: https://chromium-review.googlesource.com/c/1237528 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596018}
-
John Chen authored
Update atoms with the latest version from Selenium, to fix several bugs, including fixing Clear Element for several input element types. Bug: chromedriver:1319 Change-Id: Ic6141712ba914f7b97d341dc9d4123fc25b05e50 Reviewed-on: https://chromium-review.googlesource.com/c/1258244Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596017}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e8b02fb54234..7f47c50227fb git log e8b02fb54234..7f47c50227fb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 thestig@chromium.org Use smart pointers in CPDF_PageRenderCache. 2018-10-02 thestig@chromium.org Remove dead code in CPDF_PageRenderCache::ResetBitmap(). 2018-10-02 thestig@chromium.org Fix nits in gold.py. 2018-10-02 thestig@chromium.org Retry fetching Gold JSON data. 2018-10-02 thestig@chromium.org Normalize widget bounding boxes when flattening. Created with: gclient setdep -r src/third_party/pdfium@7f47c50227fb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890322 TBR=dsinclair@chromium.org Change-Id: If12a958b7b098357410d253584fa959db17fd135 Reviewed-on: https://chromium-review.googlesource.com/c/1257708Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55b66b22475b..64ba5a302bf0 Created with: gclient setdep -r src-internal@64ba5a302bf0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: Iaecadef1d4ea85fafb88c1be040d565c29c8399b Reviewed-on: https://chromium-review.googlesource.com/c/1257611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596015}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: If0224229b2bb6c6c848aba716cfc7faf89f34383 Reviewed-on: https://chromium-review.googlesource.com/c/1258054 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596014}
-
Christopher Cameron authored
All mojo interfaces that manipulate NSViews need to be associated (for example, adding an NSView as a child of another requires that the parent NSView be in a known state -- each NSView has its own interface, and so they all need to be associated to the same pipe). Also change all bindings to use ui::WindowResizeHelperMac's task runner. This task runner is used to pump a nested run loop inside a Cocoa resize function (for smooth resize). All bindings on the same associated connection need to use that task runner (otherwise, all messages will be blocked behind any un-handled message). Change BridgeFactoryHost to not assign a new host id, but take one in the constructor (just because the logic is easier to follow that way). R=domonickn TBR=avi (for content/ OWNERship) Bug: 821651 Change-Id: Ifb6aff292187b340d144d29ffe1258bb8d501267 Reviewed-on: https://chromium-review.googlesource.com/c/1253561 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#596013}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20afd180cccb..8775060263d6 git log 20afd180cccb..8775060263d6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 saklein@chromium.org cros_sdk_lib: remove unused command. 2018-10-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8775060263d6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4f8a747ceac10257f943585db9cbec8cd04789e5 Reviewed-on: https://chromium-review.googlesource.com/c/1257711Reviewed-by:
-
Henrique Nakashima authored
OpenActions that navigate to URIs are going to be blocked when https://pdfium-review.googlesource.com/c/pdfium/+/42731 relands. It was reverted because this test was breaking and blocking the pdfium roll into chromium. The test will now click on a link in the PDF that navigates to the URI. Bug: 851821 Change-Id: I49853e99de7b989858b1962ad4a92a4168d4c2db Reviewed-on: https://chromium-review.googlesource.com/c/1244367 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596011}
-
Christian Fremerey authored
The video capture service is designed to release resources and shut down when not in use. However, this leads to information about supported formats of the available devices, which is otherwise cached, having to be re-queried. On some platforms, in particular on Android, querying these formats can take a long time (i.e. several seconds). This CL changes the video capture service such that it holds on to the cached formats until the service is shut down. Before, this cache would be released as soon as the last client has disconnected, even if a client reconnects within the service shutdown timeout of 5 seconds. This fixes increased delay of camera capture start observed on Android. Bug: 878304, 792621 Change-Id: I8279e73d093006cf46f64c3a8cb02591bd4f4a59 Reviewed-on: https://chromium-review.googlesource.com/c/1228776Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596010}
-
Fady Samuel authored
In software draw, the entire app is a single software buffer, but webview is just drawing its content in a subrect, then the origin of the webview is not the origin of the bitmap. The rect within the full app software buffer is called the external viewport. In the case of a full viewport damage signal, when the device viewport doesn't intersect with the actual viewport, LayerTreeHostImpl::OnDraw thinks there is no damage and skips the whole frame, and then webview just appears missing or black. This CL fixes the issue by dropping the offset within the software buffer when specifying damage. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1291e96f2e1d1a04ec0ae9940bda1409eb59cd6 Bug: 877436 Reviewed-on: https://chromium-review.googlesource.com/c/1257555Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596009}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a115d8de1c98..cb192dee19d4 git log a115d8de1c98..cb192dee19d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 sadrul@chromium.org pinpoint: Include the metric name in the report. 2018-10-02 jbudorick@chromium.org devil: remove devil_arm.gni. Created with: gclient setdep -r src/third_party/catapult@cb192dee19d4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887888 TBR=sullivan@chromium.org Change-Id: I2efdf81816c6a740372cbb95eeabed8612cc605c Reviewed-on: https://chromium-review.googlesource.com/c/1257608Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2a88bcbaff3e..d73b9d8dfbf7 git log 2a88bcbaff3e..d73b9d8dfbf7 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jaebaek@google.com [Validator] AMD_gpu_shader_half_float_fetch allow float16 (#1393) 2018-10-02 jaebaek@google.com Validator: OpImageQuerySize validation (#1538) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d73b9d8dfbf7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaeeafccb8a03d4b9c3f86ec83e5e8963f3b84ddb Reviewed-on: https://chromium-review.googlesource.com/c/1257609Reviewed-by:
-
Varun Khaneja authored
This will be useful for the test team to verify that the feature is turned on or off. Bug: 747428 Change-Id: I7aba957453a5c52cdfcdec64bec778e0d2be2cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1258208Reviewed-by:
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /media. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=dalecurtis@chromium.org, tommi@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I223baa18f0318bb4c97570705d94bd9bc17c435b Reviewed-on: https://chromium-review.googlesource.com/c/1257886Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596005}
-
Eric Roman authored
Bug: 882019 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5c8f62c7615708e2b1019e11e9639552b9b267ae Reviewed-on: https://chromium-review.googlesource.com/c/1244101Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596004}
-
Joel Hockey authored
When a user opens files within Downloads using a crostini app, show a dialog for the user to give permission to share the directory that the files are in with crostini. * Move handling of 'crostin-files' flag checking into foreground/js/crostini.js * Change FileTasks.executeInternal to detect files that can be shared with crostini and do sharing before execute. * UI Test verifies share dialog is shown before execute. * ConvertFileSystemURLToPathInsideCrostini maps path from within Downloads to '/ChromeOS/Downloads/...' Bug: 878324 Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 Reviewed-on: https://chromium-review.googlesource.com/c/1243871Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596003}
-
Findit authored
This reverts commit 43ffa309. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595899 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDNmZmEzMDliZjMxMWNhODI5NzgwOTg4NmY1MmE1YWU0NzQ5ZGM0MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14146 Sample Failed Step: browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestIntermediateSliding Original change's description: > Top-chrome slide: Fix and test intermediate sliding > > Gesture scrolling starts before top-chrome starts > sliding. During that small period, the > `DoBrowserControlsShrinkRendererSize` bit should > remain unchanged. > > This CL fixes this issue and adds a test to verify > the state of the browser while top-chrome sliding > is in progress. > > BUG=884440, 867063 > TEST=Added new test > > Change-Id: I0737b5b38c727dd77fc522d9a52537f70abb16bd > Reviewed-on: https://chromium-review.googlesource.com/c/1249729 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595899} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=884440, 867063, 891516 Change-Id: I5acaddebf8b9aade85e0371dbf8b6933dcaae18c Reviewed-on: https://chromium-review.googlesource.com/c/1258215 Cr-Commit-Position: refs/heads/master@{#596002}
-
Marina Ciocea authored
In default sandbox policy handles to kernel drivers are closed [1][2]. In order to allow audio service to access device properties (such as friendly name as reported by linked bug), disable default policy for audio sandbox and configure a customized default policy on audio sandbox PreSpawn. [1] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=418 [2] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=932 Bug: 883326 Change-Id: I676f6820a0c1a4e5bd02bf7e66bec9764fc36731 Reviewed-on: https://chromium-review.googlesource.com/c/1256828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596001}
-
Ted Choc authored
This is a bulk (and rather gross) move out of LocationBar into a Coordinator. The coordinator is still the full collection of view and business logic, but this is the first attempt at the split and further refinement will be behind the coordinator API. BUG=843596 Change-Id: I435943e79d34573f3f229710470a91107d8ff5cc Reviewed-on: https://chromium-review.googlesource.com/c/1252540Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596000}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bfff4bac826c..d2650d1a2851 git log bfff4bac826c..d2650d1a2851 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 peah@webrtc.org AEC3: Reseting the ERLE at pre-amplifier gain changes 2018-10-02 saza@webrtc.org Move rtc_json code from API dir, enable unit test, unmark testonly Created with: gclient setdep -r src/third_party/webrtc@d2650d1a2851 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I53746c05d8df628d22edeb2877af651a0ea06f91 Reviewed-on: https://chromium-review.googlesource.com/c/1257704Reviewed-by:
-
Min Qin authored
This CL exposes more details on the notification for failed downloads. BUG=888786 Change-Id: I1c98621a33977359eea0636fa1120c65f3080a7f Reviewed-on: https://chromium-review.googlesource.com/c/1242040 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
-
Kevin McNee authored
We currently call preventDefault on two finger touchmoves to prevent the browser's native pinch zoom from interfering with the PDF viewer's own pinch zoom implementation. However, an intervention may prevent such an event from being cancelable. It also doesn't consider the case of touchscreen double-tap on Chrome OS in tablet mode. touch-action is now able to prevent touchscreen pinches in an OOPIF/BrowserPlugin, so we now use touch-action for the viewer. Bug: 786419 Change-Id: I4eeb3be4566db3c48f0b2ad461cafe0568379fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1247040Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#595997}
-
