- 27 Dec, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d06749..5c5d66ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0e2eca7b9614705ae3505c2f9a5b230e7bb8f842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981093Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727564}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/840ee5a43244..82462f237bb1 git log 840ee5a43244..82462f237bb1 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 rmistry@google.com Remove "-v2" from docker image names Created with: gclient setdep -r src/third_party/skia@82462f237bb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I94411cddc600b8a925d6be232842aafb928aaed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727563}
-
Adithya Srinivasan authored
Disable test on Windows. Bug: 1038037 Change-Id: I97dfaece6bd03cf2473f6e2599207d858ca94b67 Tbr: schenney@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982765Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#727562}
-
Stepan Khapugin authored
Use ApplicationModeForTabOpening. It seems to be the intention, but the type system was confused and allowed to use an incorrect type. Change-Id: Ifdb8f2e7ce3daa346889ba63600c3c8d6402c231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950997 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727561}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I995c4ece354ddd66bbb55aebcd201b5b7b9eb097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983182Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/189074525f47..263d57d37615 git log 189074525f47..263d57d37615 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 khokhlov@google.com Revert "[Telemetry] Make proto trace format the default" 2019-12-27 khokhlov@google.com [Telemetry] Make proto trace format the default Created with: gclient setdep -r src/third_party/catapult@263d57d37615 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612 Tbr: skyostil@google.com Change-Id: Ib5462f4b2d77fc69a74db7f2ed7a4ce9feaa3b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982977Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f7f84681b37..05626c706990 Created with: gclient setdep -r src-internal@05626c706990 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icf1a611fe855fb1c6fb70c0858ae848c1106efc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982976Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727558}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ebed85592533..fca5a005aa88 git log ebed85592533..fca5a005aa88 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src bd97b6f9f213..5de15a256eb0 (1 commits) Created with: gclient setdep -r src/third_party/angle@fca5a005aa88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: If5b22c2849039985ed07be1fc4dfffa9508f79cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982973Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a214bce5377a..4f7f84681b37 Created with: gclient setdep -r src-internal@4f7f84681b37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5c4b802b980c7b9917418da7205f8532c16f66a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982974Reviewed-by:
-
Umut Baris Oztunc authored
This implements the initial version of FileSystemScanner (go/arc-fs-scanner). Bug: b:145254635 Test: unit_tests --gtest_filter="Arc*" Test: Manually populated a big file system and triggered different file Test: system events. Change-Id: I14bebb3719532afac54e1913229045fb2740a9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946177Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Umut Barış Öztunç <umutoztunc@google.com> Auto-Submit: Umut Barış Öztunç <umutoztunc@google.com> Cr-Commit-Position: refs/heads/master@{#727555}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9eb5ff536a25fcb07ec14036a0626fc2b8a45744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982971Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01dd6f6ca430..ebed85592533 git log 01dd6f6ca430..ebed85592533 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6e3a387c0159..59465799210b (1 commits) Created with: gclient setdep -r src/third_party/angle@ebed85592533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: Ie9510340f8803f20022c4553a17b5f2a8deb87a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982968Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88c34f0d6d87..840ee5a43244 git log 88c34f0d6d87..840ee5a43244 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 01dd6f6ca430..ebed85592533 (1 commits) Created with: gclient setdep -r src/third_party/skia@840ee5a43244 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Iba0ee67ca2a6e121df2d65735150deb51834073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982970Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I64a2daeae981c6de8d200ac618a63bb55840f992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982503 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#727551}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: Ib88d9c7cf6bf31f0df5755e7a85b47a744514f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982337 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebdff3e12e9a..a214bce5377a Created with: gclient setdep -r src-internal@a214bce5377a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I37d22d5a560b9efaf0c2186aedf36cd7f77f2940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982969Reviewed-by:
-
Martin Kreichgauer authored
Eliminate the middle level of the Operation <- OperationBase <- {MakeCredential,GetAssertion}Operation class hierarchy. It was supposed to allow the two concrete implementations share common behavior. But the actual shared behavior was trivial, and so it just made the code more annoying to read. No functional changes intended. Change-Id: I4de1107d17d702f5dfb1407127e09b1a2efeb75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965669Reviewed-by:Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#727548}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26762d0425ff..f2dc05978f1d git log 26762d0425ff..f2dc05978f1d --date=short --first-parent --format='%ad %ae %s' 2019-12-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6f7e5e79..d814fc7e (727038:727531) Created with: gclient setdep -r src/third_party/webrtc@f2dc05978f1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4d401643958dd65f0d09957222e728e5f240baf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982962Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Idab46cbd5c3fcecd5ceedb5d9104b3024267db5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981511 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#727546}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d5e76cf5d68..88c34f0d6d87 git log 9d5e76cf5d68..88c34f0d6d87 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6e3a387c0159..59465799210b (1 commits) Created with: gclient setdep -r src/third_party/skia@88c34f0d6d87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Idb21df677c03facb9d300462ca4a812d68b8839a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982963Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c170824..26d06749 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46d898acf9c23c7759f8bb3fafb7be97daea60af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982402Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e3a387c0159..59465799210b git log 6e3a387c0159..59465799210b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 capn@google.com Remove Reactor/MutexLock.hpp Created with: gclient setdep -r src/third_party/swiftshader@59465799210b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic99d29b331c0f09df318070e468d2fa9ca0b64e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982961Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.0-1576497268-benchmark-81.0.4001.0-r1 to 81-3987.0-1577099071-benchmark-81.0.4005.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I84fe68e9d5b8b0698017be044f8829545aaca9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982967Reviewed-by:
-
Yuki Shiino authored
Makes ListNode insert the head and tail section iff the content is not empty. Bug: 839389 Change-Id: Ie154a6f252814abc3a51284f22ac04188e168e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981417Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c708e597115..ebdff3e12e9a Created with: gclient setdep -r src-internal@ebdff3e12e9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie490c1dc0930934c558de42c5b4bff2560ff547f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982960Reviewed-by:
-
Colin Blundell authored
WebLayer's CrashReporterControllerImpl is is always initialized as part of WebLayer initialization. Currently, CrashReporterControllerImpl registers to observe child process crashes and process their minidumps in its own initialization. This processing involves interaction with the CrashReporterControllerClient. However, not all WebLayer embedders set a client; e.g., WebLayer Shell does not. Without a client having been set, a child process crash causes the app to crash due to CrashReporterControllerImpl accessing a null client instance. This CL changes CrashReporterControllerImpl to register for child process crashes when its client is set. Change-Id: I280b68766cc3c5e59ca02fa685575cfe67715f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980741Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#727539}
-
Colin Blundell authored
As crbug.com/1037884 details, Blink currently implicitly requires that the embedder of //content supply an InstalledAppProvider implementation on Android (on all other platforms a default no-op implementation is provided by //content, but on Android a production implementation is provided in //chrome). That bug will hopefully be fixed soon, but in the meantime this CL provides a stub implementation in WebLayer on Android so that pages that trigger this flow don't crash in debug mode. When that bug is fixed, I will remove this workaround. Bug: 1037884 Change-Id: I7eb17431a8b43704f0ce3056babf4a5f95b6a6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980743 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89bf1547f3aa..9d5e76cf5d68 git log 89bf1547f3aa..9d5e76cf5d68 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 48115d33..d814fc7e (94 commits) Created with: gclient setdep -r src/third_party/skia@9d5e76cf5d68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I07f76e24593cfe55e53b2d27c01d4866ee99b318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982698Reviewed-by:
-
Dan Beam authored
Because of various technical details, we can show search bubbles only in cases in which the UI is fairly stably visible (i.e. not subpages). Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=355446#c14 Bug: 355446 Change-Id: I732e64da8916e183655e406b18f06f0a0b02ed31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962797 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727536}
-
Kuo Jen Wei authored
Bug: 1037982 Test: Remove chrome and rebuild and redeploy chrome, verify CCA function normally. Change-Id: I1d8f6fc121734516a0bdc77d6e5d9f2a602d3b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982506 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/451736382565..b015b7d12040 git log 451736382565..b015b7d12040 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b015b7d12040 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc67266b2674de3157ea9989f66db56f7ad97f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982697Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/198da190b2a3..4c708e597115 Created with: gclient setdep -r src-internal@4c708e597115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie5f7313bb6aa6a903eae0e8e2d6f1f314374c291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982667Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9cde626b8052da5eab820dddbcfec53acd524467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980471Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727532}
-
rbpotter authored
Remove OS settings only toggles from the browser settings privacy page, since these toggles are always hidden for showOSSettings=false. Bug: 990132 Change-Id: I568a7a3f72cd2078b74c0f6b024a463c7829c85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982142Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727531}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3057725. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1aedf762eaf394445d049638f3652f3d3718e59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982398Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727530}
-
Kurt Horimoto authored
|sender| was unused in InfobarCoordinator's implementation, and The InfobarBannerViewController only ever requested animated dismissals with no completion blocks. These unused parameters were removed to simplify the delegate interface. Bug: 1030357 Change-Id: I248b4a956d0b41e6f8acd54b4c603f6acc29784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974894 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727529}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I65f8286c208ba922b2d6574ab836e0b77a2a39d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982341 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
rbpotter authored
allowexternalscript="true" was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1980212 As a result this now causes a console error and prevents the people page from loading in debug builds. Remove flattenhtml as well, since there does not seem to be a reason to keep it for this file. Bug: None Change-Id: I43d92c68b76ae423e53cf4ce9010ee823bf9622c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982725Reviewed-by:
-
Andrey Kosyakov authored
TBR=kvitekp@chromium.org Change-Id: I53da1f16c88d4a3c5c5bc203a9e036c6bb93e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982228Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727526}
-
Kurt Horimoto authored
Previously, each OverlayRequestCoordinator had an associated OverlayRequestMediator that also supported the same request type. However, with the introduction of infobar overlays, we will have a single OverlayRequestCoordinator managing the UI, but separate mediators that support only a specific request config type used to configure the shared consumer protocol. This CL adds class properties to the coordinator and mediator interfaces that return OverlayRequestSupports rather than keeping |+supportsRequest:|. This allows each class to specify its request support separately without the need to introduce an additional |+supportRequest:| to the mediator. Bug: none Change-Id: I990467855d6cd1193db9d70e68ce412866128f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981198 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727525}
-
