GitLab

Fullscreen overlays have been enabled on minnie.
Unfortunately there are some issues in HardwareDisplayPlaneManager::
AssignOverlayPlanes with RGBX buffers.

This patch disables the overlay optimization for those buffers
while we work on a fix.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2278803003
Cr-Commit-Position: refs/heads/master@{#414281}

https://codereview.chromium.org/2241213002/ split SCT_STATUS_INVALID
into two new enum values to record the different reasons that an SCT
might be invalid. However, we didn't realize that SCT_STATUS_INVALID
might still be present in disk cache entries, resulting in renderer
kills when the browser tries to deserialize SSLStatus objects containing
these cached SCT_STATUS_INVALID values.

This CL brings back SCT_STATUS_INVALID and documents it as deprecated,
but still existent for the sake of cache entries.

BUG=640296

Review-Url: https://codereview.chromium.org/2277653002
Cr-Commit-Position: refs/heads/master@{#414280}

The main trick here is to get hand-written tests to trampoline through
the _RunGpuTest harness, which is where test expectations are
implemented.

This is done by adopting a convention that the "real" test, like
"_GPUProcessCrashesExactlyOnce", is prefixed with an underscore. This
is implemented in self-contained fashion in
ContextLostIntegrationTest.GenerateGpuTests. If necessary, this will
be generalized further into a base class.

The waterfalls will be switched to run the new version of the test in
a follow-on CL.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2271543002
Cr-Commit-Position: refs/heads/master@{#414279}

This patch converts "editing/execCommand/remove-list-item-1.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2276563003
Cr-Commit-Position: refs/heads/master@{#414278}

Current Arc package sync implemetation does not support stop sync and re-enable
sync without rebooting. So user control of arc package sync is not achievable.
This patch re-implement sync stop and enable proper user control of arc package
sync using apps checkbox in advanced sync settings.

BUG= http://b/31034323, http://b/30640291, http://b/30980543
TEST=Pass sync integration test.
TEST=Manual test1. Turn on apps sync settings. Enable Arc and install package.
Nuke Arc then enable arc. Package restored.
TEST=Manual test2. Turn on apps sync settings. Enable Arc and install package.
Turn off apps sync settings and then nuke Arc. Then enable arc. Package not
restored. Then turn on apps sync settings. Package restored.

Review-Url: https://codereview.chromium.org/2277593002
Cr-Commit-Position: refs/heads/master@{#414277}

Rather than greying out externally deleted items, delete
the files and remove the entry from history.

BUG=616324

Review-Url: https://codereview.chromium.org/2271913002
Cr-Commit-Position: refs/heads/master@{#414276}

This is completely safe because this recipe isn't
used for anything.

TBR=iannucci@chromium.org
BUG=640251

Review URL: https://codereview.chromium.org/2276033004 .

Cr-Commit-Position: refs/heads/master@{#414275}

Currently various StreamParsers return output buffers via 3 separate
collections: a queue for audio, a queue for video and a map of queues
keyed by the track id for text tracks. Now that all stream parsers
properly assign track id to each buffer we can unify all those 3
collections into a single BufferQueueMap keyed by track ids.

BUG=341581

Review-Url: https://codereview.chromium.org/2254093002
Cr-Commit-Position: refs/heads/master@{#414274}

This CL fixes an issue where the overlay scrollbar would allow Chrome to
scroll to the right to show the space covered by the vertical scrollbar.
This has been fixed by reverting to overflow:auto.

BUG=638527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2273523002
Cr-Commit-Position: refs/heads/master@{#414273}

Has the expected visual treatment, but doesn't currently do anything functionally.
Also no one is currently launching the infobar.

BUG=639497

Review-Url: https://codereview.chromium.org/2267463002
Cr-Commit-Position: refs/heads/master@{#414272}

BUG=639545

Review-Url: https://codereview.chromium.org/2268863003
Cr-Commit-Position: refs/heads/master@{#414271}

R=dschuyler@chromium.org
BUG=637068

Review-Url: https://codereview.chromium.org/2265553003
Cr-Commit-Position: refs/heads/master@{#414270}

WebUI URLRequest source data is (on desktop) backed by a memory-mapped
file. Copying that data in CompleteRead can trigger jankiness due to
potential file IO caused by the read.

This CL moves the memcpy on the file thread. It is also a re-land of
https://codereview.chromium.org/2158123003/ with minor changes to fix a
crash.

R=dbeam@chromium.org, mmenke@chromium.org, dproy@chromium.org
BUG=455423

Review-Url: https://codereview.chromium.org/2268653002
Cr-Commit-Position: refs/heads/master@{#414269}

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.

Review-Url: https://codereview.chromium.org/2277723003
Cr-Commit-Position: refs/heads/master@{#414268}

During recent reviews there have been several nits reported. This
change fixes a few of them.

BUG=442566
TEST=updated tests pass

Review-Url: https://codereview.chromium.org/2169713002
Cr-Commit-Position: refs/heads/master@{#414267}

This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition|
objects since its call site is only one for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2278463002
Cr-Commit-Position: refs/heads/master@{#414266}

This isn't implemented yet, but will be provide the Mojo service that will provide blink an access point to the BackgroundBudgetService.

This also adds a mock and a layout test to check the mojo service.

BUG=617971

Review-Url: https://codereview.chromium.org/2231873002
Cr-Commit-Position: refs/heads/master@{#414265}

Mainly for proguard and build rules changes.

Review-Url: https://codereview.chromium.org/2271343002
Cr-Commit-Position: refs/heads/master@{#414264}

Continuation from https://codereview.chromium.org/2132343002/

In HTML imports, custom elements should be created or
upgraded.

BUG=594918

Review-Url: https://codereview.chromium.org/2242743002
Cr-Commit-Position: refs/heads/master@{#414263}

This patch converts "editing/execCommand/hilitecolor.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2270693007
Cr-Commit-Position: refs/heads/master@{#414262}

Also changes NOTIMPLEMENTED policies a bit.

BUG=640773
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2269383004
Cr-Commit-Position: refs/heads/master@{#414261}

This CL removes DispatchToMethod usage in ObserverListThreadSafe, which
is the only user of DispatchToMethod that depends on base::internal::Unwrap.

Review-Url: https://codereview.chromium.org/2268283002
Cr-Commit-Position: refs/heads/master@{#414260}

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions.

BUG=638093

Review-Url: https://codereview.chromium.org/2259723003
Cr-Commit-Position: refs/heads/master@{#414259}

BUG=610521

Review-Url: https://codereview.chromium.org/2277663003
Cr-Commit-Position: refs/heads/master@{#414258}

BUG=635596

Review-Url: https://codereview.chromium.org/2244813002
Cr-Commit-Position: refs/heads/master@{#414257}

https://codereview.chromium.org/2242573002

We'll do the channel interpretation and mode in a different way.

TBR=hongchan@chromium.org
BUG=640575,636576
TEST=Test from 640575 passes

Review-Url: https://codereview.chromium.org/2276973002
Cr-Commit-Position: refs/heads/master@{#414256}

This patch converts "editing/execCommand/switch-list-type-with-orphaned-li.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2272983002
Cr-Commit-Position: refs/heads/master@{#414255}

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49

Review-Url: https://codereview.chromium.org/2270563006
Cr-Commit-Position: refs/heads/master@{#414254}

BUG=638394

Review-Url: https://codereview.chromium.org/2269083003
Cr-Commit-Position: refs/heads/master@{#414253}

This is my attempt to fix the flakiness of this browsertest by having the UI thread wait for the report to be sent on the IO thread.

BUG=613883,638316

Review-Url: https://codereview.chromium.org/2250163003
Cr-Commit-Position: refs/heads/master@{#414252}

https://codereview.chromium.org/2263733002 added 80% zoom to the list of presets, but I forgot it in the settings dropdown. And it looks like 250% was missing from the settings too, for some reason. I can't find anything to indicate this was intentional, so I included it as well. Also updated the comments so that no one else makes this mistake.

BUG=632323
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2278783002
Cr-Commit-Position: refs/heads/master@{#414251}

BUG=639823

Review-Url: https://codereview.chromium.org/2269143005
Cr-Commit-Position: refs/heads/master@{#414250}

TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub
BUG=624086

Review-Url: https://codereview.chromium.org/2270243002
Cr-Commit-Position: refs/heads/master@{#414249}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/caa4e0ba756e8a3b5592a604d53ddaf9ba92dfbf Make chromium_tests recipe module explicitly set GIT_MODE (agable@chromium.org)

R=agable@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2272213002
Cr-Commit-Position: refs/heads/master@{#414248}

This patch converts "editing/execCommand/format-block-with-braces.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2277683002
Cr-Commit-Position: refs/heads/master@{#414247}

Remove the sub-page. Add a simple dialog to select new languages. Add an
option to the language list to remove a language.

A search box will be added to the dialog next.

BUG=630982
TEST=SettingsLanguagesPageBrowserTest
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2265253002
Cr-Commit-Position: refs/heads/master@{#414246}

This seam allows us to reuse our existing network connection factories for
hypothetical future non-BlimpConnection connection objects.

Also modified/rewrote existing unit tests to accommodate new API.

R=wez@chromium.org,lethalantidote@chromium.org
BUG=635711

Review-Url: https://codereview.chromium.org/2236093002
Cr-Commit-Position: refs/heads/master@{#414245}

Revert of DevTools: merge devtools target with devtools host, part 1 (patchset #11 id:200001 of https://codereview.chromium.org/2263843002/ )

Reason for revert:
Caused compile errors on Linux ChromiumOS GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44628

Original issue's description:
> DevTools: merge devtools target with devtools host, part 1
>
> BUG=627517
> TBR=
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79
> Cr-Commit-Position: refs/heads/master@{#414208}

TBR=dgozman@chromium.org,asargent@chromium.org,skyostil@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627517

Review-Url: https://codereview.chromium.org/2277473007
Cr-Commit-Position: refs/heads/master@{#414244}

BUG=639166

Review-Url: https://codereview.chromium.org/2257173005
Cr-Commit-Position: refs/heads/master@{#414243}

While the backing Blink implementation gets further fleshed out, loosen ChromeVox's output of active descendants by reading it on children change events.

The change makes it so that active descendants are read out when:
- the focused node (node with state focused), has an active descendant
- the incoming event is either children changed or active descendant changed

TEST=drive.google.com; tab to one of the popup buttons; up/down arrow reads options.

Review-Url: https://codereview.chromium.org/2273133002
Cr-Commit-Position: refs/heads/master@{#414242}