- 26 Jan, 2018 29 commits
-
-
Kinuko Yasuda authored
http/tests/devtools/network/oopif-targets.js failing since it's added in r531805 Looks like the same reason as the other oopif test (DCHECK(creator) crash in RFI::GetSubresourceLoaderFactories). TBR=yzshen@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9c2e957986ba3756e6d0c3f51a9135d426f601a5 Reviewed-on: https://chromium-review.googlesource.com/888227 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532015}
-
Scott Graham authored
Updates clang toolchain_libs path to 7.0.0. Includes https://fuchsia-review.googlesource.com/c/zircon/+/115121 which should fix component builds crashes. Also renames calls from zx_time_get() to zx_clock_get() per recent Fuchsia syscall change. TBR=kmackay@chromium.org Bug: 724204, 707030, 803110 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If2cb1d320c27b60fb32b0337ce1c6d2886b45b33 Reviewed-on: https://chromium-review.googlesource.com/884822Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532014}
-
Gabriel Charette authored
This CL saves 27KB in chrome.dll and 5KB in chrome_child.dll. https://chromium-review.googlesource.com/868013 had regressed size by 9KB and was caught as a performance regression. This CL should recover this 3X. Also removed an extra atomic operation in the simple case (used to atomic-load for check and atomic-load again for return, now only atomic-loads once). Also moved GetOrCreateLazyPointer() to a subtle:: namespace (now that calling it is tricky), also resolving recurring confusion about whether Needs/CompleteLazyInstance() are invoked outside of it (they're not, they're strictly helpers). R=fdoray@chromium.org, thakis@chromium.org Bug: 804034 Change-Id: I8de94fe742a8f9a68d4a66e0202a6fb276843af9 Reviewed-on: https://chromium-review.googlesource.com/883364Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532013}
-
Theresa authored
Introduce a new AnchoredPopupWindow class, containing most of the logic previously in TextBubble, and refactor TextBubble to use this new class. Also introduces a ViewRectProvider that contains most of the logic previously in ViewAnchoredTextBubble. This lays the ground work for using AnchoredPopupWindow (with extra positioning customization/logic) for ListMenuButton to work around a bug in Android ListPopupWindow positioning introduced in Android N. BUG=709522 Change-Id: Ie6364ddcbd7b84736650ad3df8d433e1a75be6b6 Reviewed-on: https://chromium-review.googlesource.com/884328 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#532012}
-
Xing Liu authored
Refactor RunLoop::RunUntilIdle call in a while loop into an observer class that only hold one RunLoop. RunLoop::RunUntilIdle in a while loop may never return in multithread context on Android platform. Bug: 786626 Change-Id: Ic5deb53e892d9c6303346eb6a7f803c89eddd26d Reviewed-on: https://chromium-review.googlesource.com/882183 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
David Tseng authored
Bug: 800948 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0a314d12ad121dd5748bbeb2ab5213920772d16 Reviewed-on: https://chromium-review.googlesource.com/881956Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532010}
-
Leonard Grey authored
This came up in UX review. From Material Guidelines: "Clocks still turn clockwise for RTL languages. A clock icon or a circular refresh or progress indicator with an arrow pointing clockwise should not be mirrored." Bug: 805921 Change-Id: I1d345727b8656964b0574af9ccdc7d5dc26f8661 Reviewed-on: https://chromium-review.googlesource.com/887301Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#532009}
-
Zach Stein authored
These objects were not intended to be live. We still cache the objects returned by WebRTC here so that multiple calls to getContributingSources return the same objects when called multiple times in the same event loop. Further discussion here: https://github.com/w3c/webrtc-pc/issues/1533 Change-Id: Iada7583f7b30ae06477efe438e93ef4596d02ca1 Reviewed-on: https://chromium-review.googlesource.com/877336Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#532008}
-
khmel authored
This forces ARC OptIn OOBE for all devices. Test: Manually + test_that minnie suite:bvt-arc Bug: b/69807512 Change-Id: Iab37c463cc2c65fd25879ca9df382304f581ccb3 Reviewed-on: https://chromium-review.googlesource.com/884375 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532007}
-
Julia Tuttle authored
Cronet doesn't support controlling base::Features, so move the base::Feature to //services/network (in a tiny component, because things break otherwise), and move the feature check itself to NetworkContext. (A future change will add an experimental option to Cronet to enable Reporting and NEL.) This is a fixed re-land of https://chromium-review.googlesource.com/c/chromium/src/+/858176. Bug: 799616 Change-Id: I79c8a011c75d6b79a92f9ffe85bf5d53d509dcbc Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/879441 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532006}
-
Andrew Wilson authored
I think we have enough local knowledge on the Chrome OS Enterprise team to be owners of the enrollment code - this will also speed up the review process by allowing us to cycle reviews locally. Bug: none Change-Id: I9986d0d7cd38c8c5c5ed0b6d8badbbbccf9e0c83 Reviewed-on: https://chromium-review.googlesource.com/878333Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532005}
-
Hidehiko Abe authored
BUG=784732 TEST=Ran trybot. Change-Id: Iec5f9eaa7482d4e23f5bf2eea4b34c9cd867f89d Reviewed-on: https://chromium-review.googlesource.com/856021 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#532004}
-
Yoland Yan authored
Merge two TestCommon into ActivityTestRule since there is no long need for sharing the implementation with other classes Bug: 711517 Change-Id: I21c902f76891e2e75b4716a924871e0c2410f30f Reviewed-on: https://chromium-review.googlesource.com/887341Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532003}
-
edchin authored
The call to |-rootViewController| is used to calculate the size of the autocomplete popup view in tablet, relative to the keyboard being shown. We now convert to the mainScreen coordinate space, which is the intended use of |-rootViewController|. Bug: 791787 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6c8a6de473005de9ec2ce899990653662c1b64f Reviewed-on: https://chromium-review.googlesource.com/882311 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#532002}
-
Charles Harrison authored
This CL adds tests for: 1. Infobar existence 2. Clicking "learn more" on the infobar 3. Clicking the checkbox and reloading the site 4. Closing the infobar Bug: 800176 Change-Id: I4cf28352c182320bcec5c9e6e8e53cd2c30d02d2 Reviewed-on: https://chromium-review.googlesource.com/886743Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#532001}
-
Joel Einbinder authored
Change-Id: Ide1e84ad7b7096467643786eb0eb06decfccee11 Reviewed-on: https://chromium-review.googlesource.com/761263 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532000}
-
Gheorghe Comanici authored
The experimental contextual suggestions service provides 0-suggest autocomplete suggestions based on the URL that is visited in the active tab, at the time the address bar is focused. This CL adds to the request a timestamp corresponding to the time the user started navigating the URL for which the suggestions are requested. This change is a requirement for the process of enabling server-side logging of the contextual suggestions that are sent to Chrome clients. If logged, contextual suggestions are to be removed as soon as a synced user removes from their history the page that was visited at the time the suggestions were displayed. The timestamp is necessary for matching suggestions with the corresponding navigation. TBR=rohitrao for mechanical changes to ios/c/b/a/* Bug: 692471 Change-Id: I6939d108cfab91b69640acdbb3b8307687999320 Reviewed-on: https://chromium-review.googlesource.com/879167 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#531999}
-
Steven Bennetts authored
This CL shows 'allow shared proxies' for device managed proxies since these proxy settings may be subject to the 'use_shared_proxies' pref. This also: * Adds tests for the detail page, including a minor change to internet_detail_page.js to facilitate testing. * Fixes a subtle bug in isNetworkPolicyControlled. CrSettingsInternetDetailPageTest.InternetDetailPage Bug: 798553 Test: browser_tests --gtest_filter=\ Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I918710e106606127ff1246dd4400125b4c291273 Reviewed-on: https://chromium-review.googlesource.com/881867 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#531998}
-
Dominic Mazzoni authored
The accessibility enums were used in over 300 files and many of those uses depended on details of the bindings generated from the IDL file. To keep this as much of a pure refactoring as possible, this change does the following: * Implements Parse and ToString functions in ax_enum_util that match the behavior of the IDL bindings. * Explicitly adds a kNone and kLast item to every enum, to support code that iterates over enums. Bug: 650275 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6610169991ea1209629dab9a8c4c2c1f03c4116f Reviewed-on: https://chromium-review.googlesource.com/877417Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531997}
-
Nico Weber authored
TBR=danakj Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4278dac80badb5768e725986f6a32b11ca244507 Reviewed-on: https://chromium-review.googlesource.com/886882 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#531996}
-
Luum Habtemariam authored
We've moved from using Bind to BindOnce and BindRepeating. This implements that change in chromeos/printing. BUG=chromium:804035 TEST=passes unit tests Change-Id: Icaf15b00252398c9685a0482e114e7fef7ddea74 Reviewed-on: https://chromium-review.googlesource.com/884825 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#531995}
-
Nico Weber authored
Looks like all fallthroughs in net were intentional. No intended behavior change. Bug: 741046,177475 Change-Id: I004ce3a7b2eb487a34972ced44e1b564468c7d70 Reviewed-on: https://chromium-review.googlesource.com/887303 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#531994}
-
Xianzhu Wang authored
Bug: 768691 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I46857805a46a44c9c3a2ce3280d7dbb3e32c0825 Reviewed-on: https://chromium-review.googlesource.com/882454Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531993}
-
erikchen authored
This CL adds a new memlog stack mode: native-with-thread-names. When enabled, the thread name will be inserted as the first frame of each stack. Other minor changes: * Fixed minor bug in the parsing logic for ProfilingTestDriver. * Fixed a JSON exporter issue [node and string ids should begin at 1, not 0. chrome://tracing UI ignores nodes with id 0.] * Add TLS destructor for allocator shim. * base::android::AttachCurrentThread() now preserves thread name. Change-Id: I8c9d82084d6439e663f94e563068c987d1cf3b23 Bug: 758739 Reviewed-on: https://chromium-review.googlesource.com/877085Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531992}
-
edchin authored
[UIApplication sharedApplication].keyWindow.rootViewController was used to present UI. Now, the appropriate view controller is plumbed into autofill to present UI. Bug: 791793, 692525 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If82b5a5ee37d2ea9778d0332dd6686949d6bbfab Reviewed-on: https://chromium-review.googlesource.com/882400Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Nico Weber authored
NSNumber literals, expression literals, container literals: e.g. in base/mac/foundation_util.mm (expression literal), base/mac/foundation_util_unittests.mm (NSNumber literal, container literal). This is a compiler feature and we have used it for years. https://clang.llvm.org/docs/ObjectiveCLiterals.html @implementation instance variables, in translate_bubble_controller.h (note that ivars referred to in the _unittest.mm need to stay in the .h). This requires the "modern runtime". We could use this once we we shipped 64-bit chrome (m39, late 2014). NSDictionary and NSArray subscripting, e.g. in service_process_util_mac.mm. Note that for scoped_nsobject<NSArray>, you need to do ptr.get()[index]. (We could probably return a proxy object from scoped_nsobject::operator[] to make that unnecessary, but that feels like it might be too clever.) Custom @interfaces can add their own support for subscripting. This has worked since the 10.8 SDK. Generics, e.g. in translate_bubble_controller.h: NSDictionary<NSNumber*, NSView*> instead of just NSDictionary. This works only since the 10.11 SDK, and the bots had an older SDK until erikchen's 10.12 SDK work completed late last year. https://developer.apple.com/videos/play/wwdc2012/405/, click "slides", auth See also https://developer.apple.com/library/content/releasenotes/ObjectiveC/ObjCAvailabilityIndex/index.html We don't use property auto-synthesis because it's very magical. We build with -Wobjc-missing-property-synthesis to make sure the compiler informs us if we forget to synthesize a property in some way. We don't use arc. Bug: 324079 Change-Id: I78659ed47829fe73c2b87cce43a83ec36deb87e8 Reviewed-on: https://chromium-review.googlesource.com/884011 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531990}
-
Hugo Holgersson authored
This CL got reverted because Linux debug builds crashed when running browser tests. I reproduced the crashes locally and fixed them with: - "//content/public/gpu:gpu_sources", + "//content/public/gpu", > Background: > Sometimes (depending on the execution order of browser's > GPU vs IO thread), the IO thread is shutting down while > the GPU thread starts up. > > Problem: > BrowserIO can end up in an endless loop where it tries to > create GPU channels => Linux OOM: > > SendOutstandingReplies()'s first while-loop never exits. > > ~GpuProcessHost > GpuProcessHost::SendOutstandingReplies > BrowserGpuChannelHostFactory::EstablishRequest::OnEstablishedOnIO > BrowserGpuChannelHostFactory::EstablishRequest::EstablishOnIO > GpuProcessHost::EstablishGpuChannel // Queues a channel_request. > => SendOutstandingReplies sees another request => endless loop. > > This happens because of OnEstablishedOnIO's retry-logic. > > Solution: > (1) Run EstablishOnIO async. That gives > SendOutstandingReplies a chance to exit its loop. > (2) Synchronously Stop() the GPU thread before we destruct > its dependencies (here: tell it to stop starting). > > Q: What happens if we don't stop the GPU thread > before we destruct BrowserChildProcessHostImpl? > A: We get another race (and even a crash if we use > the bug description's timing): > > [15658:15698:FATAL:outgoing_broker_client_invitation.cc(52)] > 0 0x7fe6a522e12d base::debug::StackTrace::StackTrace() > 1 0x7fe6a522c02c base::debug::StackTrace::StackTrace() > 2 0x7fe6a52c51ea logging::LogMessage::~LogMessage() > 3 0x7fe69ef8262b mojo::edk::OutgoingBrokerClientInvitation > ::ExtractInProcessMessagePipe() > 4 0x7fe6a60592d8 content::ChildThreadImpl::Init() > 5 0x7fe6a605c032 content::ChildThreadImpl::ChildThreadImpl() > 6 0x7fe6a5eb94cf content::GpuChildThread::GpuChildThread() > 7 0x7fe6a5eb9e47 content::GpuChildThread::GpuChildThread() > 8 0x7fe6a5ee0b23 content::InProcessGpuThread::Init() > 9 0x7fe6a54c5b47 base::Thread::ThreadMain() > 10 0x7fe6a54a4161 base::(anonymous namespace)::ThreadFunc() > 11 0x7fe6ac4d56ba start_thread > 12 0x7fe691ab63dd clone > > Manual test: Follow the bug description's steps. > Automated test: Run content_browsertests. Bug: 799002 Change-Id: I1d61475b35abf11c98c6a6a21be6987f6eebdb0f Reviewed-on: https://chromium-review.googlesource.com/886483Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#531989}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia221f9c5086b54b9829c03ccbfdab345e9bbdb70 Reviewed-on: https://chromium-review.googlesource.com/887906Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531988}
-
Xiaohui Chen authored
Bug: None Change-Id: I5524c2aed18531713bfca5c047cef2f18c5c5203 Reviewed-on: https://chromium-review.googlesource.com/887752Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#531987}
-
- 25 Jan, 2018 11 commits
-
-
Ken Rockot authored
Recommends base/component_export.h and deprecates the old pattern. Bug: None Change-Id: I8bb5d5fbdbafbb9310638d7ce50c8acb5194dce7 Reviewed-on: https://chromium-review.googlesource.com/887624Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531986}
-
Artur Khachatryan authored
This reverts commit c7f6f0de. Reason for revert: Reverting because it was not the root causing the issue. Test in Waterfall still fails. Original change's description: > [ChromeDriver] Disabling GPU for Mac platform > > The waterfall tests on Mac appear to be flaky so disabling GPU for Mac platforms as well. > > Bug: chromedriver:1695 > Change-Id: Id39fea14a40857bec33e78ffe2d3c65e51ada91c > Reviewed-on: https://chromium-review.googlesource.com/884303 > Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531669} TBR=johnchen@chromium.org,khachatryan@chromium.org Change-Id: Ie149de38211f1a424b5dd341f14081b30b51e61e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:1695 Reviewed-on: https://chromium-review.googlesource.com/887168Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531985}
-
Bret Sepulveda authored
This bubble is deprecated and we don't want to maintain the UI while waiting for a possible replacement. Bug: 699338 Change-Id: I8014ca39219aad0d358a1db4c4deb3b42032520a Reviewed-on: https://chromium-review.googlesource.com/861325Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#531984}
-
Ovidio Henriquez authored
This change adds a thrown error message for browser environments that do not implement Web Bluetooth Test API. The message also points to the README file that has more information. BUG=509038 Change-Id: Ic5906a32aca5a4169184e07f6ca804170eb863c9 Reviewed-on: https://chromium-review.googlesource.com/858484Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#531983}
-
Alex Newcomer authored
To accomplish this: - Create a new view and enable/disable it. - Make that view paint to it's own layer, which will ensure it paints over the icon. Bug: 803629 Change-Id: I6de0f02024d6287c205187be1babfa2d0ab6f41f Reviewed-on: https://chromium-review.googlesource.com/884388Reviewed-by:
-
Yoland Yan authored
Merge MultiActivityTestCommon into MultiActivityTestRule since there is no long need for sharing the implementation with other classes Bug: 711517 Change-Id: I30612a8815763a56fc9764008913e6c36c846df7 Reviewed-on: https://chromium-review.googlesource.com/881833Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531981}
-
bsheedy authored
Adds a test to ensure that pressing the Daydream controller's app button while presenting from a deep linked intent is a noop. Bug: 805712 Change-Id: I7c359d8cd8f574ef239486f96a150695e84f07ef Reviewed-on: https://chromium-review.googlesource.com/887362Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531980}
-
Francois Doray authored
The goal of this CL is to provide a sample call site for base::NoDestructor. SslIndexSingleton does nothing in its destructor, so not registering with AtExitManager doesn't affect behavior. Change-Id: I19c334faa7148c8f0340c370c854272023fc3950 Reviewed-on: https://chromium-review.googlesource.com/879103Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#531979}
-
Alexei Filippov authored
The SamplingNativeHeapProfiler::GetSamples used to return all the memory allocation samples recorded since first call to Start. Make it return samples recorded since arbitrary Start event. BUG=803276 Change-Id: I66de31267c6e976a02988c0d85df3c46ae00cd9b Reviewed-on: https://chromium-review.googlesource.com/879431 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#531978}
-
Vladimir Levin authored
The code in place handles cases where the container is a TableSection with a transform. Extend this to also work when the container is a TableRow with a transform. In general, this patch changes IsTableSection to IsTablePart to handle any part of the table that can be a container. This also changes the EnclosingIntRect to RoundedIntRect in a DCHECK, since offsets under EnclosingIntRect are susceptible to int differences when the source has small floating point changes. For example, -1.0000028610 offset in one rect becomes -2, but -1.0000000000 stays -1. R=chrishtr@chromium.org Bug: 804952 Change-Id: Ibc1e062953c1c6bc436101705d4842209e6af707 Reviewed-on: https://chromium-review.googlesource.com/884681Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531977}
-
Adithya Srinivasan authored
Tbr: vasilii@chromium.org Bug: 805794 Change-Id: I958d1d6a1bce99a7213ad603be75204d35d342c0 Reviewed-on: https://chromium-review.googlesource.com/887161Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531976}
-
