- 17 Sep, 2020 40 commits
-
-
Sunny Sachanandani authored
This is a reland of ab1868c4 Adds trace test expectations for skipping software compositing tests on Android, ChromeOS, and Fuchsia. Original change's description: > gpu: Run trace tests with pixel test browser args > > Trace tests don't take extra browser args specified by the corresponding > pixel test into account. Most tests don't have any extra browser args, > but a few disable gpu compositing and don't depend on the browser args > for correctness. However, an upcoming pixel test will need its browser > args for correctness: > > https://chromium-review.googlesource.com/c/chromium/src/+/2402192 > > Bug: 1077211 > Change-Id: Ieaaa5fd0c466c8f3b52291ae903d8ab5ec7d43d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415088 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807663} TBR=zmo@chromium.org Bug: 1077211 Change-Id: I639dfcfa50ceb9f9aa86ff292931e8549ad1f76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417109Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#808076}
-
Xiaohan Wang authored
This is a follow up from previous CL [1] to fix more bots. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2415369 Bug: 1127616 Change-Id: Idaa97e3203da054d62a94b3ad59fb6fd8acab2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414570Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808075}
-
Ken Rockot authored
This gets rid of some unmanaged heap allocations from strdup() calls in the setproctitle implementation. We can trivially hold onto copied strings in static storage to eliminate the need for strdup() or a corresponding LSan suppression. Fixed: 356306 Change-Id: I5aa40583b632fd638459b2175a924f95fc56be89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416775 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808074}
-
Sonny Sasaka authored
As per recommendation in Comment #30 of crbug.com/1114876. BUG=b:167556640 Change-Id: I57bc4ff360d05d1d6a0b03f58d4f24e23492b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410746Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#808073}
-
Jose Leal Chapa authored
Using milestone 94 as it will roughly land one year from now. Bug: 1125667 Change-Id: I633884726f2c73606b0187faa794d44d28c1efb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401503Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jose Leal <joselea@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808072}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5044ddf05e6..5f863da9c924 2020-09-17 jalyn@microsoft.com Add keyboard shortcut editor experiment 2020-09-17 vidorteg@microsoft.com Removing i18n-bundle.js generation on build time. 2020-09-17 alexrudenko@chromium.org Highlight grid elements on hover If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109177,chromium:1127204,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I71aa76170c1a278a54eed09696b7c76b1f067810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808071}
-
Xiaohan Wang authored
Update the condition here to be consistent with cdm_paths.gni. Also update the comments to make sure they keep consistent. Bug: 1128458 Change-Id: I7580d30637f9aae2d856846d74e086c64a2f123d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417137Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808070}
-
James Vecore authored
Due to an order of operations issue in OnPayloadTransferUpdate() when receiving files Disconnect() was being called before the transfer updates were communicated. This caused the share target to get cleaned up before sending the completed status which left the transfer hanging around in the UI. This was missed in unit-tests due to the fact that the |FakeNearbyConnections| triggers the disconnect handler on Close() instead of the destructor like the real one. By changing the way Disconnect() behaves to call Close() on the connection we can get the tests to fail due to the missing status. Then the fix gets the tests passing again. Verified on device with a real transfer. Fixed: 1126620 Change-Id: Ida0ab7dda01a81ce7fb470333059029e461972ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413397 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/83c7e1ae8626..37457d086ed3 2020-09-17 syoussefi@chromium.org Vulkan: Support MSRTT color renderbuffers 2020-09-17 jmadill@chromium.org GN: Componentize D3D back-ends. 2020-09-17 m.maiya@samsung.com EGL: Add support for EGL_ANDROID_create_native_client_buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I2573768b622af2e2c28c2e6c1e549f7d43eca493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417132Reviewed-by:
-
Raymond Toy authored
Add some more checks and a logging message if indices are out of range. We're trying to figure out what's happening here. I've been unable to reproduce the issue. Bug: 1116104 Change-Id: Ic5343d03b2a944bb4aa421e86ac8259803cb9363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411424Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808067}
-
Collin Baker authored
TBR=rouslan@chromium.org Bug: 1129573, 1129578 Change-Id: Ic6b7132065fb5cdca9309803ec1a6c628ae5775b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417289 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#808066}
-
W. James MacLean authored
The CL ensures that frames that are explicitly removed (and thus have their FrameNavigationEntries deleted) get added to the non-isolated origin list so that a complete history of origins seen in the BrowsingInstance is maintained. This is required to be spec compliant with opt-in origin isolation. Bug: 1108898 Change-Id: If9c995340791c8361ee0554fe41695a51d25f6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398972 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808065}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/249019878c55..0de987471899 2020-09-17 ianstruiksma@google.com Move wpr test func to the test file it is used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1129208 Tbr: oysteine@google.com Change-Id: I163edd2b518066b37d4012756cd857761c6a42f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417228Reviewed-by:
-
Erik Chen authored
This CL has no intended behavior changes. It stabilizes the crosapi and hid mojoms, which were intended to be stable but were incorrectly not marked with the [Stable] tag. Change-Id: I31d0e67632c7ce7a6a9726539c5449664a0669de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417054 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#808063}
-
Siyu An authored
This will set the synced data to the Autofill Table. Added tests also Bug: 1112095 Change-Id: Ib1b05101a4db43797b8923fd215a550d5f03b6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412816 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#808062}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f10f8691..8727abed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0e94abd98f6b7f708a1a41f3b7932b0a1f83a57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808061}
-
Dominique Fauteux-Chapleau authored
Bug: 1128574 Change-Id: I324ded6e3bbf92a136ede7021b18ad0a0847241b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414914 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#808060}
-
Peter Wen authored
New API related checks are some of our most valuable lint checks, as triggering an error causes a crash directly. This CL adds compile test targets to ensure that code with API level errors trigger lint warnings. This prevents lint being accidentally turned off. Also delete now obsolete //build/android/lint directory and remove some already-fixed suppressions from lint-suppressions.xml. This is a reland of 607f1b15 fixing the compile error in LintTest.java. Tbr: mheikal@chromium.org Bug: 1108309 Change-Id: Ibf8c262b3f85b9e0eca61c8e1ec57a8986f0458a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416778 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f0602162fdd..d3aa9c6b66aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com,waffles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080854 Tbr: collinbaker@google.com,waffles@google.com Change-Id: Ie98d205433c11bd4ac54b66def94800634b020d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808058}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6419bddd9b0c..4099f6552592 2020-09-17 enga@chromium.org Typeify VertexBufferSlot and VertexAttributeLocation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I178d0731f5f3fbb96a202314ab1a291c9703d9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417135Reviewed-by:
-
Pavol Marko authored
KeyPermissionsManager gets an API to explicitly mark keys corporate. For symmetry, IsKeyCorporate is also moved to the public API. It will later replace the static function API that is being used by callers now - this has been left as a follow-up for better mergeability. Bug: 1127506 Change-Id: I1c1c7552edcd1671b93ba1bd2fcf380ad6b021d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413249 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808056}
-
Cathy Li authored
Change-Id: I7cbf3a5c94f0d5f43dc0c2e08a7832a5fc6af21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415538Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#808055}
-
David Tseng authored
common/tts_background.js:740: ERROR - [JSC_POSSIBLE_INEXISTENT_PROPERTY] Property phoneticCharacters never defined on Object if (!properties.phoneticCharacters) { ^^^^^^^^^^^^^^^^^^ R=akihiroota@chromium.org, josiahk@chromium.org Test: browser_tests --gtest_filter=ChromeVox*.*Phonetic* Change-Id: Id8935556fbfb130561596c6a334369d1c979b50f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417089 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#808054}
-
Yulun Wu authored
This CL covers changes to app list background, search box, suggestion chip, and expand arrow. Bug: 1110766 Change-Id: Idba2d0e3624e98a1af7bdd48750a6944aebc3528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400240Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808053}
-
Liviu Tinta authored
If Scroll Unification is enabled, send GSB, GSU and GSE to CompositorThreadEventQueue instead of MainThreadEventQueue in |WebFrameWidgetBase::InjectGestureScrollEvent|. Bug: 1047198 Change-Id: Iec178bf6053d937ed1b6cdd977ac7e42267b4ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392409 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808052}
-
Yann Dago authored
Bug: 243833 Change-Id: Ic70128e20a1353816d1eb85b5324c8eaa21ea0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402123Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#808051}
-
Robbie McElrath authored
This CL partially fixes an issue where the browser controls wouldn't be visible during page loads. This was caused by setView hiding the controls initially until it got positioning information from the renderer about where it wanted the controls to be. During page loads, this positioning information doesn't come because compositor commits are paused, which means the controls can be hidden for a couple seconds. Bug: 1128391 Change-Id: Iaa6b3dd1d7ef65523d19dddd94587aec9cbc6ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412810Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#808050}
-
Markus Handell authored
Bug: 1127791 Change-Id: I9e73069d8cf7a296f2929d325aafed28e8c42962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407899Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#808049}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600322062-3a48015e01b1446b1d53601d43c9f7d995fa4dd3.profdata to chrome-mac-master-1600365511-0307b18a9fe145dd28de0ead73e8fb46212de02b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9d090c042f1ccb14bcad23b2c83557c097f752ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417136Reviewed-by:
-
James Vecore authored
Fixes an issue where the foreground surface was getting unregistered when the user leaves the discovery page due to a mojo disconnect handler getting invoked. We remove the disconnect handler here so the surface stays registered as long as the webui is up so it can receive transfer status updates while the confirm page is being show. When the webui is close, the surface will unregistered itself from the destructor anyways. Change-Id: Ib9890ae996a21fffab42c940eb688db4709f1ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412937Reviewed-by:
-
Maria Kazinova authored
Making use of available strong FormRendererId and FieldRendererId types in iOS code. Change-Id: I9b551f3dd03b9b8239f67606359274d781354967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414222Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#808046}
-
Bettina authored
On Android, the ClientSideDetectionOnAndroid experiment needs to be turned on in order for the CSDService and CSDHost to be created. Also updated the CSDModel experiment to the experiment used on Android. Bug: 1108080 Change-Id: Ia53cb59331582877b6e0ebf4f08f2c921a732ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411426 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
-
Katie Dillon authored
This CL removed fixed priority from the scheduler in favor of using PrioritisationType to make priority decisions. This centralizes priority to ComputePriority/PrioritisationType. Specifically, this CL has kBestEffort queues use kBestEffort PrioritisationType and adds kInput PrioritisationType for input queues. Change-Id: Icaabc29ff6d3d8f5595c64741056899ffa474fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376574 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#808044}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1093185 Change-Id: I47bbd1dc115751de7061ed89bf771a042800a273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412554 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808043}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic660b895f06755a9f52bc09db2f9d3ec09cb036d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417129Reviewed-by:
-
Jonathan Backer authored
UMA data suggests that we never draw frames on Mali-400 with <= 512 MB. This is probably inability to use RGB565 framebuffer. Disabling SkiaRenderer until this is fixed. Bug: 1126490 Change-Id: Id9081cb178febc54d612498b8344286bd76643a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416722 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#808041}
-
Miguel Casas authored
Decoding a bitstream in VA has two steps: one, submitting the parsed parameters and encoded chunk as VABufferIDs, and two, executing the decode. This CL transfers managing the lifetime of the VABufferIDs to VP9VaapiVideoDecoderDelegate, avoiding vaCreateBuffer() calls. To do that this CL reshuffles a bit the VaapiWrapper calls to be able to call vaCreateBuffer(), MapAndCopy and Execute, in a piecemeal, configurable fashion. This is verified via chrome:tracing and codepen.io/full/RwarYvG that plays 4 1280x572 VP9 videos at the same time. Tracing is captured for a few seconds, and basically we avoid calling the vaCreateBuffer(), which takes ~50us every time, reducing the overall decode time from ~3.740ms to ~3.425ms on my BSW (reks), ~10% reduction. (Also tried on kohaku and numbers are similar albeit smaller bc the SoC is faster). Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). This CL also removes the unused VaapiWrapper::Execute() method. Bug: b/166646505 Change-Id: Id44dbb21825328dfb4fc47e1c7807bd725efd196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404740 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808040}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a787cd5e158b..e2e75b23aa67 2020-09-17 chanli@chromium.org [depot_tools] Roll led to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I70e3ab14571d3002dbe7ab7212e12bcf1fde6cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416962Reviewed-by:
-
Jochen Eisinger authored
Bug: 927509 Change-Id: Ifb35e635d8124850ed6819d3e8be76efbbb3ce95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416522Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808038}
-
My Nguyen authored
Strings update according to: http://go/cros-lang-settings-ux-writing Mock: http://go/cros-lang-settings-ux-slide#slide=11 Figma: http://go/cros-lang-settings-figma Current view: http://screen/GC6WrWAVYRGGyeh Note: - Replace settings-box with cr-row, start with flex as per https://crrev.com/c/2144429 Bug: 1113439 Change-Id: If185ce874269db8c921ae9136d15f0ad49f4146f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413767Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
