GitLab

BUG=119551
TEST=none, just landing assets
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9834025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128278 0039d316-1c4b-4281-b951-d872f2087c98

This would allow the developers to view the client/server sync traffic. In retail builds this code would be compiled out. To view the traffic you have to run chrome with the flag:
--vmodule=traffic_logger=1.


BUG=117615
TEST=git-cl try --email=foo


Review URL: http://codereview.chromium.org/9663023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128277 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for an extension API call:
chrome.experimental.bluetooth.getAddress

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9826018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87176
TEST=See bug, comment 35.


Review URL: http://codereview.chromium.org/9751001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128274 0039d316-1c4b-4281-b951-d872f2087c98

Correct the rendering of BrowserActionIcons on mac that was introduced by CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=127196

The cocoa rendering code was assuming that the CanvasSkiaPaint object was initialized to 0, which is no longer true.  This CL explicitly initializes the canvas before rendering the icon.

BUG=118755
TEST=None

Review URL: http://codereview.chromium.org/9839012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128271 0039d316-1c4b-4281-b951-d872f2087c98

Non-functional changes:

* 0 -> TemplateURLRef::NO_SUGGESTIONS_AVAILABLE
* GURL x = GURL(...) -> GURL x(...)
* Infobar -> InfoBar
* AllSources -> AllBrowserContextsAndSources
* Pass a Profile* to SearchProviderInstallData, which it will need for more purposes once UIThreadSearchTermsData takes a Profile*
* Add/modify comments
* "" -> std::string()
* Other trivial changes to minimize diffs

Functional changes:

* TemplateURLFetcher::RequestDelegate::AddSearchProvider() no longer clears the keyword for a newly-added, explicitly-requested TemplateURL that conflicts with a non-replaceable keyword.  This means the conflicting keyword will appear in the dialog box and the box will indicate a conflict.  This is mostly to avoid giving a TemplateURL an empty keyword, which will later be made illegal.
* TemplateURLFetcher::ScheduleDownload() now expects the provided keyword to be non-NULL for autodetected cases (which was always true already) and ignores the keyword for explicit cases (which only matters to tests, as the actual browser code always passed an empty keyword here anyway).
* TemplateURLService::CanReplaceKeyword() now always sets its outparam.  This prevents any possible use-without-set on the caller side.
* Properly order (expected, actual)
* ASSERT -> EXPECT
* Construct the TemplateURL for TemplateURLTableModel::Add() in that function rather than the caller.  This will make it easier to change TemplateURLs to require a Profile* later.
* Check all fields at the end of WebDatabaseMigrationTest.MigrateVersion27ToCurrent

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9811022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117300


Review URL: http://codereview.chromium.org/9827002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128269 0039d316-1c4b-4281-b951-d872f2087c98

Revert 128266 - Added a pepper test for SSLHandshake. This starts an SSL server which the test can connect to.

BUG=114626
TEST=Ran pepper TCP tests.


Review URL: http://codereview.chromium.org/9791003

TBR=raymes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9836015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128268 0039d316-1c4b-4281-b951-d872f2087c98

topSites API is now available for developers.

BUG=27759
TEST=*TopSites*

Review URL: http://codereview.chromium.org/9721013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114626
TEST=Ran pepper TCP tests.


Review URL: http://codereview.chromium.org/9791003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128266 0039d316-1c4b-4281-b951-d872f2087c98

This patches removes the usage of the deprecated Menu2 API and makes it work under use_aura=1.

BUG=117092
TEST=chromeos=1, open the bookmark editor dialog, right click on any folder, you
should see the context menu with 3 items, and everything should work as before.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9814031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128264 0039d316-1c4b-4281-b951-d872f2087c98

Push UnhandledWheelEvent and GetBrowserAccessibilityManager down to RenderWidgetHostViewPort.

Get rid of OnMessageReceivedForTesting, in favor of RenderViewHostTester::TestOnMessageReceived (which already existed but needed to be converted to a static method so it could be used with regular RenderViewHost instances).

Rename WebContentsTester::pending_rvh() to GetPendingRvh() since it's a virtual method.

Remove top-level alias for content::RenderViewHostTestHarness and switch clients to use the fully-qualified name.

Clean up a couple of other minor TODO items, some had already been done and the comment just needed to be removed; in one case the TODO was just wrong (in dump_accessibility_tree_browsertest.cc) since it's OK for content to depend on content implementations.

Remove test_tab_contents.h from DEPS (seems to have been a merge failure in my last change that left this in).

BUG=98716

Review URL: http://codereview.chromium.org/9838009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128263 0039d316-1c4b-4281-b951-d872f2087c98

Also add a line separating the header from content for app and popup windows.  At alcor's request.

BUG=119411
TEST=visual, open an app as a window, there should be no icon or title
R=sky@chromium.org


Review URL: http://codereview.chromium.org/9835013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=jamescook@chromium.org


Review URL: http://codereview.chromium.org/9834015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128259 0039d316-1c4b-4281-b951-d872f2087c98

Turns out the AutoUpdate test failures were unrelated to 127887.

BUG=108202
TBR=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9834021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119340
TEST=manual


Review URL: http://codereview.chromium.org/9812043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128257 0039d316-1c4b-4281-b951-d872f2087c98

For device_management.py only

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9839002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Visual

Review URL: https://chromiumcodereview.appspot.com/9722040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128255 0039d316-1c4b-4281-b951-d872f2087c98

Call SkBitmap::lockPixels() prior to SkPicture::getPixels() to ensure that correct pointer is returned.

BUG=111587
TEST=content_unittests --gtest_filter=RenderWidgetHostTest.Background


Review URL: http://codereview.chromium.org/9835004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128254 0039d316-1c4b-4281-b951-d872f2087c98

Delayload winspool.drv and pull the files we need from fixed locations on XP instead of relying on core drivers.
On Vista and later the install flow is unchanged GetCorePrinterDrivers and GetPrinterDriverPackagePath are delayloaded so they don't crash on XP.
Needed to modify the CabinetCallback to handle the variable structure of the cabs on the different platforms.
Added an OS version check on startup.


BUG=112035
TEST=Install on XP SP3


Review URL: http://codereview.chromium.org/9812030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128253 0039d316-1c4b-4281-b951-d872f2087c98

Refactor tests that performs an action on the password infobar to identify the infobar by type and index of type.

Originally these tests identified the password infobar by the text of the password infobar button.

TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9775001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128252 0039d316-1c4b-4281-b951-d872f2087c98

On running ChromeOS_Chrome on Linux, we log in a stub user; this is however only necessary if we aren't doing a command line login or showing the login screen to the user. On arbitarily logging in the stub user, Chrome thinks that a user is logged in even if the login screen is showing, causing all sorts of issues.


R=nkostylev@chromium.org,pastarmovj@chromium.org
BUG=None
TEST=Tested on Linux with a regular login using the login manager, a stub-login (default when not using the login manager) and a kiosk-mode login.


Review URL: http://codereview.chromium.org/9811031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128251 0039d316-1c4b-4281-b951-d872f2087c98

This follows the pattern used on other platforms to hook up the bookmark
manager to the native drag and drop system, except that on Aura we avoid the
need for the extra abstraction provided by WebDragDest/WebDragDestDelegate
since we don't have applications outside of chrome we need to interact with.

BUG=117012
TEST=drag bookmarks around in the bookmark manager, and to/from the bookmark bar


Review URL: http://codereview.chromium.org/9757001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/9827001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128249 0039d316-1c4b-4281-b951-d872f2087c98

TabContentsContainer::ChangeWebContent was calling native_container_->DetachContents then eventually calls RWH->WasHidden(), so there is no need to call it explicitly a second time.


BUG=110645
TEST=Manual

Review URL: http://codereview.chromium.org/9243013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119236
TEST=manually


Review URL: http://codereview.chromium.org/9837001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128247 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9816012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128246 0039d316-1c4b-4281-b951-d872f2087c98

Regression is here: http://build.chromium.org/p/chromium/builders/Linux/builds/21547

BUG=119504
TBR=thakis
TEST=linux builder goes green

Review URL: https://chromiumcodereview.appspot.com/9836012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128245 0039d316-1c4b-4281-b951-d872f2087c98

Regression is here: http://build.chromium.org/p/chromium/builders/Linux/builds/21547

BUG=119504
TBR=thakis
TEST=linux builder goes green

Review URL: https://chromiumcodereview.appspot.com/9808021

TBR=backer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9834017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128244 0039d316-1c4b-4281-b951-d872f2087c98

Regression is here: http://build.chromium.org/p/chromium/builders/Linux/builds/21547

BUG=119504
TBR=thakis
TEST=linux builder goes green

Review URL: https://chromiumcodereview.appspot.com/9808021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118348,119499
TEST=manually checked the following configurations: 1) Google Chrome for Chromebook (with USE=chrome_internal), 2) Chromium for Goobuntu with GYP_DEFINES=chromeos=1, 3) Chromium for Goobuntu without the GYP_DEFINES.

Review URL: http://codereview.chromium.org/9705092

TBR=yusukes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9838014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128236 0039d316-1c4b-4281-b951-d872f2087c98

This makes it easier to debug layout test cases involving scroll animation.

BUG=118507
TEST=Bring up test shell with --enable-smooth-scrolling switch and scroll around, should be animated.

Review URL: https://chromiumcodereview.appspot.com/9829003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128235 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128234 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128233 0039d316-1c4b-4281-b951-d872f2087c98

After browser crash, the wallpaper was reverted to the default wallpaper. This
CL fix the bug.

BUG=118751
TEST=Test on any chromeos device
select a wallpaper different than the default one
go to about:inducebrowsercrashforrealz, the browser will crash and restart
verify if the wallpaper reverted to the default wallpaper after restart.

Review URL: https://chromiumcodereview.appspot.com/9764012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128232 0039d316-1c4b-4281-b951-d872f2087c98

Bring the top/left/right/bottom resize shadows a bit closer to the corners.

BUG=119366
TEST=visual
TBR=derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9835014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128231 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds NIY stubs for most methods, just providing a few basic
status methods and events.

BUG=119336
TEST=Tested manually via a simple extension.  Tests will come as the bluetooth stack gains mocks.


Review URL: http://codereview.chromium.org/9822001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128227 0039d316-1c4b-4281-b951-d872f2087c98

R=mnissler@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9814011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128226 0039d316-1c4b-4281-b951-d872f2087c98

Modifies suppression for net::CertVerifyProcMac::VerifyInternal with signature change
introduced with r128172.

BUG=114343, 96300
TEST=Valgrind on Mac goes green
TBR=rsleevi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9826016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:28161
TEST=Manual


Review URL: http://codereview.chromium.org/9808013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128222 0039d316-1c4b-4281-b951-d872f2087c98