- 21 Sep, 2020 40 commits
-
-
Yue Li authored
Extend the expiry milestone of Quick Answers related feature flag. Bug: None Test: Locally build and test Change-Id: I2df16ed1037d5f333cf864c1d697b0ec8c636587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419752 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808991}
-
Mason Freed authored
NOTRY=true TBR=tkent@chromium.org Change-Id: I5dfae4f34113699296028eb0566b3b479ad16959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422443Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808990}
-
Ian Vollick authored
Looks like AddressAccessoryController::GetIfNeeded is not currently being called. Bug: None Change-Id: I4e717c1b481958b79a77bee4615b2d25c9663ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416808Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808989}
-
Yusuf Sengul authored
Bug: 1114381 Change-Id: Ia5b0ae4e408ae770cbed0086dc6ff269793ea876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343955Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#808988}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05f0bbb70bde..37f4b38fcbc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hesen@google.com,etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hesen@google.com,etiennep@google.com Change-Id: I299cec8fba8c4a215e9802438372d136829fc825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422216Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808987}
-
Matt Jones authored
Since SceneOverlays are no longer a per-layout construct, it is possible for the layer tree to become stale. Overlays may continue holding a layout's SceneLayer post being hidden. This patch adds the ability of a SceneLayer to remove itself from its parent. This happens after the layout has been hidden. Bug: 1128279 Change-Id: Iab8f1f36487bf021868591d9013c4852141ae690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414614Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808986}
-
Brian Sheedy authored
Fixes an issue in the Skia Gold Python code where if initialization failed the first time, subsequent attempts would fail due to trying to use a potentially deleted JSON file. This is fixed by making a copy on object creation that is used instead of the provided file. Bug: 1077274 Change-Id: I03ca402ed27bfedf81de320863c6c1946733b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419691 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808985}
-
Kartik Hegde authored
When the socket connections don't need to be made, return early. BUG=chromium:956783 TEST=unit_tests --gtest_filter=HttpFirewallRoutineTest* Change-Id: I51f2a42fd141742d89f1f75e91b02e14242ae666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420569Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#808984}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600076215-benchmark-87.0.4265.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib4a7889d5791ccd3ba9865050c4504053cd7d26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808983}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4247.0-1600080536-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56f13173cff64b8630070328cf938f958e2eb40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808982}
-
Olivier Yiptong authored
This change switches the Mac font enumeration API backend to use the browser-side implementation. This makes it in-line with all the other platforms and simplifies the code. The renderer-side implementation is removed as well. Fixed: 1119575,1061625,1063172 Bug: 2410594 Change-Id: I3751a5ac7496f6990f4e1f7132e068900e0a1cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411330Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#808981}
-
John Delaney authored
What: Stop reporting the AsyncTask from LocalDomWindow::DisaptchPostMessage() to the ad tracker. Why: A common loading flow for pages is: - show an ad in an iframe - wait for a postmessage from the ad to indicate it has finished - render some content Currently, anything a non-ad script does in response to a postMessage from an ad iframe gets considered an ad. We would like to use the ad status of the script processing the postMessage as a sole indicator of whether an ad is being created, rather than the frame the message was sent from. This is only an issue for same-renderer postMessages, as we currently do not route any information alongside the messages sent to a different renderer. Bug: 1127829 Change-Id: Id3e5e8c9fa313ad50fa915c28114c7fc11bbc1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416747 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808980}
-
Eric Lawrence authored
Update the code's comment to match the behavior; HKCU is checked first, and then HKLM is consulted. Bug: 1034919 Change-Id: I9e649766b6ce2328322b287267c97e9344449075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393975Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808979}
-
Glen Robertson authored
Exclusion was added as a workaround in crrev.com/c/2413427 Bug: 1126800 Change-Id: If0b09f564288810cd89e910aa8c463dd5bdef25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417474 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Carlos Pizano <cpu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808978}
-
Dominique Fauteux-Chapleau authored
This reverts commit a9fc4ecc. Reason for revert: b/169019687 Original change's description: > Remove UnsafeEventReportingEnabled policy > > This should not change deep scanning behaviour with Connectors since > OnSecurityEventEnterpriseConnector replaces this policy. Removing this > policy completely is safe since it was marked as future and it has only > been delivered as a cloud policy. > > Bug: 1103390 > Change-Id: Ie886239acd53e28c5a9104812738b7627d082a47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414550 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808361} TBR=rogerta@chromium.org,pastarmovj@chromium.org,zmin@chromium.org,drubery@chromium.org,domfc@chromium.org BYPASS_POLICY_COMPATIBILITY_CHECK='future was already in use on the policy' Bug: 1103390 Change-Id: I59f8bb3b5925acdbd6e66fdb80a592a898dde4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422165 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#808977}
-
Aleks Totic authored
I believed that empty-cells:hide was a css attribute on table, that afffects how cells are drawn. This was wrong. empty-cells:hide is a css property of a cell, inherited via CSS. Old way made this test fail: external/wpt/css/CSS2/tables/empty-cells-applies-to-014.xht Bug: 958381 Change-Id: I0fcc09bec995fd743e31d9e9ad688431e92f666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416840 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808976}
-
Joon Ahn authored
Add escapes for special characters in param names and values. This is a reland of efbdaef4 Original change's description: > flags: Add support for FEATURE_WITH_PARAMS_VALUE_TYPE feature in switches > > Fixed:805766 > Test:autoninja -C out/mychrome components_tests && ./out/mychrome > components_tests > TESTED=autoninja -C out_hatch/Release chrome && deploy_chrome > --build-dir=out_hatch/Release --device=$DUT > > Verified by setting a feature with param in chrome://flags on hatch > > Change-Id: I83f8c81237c3db50a4f23bf5b17e73363bf10504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401336 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806278} Change-Id: If059b946bd8596aebec440e14e5f6a8a66b222da Fixed: 1130035 Bug: 805766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419636 Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#808975}
-
nancylingwang authored
The ARC side has used the new icon request mojom interfaces, so the old icon request mojom interfaces in the Chromium side can be removed. BUG=1083331 Change-Id: I8421d58c035564ca6e9b944775bec85a11f4d5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346093Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808974}
-
James Cook authored
There's no per-platform difference for this function, so consolidate the two copies into one in first_run.cc. No functional changes - this is just cleanup in preparation for a first-run change for the go/lacros project. Bug: 1129954 Test: existing unit_tests Change-Id: I9871f2501f87fdd88f2e7598d0d43cf14fef59ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418570 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#808973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/078776328d3b..9f70b6b2054f 2020-09-21 jmadill@chromium.org Disable slow max uniform count test on D3D11/Intel. 2020-09-21 jmadill@chromium.org Rename ShaderImpl::mData to mState. 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d6935becabad to 0a863bc36554 (1 revision) 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from f0e102e48197 to 7f9879b1b1fa (1 revision) 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9eaa69c21c45 to 4dcc12d1a441 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I2063179b5616fa2fbb4dfd0e5d02f84179de1bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808972}
-
Tarun Bansal authored
This allows us to experiment with larger values for retry delay (e.g., value of 5 seconds would ensure that most of the preconnects finish by that time). Larger values would result in subsequent preconnects being not no-op. Change-Id: I0f35fce774ee752ede434806e7b23f3d1b724e4e Bug: 1130607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419556Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808971}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I214994a5a3dc38959f60ac788bd41e3bcc0a1fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808970}
-
Haiyang Pan authored
* StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withSoftCleanup * StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withHardCleanup Bug: 1130621 Change-Id: I47b1fb54d491fb9973ad2d3be564011775d5505a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422438 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#808969}
-
Devlin Cronin authored
We can migrate extension-apps to web-apps, but should do so only if the user still has the extension-app installed (i.e., hasn't explicitly chosen to remove it previously). Unfortunately, this currently doesn't work - the preinstalled app will still be installed. Add a test for this (with the expectations flipped) so we have it for when it's fixed. Bug: 1130619 Change-Id: Iba936e0311eb24b4d6b6c7460c1790d895df6d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416946 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808968}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uUASMSmV6UorqpFx9y7e18sqPKALaf9znxQWuHu6J5IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/152286436,b/159892033 Tbr: help-app@grotations.appspotmail.com Change-Id: Iba980d91ef67e35c1b8e653f78f8300904f5eea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808967}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cb4733136992..20186d1be641 2020-09-12 apodtele@gmail.com [raster] Improve the second pass (#58373). 2020-09-12 apodtele@gmail.com [raster] Tune SMART macro (#58352). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ib720a2c1b80af9393ba3824247228a2c8d11b22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808966}
-
Aleks Totic authored
Cells with percentage widths have either content or border box sizing. Handling of these is very inconsistent across browsers. This implements my current beliefs, and passes most test: - table-layout: auto ignores content vs border box. - table-layout: fixed distinguishes between content and border box These widths are resolved multiple times inside table layout algorithm: - computing grid_minmax - during table width redistribution Bug: 958381 Change-Id: I93eb167aa4ab9e144d4c44734c04ddbf775ecc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416843 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808965}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/5219421888970752 Bug: 1129246 Change-Id: I7d1e16885b4e2b27edbd8fd498ac5f397f7b3bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417308Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808964}
-
Etienne Pierre-Doray authored
This reverts commit dc3f7433. Reason for revert: AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive failures on multiple Linux bots. Original change's description: > Reland: Enhances editing event intents by surfacing the input event type from Blink > > This patch was reverted because it was believed that it had caused > a failure on the Linux Ozone bots. > However, after running this patch through all the Ozone bots, no failures were detected. > > Original description: > > For every editing operation in Blink, this patch exposes to the browser and to automation clients > the "type" property of its input event from Blink. > > The enumeration listing event intents was too long, and it included > intents such as paste, type and replace. > To make using intents simpler, the list of commands is now trimmed down to a few > generic ones, such as insert, delete, format and SetSelection. > For intents attached to text changed and text attributes changed events, more information > is now provided in the intent's input_type member. > Values are provided by a new enumeration that uses the same members as the > W3C Input Events Specification. > This makes the information more detailed, accurate, as well as standard's based. > > The TextBoundary and MoveDirection enums were also modified to add the "kNone" member > so that event intents such as "kClearSelection" that have no boundary information and no directionality > need not use them. > > Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. > > AX-Relnotes: n/a. > > R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org > > Bug: 989156 > Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808849} TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org Change-Id: I485a6a91e31c69c736b715ba1f570a43419d6160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989156, 1130690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422128Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808963}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/023e1ac7bc8e..d41c2a6b8aeb 2020-09-21 tommi@webrtc.org Remove AsyncInvoker from WebRtcVideoChannel. 2020-09-21 tommi@webrtc.org Remove use of asyncinvoker from WebRtcVideoSendStream. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88520a7047d4a738b754db325be645818e9a93e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808962}
-
Lei Zhang authored
They do not have any references in the codebase. The flags are: autofill-reject-company-birthyear cct-target-translate-language enable-webrtc-new-encode-cpu-load-estimator improved-cookie-controls passive-mixed-content-warning Change-Id: I91022655d4659ce3cfec88308fc79156b894624d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415551Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#808961}
-
Antonio Gomes authored
... and AudioRendererSinkCacheImpl Most files got moved to blink/renderer/modules/media/audio, but audio_device_factory.h. This one is used by Pepper and fuchsia code as well as //chromecast, so it has made it to the Blink public API at blink/public/web/modules/media/audio/. The 'Web' prefix will be added in a follow up. More details: 1/ AudioRendererMixerManager was a RenderThreadImpl variable, so a renderer process level scoped. As part of this CL, DEFINE_STATIC_LOCAL was used in the newly added GetInstance() method. All references to AudioRendererMixerManager were removed from //content. 2/ AudioRendererSinkCacheImpl::ObserveFrame was instantiated in RenderFrameImpl::Initialize. It used to inherit from RenderFrameObserver and deleted itself from its OnDestruct() override. As part of this CL, it now inherits from Supplement<LocalFrame> and get installed by ModulesInitializer::InstallSupplements(). It also inherits from ExecutionContextLifecycleObserver so its existing functionality is kept. 3/ @audio_renderer_sink_cache_test.cc, base::test::TestEnvironment was replaced by base::TestMockTimeTaskRunner. 4/ blink::Platform::GetHungRendererDelay() was added to supply content::kHungRendererDelay. BUG=787252 R=guidou@chromium.org, haraken@chromium.org TBR=spang@chromium.org Change-Id: I3ccfe526632ec5156cc346d6b868287fc45a0a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414551Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#808960}
-
Morten Stenshorne authored
Bug: 829028 Change-Id: I30d3d7349c97b497026141a242209051199c4c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421371Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#808959}
-
Sadrul Habib Chowdhury authored
Allow the LayerTreeHostImpl::SetVisible trace-event to be collected in traces, so that we can measure how long a page is visible for. BUG=1125152 Change-Id: I1be619aca28c88f834bbde989872be68e9f94e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422144 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4559368cc4a1..8614e4925896 2020-09-21 johnstiles@google.com Replace VariableReference::copy_constant with clone(). 2020-09-21 bsalomon@google.com Stop building GL backend on Android Vulkan builders 2020-09-21 jvanverth@google.com Fix D3D non-dev release build. 2020-09-21 johnstiles@google.com Allow a BasicBlock to be dumped, outside the CFG. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I672ee4ade5c45465a096856f34217d7d9aa38c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808957}
-
Luke Sorenson authored
Before this fix, we were unable to successfully restart the Media Perception Service and re-connect over Mojo IPC. Bug: 1129628 Test: Verified on-device this fixes the bug. Change-Id: I3eb60d99320c41ff2aef357ed9ae83a18d9d715a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422183Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#808956}
-
David Dorwin authored
Also breaks out the multiple cases in the *UserAgent tests into individual WebEngineIntegrationUserAgentTests. Change-Id: I4aab782d55ff327456d6a2b638739b0c4ec86204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421655 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808955}
-
Tim Volodine authored
The BundleLanguageTest#testWebLayerString and BundleLanguageTest#testSharedString tests are failing on android-pie-x86-rel. BUG=1130660 TBR=cduvall@chromium.org Change-Id: I6720dddfef3ba936e91685cbb799bda5d297b669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421656Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808954}
-
Andrew Grieve authored
This reverts commit cac6380f. Reason for reland: Fixed typo in .patch file. Original change's description: > Revert "SuperSize: Update to newer emscripten version" > > This reverts commit be818705. > > Reason for revert: Patch was corrupt. > > Original change's description: > > SuperSize: Update to newer emscripten version > > > > * Fixes an issue with an unrecognized compiler flag. > > * Could not get -flto to work and no good error message from the > > failure. Left a TODO to re-enable it. > > > > Bug: None > > Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993 > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808898} > > TBR=huangs@chromium.org,agrieve@chromium.org > > Change-Id: I8cf548eb57ed34b4fd9722ba2843f645c36c3b46 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421871 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808944} TBR=huangs@chromium.org,agrieve@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: Iff705f1de426b219e274d90236b8f8d1c7984550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422166Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808953}
-
Kyle Horimoto authored
This fixes two issues with tablet navigation button settings: (1) This setting is now shown on all devices with tablet capabilities, even if tablet mode is not currently active. Previously, it was only shown when tablet mode was active. (2) The settings search result for this toggle is now only shown on tablet-capable devices. Previously, it was always shown, even in situations where the setting was not available. This CL also moves the location of the IsBoardTypeMarkedAsTabletCapable() function to //ash/public where it can be accessed by settings. Additionally, it removes accessibility_handler_unittest.cc, since the only thing tested in this file was the previous functionality which would only show tablet navigation button settings when tablet mode was active. Bug: 1111564 Change-Id: Iefa982ab3a28fae6ad40fba827cfd658c09fe98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420771Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808952}
-