Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 09 Mar, 2018 36 commits
  3. 08 Mar, 2018 4 commits
    • bsheedy's avatar
      Generalize specifying revisions for VR bisect script · 3379baf7
      bsheedy authored 
      Generalizes the ability to specify specific revisions for other
repositories when using the VR bisect script. Previously, this was only
available as an option for specifying a clank revision, but can now be
used if some other repository is causing compile errors in the
regression range.

Change-Id: Ieb5045b21989541102a1f57bcf17e0b0e18f710c
Reviewed-on: https://chromium-review.googlesource.com/956562
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541944}
      3379baf7
    • Katie D's avatar
      Fix race condition where speech was canceled after starting. · c3123cb9
      Katie D authored 
      This occured when a user used seach+s to start speech while speech
was already in progress. The change makes sure that chrome.tts.stop
is called before the 'isSpeaking' callback is fired, to make sure
that it doesn't get called late.

This may cause a few cancel events to not be logged if the tts engine
responds very quickly, but based on some manual testing it appears
that events should be fine because the tts engine has some latency.

I'm not sure how to write tests for this because it requires a lot
of timing and a real TTS engine. Open to suggestions. Works well based
on local testing, repeatedly using search+s and search+mouse to
to cancel and restart speech.

Bug: 819926
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9b59caa4d69be1c0a8ae14af6c850113ff140360
Reviewed-on: https://chromium-review.googlesource.com/956226Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541943}
      c3123cb9
    • Alan Lau's avatar
      Register action module · 5b621734
      Alan Lau authored 
      Change-Id: I707c135fe9d7e7c18fb881f617c432a24584959e
Reviewed-on: https://chromium-review.googlesource.com/956084
Commit-Queue: Alan Lau <alanlau@google.com>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541942}
      5b621734
    • Michael Giuffrida's avatar
      AppShell: Add missing substitutions for installer template · 82a22608
      Michael Giuffrida authored 
      A new RECOMMENDS field was added to the templates for debian packaging
in https://crrev.com/c/924193, but the substitution wasn't added to the
template processor for AppShell's installer.

This is a band-aid; code like this should be moved into a common place,
like a component that creates installers given product-specific
arguments.

This regression wasn't detected because the CQ doesn't build the
AppShell installer. With the Chrome installer added to Linux CQ bots
(issue 758654), we should consider building the AppShell installer too.

Bug: 729667,820270
Change-Id: I265a3823b8523e15ff295d7f5e46c4b4b9d84f8d
Reviewed-on: https://chromium-review.googlesource.com/956603Reviewed-by: default avatarMichael Moss <mmoss@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541941}
      82a22608