- 03 Oct, 2018 40 commits
-
-
Maksim Sisov authored
There is a new class called WmMoveResizeHandler in ui/platform_window/dir now. This class can be set as a property value to the PlatformWindow, which is derived from the PropertyHandler now. That is, whenever a platform, which implements a platform window supports interactive move/resize events, it can implement a WmMoveResizeHandler and call SetWmMoveResizeHandler to set the handler. DesktopWindowTreeHostPlatform creates a WindowEventFilter now, which is a pre target handler for double click and window interaction events (move,resize). It also gets a handler from the PlatformWindow and sets it to the WindowEventFilter. The handler can be null, which will mean the non-client events won't be handled. When an event comes, it is tested against possible hittest values and whether it's a left click event. If the test is positive, the last mouse pointer location is taken and DispatchHostWindowDragMovement is called. The DispatchHostWindowDragMovement call passes the hittest and the pointer location values to a set |handler_| if it exists, which has its own platform specific implementation to request a server to start move/resize interactions. For example, in case of Wayland, xdg_surface_move or xdg_surface_resize methods are used. In case of X11, _NET_WM_MOVERESIZE message atom along with the last mouse pointer location are sent, and an x11 server grabs a pointer and starts move/resizing operation on a window. The events are also marked as non-client to ensure mouse handlers are not stuck in a "mouse pressed mode" until release events are sent. Normally, when platforms starts interactive move/resize, release events are never sent by compositors, which results in the above mentioned problem. Bug: 854564 TEST: XdgVersionV5Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV5Test/WaylandWindowTest.DispatchWindowResize/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowResize/0. Change-Id: I30f9fc50d9ab50c4cb7c6e76a0a8723015e3c777 Reviewed-on: https://chromium-review.googlesource.com/c/1078248 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#596147}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I2b5af4b25e190a564d9374c94b6f6d43be84da58 Reviewed-on: https://chromium-review.googlesource.com/c/1248245Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#596146}
-
Alexey Baskakov authored
TBR=tkent@chromium.org Bug: 891575 Change-Id: I03fc86727d16ac81bfde2a15afb5f45085f1ffa6 Reviewed-on: https://chromium-review.googlesource.com/c/1258665 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596145}
-
Maksim Sisov authored
This patch makes use of the PlatformScreen and ScreenOzone implementation. At this point, only basic functionality is added. Multi-display and other features will be added in a follow-up CL. How display fetching mechanism works: During the WaylandConnection::Initialize process, a Wayland compositor announces available global objects including a wl_output, which corresponds to one physical display. However, at this step, the WaylandScreen is not created, but the interface must be bound. Otherwise, we won't get properties of a wl_output aka physical display until something is changed on the display. That is, when a wl_output is announced, the WaylandConnection calls to a WaylandOutputManager, which creates a WaylandOutput wrapper class, and binds to the announced interface. As soon as the interface is bound, the Wayland compositor starts to send properties of the corresponding display through a wl_output_listener interface. After this, the WaylandOutput starts to receive property events, which are always stored and sent to a Delegate through a WaylandOutput::Delegate::OnOutputHandleMetrics, which WaylandOutputManager implements. The WaylandOutputManager then forwards those calls to the WaylandScreen (derived from the PlatformScreen), which it has a non-owned pointer to. Talking again about the WaylandScreen, once it is created, WaylandOutputManager has to manually tell the WaylandScreen about the existing WaylandOutputs and share their ids. The WaylandScreen starts to maintain a DisplayList based on those ids. Then, the manager calls the WaylandOutput::TriggerDelegateNotification() method, which triggers property update notifications of the existing WaylandOutputs. Once the browser is running, and the WaylandScreen exists, there is no need to manually trigger the updates. Instead, the WaylandOutputs immediately send the updates on each property change as described above. In the follow up cls, I will add more functionality and implement not implemented methods. Bug: 875161 Change-Id: I8d533149641bd5ee1970cd36c3c8601d5a81b7db Reviewed-on: https://chromium-review.googlesource.com/c/1236268 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Jinho Bang authored
This patch is initiated from this comment[1]. After this patch, the following small bugs are also fixed. - The PaymentResponse.details should always return same object. - If no details, should return empty object instead of undefined. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1226774/6/third_party/blink/renderer/modules/payments/payment_method_change_event.h#42 Bug: none Change-Id: Ib784013fbdedd42d30eb820a82d51ec4d08550f4 Reviewed-on: https://chromium-review.googlesource.com/c/1253862 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596143}
-
Yutaka Hirano authored
There are some failures when validating URLLoaderClient method parameters, and one suspect is null data pipe. There are some callsites passing data pipes created with mojo::DataPipe without null checks. There are DCHECK in DataPipe constructors, but we suspect the assumption fails in the wild, so turn them to CHECK. Bug: 890468 Change-Id: I222af288ac17a439ac2cfbc4b1bd41c12cd4fb70 Reviewed-on: https://chromium-review.googlesource.com/c/1258686Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596142}
-
David Jean authored
- Stop filtering folders out of search results in mediator. - When user selects a Folder in search results, recompute and reset the stack of view controllers, so that the user is in proper place in the bookmark panel stacks for back button functionality. Video: https://drive.google.com/file/d/18-dhC7ZE4j5tounA9I6LiLNGBtTVyTJM/view?usp=sharing Bug: 886612 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7ac42afcaba937b278548f3a37b8d07b87dc4a67 Reviewed-on: https://chromium-review.googlesource.com/c/1254142 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#596141}
-
Hans Wennborg authored
../../content/browser/renderer_host/render_widget_targeter.cc:63:22: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] TracingUmaTracker& operator=(TracingUmaTracker&& tracker) = default; ^ ../../content/browser/renderer_host/render_widget_targeter.cc:73:13: note: move assignment operator of 'TracingUmaTracker' is implicitly deleted because field 'id_' is of const-qualified type 'const int' const int id_; ^ Bug: 890307 Change-Id: I233c101f236053f02ec3affb9ea2b4655ad98d49 Reviewed-on: https://chromium-review.googlesource.com/c/1256922Reviewed-by:Ken Buchanan <kenrb@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596140}
-
Hans Wennborg authored
../../extensions/browser/service_worker_task_queue.cc:77:21: note: move assignment operator of 'WaitingDidStartWorkerTask' is implicitly deleted because field 'extension_id' has no move assignment operator const ExtensionId extension_id; ^ Bug: 890307 Change-Id: Ifb5eac24bd150c9a20d170f0ef084334abfb6601 Reviewed-on: https://chromium-review.googlesource.com/c/1256807Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596139}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ifc6a5df838d21e14090c5e3b66d89590f3516424 Reviewed-on: https://chromium-review.googlesource.com/c/1258417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596138}
-
Matt Falkenhagen authored
ServiceWorkerContainerHostPtr is cloned in several places, not just for worker fetch contexts now. Bug: 715640 Change-Id: I8670b4fea9e215a00b9a1c5788e7ca9a2e8eaca3 Reviewed-on: https://chromium-review.googlesource.com/c/1256466Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596137}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe82844a1a45..dfd8fd1ee3a9 Created with: gclient setdep -r src-internal@dfd8fd1ee3a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I26ab69d72bc6320c9c4ce77f3982a20ee85acd73 Reviewed-on: https://chromium-review.googlesource.com/c/1258416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596136}
-
Hiroki Nakagawa authored
Using WebLocalFrameImpl in core/ is disallowed by core/DEPS. Bug: n/a Change-Id: Ie3f28322332132040850d89e9aaaf2d7a30a4fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1257467Reviewed-by:
-
Amos Lim authored
Replace NullString with EmptyString since [TreatNullAs=NullString] is deprecated. This CL has no behavior changes. Bug: 497307, 831544 Change-Id: I4ae886b3f3b1159f67b9897e2e0f4f0423477f7f Reviewed-on: https://chromium-review.googlesource.com/c/1175589Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#596134}
-
Yuichiro Hanada authored
Chrome OS provides the fallback virtual keyboard for IMEs that provide their own HTML-based virtual keyboard. It's not useful for ARC IMEs because their UI is based on Android's View. This CL disables the fallback virtual keyboard while an ARC IME is active. Bug: 845079, 890677 Test: unit_tests Change-Id: I9a799cf049c886cdc25f7ae04a97d716e38338ea Reviewed-on: https://chromium-review.googlesource.com/c/1253318 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#596133}
-
Kenichi Ishibashi authored
In production, the loader factory runs on a background thread. Change-Id: If5261b012d96b714135118a2157092cb7fa983f2 Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1256396 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Robert Ogden authored
This infobar notifies existing DataSaver users that this new feature will impact their secure page browsing as well. This is done on the first eligible pageload after the feature is released and enabled. A simple boolean pref keeps track of this state persistently. The user does not need to interact with the infobar. Once it has been shown one time it should not be shown again and this preview can be triggered. Prior to being shown, the preview should not be triggered on otherwise eligible page loads. Users who do not have DataSaver enabled should not see the infobar. Bug: 889124 Change-Id: I6eb52f516555980a0af90505637201669451c03f Reviewed-on: https://chromium-review.googlesource.com/c/1244903 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/deb512045e6a..be8193c9313a git log deb512045e6a..be8193c9313a --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df836ff8f17d..607f907d47b0 (2 commits) Created with: gclient setdep -r src/third_party/skia@be8193c9313a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib5d3b17cff2cd936e95c118cc737ce95f1b1c363 Reviewed-on: https://chromium-review.googlesource.com/c/1258414Reviewed-by:
-
Tarun Bansal authored
Enable the experiment to delay low priority requests on multiplexed connections. net-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/abRbGlGlNd0 loading-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/s22tVFiDru0 predictability-advice: http://shortn/_WJaP3jsRbk Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6141733ec7bfbd45c6b3c3d8ed98857104dee442 Bug: 836552 Reviewed-on: https://chromium-review.googlesource.com/c/1257677Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure DetectedBarcode, DetectedFace, and DetectedText results can be passed as a message in postMessage(). Change-Id: If8e50d359a321816222a3fabfa9bb02c4106154a Reviewed-on: https://chromium-review.googlesource.com/c/1251549Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78bda58bfcba..fe82844a1a45 Created with: gclient setdep -r src-internal@fe82844a1a45 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia83cfed80a0f7c1d41f39542c0b1db3c1dd3b656 Reviewed-on: https://chromium-review.googlesource.com/c/1258415Reviewed-by:
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I361dbb5b1bf477623a772f1b0e6d074283bf6c5d Reviewed-on: https://chromium-review.googlesource.com/c/1258642Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e6ded16045a9..086cac5c439c git log e6ded16045a9..086cac5c439c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 buildbot@webrtc.org Roll chromium_revision b06fe539..601c715f (595926:596047) Created with: gclient setdep -r src/third_party/webrtc@086cac5c439c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I84e748da83bbd53a5df6afee6f0eb26a6d9743b2 Reviewed-on: https://chromium-review.googlesource.com/c/1258413Reviewed-by:
-
Yutaka Hirano authored
The test has used synchronous XHR, but blink::ThreadableLoader ignores a network error for the synchronous case. Currently CORS is implemented in ThreadableLoader and thus the error is notified, but that will not be true with out-of-blink CORS. This CL fixes the test so that it uses asynchronous XHR to make it pass even with out-of-blink CORS. Bug: 870173 Change-Id: I1c315ddf7f2a25d54f6de7f297d16677da8ba862 Reviewed-on: https://chromium-review.googlesource.com/c/1245057Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596124}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bebca3c7eec..78bda58bfcba Created with: gclient setdep -r src-internal@78bda58bfcba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I92e681dd678e574a629f5473740a1ae5b047c1ff Reviewed-on: https://chromium-review.googlesource.com/c/1258411Reviewed-by:
-
Hiroki Nakagawa authored
This CL makes SharedWorkerScriptFetcher ask network interceptors if they want to handle a response served by the default network loader. This is necessary for supporting AppCache's fallback. A possible confusing point of this CL is SharedWorkerScriptFetcher::OnReceiveResponse() can be called twice. First, it's called when the interceptor or the default network loader serves the shared worker's main script. Then, it's called again when the interceptor wants to serve an alternative response for the response served by the default network loader. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I93b45fa1f2e42422c0e85d3a67471c891dc5992a Bug: 715632 Reviewed-on: https://chromium-review.googlesource.com/c/1224611Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596122}
-
Joe Downing authored
We've received reports that the disconnect window is appearing at odd times after the auto-hide timeout has taken effect. I suspect there could be hardware which is emitting spurious HID events which is triggering the reshow logic. My assumption is that this behavior is't egregious, otherwise the user would notice the mouse cursor moving or errant keypresses. Thus I want to prevent triggering the reshow logic if we receive a RAWINPUT event where the cursor has not moved and no button states have changed. Bug: 891584 Change-Id: Id9efd72f24f8caf0e67b1a717fee2bbafaab55af Reviewed-on: https://chromium-review.googlesource.com/c/1258316 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#596121}
-
Andrey Kosyakov authored
... just use the command line switch instead. This is one of a steps to prepare for the network service migration -- network service does not expose an interface other than command line flag to configure resolver, so we could as well let it interpret the flag directly. Bug: 838291 Change-Id: I249beb1b64a0b5f332a1f2fa43325af2c4c0a6b6 Reviewed-on: https://chromium-review.googlesource.com/c/1258326Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596120}
-
Hiroki Nakagawa authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6933b37bf1e876f5c622876dd1c84ff830436c6a Bug: n/a Reviewed-on: https://chromium-review.googlesource.com/c/1245341Reviewed-by:
-
Malay Keshav authored
This patch implements a thread safe wrapper for the core skottie animation object. We want to share the same animation resource file for multiple SkiaVectorAnimation objects. This would allow us to do that. This is also needed to implement the Phase 2 and Phase 3 of rasterization where the rasterization would be handled by different threads. go/cros-skottie Bug: 890512, 890224 Change-Id: I40371e58985ea4db5661f28a2ee8b31aab354a03 Component: Skia vector animation, skottie Reviewed-on: https://chromium-review.googlesource.com/c/1253071Reviewed-by:
-
Victor Miura authored
Adds stories for root scroller cases, with a "position:fixed" element on top. BUG=880195 Change-Id: I3b293a1818225aca5807adc60f5db3954d61eb95 Reviewed-on: https://chromium-review.googlesource.com/c/1252634Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#596117}
-
Bo Liu authored
Obtained desired data. Bug: 841572, 891053 Change-Id: Ib81d8fb1ad0dc6df8437fe16264c249b60a5ae30 Reviewed-on: https://chromium-review.googlesource.com/c/1257856Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596116}
-
Tetsui Ohkubo authored
This CL adds NewUnifiedMessageCenterView and UnifiedMessageListView that replace UnifiedMessageCenterView, and MessageListView. The new implementation is behind a flag (--enable-features=NewMessageListView). Eventually old implementation will be removed and NewUnifiedMessageCenterView will be renamed to UnifiedMessageCenterView. Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest BUG=769219 Change-Id: I1db9d73acfed918bc73b828ef3b406ef5da97a0c Reviewed-on: https://chromium-review.googlesource.com/c/1244182 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596115}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/779366899ae8..e6ded16045a9 git log 779366899ae8..e6ded16045a9 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 qingsi@google.com DCHECK that PortAllocator::SetConfiguration does not create a pooled 2018-10-02 steveanton@webrtc.org Check all BasicPortAllocatorSession methods are called on the network thread 2018-10-02 peah@webrtc.org AEC3: Correct the check for not reacting on initial pre-amp gain changes Created with: gclient setdep -r src/third_party/webrtc@e6ded16045a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ba1d5747615e0324eaafcfb04efad2ca76e5ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1258255Reviewed-by:
-
yoshiki iguchi authored
Previously it was rarely visible but now it's visible on closing. So this CL improves the quality of shapshot by enabling shrink filter. Bug: none Change-Id: Ic509de0d83d5641f9a18acdb73e759639cb38507 Reviewed-on: https://chromium-review.googlesource.com/c/1255749Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596113}
-
Koji Ishii authored
Following bot results are included. 10213 10215 10219 10221 10225 10229 10232 10234 10241 10246 2 lines were removed and 3 lines were deflaked by consecutive results since 10201. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic45d48d8852938576bbb01d1758853875795cda4 Reviewed-on: https://chromium-review.googlesource.com/c/1255742 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596112}
-
Alexey Baskakov authored
TBR=poromov@chromium.org TEST=none Bug: 891573 Change-Id: I3837b32e995ac6d7dd757ca70a0a8d16e6c7e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1257485 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This changes how we calculate the reference box when the layout box is a non-atomic inline. It was very broken for LayoutNG; we just set the height to 0. For legacy layout we used the width of the bounding box for all lines and the height of the first fragment. Instead, consistently use the size of the first fragment, in both NG and legacy. Also get it right if writing-mode is vertical-rl. Bug: 641907 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I652f197bc3d950fad1bf6067dc5f38c2df72a0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1256808Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Joel Hockey authored
This is a reland of dec38a71 Failure was flaking in test FileManagerUITest.Crostini which was caused by dialogs not being fully cleared before a new dialog was being shown. This is fixed by changing the test code to wait for the dialog elements to be fully removed from the dom: assertTrue(test.fakeMouseClick('button.cr-dialog-ok')); test.waitForElementLost('.cr-dialog-container'); rather than just waiting for the .shown class to be removed: assertTrue(test.fakeMouseClick('button.cr-dialog-ok')); test.waitForElementLost('.cr-dialog-container.shown') The behaviour that we were getting was: 1/ show dialog1: adds div.cr-dialog-container.shown to body 2/ test clicks on OK button to close dialog1. 3a/ dialog1 div.cr-dialog-container removes .shown attr The removal of the dialog div is delayed by design. 4/ next test show dialog2: 2nd div.cr-dialog-container added to body 5/ test clicks on OK button to close dialog2, but actually ends up clicking on dialog1 6/ Error at https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/dialogs.js?l=262&rcl=e20c6e8387cdccf61eef8615ac2b3b0a582b156b 3b/ dialog1 div finally removed from dom. Original change's description: > CrOS FilesApp: Share crostini entries before opening > > When a user opens files within Downloads using a crostini app, > show a dialog for the user to give permission to share the > directory that the files are in with crostini. > > * Move handling of 'crostin-files' flag checking into > foreground/js/crostini.js > * Change FileTasks.executeInternal to detect files that > can be shared with crostini and do sharing before execute. > * UI Test verifies share dialog is shown before execute. > * ConvertFileSystemURLToPathInsideCrostini maps > path from within Downloads to '/ChromeOS/Downloads/...' > > Bug: 878324 > Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 > Reviewed-on: https://chromium-review.googlesource.com/c/1243871 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596003} Bug: 878324 Change-Id: Ied6225dca13a244ebbdbfa291fdd789d762ee140 Tbr: nverne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1258683 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596109}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0daedf7758e1..22300e1fb562 git log 0daedf7758e1..22300e1fb562 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 iannucci@chromium.org [led] Roll led to add gerritcodereview scope to edit-cr-cl Created with: gclient setdep -r src/third_party/depot_tools@22300e1fb562 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3c670d7937c72b4f755b8a12723d94c3006a7bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1258254Reviewed-by:
-
