- 10 Aug, 2020 30 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c255306f7cd6..fbb7e0951a27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I612d68b3a0fb6f7ca670f7f78263ab15b6a3ad8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345288Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796312}
-
Curtis McMullan authored
This CL adds the metrics for interactions with the virtual keyboard handwriting suggestion menu. The code to record the metrics is added in the following CL: cl/325364890 BUG=1114003 Change-Id: Id3fd1f9d2a44edce169e665a690b8627aec3ee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342485Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796311}
-
Khushal authored
We were incorrectly using fences from the video buffer for initializing the fences used for the primary plane. While this was hitting a debug assert it didn't cause any errors in the metric since the primary plane is always scheduled last, so the fences eventually used in the metric did belong to the primary plane. R=vikassoni@chromium.org Bug: 1100442 Change-Id: I7412c4f81d6356849a1b3b42c9af94c06d565882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344007 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796310}
-
Mihai Sardarescu authored
The canonical cookie domain needs to start with a ".". This CL uses a helper function to create a domain for the cookie instead of having this inlined in each test. Bug: None Change-Id: If00f14e0f19ed9fc89fbc0ff93471f07e37a8f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332612 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796309}
-
Andy Paicu authored
TBR: jdeblasio@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113105 Change-Id: Iec8d55a08534d24fc5b4fc4fa612a1770ba669e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344445Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796308}
-
Karel Král authored
Use the newer LibTooling API (bind instead of id). Fix empty_string/tests for use with tools/clang/scripts/test_tool.py Bug: 1111787 Change-Id: I8cdd62f05afd9f41cc3eec22d638d39d39c32ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343065Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#796307}
-
Marc Treib authored
MockHostResolver::AllowDirectLookup("host_pattern") ensures that hosts matching the pattern are not affected by host resolver procedures (commonly used to map hosts to the embedded_test_server). These calls are important in E2E tests, but really have no business in regular browser tests, so let's get rid of them there. It turns out that two tests from SyncErrorTest.* depended, very indirectly, on the presence of the AllowDirectLookup() calls. These tests are updated here to become more robust. See more details on the linked bug. Bug: 1112789 Change-Id: I69430b6ceecb904d063e17f8ac8d59f15a1544d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339986 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796306}
-
Preethi Mohan authored
Bug: 1098096 Change-Id: Iad313e98c90616d2b2ab04ccb6682ecbdeb2274c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325082 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#796305}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597017082-f8f51ec7c105c76c8c188f2df326b7b00c9b3e5a.profdata to chrome-mac-master-1597037945-c748d93b7b3b8df201950e67d57a776238968dea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I82719b0b5d037149b32096f4511538facd2d9a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796304}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3b46e8ff5b2b3ed83e5a1744b470a683fa2e056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796303}
-
Zain Afzal authored
crrev/c/2316189 removed the need for a save copy delegate function by adding the save as code path, to make sure TOT wasn't broken it left the old save copy delegate function as is until the next version of the media app was rolled in. crrev/c/2344327 should update the version of media app so it no longer uses the "save copy" function and as such its now safe to delete it. Change-Id: I5f7a67ffec261a8d76c1c1e6e4ff2e82851f2743 BUG: b/161193454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344436Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#796302}
-
Omar Morsi authored
This CL refactors the enumerator chromeos::platform_keys::KeyAttributeType::CertificateProvisioningId to kCertificateProvisioningId so as to comply with Google C++ Style Guide and to be consistent with chromeos::platform_keys::KeyAttributeType::kKeyPermissions attribute that will be added in a future CL. Bug: None Change-Id: Idd46415a0140a56fd63636c75dcb6b3d68625332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343078Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#796301}
-
Alexander Hendrich authored
voit@ has left the team, replacing with general policy owners. Bug: none Change-Id: I218c0b531a38af59f0084099c88c022b7553871a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341130 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#796300}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2f3a43df40..5d3b414c97dd 2020-08-10 paulirish@chromium.org InspectorFrontendHostStub.close() should release createObjectURL memory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48e3108449c815a4b44fcd6b01b8af1ce05cb8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31954bf23f24..64aee0acaab2 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 2cf5a08cfc1b to 1662e97f324e (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I7168658b559e7d66b6c1d311e3242e10fba0c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796298}
-
Jiewei Qian authored
This CL adds a RegisterAutoGrantedPermissions method WebUIAllowlist. This method allows registering a list of permissions, instead of doing a for-loop. Also adds a comment about permissions (and content settings) commonly wanted by WebUIs. Bug: 1109773 Change-Id: I50c05d3b2b7672978dbf53c267ddcaa0352c0545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336425Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#796297}
-
Maggie Cai authored
This CL fixes the sharesheet button type in file_manager.css. BUG=1097623 Change-Id: I902164400191bafcefe09489129e2441dd0a2838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335851Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#796296}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcddb0efbf60..ea2f3a43df40 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3c977f47e147e1e45161ddb139304b94bd0cfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dbe3f25ad27..c255306f7cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I57aa3031ef6ed401b07caea1abfb157d618f0e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345093Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796294}
-
Miyoung Shin authored
This is a reland of a7c54a0f Original change's description: > Fix a crash in WebUIMessageHandler::AllowJavascript > > If WebUI's JS is sending the message when we navigate cross-site, > then we use the new process ID from WebContents in > WebUIImpl::CanCallJavascript and a CHECK crash will happen. > > This CL changes to use the old process ID from RFH in > WebUIImpl::CanCallJavascript. > > Bug: 1110276 > Change-Id: Ie827060b637dbd3aa4c7ad771c0cb4862763ced2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326050 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#793816} Bug: 1110276, 1112189, 1112238 Change-Id: I02916364f8cb3871ab4cdf17cd2827a5f1cfbb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335213Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#796293}
-
Zhuoyu Qian authored
Bug: 1100751 Change-Id: I93cf812110c67bdd105678057af49469d24ebd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335716 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796292}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ibfa1420915f08f9afd0ca8c7bf11d92848d470b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345490Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796291}
-
Sergei Datsenko authored
Don't drop errors on the floor when can't identify of find the mentioned file. Bug: 1012031 Change-Id: I39111b68a6e719bdf989b4e29aba67f270d256ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342226Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#796290}
-
Ahmed Mehfooz authored
Bug: 1111969 Change-Id: I5fafeb1002852d5c584209e4da2bb492b72113fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343006 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796289}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/101a5829d50f..1662e97f324e 2020-08-10 jiawei.shao@intel.com Add tests for lazily initializing indirect buffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I129f58ac2ffff62b44365742a4ebaa68ed25ac37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796288}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596990221-f7c51694ae9bdb5086b4bb0c066d592c9842dbc8.profdata to chrome-mac-master-1597017082-f8f51ec7c105c76c8c188f2df326b7b00c9b3e5a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I75f5211412da1cc29ac03da97f797c5deb74048b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb506f87ca90..6dbe3f25ad27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I5c3b58412792ad38d85eb5e000968698c465511f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345524Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796286}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/UZ0LaGP4pONeWSmuhGzTHaNGXAnBjLFccXtfgum0L4QC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008090800_RC00.html Bug: b/161193454, b/163023477, b/162996761 Fixed: 1112752 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ie0060eb5151bbb308ca6e26b0218549b0417cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344327 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#796285}
-
My Nguyen authored
According to spec, max width should be 488dp. Annotation_label sets to 16 else it will resize when in multi-line. Current view: http://screen/VNjzkDSKZ0D Spec: go/assistive-inputs-figma Bug: 1094843 Change-Id: I80fdb6a38f4139d5e4b52ea14e156364d7a243f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344435 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#796284}
-
Melissa Zhang authored
This CL removes margins and ensures Actions appear before apps. Bug: 1097623 Change-Id: I787cb122e60f569a2085060ad32044fb9e86c437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342334Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796283}
-
- 09 Aug, 2020 10 commits
-
-
Dylan Cutler authored
We want to abort the instrumentation as early as possible for users not in the study, so each overload has its own guard clause. Bug: 973801 Change-Id: Ifed7e75ef90cff0bc41cad2eeaaeaf5bea340e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341809 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#796282}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ac006783519..cb506f87ca90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4a5d160374f614a8512ef78952a7a64ff7c223be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796281}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I51e985fc81e4526f0a0403c56f3c906652dbea0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796280}
-
Josh Simmons authored
allow experimentation and capability testing. Bug: 1111229 Change-Id: I4737f4b52737977619f98f6cc18a166eeae89a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328254Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#796279}
-
My Nguyen authored
Based on UX Writing review, update the learn more string. Current view: http://screen/JQq8aOgGExX Also update font size to 11 according to spec go/assistive-input-figma Bug: 1094843, 1113612 Change-Id: Ic70c29cd101ab813e4fb72b881b616d5c188c327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344433Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23d59f2f20fb..3ac006783519 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I22a1d181fca998d14d581064e3d4677f946cbf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345435Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796277}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596969922-273270c5768fa245d6eb486d3911a64a186d6010.profdata to chrome-mac-master-1596990221-f7c51694ae9bdb5086b4bb0c066d592c9842dbc8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I3be31b4ffabb2f03623e98c79d5fd1b49a6f4734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796276}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1114450 Change-Id: Ie0518baca0bbc3f7835864dea236bcf2b676864e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344663Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796275}
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: I5e95537b9d194c83bbb483dc38a19358437c8a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339993 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#796274}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecdc9f6fa97..23d59f2f20fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I015890d5e8fc378ac7f4a0cab92a4890066df612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796273}
-