GitLab

Currently WebContentsViewDelegate has a mix of ObjectiveC and C++ code
guarded by #ifdef OS_MACOSX. This means, on Mac, it can only be included
in .mm files.

For views on Mac, we want to reuse the toolkit-views WCVD (and tests)
when hosting a WebContents in a views::Widget. So we can't convert
everything to .mm.

This CL changes the guards to use __OBJC__ and ensures the vtable is a
consistent size with the compile flags used on MacViews.

To reduce churn, the WCVD methods are given default implementations.
MacViews needs the other methods, currently guarded by USE_AURA, so
things get really complex without this.

BUG=399191

Review URL: https://codereview.chromium.org/507363002

Cr-Commit-Position: refs/heads/master@{#292349}

BUG=259656
TEST=manually

Review URL: https://codereview.chromium.org/510713002

Cr-Commit-Position: refs/heads/master@{#292348}

The role of MountedDiskMonitor is replaced with DeviceEventRouter.

BUG=360946,396258
TEST=manually

Review URL: https://codereview.chromium.org/479563007

Cr-Commit-Position: refs/heads/master@{#292347}

https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/516563003

Cr-Commit-Position: refs/heads/master@{#292346}

Review URL: https://codereview.chromium.org/508953003

Cr-Commit-Position: refs/heads/master@{#292345}

Cleaning up weak_ptr_factory destruction order in "src/net" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/506523002

Cr-Commit-Position: refs/heads/master@{#292344}

https://codereview.chromium.org/501093003/

BUG=None
TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/517483002

Cr-Commit-Position: refs/heads/master@{#292343}

Heap allocated MultiThreadedCertVerifier was passed to URLRequestContext::set_cert_verifier, which doesn't take ownership.

Leak was introduced in r249928.

BUG=NONE

Review URL: https://codereview.chromium.org/516453002

Cr-Commit-Position: refs/heads/master@{#292342}

Currently, it crashes entire chrome. This CL is to stop devtools gracefully
when socket for http server cannot be instantiated because of any reasons
including address-already-in-use error.

BUG=407999

Review URL: https://codereview.chromium.org/516483002

Cr-Commit-Position: refs/heads/master@{#292341}

BUG=none
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/511903003

Cr-Commit-Position: refs/heads/master@{#292340}

It's flaky on Windows 7, but appears to be okay on Windows 8.

BUG=336558
TEST=None.
TBR=tonyg

Review URL: https://codereview.chromium.org/510263002

Cr-Commit-Position: refs/heads/master@{#292339}

BUG=390086

Review URL: https://codereview.chromium.org/467113004

Cr-Commit-Position: refs/heads/master@{#292338}

Cr-Commit-Position: refs/heads/master@{#292337}

Revert of Re-enable SitePerProcessBrowserTest.CrossSiteIframe (patchset #10 of https://codereview.chromium.org/479403004/)

Reason for revert:
This is causing unaddressable memory errors on the DrMemory full bot. Build where the error was introduced:

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/945

(error hash: 25DFC5E3C30FC6B7)

Sample log output:

UNADDRESSABLE ACCESS of freed memory: reading 0x034348e0-0x034348e4 4 byte(s)
# 0 blink_web.dll!blink::toCoreFrame                                      [third_party\webkit\source\web\webframe.cpp:24]
# 1 blink_web.dll!blink::RemoteFrameClient::firstChild                    [third_party\webkit\source\web\remoteframeclient.cpp:49]
# 2 blink_web.dll!blink::WebRemoteFrameImpl::~WebRemoteFrameImpl          [third_party\webkit\source\web\webremoteframeimpl.cpp:106]
# 3 blink_web.dll!blink::WebRemoteFrameImpl::close                        [third_party\webkit\source\web\webremoteframeimpl.cpp:131]
# 4 content.dll!content::RenderFrameProxy::~RenderFrameProxy              [content\renderer\render_frame_proxy.cc:120]
# 5 content.dll!content::RenderFrameProxy::`vector deleting destructor'
# 6 content.dll!content::RenderFrameProxy::OnDeleteProxy                  [content\renderer\render_frame_proxy.cc:180]
# 7 content.dll!content::MessageRouter::RouteMessage                      [content\common\message_router.cc:54]
# 8 content.dll!content::MessageRouter::OnMessageReceived                 [content\common\message_router.cc:46]
# 9 content.dll!content::ChildThread::OnMessageReceived                   [content\child\child_thread.cc:494]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage                 [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run                                [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask                          [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask                                   [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask                     [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork                                    [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run                                [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler                                [base\message_loop\message_loop.cc:408]
#18 content.dll!content::RendererMain                                     [content\renderer\renderer_main.cc:227]
#19 content.dll!content::RunNamedProcessTypeMain                          [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run                       [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain                                      [content\app\content_main.cc:19]
#22 content::LaunchTests                                                  [content\public\test\test_launcher.cc:475]
#23 main                                                                  [content\test\content_test_launcher.cc:123]

BTW IMHO the CL summary for this change could be better, this change did way more than re-enalbe a test. Ideally the summary would capture the entirety of the change.

Original issue's description:
> Re-enable SitePerProcessBrowserTest.CrossSiteIframe
>
> This CL fixes a few issues in the cross-process subframe navigation and re-enables the CrossSiteIframe test on most platforms. There are still some issues on ChromeOS and Android, which will be investigated and fixed in follow-up CL.
>
> BUG=399775, 357747
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291437

TBR=creis@chromium.org,avi@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399775, 357747

Review URL: https://codereview.chromium.org/515073002

Cr-Commit-Position: refs/heads/master@{#292336}

This CL depends on https://codereview.chromium.org/512943003/

BUG=408373
R=oshima@chromium.org
TBR=tony@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/515723003

Cr-Commit-Position: refs/heads/master@{#292335}

Cleaning up weak_ptr_factory destruction order in "src/ipc" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/508903002

Cr-Commit-Position: refs/heads/master@{#292334}

Per request by blundell@chromium.org (https://codereview.chromium.org/500023002/)

BUG=388515
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/510783002

Cr-Commit-Position: refs/heads/master@{#292333}

Both Pipeline and RendererImpl use it's own lock. We could end up with a dead
lock in the following scenario:
- On main thread, Pipeline holds it's lock (lock A) and calls into RendererImpl,
  which also requires the RendererImpl's lock (lock B).
- On media thread, RendererImpl holds it's lock B and calls callback provided by
  the Pipeline, which requires lock A.

This CL makes sure Pipeline never calls into RendererImpl while holding lock A
and RendererImpl nevers calls (back) into Pipeline while holding lock B. So
deadlock should not happen.

This CL also reverts 3 CLs that disabled various tests due to the bug:
- Revert "Exclude tests that deadlock under DrMemory (and Tsan)"
   This reverts commit 0e014b9a.
- Revert "Disable deadlock-y tests in TSan instead of just suppressing the error."
   This reverts commit f712d106.
- Revert "Suppress a deadlock report through media::Pipeline::GetMediaTime."
   This reverts commit 5c72e0f6.

BUG=407452
TEST=Ran PipelineIntegrationTest.ChunkDemuxerAbortRead_VideoOnly in a TSAN build for 10 mins and didn't see any issue.

Review URL: https://codereview.chromium.org/512973002

Cr-Commit-Position: refs/heads/master@{#292332}

BUG=
TEST=gpu bots
TBR=kbr@chromium.org,bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/516563004

Cr-Commit-Position: refs/heads/master@{#292331}

BUG=407932
TEST=manually

Review URL: https://codereview.chromium.org/507983002

Cr-Commit-Position: refs/heads/master@{#292330}

The test is failing there.

NOTRY=true
TBR=zhaoqin
BUG=408443

Review URL: https://codereview.chromium.org/511903004

Cr-Commit-Position: refs/heads/master@{#292329}

NOTRY=true
TBR=zhaoqin
BUG=408013

Review URL: https://codereview.chromium.org/517453002

Cr-Commit-Position: refs/heads/master@{#292328}

This patch adds a EntryWatcherService, which is a bridge between extensions and
fileapi. Also, WatcherManager interface has been created to let backends
implement their own watching logic.

Note, that EntryWatcherService is not wired up to File System API yet. Also,
a lot of features are missing.

TBR=noamsml, jcivelli
TEST=unit_tests: *EntryWatcherService*
BUG=261491

Review URL: https://codereview.chromium.org/452043003

Cr-Commit-Position: refs/heads/master@{#292327}

When TabModelBase is destroyed, Tabs and Observers List should
be cleared to free any holding tabs and observers respectively.

BUG=None.

Review URL: https://codereview.chromium.org/511903002

Cr-Commit-Position: refs/heads/master@{#292326}

BUG=406227

Review URL: https://codereview.chromium.org/510563004

Cr-Commit-Position: refs/heads/master@{#292325}

BUG=370433
TEST=None
R=sky@chromium.org
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/490123003

Cr-Commit-Position: refs/heads/master@{#292324}

We get the touch ellipse geometry from the major/minor/orientation axis
of the MT protocol. Use those intead of attempting to derive it from
pressure.

BUG=381898
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true

Review URL: https://codereview.chromium.org/509713002

Cr-Commit-Position: refs/heads/master@{#292323}

Revert of Replace NPObject usage in ppapi with gin (patchset #26 of https://codereview.chromium.org/459553003/)

Reason for revert:
Crash in telemetry tests http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/6615

Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3

TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=351636

Review URL: https://codereview.chromium.org/512983004

Cr-Commit-Position: refs/heads/master@{#292322}

Move the gesture event targeting logic from
RootView::DispatchGestureEvent() into ViewTargeter's
overrides of FindTargetForEvent() and
FindNextBestTarget().

BUG=404224
TEST=ViewTargeterTest.ViewTargeterForGestureEvents

Review URL: https://codereview.chromium.org/481433006

Cr-Commit-Position: refs/heads/master@{#292321}

This CL removes the custom layout from SearchBoxView and uses a BoxLayout
instead. This slightly changes the layout of the app list search box.

BUG=406983

Review URL: https://codereview.chromium.org/463403003

Cr-Commit-Position: refs/heads/master@{#292320}

NOTRY=true

Review URL: https://codereview.chromium.org/510163002

Cr-Commit-Position: refs/heads/master@{#292319}

Remove some unnecessary includes, typedefs, and forward declarations.

BUG=none

Review URL: https://codereview.chromium.org/490923006

Cr-Commit-Position: refs/heads/master@{#292318}

height of top infobar arrow doesn't changed through animation when the status
of bookmark bar changes from show to hide/detach.

Set the view of info bar to be auto resizable and change the height of top infobar
arrow when the its frame is changed.

BUG=382141
TEST= ./browser_tests --
gtest_filter="BrowserWindowControllerTest.InfoBarTipStrechedWhenBookmarkBar
StatusChanged", manually tested.

Review URL: https://codereview.chromium.org/435863002

Cr-Commit-Position: refs/heads/master@{#292317}

Depend on the correct target

BUG=388515

Review URL: https://codereview.chromium.org/514603002

Cr-Commit-Position: refs/heads/master@{#292316}

gles2_thunks.cc, gles2_impl_thunks.cc, etc define symbols that should be
exported from loadable modules.  If these files are linked into a static
library and that static library is then linked into a loadable module,
the linker may or may not pull in the object files for the thunks
depending on if any symbols from that object file are referenced by
some other object file in the component.

This puts the thunks into a gypi that can be included directly into a
loadable module so the object files containing the thunks are on the
link line directly and make it into the final library.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/509123003

Cr-Commit-Position: refs/heads/master@{#292315}

Implement HandleContextMenu in ExtensionOptionsGuest so that the right
click context menu within guest views are properly positioned next to
the pointer.

BUG=406885

Review URL: https://codereview.chromium.org/510993002

Cr-Commit-Position: refs/heads/master@{#292314}

Create a component necessary for showing PDF in a content-based client. Much of
the relevant code currently lives in //chrome/, and is usable by chrome. Moving
this code into a separate component in //components/pdf/ allows it to be easily
used by other content-clients (e.g. app-shell, athena, etc.). This patch moves
PPB_PDF_Impl (implementation for the PPB_PDF interface in ppapi) and the
relevant IPC messages in the pdf component.

A short summary of the changes in this patch:
. Move ppb_pdf_impl.cc|h into //components/pdf from //chrome/renderer/pepper
. Put this code in the 'pdf' namespace. This code lives in 'pdf_renderer'
  target. 'chrome_renderer' depends on this target.
. Move the following IPC messages from render_messages.h to pdf_messages.h:
  - PDFUpdateContentRestrictions
  - PDFHasUnsupportedFeature
  - PDFSaveURLAs
  - PDFModalPromptForPassword
 Change the prefix of these messages from ChromeViewHostMsg_ to PDFHostMsg_
. Move PDFTabHelper into //components/pdf from //chrome/browser/ui/pdf.
  Put this code in the 'pdf' namespace. This code lives in 'pdf_browser'
  target. 'chrome_browser' depends on this target.

BUG=401242
R=blundell@chromium.org, raymes@chromium.org, thestig@chromium.org, tsepez@chromium.org
TBR=darin@chromium.org for DEPS

Review URL: https://codereview.chromium.org/477263003

Cr-Commit-Position: refs/heads/master@{#292313}

BUG=406575
TBR=cpu@chromium.org for changes to *.grd

Review URL: https://codereview.chromium.org/497843002

Cr-Commit-Position: refs/heads/master@{#292312}

. RootNodeManager->ConnectionManager. A better name might be
  ViewManagerServiceImplsManager, but I can't come to type that in.
. Node->ServerView. I really want to use View, but having a class
  named View in the server and lib has confused everyone I've talked
  to and makes talking about View extremely abiguous.

BUG=none
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/513923004

Cr-Commit-Position: refs/heads/master@{#292311}

BUG=

Review URL: https://codereview.chromium.org/512943002

Cr-Commit-Position: refs/heads/master@{#292310}