GitLab

BUG=488194

Review-Url: https://codereview.chromium.org/2627113002
Cr-Commit-Position: refs/heads/master@{#443120}

. Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe.
. Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change.

Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway.

R=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2610853013
Cr-Commit-Position: refs/heads/master@{#443119}

Review-Url: https://codereview.chromium.org/2620363003
Cr-Commit-Position: refs/heads/master@{#443118}

Revert of Moves definitions of RootWindowController into root_window_controller.cc (patchset #2 id:20001 of https://codereview.chromium.org/2628973002/ )

Reason for revert:
Attempting to resolve error in
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumOS%20amd64-generic%20Compile/builds/28853

>On 2017/01/11 22:44:48, James Cook wrote:
>> FYI I have a CL that deletes this method. We'll see who lands first.
> Done.

It looks like jamescook@ committed a bit more than four minutes earlier.
-- sheriff.

Original issue's description:
> Moves definitions of RootWindowController into root_window_controller.cc
>
> As part of this I made sure the definitions and declarations matched
> up. This resulted in reordering a couple of things. In addition the
> only other non-move I did was moving what was CreateLayoutManagers()
> into InitLayoutManagers() and CloseChildWindowsImpl() into
> CloseChildWindows().
>
> BUG=671246
> TEST=none
> R=jamescook@chromium.org
>
> Review-Url: https://codereview.chromium.org/2628973002
> Cr-Commit-Position: refs/heads/master@{#443109}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20a89e7b56ad53a58f19edf4775528d066577d5

TBR=jamescook@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671246

Review-Url: https://codereview.chromium.org/2623393002
Cr-Commit-Position: refs/heads/master@{#443117}

Move these classes into components/safe_browsing_db/ and update references

BUG=679018

Review-Url: https://codereview.chromium.org/2622773002
Cr-Commit-Position: refs/heads/master@{#443116}

In the last cases of inconsistent evaluation of compile-time-constants
just make them constexpr and then ensure we always see constexpr things
as compile-time constants. Actually compiling figures this out even
though from the AST we see unresolved things that make this hard.

R=dcheng
BUG=677285

Review-Url: https://codereview.chromium.org/2626923004
Cr-Commit-Position: refs/heads/master@{#443115}

Attepted to enable this on an FYI bot. But that is unable to
successfully run chrome_public_test_apk due to some issue. Would
like to enable this on a bot already running chrome_public_test_apk
to see if it works as intended.

Review-Url: https://codereview.chromium.org/2626183002
Cr-Commit-Position: refs/heads/master@{#443114}

Now that there is support to count the number of active MediaKey
and MediaKeySession objects, update the tests to check the count
directly (there should be no such objects at the start of the test,
and if there are then something else is running and the counts
will be wrong anyway). By converting these tests to promise tests,
we get better logging if the test fails.

BUG=445324
TEST=updated tests pass

Review-Url: https://codereview.chromium.org/2618603002
Cr-Commit-Position: refs/heads/master@{#443113}

Provides a ScriptModule wrapper around v8::Module, as
well as primordial forms of the three basic operations
on modules:

  - compile(), a static method which takes a string and
    returns a ScriptModule
  - instantiate(), which "links" a module with its dependencies
    (the initial implementation does no actual linking)
  - evaluate(), which runs the module (and its dependencies;
    naturally this version doesn't do the latter)

Landing this in its early state makes it easier for others
working on <script type="module"> support to make progress
on other CLs, many of which will interact with this class

BUG=594639

Review-Url: https://codereview.chromium.org/2566513002
Cr-Commit-Position: refs/heads/master@{#443112}

BUG=678567

Review-Url: https://codereview.chromium.org/2623973002
Cr-Commit-Position: refs/heads/master@{#443111}

This required
1. Adding media_perftests to gn_isolate_map so that isolate can understand how
   to run them
2. Adding data dependencies to media_perftests target that are needed by the
   isolate script.
3. Added media_perftests to generate_perf_json.py configuration file.

A previous version of this CL (https://codereview.chromium.org/2595123002) got
reverted because I didn't do step 2. For that CL, I only tested media_perftests
in a local run. This time, I also ran using isolates as well. (Thanks eyaich@!)
See test run: https://chromium-swarm.appspot.com/task?id=3390ffce2596c810&refresh=10&request_detail=true&show_raw=1

Follow up CL(s) will also add support on Mac, Windows, and Android.

BUG=676188,392620

Review-Url: https://codereview.chromium.org/2617133004
Cr-Commit-Position: refs/heads/master@{#443110}

As part of this I made sure the definitions and declarations matched
up. This resulted in reordering a couple of things. In addition the
only other non-move I did was moving what was CreateLayoutManagers()
into InitLayoutManagers() and CloseChildWindowsImpl() into
CloseChildWindows().

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2628973002
Cr-Commit-Position: refs/heads/master@{#443109}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2625873006
Cr-Commit-Position: refs/heads/master@{#443108}

This CL:

1. Moves the code out of LayoutObject.
2. Forces the GraphicsLayer to be m_graphicsLayer and not
m_scrollingContentsLayer.

TEST=manual testing
BUG=679674

Review-Url: https://codereview.chromium.org/2620383004
Cr-Commit-Position: refs/heads/master@{#443107}

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}

https://pdfium.googlesource.com/pdfium.git/+log/96f482c9cd3c..d805eec52f6a

$ git log 96f482c9c..d805eec52 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 tsepez Use observed pointers in CPDFSDK_AnnotIterator.
2017-01-11 npm Make tiff_read return actual length read

BUG=679230,670928

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2625253002
Cr-Commit-Position: refs/heads/master@{#443105}

If error page shows "DOWNLOAD PAGE LATER" button, we should also
enable download page action.

BUG=675225

Patch

Review-Url: https://codereview.chromium.org/2588253002
Cr-Commit-Position: refs/heads/master@{#443104}

This CL creates a StreamSocket::SocketMemoryStats to hold relevant
socket information so that we can avoid creating individual
MemoryAllocatorDump for each socket. MemoryAllocatorDump is expensive
to create. This CL makes net/ MemoryDumpProvider create fewer
MemoryAllocatorDump so that it can be enabled in Slow Reports.

BUG=669108

Review-Url: https://codereview.chromium.org/2623803002
Cr-Commit-Position: refs/heads/master@{#443103}

Thanks to zmo@ for catching this omission.

BUG=666077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2623223004
Cr-Commit-Position: refs/heads/master@{#443102}

Revert of Made text-align property independent. (patchset #2 id:20001 of https://codereview.chromium.org/2628503002/ )

Reason for revert:
Misaligned text elements found in manual testing.

BUG=680009

Original issue's description:
> Made text-align property independent.
>
> Made text-align property independent. Also updated
> independent-inheritance-fast-path.html to include textAlign.
>
> Tested using independent-inheritance-fast-path.html.
>
> BUG=628043
>
> Review-Url: https://codereview.chromium.org/2628503002
> Cr-Commit-Position: refs/heads/master@{#442500}
> Committed: https://chromium.googlesource.com/chromium/src/+/d8b62ea53246ab528786b9a8d312d0a3733e46e9

TBR=sashab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628043

Review-Url: https://codereview.chromium.org/2627833003
Cr-Commit-Position: refs/heads/master@{#443101}

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624043002
Cr-Commit-Position: refs/heads/master@{#443100}

Moved unicode-bidi to be generated in ComputedStyleBase, which uses the
external type platform/text/UnicodeBidi.

Review-Url: https://codereview.chromium.org/2627563002
Cr-Commit-Position: refs/heads/master@{#443099}

In the views tree, dialogs as annotated today are fairly loose semantically.

1. In the Launcher, we're using dialog for bubble views.
Example:
window
  ...
  search text field
...
window
  ...
  dialog
    ...
    dialog
      files app button

The problem arises when trying to wrap. It is not clear if we should wrap based on the inner dialog, the outer dialog, or the outer window.

Furthermore, consider the views tree for app installation

window
  dialog
  ...
    close button
  ...
  dialog
    description text static text
  ...
  install button

Here, we should not wrap for the inner dialog because we'll miss the buttons that come after.

Thus, we need to be far more strict when detecting dialogs as root. In particular, dialogs that are not parented to windows and have siblings that are not all windows or dialogs, should not be a root.

TEST=navigate both app install window and launcher. Verify that wrapping only occurs for the launcher case and not for the install window.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2573203002
Cr-Commit-Position: refs/heads/master@{#443098}

This adds a path for VDAv2 clients to look up a command buffer identified by |command_buffer_id|.

Also in this CL is a method to look up the route ID from the accelerated GPU factories so that it's easy to pass the |command_buffer_id|.

BUG=522298
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2526953003
Cr-Commit-Position: refs/heads/master@{#443097}

Also updated the test to check for the matching full hash in that case.

BUG=679906

Review-Url: https://codereview.chromium.org/2622063002
Cr-Commit-Position: refs/heads/master@{#443096}

The argv list passed to the main method when running a test in a
subprocess was not NULL terminated, something that the gtest launcher
takes advantage of.
This was causing an invalid memory read causing failures on the ASAN
bots.

BUG=680155,680156

Review-Url: https://codereview.chromium.org/2622073004
Cr-Commit-Position: refs/heads/master@{#443095}

Any child classes don't override it.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2624323002
Cr-Commit-Position: refs/heads/master@{#443094}

Review-Url: https://codereview.chromium.org/2624123003
Cr-Commit-Position: refs/heads/master@{#443093}

This patch removes the enum value TransformOperation::None, which is
currently only used in an ASSERT_NOT_REACHED case.

Review-Url: https://codereview.chromium.org/2616863002
Cr-Commit-Position: refs/heads/master@{#443092}

paper-slider uses a fixed size of 200px.
This does not work well with cr-slider when the size of the labels
increases. Instead, set the minimum width of cr-slider to be 200px,
and the width of the embedded paper-slider to 100%.

BUG=679319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628633002
Cr-Commit-Position: refs/heads/master@{#443091}

BUG=679992,653093

Review-Url: https://codereview.chromium.org/2624273003
Cr-Commit-Position: refs/heads/master@{#443090}

The bottom bar was used to let users know they would receive
notifications from the Physical Web.  Now that we don't fire
notifications, we should remove this bottom bar.

BUG=679363

Review-Url: https://codereview.chromium.org/2622743002
Cr-Commit-Position: refs/heads/master@{#443089}

Revert of Adds animated touch point and the hint box for touch calibration UX (patchset #4 id:120001 of https://codereview.chromium.org/2600213002/ )

Reason for revert:
Hoping to clear up issue on builder here:

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/18918

-- sheriff

Original issue's description:
> Adds animated touch point and the hint box for touch calibration UX
>
>  - Adds the circular throbbing touch point view that the user interacts
>    with during touch calibration.
>  - Adds the hint box view that contains the hint message as given in the
>    UX specs.
>    (https://drive.google.com/file/d/0B_2Uyb2Rhx2OU0FIbXUyMkhMZlE/view)
>  - Adds required resource strings for hint box messages.
>
> Working protottpe(The video is the entire prototype. This change only
> involves adding the touch point and hint box.):
> https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1QVR0WFJYdUY2SmZTdWdUVFNSM0F5WDF4YlBn/view
>
> Screenshot of how it looks on different DPI screens:
> https://screenshot.googleplex.com/ND5d9v0799y.png
>
> Screenshot for RTL:
> https://screenshot.googleplex.com/Xd3PyAYbDTV.png
>
> BUG=634166
> COMPONENT=Touch Calibration, ChromeOS, UI Strings
>
> Review-Url: https://codereview.chromium.org/2600213002
> Cr-Commit-Position: refs/heads/master@{#443000}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f631d1860f7dfcf100b5a6bef46263cd7a4e698

TBR=oshima@chromium.org,stevenjb@chromium.org,malaykeshav@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634166

Review-Url: https://codereview.chromium.org/2629003003
Cr-Commit-Position: refs/heads/master@{#443088}

1. Create a BaseBlockingPage in components/safe_browsing, and move
   basic user interaction handling logic into this class
2. Implement BaseUIManager::DisplayBlockingPage to work with
   BaseBlockingPage
3. Make security_interstitials::MetricsHelper a non-abstract class,
   such that it can be instantiated by BaseBlockingPage
4. Adjust unit_tests and browser_tests
5. Rename BaseSafeBrowsingUIManager to BaseUIManager,
   BaseSafeBrowsingResourceThrottle to safe_browsing::ResourceThrottle

Overall, no logic change in
chrome/browser/safe_browsing/SafeBrowsingBlockingPage class

BUG=666100

Review-Url: https://codereview.chromium.org/2623733002
Cr-Commit-Position: refs/heads/master@{#443087}

BUG=649558

Review-Url: https://codereview.chromium.org/2626943002
Cr-Commit-Position: refs/heads/master@{#443086}

This patch adds an ability to request an image decode from
the compositor. The caller should specify which image
(SkImage) to decode and a callback. In return, it gets an
id. When the image is decoded, the callback is issued with
this id. The decode is then kept alive for 2 compositor
frames.

Right now, only unittests are using this functionality.

R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537683002
Cr-Commit-Position: refs/heads/master@{#443085}

BUG=80267

Review-Url: https://codereview.chromium.org/2624553002
Cr-Commit-Position: refs/heads/master@{#443084}

Background: When support for wptserve was originally added [1],
WPTServe had a _stop_running_server to override the version in
ServerBase, which tries to kill the existing process with
Executive.interrupt instead of  Executive.kill_process on non-Windows
platforms.

Later this method was changed in http://crrev.com/2511013002 and
now when interrupt fails to kill the process, there's an infinite
loop which results in the job stalling for days.

But, I'm not sure why it was necessary to use Executive.interrupt
rather than Executive.kill_process. If the overridden method is removed,
then ServerBase._stop_running_server would be used, which is:

    def _stop_running_server(self):
        self._wait_for_action(self._check_and_kill)
        if self._filesystem.exists(self._pid_file):
            self._filesystem.remove(self._pid_file)

[1] https://chromium.googlesource.com/chromium/src/+/0129094b0ad431a2aee9cf5ea9225037283f3c37/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Note, the actual change to behavior here is in webkitpy/layout_tests/servers/wptserve.py -- the rest of the changes are related to unit testing; I could also put those changes in a separate CL.

BUG=669802

Review-Url: https://codereview.chromium.org/2624093003
Cr-Commit-Position: refs/heads/master@{#443083}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/64cff499aefc..dcd70be386e3

$ git log 64cff499a..dcd70be38 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 sullivan Horrible workaround for v8 bug 2830.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2623343002
Cr-Commit-Position: refs/heads/master@{#443082}

Fixed the conversion of timestamps in vr_input_manager

BUG=

Review-Url: https://codereview.chromium.org/2622333002
Cr-Commit-Position: refs/heads/master@{#443081}