- 14 Oct, 2019 6 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3838fe3c82b4..a7e1b45d9c28 git log 3838fe3c82b4..a7e1b45d9c28 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@a7e1b45d9c28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I84516559b49f3324b6ce76681bcd010e16461724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705446}
-
Darren Shen authored
It is deprecated and no longer used. Bug: 1009903 Change-Id: I6774a4506bd0bb41a5d1a5909a40a2a781564b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833029 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#705445}
-
Alan Cutter authored
This CL is a simple refactor that moves WebAppInstallManager code for enqueuing tasks that use a WebContents into a helper method. This is in preparation for adding an update task to the queue: https://chromium-review.googlesource.com/c/chromium/src/+/1811402 Bug: 926083 Change-Id: If66cebcbefe6ce931340c8d3c149fd42c9b36168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832131 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#705444}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2f89c000483..fede5cb664d9 git log a2f89c000483..fede5cb664d9 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 jmadill@chromium.org Vulkan: Remove resource destruction layer suppressions. Created with: gclient setdep -r src/third_party/angle@fede5cb664d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ida2ca1c29b898f09723534a338e8b6719835b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858604Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::TestMojoSandboxHooks interface. Bug: 955171 Change-Id: I105f2220f847fc9a51da9eb79244bd6213354497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833467Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#705442}
-
Chris Hall authored
This reverts commit 52ecdd0e. Suspected cause of android-archive-dbg breakage causing tree closure. TBR=jbudorick@google.com, sidereal Change-Id: I1d33c46a29f54db8b5afbcf29ab6479a15c534e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858547Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705441}
-
- 13 Oct, 2019 22 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/17844a0135bf..c28d6f116472 git log 17844a0135bf..c28d6f116472 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 mmortensen@google.com Implement SimpleChromeWorkflowTest in the Test endpoint. 2019-10-13 wbbradley@chromium.org build api metrics: include metrics events in CreateImageResponse Created with: gclient setdep -r src/third_party/chromite@c28d6f116472 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic0e19d71fd529e5f86bd1f9241058e779197e584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857717Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f960fbb7d1a..2657a7f2a179 Created with: gclient setdep -r src-internal@2657a7f2a179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id0039abc318c3fa88970930ea3d4d7377e213296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857716Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705439}
-
Rob Paveza authored
The source editor, when it cannot load a particular file, will simply display a blank file instead. At the bottom, this is because the APIs used to load the files do not have a way to propagate an error up to the call site. Rather, the callback either is never called, or is called with just an empty string. This refactor changes the way the project system loads file contents by replacing the callback model with a Promise-based model. However, in this version, rather than propagating an error (handled via catch), the error is exposed as a property on the object passed via the the load functions. Although it might be preferable to use async throw/catch, because there are ~4-5 layers of redirection through the project system, the added complexity seems to not really justify that work. I'm open to reconsidering this design, though. Attempting to load a file via file:// which does not exist previously produced no error because the DevToolsUIBindings handler would just always resolve with no content and HTTP status 200. I had previously addressed that bug in this changeset, but I've split it out to https://chromium-review.googlesource.com/c/chromium/src/+/1847833 . Sample "after" screenshot: https://imgur.com/a/tlm90sg Bug: 961940 Bug: 941035 Change-Id: If121611090e9c35eeb1de162b59f8a9f72f696d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817677Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705438}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de55c3cb9904..2f960fbb7d1a Created with: gclient setdep -r src-internal@2f960fbb7d1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2891ecda7aef9e469fd4c1637b82c9d3a88f491f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858294Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I89fe210495fa631df0c4253680d11154d79fd445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858293Reviewed-by:
-
Koji Ishii authored
TBR=eae@chromium.org, ikilpatrick@chromium.org NOTRY=true Bug: 1013898 Change-Id: I51c2c88fd8c737019163a91f5ecbeb2286068025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858539Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705435}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1971773623d0..de55c3cb9904 Created with: gclient setdep -r src-internal@de55c3cb9904 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ide8bbd1fd51e1ab1206b92628f5f09ad8f871f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857916Reviewed-by:
-
Antonio Gomes authored
... so base::CommandLine is not directly referenced when rtc_peer_connection_handler.cc gets Onion soup'ed. CL also removes some unneeded includes. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icf966ea9842b0600a2f8bd039f5b9507d2b0fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836312 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f8629ed. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic8f81c3709ccc17412632ebeecf7f47ddcb28129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858563Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705432}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc9eb022. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4cdd1ebae850e1923eec5d474ca87e2c60624b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857247Reviewed-by:
-
David Benjamin authored
The EnsureNSSInit portions of NSSInitSingleton are now completely stateless and thus have no intersection with the CrOS-specific profile bits. (Except that the CrOS-specific profile bits require NSS to be initialized, but they can just call EnsureNSSInit() like anyone else.) We can split them up entirely now. Bug: 125848 Change-Id: I6c3b32503da763272263ee84bbdb076b7826c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857045Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#705430}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ide59e0e62b69749ab12bbfb3fd63477c65dd0a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858520Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1877e9da..4b3dd5a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e5729f24710add8615909eb69cc020c6f381fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857246Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705428}
-
Xianzhu Wang authored
We always have at most one link highlight in a page. Also move renderer/core/frame/link_highlights.* to renderer/core/page/link_highlight.*. Bug: 1012594 Change-Id: I4d0308a2a5051d3ec41aa3763ae7d8230fc131e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849989 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705427}
-
Raul Tambre authored
* Use bytestrings for operations in cases where files are read in binary mode. * Output from subprocess is a bytestring in Python 3. Need to decode it before using in normal string operations. * Due to use of bytestrings need to encode UUID string. * Had to use branching code for ord() due to string vs bytestring in Py2/3. * array() typecode 'c' (char) has been removed in Python 3. Use 'B' (unsigned char) instead. * Use '//' for division where necessary. Add 'from __future__ import division' to avoid this in the future. * Import reduce() for Python 3. * Fixed open(mode='U') DeprecationWarnings. Use io.open for universal newlines on both Py2/3. The changes are backwards compatible with Python 2. Formatting changes are a result of running "git cl format --python". Errors fixed: Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 240, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 205, in main processing = set(os.path.basename(x) File "../../build/toolchain/win/midl.py", line 206, in <genexpr> for x in lines if x.startswith(prefixes)) TypeError: a bytes-like object is required, not 'str' Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 239, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 213, in main ZapTimestamp(os.path.join(tmp_dir, f)) File "../../build/toolchain/win/midl.py", line 71, in ZapTimestamp contents = re.sub( File "C:\Program Files\Python38\lib\re.py", line 208, in sub return _compile(pattern, flags).sub(repl, string, count) TypeError: cannot use a string pattern on a bytes-like object Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 241, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 167, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 152, in overwrite_cls_guid overwrite_cls_guid_h(h_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 99, in overwrite_cls_guid_h br'class DECLSPEC_UUID("%s")' % str(dynamic_guid), contents) TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 241, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 167, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 153, in overwrite_cls_guid overwrite_cls_guid_iid(iid_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 106, in overwrite_cls_guid_iid hexuuid += ','.join('0x%02x' % ord(b) for b in dynamic_guid.bytes[8:]) File "../../build/toolchain/win/midl.py", line 106, in <genexpr> hexuuid += ','.join('0x%02x' % ord(b) for b in dynamic_guid.bytes[8:]) TypeError: ord() expected string of length 1, but int found Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 241, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 167, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 154, in overwrite_cls_guid overwrite_cls_guid_tlb(tlb_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 120, in overwrite_cls_guid_tlb assert ord(contents[type_off]) == 0x25, "expected coclass" TypeError: ord() expected string of length 1, but int found Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 241, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 167, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 154, in overwrite_cls_guid overwrite_cls_guid_tlb(tlb_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 125, in overwrite_cls_guid_tlb contents = array.array('c', contents) ValueError: bad typecode (must be b, B, u, h, H, i, I, l, L, q, Q, f or d) Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 241, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 167, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 154, in overwrite_cls_guid overwrite_cls_guid_tlb(tlb_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 131, in overwrite_cls_guid_tlb hashtab = [0xffffffff] * (0x80 / 4) TypeError: can't multiply sequence by non-int of type 'float' Traceback (most recent call last): File "../../build/toolchain/win/midl.py", line 242, in <module> sys.exit(main(*sys.argv[1:])) File "../../build/toolchain/win/midl.py", line 168, in main overwrite_cls_guid(os.path.join(outdir, h), File "../../build/toolchain/win/midl.py", line 155, in overwrite_cls_guid overwrite_cls_guid_tlb(tlb_file, dynamic_guid) File "../../build/toolchain/win/midl.py", line 138, in overwrite_cls_guid_tlb guidhash = reduce(operator.xor, [w for w in words]) % (0x80 // 4) NameError: name 'reduce' is not defined ../../build/toolchain/win/midl.py:231: DeprecationWarning: 'U' mode is deprecated open(fromfile, 'bU').readlines(), ../../build/toolchain/win/midl.py:232: DeprecationWarning: 'U' mode is deprecated open(tofile, 'bU').readlines(), fromfile, tofile))) Bug: 941669 Change-Id: I3e5985c732db114eff2209e428ec9ee3f209e3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829205 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:Dirk Pranke <dpranke@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#705426}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e74f8be31fac..1971773623d0 Created with: gclient setdep -r src-internal@1971773623d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0395eca80f50dbc2a1185e82ef2def50dab44498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857471Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia5af05b6fe3d6855e6041a383c0806130603592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857028Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705424}
-
Julie Jeongeun Kim authored
This CL converts MjpegDecodeAccelerator to new Mojo types using PendingReceiver, PendingRemote, and Remote. Bug: 955171 Change-Id: If5df104401e04075180f447ac1474a80b147ecbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849733Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705423}
-
Xianzhu Wang authored
Now we record foreign layers directly in LinkHighlightImpl::Paint() without GraphicsLayers, just like what we have been doing for CompositeAfterPaint. Bug: 1012594 Change-Id: I448b4b109dae4778a9f4650639633d083e4a5e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849252 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jinfeng Ma authored
Renaming the variables and functions related to the original kOverlayScrollbars paint phase. This is 3/3 of a series of patches: 1. https://crrev.com/c/1816486 2. https://crrev.com/c/1817874 3. This patch. Bug: 1006173 Change-Id: Ie34b71936d03ade4673fdcb8510de735276937ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831917Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705421}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ica60821676b7c7884c0f6c3cec9eb72ef390a684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857711Reviewed-by:
-
Kevin Marshall authored
Addresses wez's post-landing comments made to CL#1848411: * All paths from URLs are assumed to begin with slash. Conditional handling of relative paths is removed. * Add a comment explaining Fuchsia's lack of support for absolute paths. Bug: 1011180 Change-Id: Idb4cbe0cfac2a7547f44488ee9133b8ca0ea8207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854801 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705419}
-
- 12 Oct, 2019 12 commits
-
-
Jinfeng Ma authored
Clean up PaintLayerScrollableArea::UpdateScrollCornerStyle and ScrollableAreaPainter::PaintResizer with the new added function: PaintLayerScrollableArea::HasNonOverlayOverflowControls. This is 2/3 of a series of patches: 1. https://crrev.com/c/1816486 2. This patch. 3. https://crrev.com/c/1831917 Bug: 1006173 Change-Id: Ic6bb659cb7d7e646955e08a4f5035313f71dee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817874Reviewed-by:
-
Xianzhu Wang authored
This reverts the line to before crrev.com/c/1826994 (see crrev.com/c/1826994/3/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc#b2680). Still not sure how the visual rect of composited overlay scrollbar affects texture memory. The visual rect doesn't affect paint or raster invalidation. Bug: 1011996 Change-Id: I20f2c9bddd2e6a0aff254f598ba0f16b3d6d5738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847942 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/88d7869db091..5abb9b7c5d0c git log 88d7869db091..5abb9b7c5d0c --date=short --no-merges --format='%ad %ae %s' 2019-10-12 nodir@chromium.org Revert "Reland "depot_tools: Add httplib2 to .vpython"" Created with: gclient setdep -r src/third_party/depot_tools@5abb9b7c5d0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: Idc93fd0b88cc8e8928be3fd6f159c0f4a28c7257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857664Reviewed-by:
-
Xianzhu Wang authored
Most of the new baselines are following up https://chromium-review.googlesource.com/c/chromium/src/+/1856359 (Disable mock theme) TBR=wangxianzhu@chromium.org Change-Id: Id9c07511f90d689a774fecdf39d56b99901366ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857665Reviewed-by:
-
Daniel Cheng authored
Currently, state synchronization between the browser and the renderer process is complicated and buggy for cross-process navigations. The renderer process is responsible for processing the commit IPC and then reporting success back up to the browser process, which then updates its state. However, it's unclear if this can lead to races. Instead, if it is possible to assume that one CommitNavigation() IPC from the browser always maps to one committed navigation in the renderer, the code can be simplified to remove multiphase navigation commits. This means the browser would be able to mark a provisional local frame as committed as soon as it sends a commit IPC to the renderer for that frame. Bug: 999255 Change-Id: I7d58293e6c2ec6ca0d09b614ae5a41340f4afd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775663 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe95b86e. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6296b99a81334c4347fbf8d7f2711899c3e9e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857245Reviewed-by:
-
Weiliang Chen authored
For Android Classic overlay path, connect the shared image video to receive overlay promotion hints through SkiaOutputSurface. This includes adding a new type of scoped read lock on display resource provider for shared image, and making sure overlay resources are waited and kept alive. This approach uese the SharedImage API for video, and doesn't change logic to generate overlay candidates. TBR=kylechar Bug: 979795 Change-Id: Ia370be37c6bbbcfaa4cba26f179e79ac9124ac77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811961 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#705412}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I06b0b9ca51a016d2e258639129c6cfa4b46a4ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857709Reviewed-by:
-
Fergal Daly authored
Change-Id: I5f4e72e22247b16424230fcf6bbdcb7b3c147db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852351 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705410}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/130fdbcc23ed..a2f89c000483 git log 130fdbcc23ed..a2f89c000483 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 jiajie.hu@intel.com Add sampler array index validation for ESSL 3.00 onwards Created with: gclient setdep -r src/third_party/angle@a2f89c000483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:985032 Change-Id: If974b1060689f6e0303d669d558a808aa179aad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856855Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15aa86bf55aa..e74f8be31fac Created with: gclient setdep -r src-internal@e74f8be31fac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I47f4073a5988247e8ca6a37aae3070e9d0d33739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856854Reviewed-by:
-
Miyoung Shin authored
This CL converts SocketObserver{Ptr, Request} in chrome, components, content, extensions, jingle, google_apis and services to the new Mojo type, and uses pending_remote<T> in network_context.mojom, proxy_resolving_socket.mojom and tcp_socket.mojom. Bug: 955171 Change-Id: I3bac36caf28dd5008f32deb6157dec202e8e2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851888 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
-
