- 21 Nov, 2018 40 commits
-
-
Greg Thompson authored
BUG=898958 R=pkasting@chromium.org Change-Id: Ib5790e607c4b0d500e39cfea7dd240596dee27ca Reviewed-on: https://chromium-review.googlesource.com/c/1333372 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609981}
-
Javier Ernesto Flores Robles authored
Only fill credit cards on HTTPS, and passwords on HTTPS and password fields. Show an alert to the user otherwise. Bug: 905652, 878388, 845472 Change-Id: I51e0f07757dc4f7f1e002b88b83a2d2eeea071b5 Reviewed-on: https://chromium-review.googlesource.com/c/1340259 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609980}
-
Vaclav Brozek authored
Autofill's ParsePhoneNumber parses strings to extract valid phone numbers. This is a considerable effort (including regex matching) and a potential attack surface for malicious inputs. Phone numbers are not arbitrarily long, so exceedingly large inputs for ParsePhoneNumber signal an error or an attack. They are also expensive to parse. Thus, this CL introduces an upper bound on the input length, and the parser will refuse inputs exceeding this bound. As a side effect, the autofill_phone_number_i18n_fuzzer will stop timing out on large inputs. The CL also wraps the phone number unittest in the anonymous namespace: This is to prevent potential name clashes for the newly introduced GenerateTooLongString helper method, but is in general a good thing to do in unittests, which are never meant to be exported beyond their own file. Bug: 901675 Change-Id: Ie3b069f846288ccd7f11fbce98c54669a55f980f Reviewed-on: https://chromium-review.googlesource.com/c/1343007 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609979}
-
Sam McNally authored
Rapidly clicking on the new folder button in the files app acting as a save-as dialog can cause multiple flows through that process (from pressing the button through to completing the rename) to run concurrently. This can cause some strange effects: - reporting that the directory already exists, despite the name intending to be unique; - getting stuck a state renaming a newly-created directory that hasn't been rendered into the file list, causing the app to be effectively unresponsive. Avoid these problems by disallowing execution of the new-folder command while another is in progress. Bug: 632270 Change-Id: I48eb43197403bf85ac78e42a6361c972499b008c Reviewed-on: https://chromium-review.googlesource.com/c/1345687Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609978}
-
Alex Clarke authored
The TimeDomain introduced by http://crrev.com/c/1324391 needs to know if the current RunLoop should quit when idle because if so it needs to stop advancing mock time. We do this by plumbing a flag through to MaybeFastForwardToNextTask. Bug: 863341, 891670 Change-Id: I71d8240fa5c6e7088cafacba57a31ec15abfe695 Reviewed-on: https://chromium-review.googlesource.com/c/1337336 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609977}
-
DongJun Kim authored
This CL has 2 changes as below - Change DOMWindowEventHandlers to WindowEventHandlers. - Makes WindowEventHandlers a static-only class by [1] [1] https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/bindings/IDLExtendedAttributes.md#ImplementedAs_i_m_s_a Bug: none Change-Id: Iac78712e3567ffb4f43d1f1c493719f7d1613f65 Reviewed-on: https://chromium-review.googlesource.com/c/1343595 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609976}
-
Rayan Kanso authored
ChromeOS was creating multiple BackgroundFetchDelegate clients, and overwriting the client initiating the fetches. The fix was to check that we are not overwriting the client. This fixes our problems in the short term, and a longer term fix is planned in crbug.com/907075. The fix works on ChromeOS head, as well as 71 (tested via manually merging the change). Bug: 907038 Change-Id: Ic1d5bc9f55b22359aa592c71f49d8ab5ed90de5e Reviewed-on: https://chromium-review.googlesource.com/c/1344030 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609975}
-
https://chromium-review.googlesource.com/c/1312234Nico Weber authored
This is a reland of c5612605 Original change's description: > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234 > > Bug: 875037 > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1339339 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608783} TBR=hans Bug: 875037 Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1344198 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609974}
-
Robert Ogden authored
Also refactors GetSessionKeyFromRequestHeaders to be static and return a bool to indicate success, setting a passed pointer to the parsed session key. This is needed to support Lite Page Redirect pingbacks, in order to get the DRP session id and page id that were used on a navigation. Bug: 864665 Change-Id: Iefa1d6e39b58a0b71dbc1976ef1a0a2ba4712e73 Reviewed-on: https://chromium-review.googlesource.com/c/1345424 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609973}
-
jdoerrie authored
As a follow up to r609674 this change adds NavigateToManagePasswordsPage to PasswordManagerClient in order to remove the dependency on ChromeAutofillClient. In addition, this change inlines password_manager_util::UserTriggeredShowAllSavedPasswordsFromContextMenu Bug: 904821 Change-Id: Ib66e5c20e8babcf84de3e07a0c031cf9e700e43d Reviewed-on: https://chromium-review.googlesource.com/c/1344031 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609972}
-
Anders Hartvoll Ruud authored
TBR=lukasza@chromium.org Bug: 907402 Change-Id: I939381e79f68c912b70207c9412b42d65e74f3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1345077Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#609971}
-
Joel Hockey authored
MockEntry.deleteRecursively added to help debugging in browser. Bug: 571355 Change-Id: I74422501b0e69380d8d5ff05c796ef1d42c68992 Reviewed-on: https://chromium-review.googlesource.com/c/1345951 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609970}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e47ac15d93b8..a85a4b01ee72 git log e47ac15d93b8..a85a4b01ee72 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 jbudorick@chromium.org Don't fetch flash when fetching android_internal. (reland) 2018-11-21 tandrii@chromium.org git cl: remove Rietveld implementation entirely. 2018-11-21 tandrii@chromium.org git cl: remove Rietveld import and things it depends on. 2018-11-21 tandrii@chromium.org git cl: get rid of Rietveld's upload.py import. 2018-11-20 vadimsh@chromium.org Revert "[vpython] Roll to pick up user differentiation of cached envs." 2018-11-20 iannucci@chromium.org [vpython] Roll to pick up user differentiation of cached envs. 2018-11-20 jbudorick@chromium.org Revert "Don't fetch flash when fetching android_internal." 2018-11-20 abenner@google.com Enable python formatting by default if yapf file provided 2018-11-20 jbudorick@chromium.org Don't fetch flash when fetching android_internal. Created with: gclient setdep -r src/third_party/depot_tools@a85a4b01ee72 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278,chromium:869227,chromium:869227,chromium:856278,chromium:846432,chromium:856278 TBR=agable@chromium.org Change-Id: Ifc45e8c4dda5ca7c283310fc840910250a778ffd Reviewed-on: https://chromium-review.googlesource.com/c/1345394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609969}
-
Adrienne Walker authored
Debug builds of Android were crashing because of misaligned read/writes of float variables in PaintOpWriter::WriteSimple and the accompanying reader. Fix this by rounding up all WriteSimples to align the size they write to 4 bytes. This is just a spot fix, but fixes most of the alignment issues on a few checked pages. If we wanted to move to DCHECKing the alignment, this would probably need more work. This continues to avoid calling AlignMemory in Write/ReadSimple, as that appears to cause about 30% slowdown in serializing/deserializing speed in the cc_perftests --gtest_filter=PaintOp* tests. Bug: 905665 Change-Id: Ib6db27d7cafe22b40b96f841dc2df54c1b6a4f1c Reviewed-on: https://chromium-review.googlesource.com/c/1343565 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#609968}
-
Eric Seckler authored
Fragment may not have immediately attached during activity creation, so wait for it to attach in test. TBR=twellington@chromium.org Bug: 907224 Change-Id: I4fa6a9b9478b0d0e34579e5712da3822ebb6e8ec Reviewed-on: https://chromium-review.googlesource.com/c/1345435Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#609967}
-
Anders Hartvoll Ruud authored
TBR=cmumford@chromium.org,jam@chromium.org Bug: 905423 Change-Id: I2572c956ac4ef4fcc0553cd595fb93679b79ca12 Reviewed-on: https://chromium-review.googlesource.com/c/1345513Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#609966}
-
Vaclav Brozek authored
There was a discussion about whether Chrome should avoid filling on load if a form has some new-password fields, or if the condition should be "has no current-password fields". The PasswordForm.FillOnLoad metric supported a team decision on that. The decision was to go with the new condition (for the new parser). Therefore the metric is now marked as obsolete and no longer collected. Bug: 895781 Change-Id: I3a153bf706abe12a5621b0a209cb53b6604ce875 Reviewed-on: https://chromium-review.googlesource.com/c/1341540 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#609965}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. While I'm here, also - update a comment in GetSyncUsernameIfSyncingPasswords to be more specific, since the semantics here are a bit weird, and - remove a CanSyncFeatureStart check from ShouldAffiliationBasedMatchingBeActive since it's redundant with the check for IsSyncFeatureActive which is strictly stronger. Bug: 884159 Change-Id: Ibbb9a82a2d89520e1a349e29a1050cd84dd52ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1344096Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609964}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d11507507daa..fd17a12ec7ac git log d11507507daa..fd17a12ec7ac --date=short --no-merges --format='%ad %ae %s' 2018-11-20 benjhayden@chromium.org Add alerts-controls for v2spa 2018-11-20 mlippautz@chromium.org vinn: Roll Mac d8 to 7.0.276.40 2018-11-20 mlippautz@chromium.org vinn: Roll Linux d8 to 7.0.276.40 Created with: gclient setdep -r src/third_party/catapult@fd17a12ec7ac The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If62503fef89ea0409ba690729cee0a6da769e6db Reviewed-on: https://chromium-review.googlesource.com/c/1345770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609963}
-
Mohamed Amir Yosef authored
This CL converts SyncerError to a class. This is in preparation for a later patch that would add more data to the SyncerError class. Bug: 897049 Change-Id: Ie44fa2f65e92ee9ad9733cdd9586a8c7095befb4 Reviewed-on: https://chromium-review.googlesource.com/c/1344098 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609962}
-
Danan S authored
Bug: 904564 Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a Reviewed-on: https://chromium-review.googlesource.com/c/1334563 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609961}
-
Carlos Caballero authored
Replace all the state checking and tracking code with the new and shiny OperationsController. Bug: 901345 Change-Id: I8023e78ebfee679fd565de465e810dbb9c6ee2ec Reviewed-on: https://chromium-review.googlesource.com/c/1341525 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#609960}
-
Christopher Cameron authored
When using RemoteMacViews, for a given widget, the widget's NSWindow and content NSView exist in the app shim process, while the tree of AXPlatformNodeCocoas exists in the browser process. In the browser process, the widget's NSWindow and content NSView are represented by NSAccessibilityRemoteUIElements in views::BridgedNativeWidgetHostImpl. Update AXPlatformNodeDelegateMac::GetParent and GetNSWindow to retrieve these values from views::BridgedNativeWidgetHostImpl. In AXPlatformNodeDelegate, replace the method GetTopLevelWidget with the method GetNSWindow and call this method in -[AXPlatformNodeCocoa AXWindow]. Replace all subclass implementations except for AXPlatformNodeDelegateMac with NOTREACHED. Bug: 900846 Change-Id: Ia0d26c4d118391ce66cc1e080ca3b62fb228aa8c Reviewed-on: https://chromium-review.googlesource.com/c/1338722 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609959}
-
Alexey Baskakov authored
- Use WebAppIconDownloader in WebAppDataRetriever. - Extract InstallFinalizer interface: WebAppInstallFinalizer is a BMO implementation. BookmarkAppInstallFinalizer will use extensions and CrxInstaller. Bug: 901226 Change-Id: Ie865bfd4facfc6f890ab92d5d6451a37a34979ea Reviewed-on: https://chromium-review.googlesource.com/c/1343410Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#609958}
-
Olivier Robin authored
Cannot reproduce failure. Tentatively reenable. Bug: 796082 Change-Id: I5ec7a55a723f91bb8a76e3f872abfe06eb7693c1 Reviewed-on: https://chromium-review.googlesource.com/c/1338080Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609957}
-
Rune Lillesveen authored
NeedsLayoutTreeUpdateForNode() is true if an ancestor returns true for NeedsAdjacentStyleRecalc(). For getComputedStyle we may start out with a tree where we don't need a full style/layout-tree update, but matching selectors as part of EnsureComputedStyle() up the ancestor chain may cause those flags to be set if we match adjacent selectors which were not previously matched. We need to ignore those flags for the sanity check in EnsureComputedStyle. This may be the situation in which the DCHECK triggers for 900138 as well. Bug: 906830, 900138 Change-Id: I51927fdb9f4bc44e3612628cf9b9710d26e2d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1344130Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609956}
-
Yoshifumi Inoue authored
This patch changes "dfg-arguments-alias-activation.html" to utilize w3c test harnes for ease of maintenance and avoid timeout for dumping result. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: I5fcd46f0dd31eb8869917af288d7ad385626612c Reviewed-on: https://chromium-review.googlesource.com/c/1345752Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0e604f9f1107..836674c28b1e git log 0e604f9f1107..836674c28b1e --date=short --no-merges --format='%ad %ae %s' 2018-11-20 geofflang@chromium.org Expose GL_CHROMIUM_compressed_texture_etc on top of ES drivers. 2018-11-20 geofflang@chromium.org Skip SetUp and TearDown in VulkanCommandBufferPerfTest if its flaky. 2018-11-20 geofflang@chromium.org Fix typo in OWNERS file email address. 2018-11-20 jmadill@chromium.org Use xxHash for faster hash map lookups. Created with: gclient setdep -r src/third_party/angle@836674c28b1e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie0a716588f37fa54c1e7a03a40a1acf909f25371 Reviewed-on: https://chromium-review.googlesource.com/c/1344901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609954}
-
Gauthier Ambard authored
This is needed to move the subclasses to UITableView one by one. Bug: 894791 Change-Id: I6790f649df2ca61cfd2551ac9afe6fff732a39dd Reviewed-on: https://chromium-review.googlesource.com/c/1344057 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609953}
-
Takuto Ikuta authored
NOTRY: true Change-Id: Ic123d54cbaaa56e28386d5377fb4f4421c847527 Reviewed-on: https://chromium-review.googlesource.com/c/1345170 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609952}
-
Antoine Labour authored
The default 3D texture's first level image was accidentally described as a 2D image. Oops. Bug: 907054 Change-Id: Ib2f016a668baeb7d83b7c70579fed17d6822e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345651 Commit-Queue: Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609951}
-
Yi Su authored
fail on small screens. The refactor work on Settings makes Privacy menu larger, thus the "Clear Browsing Data" button is hidden on iPhone 5s due to the screen size. The EG test, ClearBrowsingDataSettingsTestCase, doesn't scroll to find the button, so it failed. This CL will fix the bug and stop failures on iOS12beta. TBR=edchin@chromium.org Bug: 907194 Change-Id: I9fc50a0979b005bcc07628c0d7ae4b3be86050bf Reviewed-on: https://chromium-review.googlesource.com/c/1345071Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609950}
-
Jonathan Metzman authored
Don't allow building of afl_driver since it isn't intended to be built on Windows. Change-Id: I8aeb89b5cf98f1998258847b60a8e12a465d3ca9 Bug: 903078 Reviewed-on: https://chromium-review.googlesource.com/c/1342772 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609949}
-
Hayato Ito authored
This reverts commit 4da12d2d. Reason for revert: Flakiness of RlzLibTest.DelayedInitOnlyNoFirstRun The bug is https://crbug.com/907379 Culprit (70.0% confidence): r609428 Original change's description: > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz > > |UpdateExistingAccessPointRlz| involves file I/O, so it should be > posted on a task runner that has MayBlock() in its TaskTraits. > |background_task_runner_| serves this purpose. > > Bug: 906293 > Change-Id: If36215767a0dbcfbad56c0432b16b584f6185376 > Reviewed-on: https://chromium-review.googlesource.com/c/1340607 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609428} TBR=rogerta@chromium.org,wzang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906293 Change-Id: I20dbe6c1f73e3599aa30cf8b74512122ad2d0a25 Reviewed-on: https://chromium-review.googlesource.com/c/1345707Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609948}
-
Martin Kreichgauer authored
The ContentBrowserClient in WebAuthn requests originating from the cryptotoken extension is not associated with any tab and therefore trying to show dialogs, such as the one for collecting attestation consent, will fail. cryptotoken has its own attestation consent dialog already, so we can safely disable attestation consent prompts if the caller origin is cryptotoken. Bug: 898718 Change-Id: Ic2d530665494cfa10ac4c3a7812e8284091e50fb Reviewed-on: https://chromium-review.googlesource.com/c/1340586 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609947}
-
Peter Kasting authored
Per the linked bug, RenderTextMac is effectively dead. While I was touching render_text_unittest.cc anyway, I thought I'd help a little with the cleanup. Bug: 131618 Change-Id: I679ce91e4eebc9984ff44b0a8e899f0c36910ee7 Reviewed-on: https://chromium-review.googlesource.com/c/1343106 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#609946}
-
Hajime Hoshi authored
This might invoke V8, and V8 should not be executed on per-thread task runners. This CL gives a per-frame task runner at binding. Bug: 870606 Change-Id: Ib814c717e2805beca341a6ad1a10926b231c361f Reviewed-on: https://chromium-review.googlesource.com/c/1343878Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609945}
-
Greg Thompson authored
BUG=607592 R=zmin@chromium.org Change-Id: I1c1c346c39cfeed164e1a3a56513356a2a142a5e Reviewed-on: https://chromium-review.googlesource.com/c/1337491Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#609944}
-
Chase Phillips authored
Change-Id: I9e7274f3ac67f57f1d0c62eb9223f437e9b1da8b Reviewed-on: https://chromium-review.googlesource.com/c/1340832 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#609943}
-
Andreas Haas authored
This CL enables WebAssembly trap handlers on MacOS. In this CL we use the default trap handler provided by V8. Bug: chromium:906565 Change-Id: I2d007da1a86ca05010a0a7bf830586767f19a24d Reviewed-on: https://chromium-review.googlesource.com/c/1290955 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609942}
-