GitLab

These were removed in https://codereview.chromium.org/969973002
Please see that CL for why.

Review URL: https://codereview.chromium.org/1059803003

Cr-Commit-Position: refs/heads/master@{#326843}

Changes Client destructor to be override instead of virtual to conform with chromium-style.

BUG=417463

Review URL: https://codereview.chromium.org/1108613002

Cr-Commit-Position: refs/heads/master@{#326842}

- pick up the decsription attribute in buttons
- add the help attribute in sliders

TEST=chromevox_tests --gtest_filter=OutputE2ETest.Audio

Review URL: https://codereview.chromium.org/1099023005

Cr-Commit-Position: refs/heads/master@{#326841}

A flaky test was added in https://codereview.chromium.org/1058003004/
that involved modifying the root cert cache, which did not happen
reliably. This changes and simplifies the test to use two different
servers on the same host, so the test passes since it relies on
same-host not same-origin, but avoids modifying any caches.

R=rsleevi@chromium.org
BUG=480667

Review URL: https://codereview.chromium.org/1080593006

Cr-Commit-Position: refs/heads/master@{#326840}

BUG=466848

Review URL: https://codereview.chromium.org/1090323003

Cr-Commit-Position: refs/heads/master@{#326839}

Remove IsSystemLibrary() and its list of NDK-exposed system libraries.
It is incomplete and not completable.

Replace it with a flag argument to LoadLibrary() that is true if the
library load is prompted by either preloads or dependencies.  Assume
the library being loaded is a system library and load through dlopen()
when the flag is true.

BUG=479220

Review URL: https://codereview.chromium.org/1105893002

Cr-Commit-Position: refs/heads/master@{#326838}

It is possible that an input device has been removed from the system
right after grabbing the device ids using InputDevice.getDeviceIds().
This CL adds checks in TouchDevice.java to avoid NPEs in such cases.

BUG=480619

Review URL: https://codereview.chromium.org/1087263004

Cr-Commit-Position: refs/heads/master@{#326837}

Imports:

- https://android-review.googlesource.com/#/c/147620/
    Exit normally when packing relocs saves no space

- https://android-review.googlesource.com/#/c/147745/
    Always use signed leb128 encoding

- https://android-review.googlesource.com/#/c/148073/
    Adjust DT_VERSYM/VERNEED/VERDEF dynamic sections

BUG=385553

Review URL: https://codereview.chromium.org/1099343004

Cr-Commit-Position: refs/heads/master@{#326836}

This CL also instruments the function to better understand which edge case
triggers the issue in the first place.

BUG=471586

Review URL: https://codereview.chromium.org/1054113004

Cr-Commit-Position: refs/heads/master@{#326835}

The Launcher_MinimzeTask user action is recorded when the user activates a
shelf icon causing a window to be minimized.

TEST=ShelfViewTest.Launcher_MinimizeTaskIsRecordedWhenWindowIsMinimized

BUG=471358

Review URL: https://codereview.chromium.org/1098193003

Cr-Commit-Position: refs/heads/master@{#326834}

Encapsulate task queue selector inside the scheduler helper to avoid
clients changing task queue states in an uncontrolled way.
This will be needed by the upcoming shutdown task queue.

No functional changes.

BUG=463143

Review URL: https://codereview.chromium.org/1103853004

Cr-Commit-Position: refs/heads/master@{#326833}

BUG=466848

Review URL: https://codereview.chromium.org/1092963004

Cr-Commit-Position: refs/heads/master@{#326832}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1052683004

Cr-Commit-Position: refs/heads/master@{#326831}

Remove this ducplication, and let the "run_at" property to refer
extensionTypes.RunAt.

The CL that fixed the complier bug for JSON is:
https://codereview.chromium.org/1100333006

BUG=477457

Review URL: https://codereview.chromium.org/1085033006

Cr-Commit-Position: refs/heads/master@{#326830}

There is delay between suggest apps dialog restoring focus to file manager
window (which happens in BaseDialog.hide) and suggest dialog reporting
result and being marked not shown (which happens in onHide callback).
If another suggest apps dialog is started during that time, it should
fail silently instead of reporting error. Also, any widget container
state set by the new dialog should be reset.

BUG=477106
TEST=1. Open suggest apps dialog for a file.
2. Cancel the dialog by pressing 'Esc'.
3. Try to open an new dialog immediately by clicking 'Enter'
(the list entry for the initial file should have focus at this point)
4. Verify no error is shown.
5. Verify subsequent attempts to open the dialog succeed (after a second
or two)

Review URL: https://codereview.chromium.org/1082423003

Cr-Commit-Position: refs/heads/master@{#326829}

Review URL: https://codereview.chromium.org/1081803005

Cr-Commit-Position: refs/heads/master@{#326828}

I subtly broke this in https://codereview.chromium.org/1071803003. Due
to a cut and paste error, we were never updating |delta|.

Consequently, I missed a regression due to my property trees skipping:
I wasn't forcing a rebuild when contents scale or content bounds
changed (and this was required). I've fixed that in this CL as well.

BUG=471786

Review URL: https://codereview.chromium.org/1105933002

Cr-Commit-Position: refs/heads/master@{#326827}

Revert of Implementing a BLE connection finder. (patchset #6 id:100001 of https://codereview.chromium.org/1094273003/)

Reason for revert:
This change broke the chromium perf dashboard:

https://build.chromium.org/p/chromium/builders/Linux/builds/61221

by adding a new static initializer:

const std::string kSmartLockServiceUUID =
    "b3b7e28e-a000-3e17-bd86-6e97b9e28c11";

I think you want static const char* instead.

Original issue's description:
> Implementing a BLE connection finder.
>
> This CL adds a connection finder class. The connection finder scans for
> Bluetooth Low Energy devices advertising a given target service.
>
> The current version only works when the remote device advertising the
> target service is sending all its primary services UUID.
>
> BUG=479673
> R=msarda
> TBR=tengs
>
> Committed: https://crrev.com/f56835d5211fc533a02f143e06eb310764f6b901
> Cr-Commit-Position: refs/heads/master@{#326807}

TBR=msarda@chromium.org,tengs@chromium.org,sacomoto@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=479673

Review URL: https://codereview.chromium.org/1105863003

Cr-Commit-Position: refs/heads/master@{#326826}

BUG=267773

Review URL: https://codereview.chromium.org/1101603002

Cr-Commit-Position: refs/heads/master@{#326825}

BUG=433446
TEST=media_unittests and EME layout tests pass

Review URL: https://codereview.chromium.org/1072403009

Cr-Commit-Position: refs/heads/master@{#326824}

The events create a lot of log spew.  They used to be done independently
of DNS resolutions, but now that they're done on every resolution, no
need to make them separate events.

BUG=none

Review URL: https://codereview.chromium.org/927533005

Cr-Commit-Position: refs/heads/master@{#326823}

BUG=464238
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/1104793003

Cr-Commit-Position: refs/heads/master@{#326822}

This API is used on Chrome OS only. No need to compile the schema on all
operating systems.

TEST=All current Files app tests pass.
BUG=None

Review URL: https://codereview.chromium.org/1093923006

Cr-Commit-Position: refs/heads/master@{#326821}

ServiceWorkerPerfTest was failing on Android One, due to timeouts of
VideoRecorder.IsStarted(). This patch attempts to fix this by increasing
the timeout from 5 seconds to 10 seconds, and re-enable the test.

BUG=469841
TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker

Review URL: https://codereview.chromium.org/1093923004

Cr-Commit-Position: refs/heads/master@{#326820}

As a result of crbug.com/474421, sync sometimes stores incorrect data to the
favicons database.

This CL:
- Expires bookmark favicon bitmaps when history is cleared
- Expires the favicon bitmap data if MergeFavicon() overwrites the current
  favicon bitmap. MergeFavicon is the entry point used by sync to update
  favicons. MergeFavicon() has other callers but they pass in the page URL as
  the icon URL.

BUG=474613
TEST=ThumbnailDatabaseTest.*, BrowsingDataRemoverTest.*

Review URL: https://codereview.chromium.org/1098053003

Cr-Commit-Position: refs/heads/master@{#326819}

The feature is in stable status since 2013. No runtime check in blink
currently. So just remove the call for runtime enabling.

The blink side patch is at: https://codereview.chromium.org/1074943004/

BUG=402536

Review URL: https://codereview.chromium.org/1094103007

Cr-Commit-Position: refs/heads/master@{#326818}

This CL follows crrev.com/1086943003. This CL adds a dump provider to
dump the values given by java.lang.Runtime class on dalvik heap
statistics into tracing.

BUG=477464

Review URL: https://codereview.chromium.org/1050233004

Cr-Commit-Position: refs/heads/master@{#326817}

On GYP builds, chrome_junit_tests was building and running tests for
media.remote, but GN builds didn't do that. This patch does the
manual addition required for it with GN

BUG=472067

Review URL: https://codereview.chromium.org/1099713004

Cr-Commit-Position: refs/heads/master@{#326816}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5b5f7c18..d8992d97

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1108603002

Cr-Commit-Position: refs/heads/master@{#326815}

BUG=479966

Review URL: https://codereview.chromium.org/1106573002

Cr-Commit-Position: refs/heads/master@{#326814}

Check that the WebView has not been destroyed before calling
mContentViewCore.getWebContents() in requestExitFullscreen.

BUG=479310

Review URL: https://codereview.chromium.org/1057923007

Cr-Commit-Position: refs/heads/master@{#326813}

This draws a light stroke around the selection rectangle so that it will be
visible on dark or solid black backgrounds. Additionally the border painting
code was fixed to not draw the corners twice, which with a transparent draw
color was visible as more opaque borders in the corners.

BUG=294860
TEST=visual, enter overview mode (F5) and press arrow key to show selection.

Review URL: https://codereview.chromium.org/1105563003

Cr-Commit-Position: refs/heads/master@{#326812}

The final if condition in
PushMessagingServiceImpl::DidGetNotificationsShown is always true.

This patch replaces the if with DCHECKs to make the code more
understandable.

Review URL: https://codereview.chromium.org/1086393005

Cr-Commit-Position: refs/heads/master@{#326811}

BUG=480999

Review URL: https://codereview.chromium.org/1109553002

Cr-Commit-Position: refs/heads/master@{#326810}

These are no longer part of the mojo repo, but we want to persist them
when rolling to chromium.

This also brings over the small utils module that the script
depends on, with some minor adjustments. Rather than taking
the chromium path as an arg and inferring the mojo path, we
now do the reverse.

BUG=None
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1102043002

Cr-Commit-Position: refs/heads/master@{#326809}

Add new helper method to construct an HistoryDatabaseParams for a FilePath
on iOS. Constants used for DownloadInterruptReason are based on the values
from content/public/browser/download_interrupt_reasons.h.

BUG=370850

Review URL: https://codereview.chromium.org/1106763002

Cr-Commit-Position: refs/heads/master@{#326808}

This CL adds a connection finder class. The connection finder scans for
Bluetooth Low Energy devices advertising a given target service.

The current version only works when the remote device advertising the
target service is sending all its primary services UUID.

BUG=479673
R=msarda
TBR=tengs

Review URL: https://codereview.chromium.org/1094273003

Cr-Commit-Position: refs/heads/master@{#326807}

BUG=none

Review URL: https://codereview.chromium.org/1101243002

Cr-Commit-Position: refs/heads/master@{#326806}

Export kTestDownloadInterruptReason{None,Crash} and use them in
history_unittests.cc to remove dependency on content::DownloadInterruptReason.

Remove unused #includes.

BUG=370850

Review URL: https://codereview.chromium.org/1107683003

Cr-Commit-Position: refs/heads/master@{#326805}

This patch removes sharing tiles from tilings. Previously, tiles
that were not invalidated were shared between the pending and
the active trees. With this patch, tiles that are exist on the
active tree and are not invalidated are not created on the pending
tree, resulting in fewer overall tiles. This improves performance
of updating and managing tiles.

Also, this patch opens up opportunities for a lot of code clean
up that can otherwise be confusing when two trees are involved.

R=danakj, enne

Review URL: https://codereview.chromium.org/1051993002

Cr-Commit-Position: refs/heads/master@{#326804}