- 19 Jul, 2018 40 commits
-
-
Nigel Tao authored
That keyed service will, in the future, be responsible for more web app things than just policy. Also move c/b/wa/policy to c/b/wa/bookmark_apps/policy, where c/b/wa means chrome/browser/web_applications. We (nigeltao@, ortuno@, loyso@, dominickn@) want to organize c/b/wa into a 'root' directory and three or four sub-directories as we de-tangle web apps from extensions: - c/b/wa holds only the WebAppProvider and its Factory. - c/b/wa/extensions is code that is tightly coupled to extensions. - c/b/wa/bookmark_apps is code that currently depends on c/b/wa/extensions but, in the future, should not. - c/b/wa/components is low level code that is unrelated to extensions. - c/b/wa/new_bookmark_apps (name pending) is high level code that is unrelated to extensions. Change-Id: Ie42bfc348be7166c710fc6232848b5e9eb91960e Reviewed-on: https://chromium-review.googlesource.com/1142844 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#576500}
-
Dominik Röttsches authored
In r492524 we resumed performing per-character fallback for unassigned characters. This was intended to avoid problems upgrading the emoji data file. When updating the emoji data before updating ICU new emoji may have appeared in the unassigned range, which we would erroneously exclude from fallback in that case. However, allowing the full range of unassigned characters does not make sense either and triggered a memory regression in our benchmark when the amazon.in page triggers fallback for the non printable U+FFFE sentinel character. To solve this, in addition to private use area codepoints we exclude 66 Unicode non-characters, defined in http://www.unicode.org/faq/private_use.html#nonchar4 They are part of the unassigned range, but have special meanings and are explicitly intended as non-characters. We must not try to look for glyphs in fonts for these. Bug: 862352 Change-Id: I50b22a4acb0d148595c5ae4f99a57d59ee8c41dd Reviewed-on: https://chromium-review.googlesource.com/1143277Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#576499}
-
Jonathan Backer authored
Check if sized internal format is supported before making the glTexStorage2DEXT call. This was called by autogen code for GLES2Decoder and was not ported over to RasterDecoder. Also remove some dead autogen code that is not compiled in anywhere. Bug: 862376 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I116aa08ac6d381c95650ab8fad9d984ea19af109 Reviewed-on: https://chromium-review.googlesource.com/1140358 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576498}
-
Christian Fremerey authored
Moves the existing methods for creating a platform-specific instance of interface media::VideoCaptureDeviceFactory out of the interface class and into standalone functions in a separate file. This is reasonable, because the factory logic does really not belong in the abstract interface. This is needed to be able to move the factory logic part and the VideoCaptureDeviceFactory interface to separate gn targets in the subsequent CL. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing Change-Id: Iddd093c3a8d0b665094ca3ded32ff4c46f592219 Reviewed-on: https://chromium-review.googlesource.com/1139175Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#576497}
-
lixia zhang authored
A preparation patch for adding MMI optimizations in libYUV project. BUG=libyuv:804 Review-Url: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/1122064 Change-Id: I8840920f628095784756b5b3791bae47197e0a5a Reviewed-on: https://chromium-review.googlesource.com/1137811Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576496}
-
Nico Weber authored
I noticed that I forgot to remove android_unswarmed_n5_rel from mb_config.pyl in https://chromium-review.googlesource.com/c/chromium/src/+/1135556, so I tried to write some code to check that all bots referenced in mb_config.pyl actually exist now that the bot inventory exists src-side. I couldn't get that to work reliably, but I manually went through the list my code produced and removed the bots that appear to really not exist according to cs.chromium.org. Bug: 863167 Change-Id: I4aa4744d8fda8771eded403a8ebfbfca0f09de12 Reviewed-on: https://chromium-review.googlesource.com/1138338 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576495}
-
Chris Hamilton authored
This reverts commit 94218d2c. Reason for revert: Causing official build test failures. BUG=865406 Original change's description: > Make TabLoader responsible for loading all tabs. > > Currently there's an inversion where active tabs in minimized windows don't get > loaded as they are created. This is an optimization in the occlusion tracking code > that doesn't calls ReloadIfNecessary unless the window hosting the active tab > actually becomes visible. Due to this inversion the TabLoader can start loading > background tabs in the minimized window before the active tab in the minimized > window is ever loaded. > > Giving TabLoader responsibility to load all tabs fixes this. In the case of > active and visible tabs whose loads are initiated by the browser this is fine > because calling ReloadIfNecessary twice is effectively a nop, and the TabLoader > is already smart enough to track tabs that have started loading for external > reasons. > > BUG=864725 > > Change-Id: I4b86a71470b2cb1a1a9106c4d4d92ee6b18c7284 > Reviewed-on: https://chromium-review.googlesource.com/1141071 > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576071} TBR=chrisha@chromium.org,sebmarchand@chromium.org Change-Id: Icc2545c1a643042e44b15aa3fb4970045bdba105 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864725 Reviewed-on: https://chromium-review.googlesource.com/1143565Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#576494}
-
John Delaney authored
Only provision an AdTracker to a local frame if AdTagging is enabled. Useful to measure the performance impact of the AdTracker. AdTagging feature declaration moved to support RuntimeEnabledFeature Bug: 856273 Change-Id: I898c78d5be916583744b445afad885d445b440bf Reviewed-on: https://chromium-review.googlesource.com/1115374Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576493}
-
Chris Hamilton authored
This reverts commit 15986e3d. Reason for revert: Failures on official builds. BUG=865420 Original change's description: > [RC] Plumb in the enterprise policy setting. > > This adds plumbing so that the enterprise policy setting can actually override > the tab lifecycles feature. > > BUG= > > Change-Id: If86dd7687e993c7ed66955692be8eae88b505990 > Reviewed-on: https://chromium-review.googlesource.com/1142355 > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576304} TBR=chrisha@chromium.org,sebmarchand@chromium.org Change-Id: I85eaea71836ceee31522cb36503d29341486b8a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1143564Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#576492}
-
Quan Nguyen authored
Change-Id: I954a0d3e1ea86730e67188408b384f04785d837c Reviewed-on: https://chromium-review.googlesource.com/1142455Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576491}
-
Tiger Oakes authored
We now cache the data file as binary data, which can be cached in memory without crashing the page. When streaming, we build the final cache by tracking the total size of the bytes streamed in. This cache allows us to reuse the data on subsequent runs (such as when filters change) rather than calling fetch again. Bug: 847599 Change-Id: I09fb9f45c992984ed56c1270c1c015d274c4c167 Reviewed-on: https://chromium-review.googlesource.com/1136852 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#576490}
-
Vadym Doroshenko authored
When filling forms, Chrome identifies fields by FormFieldData::id on iOS and FormFieldData::name on other platforms. The new FormData->PasswordForm parser failed to use 'id' on iOS. This CL fixes that by introducing platform-dependent identifier selector, which returns 'id' on iOS and 'name' elsewhere. The alternative solution of switching the iOS code to use 'name' (or the rest to use 'id') is not good for various reasons: - non-iOS code will ultimately migrate to using FormFieldData::unique_renderer_id, which is superior to both but not supported on iOS - iOS code contains significant improvements which ensure that FormFieldData::id is actually unique; this has been neither done outside of iOS, nor for FormFieldData::name - the amount of code needing change would be large and the benefit virtually null (compared to the solution from this CL). Bug: 831123 Change-Id: I24960064bb3f792ef4e0ebe6fbf769509481bad1 Reviewed-on: https://chromium-review.googlesource.com/1142151 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576489}
-
Tiger Oakes authored
Replaced --min-symbol-size with --all-symbols. By default, 100,000 symbols are included in the data file (similar to the amount when min symbol size was 1024 bytes). If the all-symbols flag is used, every symbol is included. Bug: 847599 Change-Id: I4511d0fdb6c179ff368ce5eceaa529890f8d2d5b Reviewed-on: https://chromium-review.googlesource.com/1142477 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#576488}
-
Rayan Kanso authored
The Cleanup task spawns some deletions tasks which access the cache storage on another thread. This can cause a race condition with a regular RunLoop, so I replaced it with the TestBrowserThreadBundle. TBR=peter@chromium.org Change-Id: I6ab56a4a0c72b50831461832bce6a3ab10ea5543 Reviewed-on: https://chromium-review.googlesource.com/1143404Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#576487}
-
Kevin McNee authored
As part of issue 855840, we will need to hit test touchpad gesture fling cancel events. However, we currently generate a synthetic fling cancel before every wheel event in a scroll. This is excessive, since we have wheel scroll latching, and would become expensive, since we would need to hit test them all. We now only generate a synthetic fling cancel at the beginning of a touchpad scroll. Bug: 855840 Change-Id: I108393814065c90cea80ba5326772a1764526ad7 Reviewed-on: https://chromium-review.googlesource.com/1138637 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576486}
-
Chris Hamilton authored
Allow tabs to be discarded more than once. The heuristics have changed so much in in the last 6 months that this additional protection isn't needed. BUG=794622 Change-Id: I094af452b5a7190f229fefbc77f4571ac0601a17 Reviewed-on: https://chromium-review.googlesource.com/1142479 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#576485}
-
Travis Skare authored
Bug: 864302 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If94e1b5b1cff588da4b83dcee1bdc652889bc05f Reviewed-on: https://chromium-review.googlesource.com/1141119 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576484}
-
Justin Cohen authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I60c506d9c15bce437c32c844162ec5df243bb501 Reviewed-on: https://chromium-review.googlesource.com/1142957 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576483}
-
Samuel Huang authored
This CL is similar to: https://chromium-review.googlesource.com/1133688 BufferRegion::FitsIn() (and BufferViewBase::covers()) decides whether a BufferRegion fits inside a buffer. A special case is whether an empty region fits at the end of a buffer? Previously this was considered to be a pathological case, so the result is "false". However, this led to a DCHECK failure found by the DEX fuzzer: a CodeItem with insns_size = 0 is checked against an empty buffer. It may seem straightforward to change the DCHECK to a handled failure. However, the failing code (in CodeItemParser::GetCodeItemInsns()) occurs after CodeItem have been supposedly validated, so the DCHECK is correctly placed! Two causes are: (1) Technically insns_size should be > 0, as dictated by constraint A1 ("The insns array mus tnot be empty") in Dalvik spec. (2) The FitsIn() check is too stringent. This CL focuses on relaxing (2). This makes checking slightly more permissive elsewhere in code (patch_reader.cc and Win32 disassembler), but this looks like the right thing to do. As for (1), we plan to visit https://source.android.com/devices/tech/dalvik/constraints and implement more rigorous checks. So we simply add a TODO for now. Bug: 863478 Change-Id: Iacbb2bb9bf26701db960192c7b727351ea5afdec Reviewed-on: https://chromium-review.googlesource.com/1142517Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576482}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cfe9e51. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Iff1eed3e65d8617ecc6f96b72b0d719768426321 Reviewed-on: https://chromium-review.googlesource.com/1143133 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576481}
-
Justin Cohen authored
Adds two fixes for Xcode 10 / iOS 12. Bug: 843236 Change-Id: If619d0899e65fd86cf98a980dd0e6b741a4f5d90 Reviewed-on: https://chromium-review.googlesource.com/1142601Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576480}
-
Leonard Grey authored
Also fixes assumption in AXPlatformNodeCocoa that all children are also AXPlatformNodeCocoa Bug: 861756, 833638 Change-Id: I3fbf05858b00f8a8ee06d8c5d0af988252ca26a8 Reviewed-on: https://chromium-review.googlesource.com/1138793 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576479}
-
chrome://conflictsChris Hamilton authored
This makes it so that all the information needed to diagnose whitelist issues is available in one place. BUG=847544 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idef99fa83d84ff1d7258c65f9ca4f481267758f8 Reviewed-on: https://chromium-review.googlesource.com/1142515 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576478}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c3318d5f367c..2ec2b508e610 git log c3318d5f367c..2ec2b508e610 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 nednguyen@google.com Update screenshot taking method on Linux to use gnome-screenshot Created with: gclient setdep -r src/third_party/catapult@2ec2b508e610 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862996 TBR=sullivan@chromium.org Change-Id: I009a3ce12d60d85f97ae4070ebd93c8c8a73594f Reviewed-on: https://chromium-review.googlesource.com/1143031Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576477}
-
stkhapugin@chromium.org authored
Moves the logic to retrieve the image for the topmost suggestion in the omnibox from omnibox_popup_view_ios to the left image consumer. Bug: 865000 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b839bb546d5aa652e7db87c91fe88fcbc2b594e Reviewed-on: https://chromium-review.googlesource.com/1143184Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576476}
-
Koji Ishii authored
Following bot results are included. dummy 0 lines were removed and 0 lines were deflaked by consecutive results since 0. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I681f0fa76c214b616b904a9d55d29b34a71e1f56 Reviewed-on: https://chromium-review.googlesource.com/1142053 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576475}
-
cathiechen authored
Like the legacy layout, make single li as list-style-position: inside. We consider li is with ul/ol by default. If not, use not_in_list_changed_ to indict that we should UpdateMarker(). Bug: 725277 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5a245fd12c204f5dd4d68c6ce7aacd4582cedb78 Reviewed-on: https://chromium-review.googlesource.com/1141745 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576474}
-
Alex Clarke authored
Bug: 863341 Change-Id: I591ec517b11e206e5249578d0ca5583790ef0be4 Reviewed-on: https://chromium-review.googlesource.com/1143390Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576473}
-
Wang Hui authored
BUG=None Change-Id: I1eae52d89a5023ca853ffd3de1f884e174bdd0da Reviewed-on: https://chromium-review.googlesource.com/1143173Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576472}
-
Calder Kitagawa authored
Rearrange the WebAPK resources such that a higher density app_icon_<density>.png can be used as the splash_icon.xml and add app_icon.xml to not break anything as a result of moving and renaming the app_icon.png files. Also adds a splashId to the AndroidManifest.xml for use in Chrome such that the WebAPK can update the splash screen image rather than using the primaryIcon for the splash screen. Modifies Chrome code to support decoding XML aliases to images. TBR=dominickn@chromium.org Bug: 819755 Change-Id: Id42c2e898a5996dfba46ad6608cc1d3103300521 Reviewed-on: https://chromium-review.googlesource.com/1128256 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576471}
-
Ian Clelland authored
external/wpt/workers/modules/dedicated-worker-import-blob-url.any.worker.html has been semi-consistently timing out on WebKit Linux Trusy bot. Bug: 865432 Tbr: dullweber@chromium.org Change-Id: Ie5c494138c9226cb37d690f0aa526227c652381d Reviewed-on: https://chromium-review.googlesource.com/1143136Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576470}
-
Thomas Tangl authored
- strings for the spell check hint are added - the autocomplete-searches description is updated Bug: 855945, 864793 Change-Id: I33b520fbef30122e6add794d71d8f48053fc253c Reviewed-on: https://chromium-review.googlesource.com/1143304Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#576469}
-
Mathieu Perreault authored
Bug: 788432 Change-Id: I0c6b058149896f693caeb0420dd3475aa5486e08 Reviewed-on: https://chromium-review.googlesource.com/1141925 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576468}
-
Elly Fong-Jones authored
This change adds a high-contrast theme supplier (IncreasedContrastThemeSupplier) and enables it on Mac when the system "Increase Contrast" setting is enabled, or when --force-high-contrast is passed at startup. This theme maximizes contrast between UI elements. Bug: 831769 Change-Id: I6cbb1b67fd95372dd65501feab6639942f767019 Reviewed-on: https://chromium-review.googlesource.com/1142030Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576467}
-
Maja Kabus authored
Existing implementation of setHref() changed, older version is abandoned. Added new function href() to accept URLString as an argument. Bug: 739170 Change-Id: Id57e361574c50b13df1876fe83e8693429b66fc8 Reviewed-on: https://chromium-review.googlesource.com/1136635 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576466}
-
Maja Kabus authored
Modified data and codeBase attributes definition in *.idl file. Bug: 739170 Change-Id: Ia332493450d0e780e4e6eb332708216da02060d1 Reviewed-on: https://chromium-review.googlesource.com/1137824 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#576465}
-
Michael Hablich authored
This is a roll-back to V8 6.9.427. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org NOTRY=true Change-Id: I4d7f1c1a1408f37cfcab66001ceba90851183cb3 Reviewed-on: https://chromium-review.googlesource.com/1143278 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#576464}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ed4c83aac3f1..e34766b47b67 git log ed4c83aac3f1..e34766b47b67 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hidehiko@chromium.org Add four more boards to pre-cq. 2018-07-19 xixuan@chromium.org SkylabSuite: Separate create and wait for buildbot silency check. Created with: gclient setdep -r src/third_party/chromite@e34766b47b67 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5759c93332ddaec1c7cd63f5f72c3ff043282a11 Reviewed-on: https://chromium-review.googlesource.com/1143028Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576463}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b013420703b..c6f7ba31d255 git log 1b013420703b..c6f7ba31d255 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hjd@google.com Merge "perfetto-ui: Increase correctness of build" 2018-07-18 hjd@google.com perfetto-ui: Increase correctness of build Created with: gclient setdep -r src/third_party/perfetto@c6f7ba31d255 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iac780d43d91857fa9265da29b695e1f075ecc7bf Reviewed-on: https://chromium-review.googlesource.com/1143030 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576462}
-
Rayan Kanso authored
Collect errors per registration on initialization, and clear the corrupt data if applicable. Change-Id: I4f8da3c389e70a6d041c72a0e08c3ae1b5a85051 Reviewed-on: https://chromium-review.googlesource.com/1141881 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#576461}
-