- 23 Nov, 2020 40 commits
-
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. The "test_policy" field used to be read by the code, but the value is not used anywhere. Bug: 1151251 Change-Id: I472e4daa552e1f276c4d1ec6b4da04c8670cb507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552582 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830238}
-
Illia Klimov authored
This CL prevents abusive origin permission revocation for profiles with disabled Safe Browsing. Bug: 1151900 Change-Id: I87d117073363177d16b8957791ebf2badb307fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552599 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830237}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c0dc3026eed..260eb0f662b4 2020-11-23 nodir@chromium.org [tryserver] Report affected files via property If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1151655 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I700efd778dea11245a8bc8c3b2a86a49597160f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830236}
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. The field only exists as part of the "indicator_tests" so it is ignored here. Bug: 1151251 Change-Id: I6ff4ff8b88c4befaa7b340000fd149c5ea206f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550819Reviewed-by:
-
Fabio Rocha authored
This CL adds the ProtocolHandlerManager class and its interface to handle protocol handler registration operations. It also ties it to the OSIntegrationManager, which handles app events that interact with the OS (e.g.: app install, update, uninstall, profile deletion, etc..). This CL does not, at this point, add any OS hooks for protocols -- that will come as we add the implementation for ProtocolHandlerManager. This CL is mostly conceptual and therefore should not cause product changes. Future CLs will hook handler registration APIs into ProtocolHandlerManager/OSIntegrationManager. Bug: 1019239 Change-Id: I0c5a26499c000a31067887d42b93d18d0f6c3f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243335Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#830234}
-
Yue Zhang authored
Some of the test flakiness in tab_ui are caused by tab switcher button being invisible in NTP when we try to click it. This is likely due to unexpected scrolling in NTP which hides the top tool bar. Before landing the actual fix which could introduce some other flakiness, this CL lands a workaround first to see how many flakiness could be fixed by resolving this issue. Bug: 1145271 Change-Id: Iae74425cdc66f41dbfc8eca0d91129c67e9bca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536385Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830233}
-
Alex Ilin authored
TBR: twellington@chromium.org Bug: 1142979 Change-Id: I87c143a25d4d6cfde29947a91f099d49561c89d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555002Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830232}
-
Sigurdur Asgeirsson authored
This makes the class simpler to use in the common case. Bug: 1145565 Change-Id: Ib6aab62eebf4e402e364687d4224d0f8d7077e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549534Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830231}
-
GioVAX authored
by introducing base classes for LogCollector and Logger BUG=chromium:10734365 TEST=unit_tests --gtest_filter=ExtensionInstallEventLoggerTest.*:ExtensionInstallEventLogCollectorTest.*:AppInstallEventLogCollectorTest.*:AppInstallEventLoggerTest.* Change-Id: I32743bee419682b942b4867b8705d071b48da9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485102 Commit-Queue: Giovanni Pezzino <giovax@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Vasiliy Telezhnikov authored
This reverts commit db7626d6. Reason for revert: Causes crash on windows Original change's description: > Use GrShaderCache with Vulkan > > VulkanContextProvider is created before GrShaderCache and so cache > wasn't pass to Skia via GrContextOptions. > > This CL defers init of GrContext in VulkanInProcessContextProvider to > SharedContextState::InitializeGrContext to mitigate this. > > Use of cache itself is under feature flag for metrics comparison and > a kill switch purpose. > > Bug: 1151031 > Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829651} TBR=penghuang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151031, 1151645 Change-Id: Ic6712d111d234f72fd799a4c48a90a4426aa1a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553698Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830229}
-
Nick Burris authored
This patch refactors SslValidityChecker from chrome into components, so that it can be used in WebLayerPaymentRequestFactory to implement getInvalidSslCertificateErrorMessage(). SslValidityChecker is modified to check the certificate without using chrome's security_state_tab_helper, instead using security_state directly. Bug: 1144850 Change-Id: I5964d43e97b66ed5c3470ca6d331b34303bc8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551798Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#830228}
-
Alex Ilin authored
MediaCaptureTest#twoStreams and MediaCaptureTest#twoStreamsNotification are still flaky on Lollipop Tablet Tester and Marshmallow Tablet Tester TBR=sky@chromium.org,estade@chromium.org Bug: 1107380 Change-Id: I4f875f32d4d3de74ab99b225e4ee78a2637a955f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555337 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. Some test cases incorrectly defined the test as a single object instead of a list of objects, which caused them to be skipped entirely. Bug: 1151251 Change-Id: I10c2354dc0f4545b072af2f6b75f6871a36cf402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552581 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Johannes Kron authored
The initial implementation of the low-latency renderer assumed that the display rate was fixed at 60Hz. This CL adds support for generic frame rates as well as missed render intervals. The low-latency renderer algorithm is enabled from WebRTC by setting the metadata field maximum_composition_delay_in_frames. This is an experimental feature that is active if and only if the RTP header extension playout-delay is set to min=0ms and max>0ms. The feature can be completely disabled by specifying the field trial WebRTC-LowLatencyRenderer/enabled:false/ Bug: 1138888 Change-Id: Ic64b26331d31aaf8fb8ed4fb8f1056b227cb6eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527424Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#830225}
-
Sinan Sahin authored
If a navigation occurs while the context menu is showing, the RenderFrameHost becomes invalidated and causes a seg-fault if the user tries to share the image. This CL dismisses the menu on navigation to prevent this. Bug: 1150622 Change-Id: I3aba40a2fae69715454ed753b4af623aca02006d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553191Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830224}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 454e5714. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I461419487c26a60bbbe172ca415262e4458b1769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554783Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830223}
-
Amr Aboelkher authored
Enable PSM protocol by default during the initial enrollment. BUG=chromium:1130590 Change-Id: Iab0adabc30e5e47eb8bde814751f135627161f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552382Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Bo Liu authored
//media/gpu is depending directly on ipc_common_sources which ends up compiling a separate copy of ipc_common_sources into media_gpu in component builds. Fix this by depending on the group instead. This fixes any crashes related to CheckFeatureIdentity failing on AImageReader in component build. Fixed: 1144945 Change-Id: Ice2758de77f704103e792242449b985b3937e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553969 Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#830221}
-
Connie Wan authored
This reverts commit 27401214. Reason for revert: Suspected cause for test failures: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/10771 Original change's description: > Fixes erroneous focus placement on Mac > > When using VoiceOver, focus is often erroneously placed in Chrome's toolbar instead of the web contents > as soon as the user navigates to a new page and after the page has loaded. > If the page includes logic that moves the focus to a specific item as soon as it loads, > that logic often has no effect on the location of the VoiceOver cursor. > For example, after visiting a user's Gmail inbox, VoiceOver often > neglects to automatically move to the list of emails, even though the page has logic to do that after load. > > The same problem often occurs when an iframe is inserted in the page and focus programmatically moves > to somewhere inside it. > For example if the user presses "h" and then "c" to focus the list of chat conversations in Gmail > and then selects and opens one of the conversations, the VoiceOver cursor might not move to the edit field in that conversation. > > This patch: > 1. Removes the logic that prevents the firing of a focus event if the page has not loaded, or has no content. > A) The page is marked as loaded as soon as the HTML is parsed, i.e. extremely quickly, so in 99% of cases this condition has no effect. > B) Even if the page is empty, user confusion does not occur, because everything happens too fast. > I tested with Jaws and NVDA, which were the AT for which this second condition was added in the first place. > C) This logic of preventing some focus events has caused bugs in the past, so I think simplifying it should > improve the health of our codebase, given that it doesn't cause any regressions. > 2. Adds accessibilityFocusedUIElement to BrowserAccessibilityCocoa. > It was implemented in Views, but was missing from Web. > > I suspect that the reason that this patch seems to fix the bug is because > VoiceOver monitors the load progress on the web contents, and expects a focus event to arrive as soon as the page has loaded. > > AX-Relnotes: VoiceOver focus should be in sync with browser focus, if the user has chosen this setting. > > R=dmazzoni@chromium.org, abigailbklein@chromium.org > > Change-Id: I9ae7b69fc3c7872bbbb39ffdd13562c97b8d1174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551814 > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Abigail Klein <abigailbklein@google.com> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830186} TBR=nektar@chromium.org,abigailbklein@google.com Change-Id: I21b95965a0bfd0c3186b1e8f14e38612ee7583cb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554903Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830220}
-
arthursonzogni authored
This was a TODO(https://crbug.com/1136678). The associated bug has been fixed. TBR=mkwst@chromium.org Fixed: 1151647 Bug: 1136678,1151647 Change-Id: I74e73d83be87a063b7a5266f64d6a5abba7e1dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552411 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830219}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/546a7c98c897..3cd31e647c7d 2020-11-23 cwallez@chromium.org Metal: Prevent data race on mLastSubmittedCommands If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1142024 Tbr: enga@google.com Change-Id: I86c44dd04c34e82a470bacd8ae216a0c40382930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554958Reviewed-by:
-
Andy Paicu authored
DD: go/permissions-suggestions-client-doc Since the URL has changed again and it's still not set in stone we should proactively set it up in such a way where we can control it without needing to update the code. This CL adds a new feature with a feature param that will be used as an override for the default URL, that way we can temporarily write a finch config to set the URL for M88 clients if it changes again. Bug: 1138595 Change-Id: I61e92577f95e87cf6fd79a225e18d69b34becc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545626 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#830217}
-
Francois Doray authored
Affected tests: MemoryTracingBrowserTest.TestMemoryInfra MemoryTracingBrowserTest.TestBackgroundMemoryInfra TBR=thakis@chromium.org,ssid@chromium.org Bug: 806988, 808152 Change-Id: Ibaea22b3bd99596763d062a6853a99494c1af6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553111Reviewed-by:
-
Mark Cogan authored
Because BVC's -keyCommands method is a UIResponder API, it can be called in response to many events outside of Chrome's direct control; UIKit calls it (for example) after a child view controller is removed from the BVC. This can happen while the BVC is shutting down. KeyCommands needs to access BVC's |self.browser| method to fetch a browser agent. If the BVC has shut down, |self.browser| is nullptr. This CL changes -shouldRegisterKeyboardCommands to return NO when the BVC is shutting down, or when |self.browser| is null. Bug: 1151894 Change-Id: Iba8f5e7fa4bf2a2b6a85815ad030935c86c1bfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553427Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830215}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ca1b95..7950639f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a64e89e5eb44f5551fa3d3d7020d3e1af621274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554898Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830214}
-
Liviu Tinta authored
Check pointerId, pointerType are the same as for the pointer event stream that generated the click/auxclick event. Bug: 1150441 Change-Id: Ic3c7bc05efad1b4024edbe3fc83cdbd812111c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549464 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830213}
-
Morten Stenshorne authored
The test assumed that block fragmentation takes place after relative positioning, but it's the other way around: https://www.w3.org/TR/css-break-3/#transforms Bug: 829028 Change-Id: I297bf572354216188b5a8c8d007f7a137c36e773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554543Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830212}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/168214172df5..da303cba1a43 2020-11-22 mmortensen@google.com Revert the revert and fix Port FindSymbolFiles from scripts/upload_symbols.py. 2020-11-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-20 saklein@chromium.org Revert "cros_extract_deps: Begin moving functions." 2020-11-20 henrysun@google.com dedede: add firmware-dedede-13606.B branch to builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1ceb3382d7016a9a06f334b0386a9f440aeab941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554293Reviewed-by:
-
Clemens Arbesser authored
When starting a regular script after a trigger script was shown, there used to be an animation glitch while the bottom sheet resized. This was caused by the progress bar repopulating all of its views. This CL is a hotfix for this issue. Adding the new icons before clearing the old ones ensures that the height of the progress bar never changes. Bug: b/174014637 Change-Id: I37e836a7f579cefc227feddabcbf8cb864a6bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554919Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#830210}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d5a4b4a64eb..b432754c00d7 2020-11-23 egdaniel@google.com Reland "Move vulkan memory uma stats to report on submit." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I2b39f411346d21756e3a3692f468165d3115a1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554824Reviewed-by:
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/a1fb8becdf2d..e6fd1cf8d622 $ git log a1fb8becd..e6fd1cf8d --date=short --no-merges --format='%ad %ae %s' 2020-11-19 wub Add a TlsServerHandshaker::ValidateHostname method to validate SNI. 2020-11-19 renjietang Add connection options to experiment client path degrading alarms with PTOs. 2020-11-19 danzh Add unused QuicSession interfaces to initiating IETF connection migration: MigratePath(), ValidatePath(). These new interfaces are used by toy client in e2e tests. 2020-11-19 bnc Internal QUICHE change 2020-11-18 quiche-dev Introduce QuicDatagramQueue::Observer Created with: roll-dep src/net/third_party/quiche/src Change-Id: I1a3d2c6a5cea7b1bfe999c6622d392dc0a05cbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552221Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#830208}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I753a31a5c4abf4f68ffae1e9d02f14b4a22c1cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554333Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#830207}
-
François Doray authored
This reverts commit a777fd4b. Reason for revert: Suspect for crbug.com/1151948 Original change's description: > [PartitionAlloc] Implement SpinningMutex on macOS. > > macOS has futex()-like locks in pthread, meaning that SpinningFutex can > be useful there, the same way it is on Windows. Use pthread to implement > it. > > Bug: 998048 > Change-Id: I77df835baf2f099eedcfcee675f7a56ed6b3bb2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550797 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830175} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: I636660d7834a80595578ee18ad80b7dfe42d6ed6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048, 1151948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555177Reviewed-by:
-
Alex Turner authored
base::Bind is deprecated and should be replaced with the more explicit base::Bind{Once,Repeating}. The vast majority of this directory was already migrated, but a few uses remained. We fix the remaining uses and enable the presubmit to avoid any future regressions. Bug: 1141533, 1007652 Change-Id: I18541dce79a90379bf2874e82b168fbf37d20ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506049Reviewed-by:Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830205}
-
Victor Hugo Vianna Silva authored
If the kSendTabToSelfWhenSignedIn feature is enabled, IsReceivingEnabledByUserOnThisDevice() will now return true both for signed-out and signed-in but not syncing users. This WAI since this information will never be sent to other clients unless the user is actually signed-in and sync-the-transport is running. It's hard to use to the SyncService API in this layer due to cyclic dependencies between DeviceInfoSyncService and ProfileSyncService. So the code still relies on the state of SyncPrefs, particularly IsFirstSetupComplete and SyncRequested. Bug: 956722 Change-Id: I60318e730a250c48d73417b71a2f23b263d665ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526426Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#830204}
-
Antonio Sartori authored
The Content-Security-Policy keyword 'self' in a source expression is a placeholder for allowing sources with the same origin as the document. Even if the document is sandboxed (i.e. has a unique opaque origin), the keyword 'self' should match the document URL's origin. This test checks that a document with CSPs: Content-Security-Policy: sandbox; frame-src 'self' can still embed a frame delivered by the same document URL's origin. Bug: 1151323 Change-Id: Icba5fb8a15bca30ab807ca81ae97152122efb292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552593 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: -
Maria Kazinova authored
Replacing a DCHECK in PasswordAutofillAgent::InformAboutFormClearing() with a condition check and return, since this condition might be true and the method should not proceed, but it shouldn't cause a crash. Bug: 1151915 Change-Id: Ib23746cb1e063f8539a5812fcd8105b799e636b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553553Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#830202}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011230600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/TQZeWYEoU6kk_nvBNEUoTxcbn05BDdKuAT2yGqC9r0IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/150642729,b/168069888,b/173695073 Tbr: media-app@grotations.appspotmail.com Change-Id: Ib63c40f7129a12a4005cd51fe83742a942deec0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554823Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830201}
-
Felipe Andrade authored
Remove duplicate import("//tools/polymer/polymer.gni") from a BUILD.gn file in webui resources. This is simply a clean up work. Bug: 11509326 Change-Id: I8f386a46086ede1a8d37de0352b21b4590d28aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550742Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#830200}
-
Chris Sharp authored
Add jamiewalch@ as a second owner to policies only owned by remoting/OWNERS. Bug: 1018157 Change-Id: Ie9bbb06445be136ef2ccf295b31654e074152e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550262 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830199}
-
