- 12 Apr, 2018 40 commits
-
-
Xianzhu Wang authored
This is a reland of 2d526f29 Was reverted because it caused crbug.com/832020 which is a crash in the following case: <div style="width: 0; height: 0; box-shadow: 0 5.5px"></div> The div has zero size and visual effect outset on one side only, so the overflow is still zero and doesn't create OverflowModel. Original change's description: > [PE] Let visual rect cover sub-pixel visual effect outsets > > If an overflowing visual effect has sub-pixel geometry and is painted > with anti-aliasing along pixel-snapped border box, the pixel-snapping > may cause the anti-aliased edge overflow the calculated visual rect. > > Let LayoutBox::VisualRectOutsetForRasterEffects() return 1 if there are > any sub-pixel visual effect outsets to ensure the visual rect covers > all pixels. > > Bug: 827516 > Change-Id: I48f8350fb2124d002333a4cc76486c63ca55f8c9 > Reviewed-on: https://chromium-review.googlesource.com/1003492 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550014} Bug: 827516, 832020 Change-Id: I4e7831d7d91cc541127670ac102ec0292ae50387 Reviewed-on: https://chromium-review.googlesource.com/1010583Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550334}
-
liberato@chromium.org authored
To facilitate adding new features, VideoDecodePerfHistory and related clases now take a mojom::PredictionFeatures struct which wraps the old values. Similarly, the resulting predictions are wrapped up as PredictionTargets for symmetry. Change-Id: Ic204aa8e66cc66090962acb65e7fcd250c123ce2 Reviewed-on: https://chromium-review.googlesource.com/975993Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#550333}
-
Kevin Marshall authored
This reverts commit 8c5544c2. Reason for revert: Breaks https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5174 Could be due to WideFrameView lacking an export directive? Original change's description: > Add WideFrameView class > > This will be used for ARC++ windows. This > a) is always placed at the topof the display and covered full width. > b) supports immersive mode > c) is resized when the display metrics changes. > > BUG=b/33693796 > TEST=covered by unittest > > Change-Id: I27c8e9d27b673b5f85ff6992380c8ea707d3ea55 > Reviewed-on: https://chromium-review.googlesource.com/990203 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550278} TBR=mukai@chromium.org,oshima@chromium.org Change-Id: I31847f2485f5e8b0f70cf2342991596863f097f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/33693796 Bug: 832275 Reviewed-on: https://chromium-review.googlesource.com/1010843 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550332}
-
Troy Hildebrandt authored
LBL#finishUrlFocusChange calls UrlBar#scrollToTld directly, which isn't behind the protective if check of scrollDisplayText. This patch makes all the scrolling methods in UrlBar private except for scrollDisplayText to ensure we perform this safety check, and instead we only call scrollDisplayText from #finishUrlFocusChange if the scrollType is SCROLL_TO_TLD to ensure the behavior is the same as before. Bug: 831472 Change-Id: Ib44e582a571bd5a45a2921581f4b2d2c1c388024 Reviewed-on: https://chromium-review.googlesource.com/1008279 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550331}
-
sebsg authored
A classic example that will now support is filling a Canadian profile into a page where the default country was the US. When the country changes, some sites change the "state" field to a "province" field. Bug: 831661 Change-Id: Iec0deb5ab69f554756a75dd4e893f3535c6bfc06 Reviewed-on: https://chromium-review.googlesource.com/1010528Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550330}
-
Ian Vollick authored
Short-circuiting tree walks can cause subtle issues. This CL introduces a variable to make it trivial to disable. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6af5f8c0c1b96c88c3c64f366b610e876e34d9c9 Reviewed-on: https://chromium-review.googlesource.com/1008522Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550329}
-
Eric Lawrence authored
Devtools keybindings to Actions are not disabled when the associated command is disabled. The recently added Focus Debuggee command used F12 as a key binding but this had undesirable behavior when the DevTools were docked in the browser window. This CL removes the F12 key binding. Bug: 821285 Change-Id: I6acd66e01ba9a8ef3a8a082bd18e7da569ff347f Reviewed-on: https://chromium-review.googlesource.com/1010469 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550328}
-
John Chen authored
Remove a workaround that is no longer needed in Chrome 67 and above. This workaround caused ChromeDriver to return too early, while iframes are still loading. Bug: chromedriver:2198 chromedriver:2350 Change-Id: I7e070cd02a4798b72315b6ba8f904567907eeba5 Reviewed-on: https://chromium-review.googlesource.com/1005618Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550327}
-
Daniel Park authored
Bug: 832212 Change-Id: If9f76cf12ac58c8367c16275796acd2e38847051 Reviewed-on: https://chromium-review.googlesource.com/1010837Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550326}
-
Xiaoqian Dai authored
See https://drive.google.com/file/d/1XFKAracGq63nmlE9yIambuS0WhzVt8YS/view for the spec. Bug: 827730 Change-Id: I61f7bb183c618567a3fc38bfefbffec358071284 Reviewed-on: https://chromium-review.googlesource.com/1008868 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550325}
-
Pavel Feldman authored
Bug: 830526 Change-Id: I12665a63034f0a9ec5f628874b0af49194027668 Reviewed-on: https://chromium-review.googlesource.com/1006269Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550324}
-
Hongchan Choi authored
As this discussed in the issue[1], use scoped_refptr<base::SingleThreadTaskRunner> instead of directly accessing the worklet thread. By fetching a per-global-scope task runner from the WorkerThread (that backs AudioWorkletThread), we can guarantee safe operation when the global scope is running. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=822725#c10 Bug: 822725 Test: The repro case in the bug does not crash anymore. Change-Id: I6fa00b342f3050b9b1197e257b0a9fb16c280117 Reviewed-on: https://chromium-review.googlesource.com/971445 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550323}
-
Pavel Feldman authored
Bug: 831087 Change-Id: Ife9e0fde092818be3c08c4e7fde2cd55bcfd4cef TBR: dgozman Reviewed-on: https://chromium-review.googlesource.com/1005360Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550322}
-
Quinten Yearsley authored
This reverts commit 0d5e3630. Reason for revert: The tests that were failing after the first time landing this have now been removed (crbug.com/825837). R=eyaich@chromium.org Bug: 825837 Change-Id: Ibbd16ba0976863870ebb4cb00fc72a6bae3b9e0e Reviewed-on: https://chromium-review.googlesource.com/1005738Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#550321}
-
Dave Tapuska authored
Don't evict frames when the width doesn't change to avoid a few frame repaints that are completely blank. When the size is expanded only the area that doesn't exist in the old frame appears black. This is less jarring to the user and appears as less jank. BUG=831656 Change-Id: I787e10d277ffa08ddedd080efa76b984df92c1e1 Reviewed-on: https://chromium-review.googlesource.com/1008245 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550320}
-
Andrey Lushnikov authored
This patch starts fetching mime type from the subrequest, if any. R=caseq Change-Id: Ic3ca487fa7ee80f5d8a1bcc270f7d7120fee8fc5 Reviewed-on: https://chromium-review.googlesource.com/1010415 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550319}
-
Mihai Sardarescu authored
This CL add a generic function to records user actions for impressions (Signin_Impression_From* and Signin_Impression{With|No}Account_From*). It uses the new functions for the following: * To replace calls to base::RecordAction(base::UserMetricsAction("Signin_Impression_From*")) to match what was done for "Signin_Signin_From*" user actions). * To record "Signin_Impression{With|No}Account_From*" for contextual promos when DICE is enabled This CL also removes a double counting of "Signin_Impression_FromExtensionInstallBubble" user action. Bug: 819432 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic605ef1991b532221bdd6547edbca1624fc91067 Reviewed-on: https://chromium-review.googlesource.com/1002846 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550318}
-
Scott Little authored
This CL adds basic support (behind a flag) for deferring the load of cross-origin frames until the user scrolls near them, in order to reduce network data usage, memory usage, and speed up the loading of other content on the page. When a frame is deferred, an IntersectionObserver is used to detect when the deferred frame element is within a specific distance threshold of the viewport and resume loading the frame. Currently, this distance-from-viewport threshold is hardcoded, but in future CLs it will be supplied from a field trial parameter. Heuristics (i.e. tiny dimensions or offscreen position) are used to recognize and immediately load frames that are likely used for analytics or inter-frame communication, since those kinds of frames would be broken by deferring them. Once a lazily-loaded frame starts loading in, children within that lazily-loaded frame won't be lazily loaded themselves. This will make it possible for subresources in hidden frames to load that will never be visible, as well as make it so that deferred frames that have multiple layers of iframes inside them can load faster once they're near the viewport or visible. See the design docs below for more info. LazyFrames design doc: https://docs.google.com/document/d/1ITh7UqhmfirprVtjEtpfhga5Qyfoh78UkRmW8r3CntM/edit LazyLoad design doc: https://docs.google.com/document/d/1e8ZbVyUwgIkQMvJma3kKUDg8UUkLRRdANStqKuOIvHg/edit Bug: 635105 Change-Id: I970221f527861298b58ed5b4662eb04019bc86ff Reviewed-on: https://chromium-review.googlesource.com/979256 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550317}
-
chrome://discardsFrancois Doray authored
This is useful to debug occlusion tracking issues and to get a better understanding of which tabs might be discarded. Bug: 775644 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1ad43559a96eb758d3a7796186930d6a7ffa4b39 Reviewed-on: https://chromium-review.googlesource.com/993702Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550316}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceAggregatorPixelTest is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ea6b0cde545dd2a0a60cff2294028baf5569747 Reviewed-on: https://chromium-review.googlesource.com/1010705 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550315}
-
Carlos IL authored
Added a GetErrorDescription method to chrome_content_renderer_client, which unlike PrepareErrorPage, does not set pending_error_page_info_. Bug: 829554 Change-Id: I91f310b1bb9539f07e7d1dd3f33b2269cd862bd0 Reviewed-on: https://chromium-review.googlesource.com/1000723Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#550314}
-
Fredrik Söderquist authored
This flag is never set to true anymore. Bug: 442939 Change-Id: I03bc6129d923ff90d39e32b7508bb56cf1139b31 Reviewed-on: https://chromium-review.googlesource.com/1010164 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550313}
-
Evan Stade authored
Move the accelerator data to ash/public for those that need it and remove references that are redundant. Bug: 826411 Change-Id: I3c20bc590dd9b3c1920dde65431dad09cdc59da4 Reviewed-on: https://chromium-review.googlesource.com/996473 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#550312}
-
dpapad authored
Latest version of Closure compiler is smarter and stricter. The errors need to be fixed to unblock rolling the latest Closure compiler version. Bug: 831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5cf2abbcba1a209e28fb826b16f57e5dbd084853 Reviewed-on: https://chromium-review.googlesource.com/1006195 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550311}
-
Nicolas Pena authored
This CL moves the final user-timing tests to external/wpt and removes the folder. The performance_entrylist_checker is changed as in the http counterpart to allow de-duplicating test messages. There are some tests that are related to the wpt counterparts, but not equivalent and in a different format, so unifying some of these tests can be done in the future. Bug: 498037 Change-Id: I6f35d962ba088d92a9768e49a65dea4d5c267491 Reviewed-on: https://chromium-review.googlesource.com/1007888Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#550310}
-
Peter K. Lee authored
SSO Sign-In for FeedbackKit V2 was disabled because "Add another account" would cause a crash. FeedbackKit V2 now provides a configuration option to not show "Add another account" http://crrev/i/605488. With this option SSO Sign-In can be re-enabled. Bug: 816883 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I071548a178be47f9b260359d0aeb76642562c4bd Reviewed-on: https://chromium-review.googlesource.com/1009006 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550309}
-
Sergey Ulanov authored
New SDK contains - fixes for goland fdio namespace - pkgfs perf improvements - updated async API Bug: 707030 Change-Id: Ie97e68fc9a7623575d2673b6bba7647b5ef33733 Reviewed-on: https://chromium-review.googlesource.com/1010824 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550308}
-
John Abd-El-Malek authored
The code switched threads but a DCHECK_CURRENTLY_ON wasn't updated. Bug: 825242 Change-Id: I68a93bfd9e3a1aee2bd8abdb599b832b4226c3b4 Reviewed-on: https://chromium-review.googlesource.com/1010407Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550307}
-
Steve Anton authored
This moves the reporting for the SdpSemanticRequested UMA metric to the PeerConnection handler directly and removes the usage of the SdpSemantic::kDefault WebRTC value. Bug: 811683 Change-Id: Icecd551e40fb174eb21a5bd48943d5f8b522dd42 Reviewed-on: https://chromium-review.googlesource.com/944248 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550306}
-
Nate Fischer authored
This adds feature flags for WebResourceError and SafeBrowsingResponse methods (objects which are passed back in WebViewClient callbacks). Support for these methods landed a while ago, so this CL declares the features are implemented. Bug: 832205 Test: N/A Change-Id: I73665515915cc9305636f09b72fbad8d6a9313ca Reviewed-on: https://chromium-review.googlesource.com/1010717Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550305}
-
Michael Lippautz authored
Similar to ScriptWrappableMarkingVisitor, thread all write barrier calls through MarkingVisitor::WriteBarrier. Drive-by: - Add missing write barrier to CSSRule. Bug: chromium:757440 Change-Id: Ibc9885ac0724ec157df9c7c314be2aa14555691b Reviewed-on: https://chromium-review.googlesource.com/1010204 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550304}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/272be0ac4cae..5af686b3cfa2 $ git log 272be0ac4..5af686b3c --date=short --no-merges --format='%ad %ae %s' 2018-04-11 wolenetz lavc/libopusdec: Allow avcodec_open2 to call .close Created with: roll-dep src/third_party/ffmpeg TBR=xhwang@chromium.org Bug: 828526 Change-Id: I07f28b8b0cc722d5f07040738fc15d3a3db3f832 Reviewed-on: https://chromium-review.googlesource.com/1008879Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550303}
-
Kevin Marshall authored
native_library_fuchsia uses the Fuchsia-specific dlopen_vmo() function instead of dlopen() as on other POSIX builds. The library is package-aware, resolving full library paths differently if the process is running inside a packaged namespace. Bug: 798847 Change-Id: I1f4e0769e8b94bff65704df4dcfd73c622df13bc Reviewed-on: https://chromium-review.googlesource.com/1003060Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550302}
-
James Hawkins authored
R=khorimoto@chromium.org, stevenjb@chromium.org Bug: none Test: none Change-Id: I0417430122f57980e62b52a40d44f9c1e38024d6 Reviewed-on: https://chromium-review.googlesource.com/1003895Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#550301}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e9e2c82bdf1..b1c21a5af2ec $ git log 7e9e2c82b..b1c21a5af --date=short --no-merges --format='%ad %ae %s' 2018-04-11 cwallez presubmit_unittest.py: use LUCI for the optional GPU tests on Windows Created with: roll-dep src/third_party/depot_tools BUG=chromium:815092 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I71e7fa6024b9faf97379628674ee729f21b50ace Reviewed-on: https://chromium-review.googlesource.com/1010762 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550300}
-
Mark Pearson authored
Can't hurt. TBR=hpayer (who LGTMed this earlier, in writing, just without the +1) Change-Id: Ia39c47bfe378182ee6e631554d5a24662598de98 Reviewed-on: https://chromium-review.googlesource.com/980590Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550299}
-
Xiaohan Wang authored
MediaService has been shipped on Android and ChromeCast, to support remote CDM, AudioDecoder and media Renderer. It will be shipped on Mac and Windows soon to support hardware audio/video decoders running in the GPU process. CdmService (also covered by this test) has been shipped on all desktop platforms to support CDMs. Hence, it's getting more important to have proper test/bot coverage on both MediaService and CdmService. This CL enables "media_service_unitests" in "chromium_gtests" so we run the test on more bots. More test cases will come later. Bug: 826039 Test: This CL enables the test on more bots. Change-Id: I4ef9508f47386dfb61a0fefeba4640657aa1b725 Reviewed-on: https://chromium-review.googlesource.com/994873Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550298}
-
Shenghua Zhang authored
Manage Android SDK binary deps via CIPD logic. Move CIPD dependencies in DEPS. Adding cipd_*.yaml files for SDK packages, which are used to create and upload the CIPD packages to service url. Changing config.gni to point the android sdk root to //third_party/android_sdk/public. Split package /sources out to third_party/android_sdk/sources due to different gclient condition. Modify update_sdk.py to 1) Support changing pkg version in DEPS 2) Change --sdk-root default path for sources 3) Fix bugs Bug: 659808 Change-Id: Ia9bafae24a15d8b1c917cf8c0953eb74b8daa0db Reviewed-on: https://chromium-review.googlesource.com/807594Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550297}
-
Adam Parker authored
Local Media Casting will be shipping in 66 so it can be turned on by default in 67. Bug: 721802 Change-Id: Ia8db6abad8a022054e54e9999f798fff9fb0b70b Reviewed-on: https://chromium-review.googlesource.com/1010413 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550296}
-
Maria Khomenko authored
CFIBacktraceAndroidTest.TestFindCFIRow is flaky on Android. TBR=torne@chromium.org Bug: 829555 Change-Id: I7cab963e1cde280cbd47ad51bc7d569055d9dfc9 Reviewed-on: https://chromium-review.googlesource.com/1010825Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550295}
-