- 11 Apr, 2018 40 commits
-
-
Jonathan Backer authored
Copy a few more lines from GLES2DecoderImpl. Tested by hand on Linux desktop build with video, webgl, and canvas 2d. Bug: 829438 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1d1edab35a7f418a2392a3dc1fa42aef4739d1c1 Reviewed-on: https://chromium-review.googlesource.com/1005786Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549914}
-
Antonio Gomes authored
SpellcheckHunspellDictionary callers are changed to pass a content::BrowserContext instance instead of a net::URLRequestContextGetter. This new parameter is used to create a network::mojom::URLLoaderFactory instance. Note that previously the URLRequestContextGetter param was used to configure the net::URLFetcher instance. These are not used by SpellcheckHunspellDictionary anymore. CL also updates SpellcheckCustomDictionaryTest::thread_bundle_ to initialize with IO_MAINLOOP, so that it accommodates network requests being made on UI thread. Last, it sets up an EmbeddedTestServer instance with default handlers, and add a static method to SpellcheckHunspellDictionary to set the URL it uses as global. ::SyncBeforeLoadDoesNotDuplicateWords then sets the URL to embedded_test_server->GetURL("/hang"); to make it requests a hanging URL. TEST=covered by existing tests. BUG=773295 Manual test= - chromeos/linux build - load chrome://settings/languages/ - in 'language' box, add a new language (eg portuguese) - in 'spell check' box, enable spellchecking for the newly added language. - insert any text content that trigger spelling markers, right click w/ mouse to see the spell corrections. Change-Id: I62e646634ab0eff208a80f7f1582326dbd4eb5db Reviewed-on: https://chromium-review.googlesource.com/1000053Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#549913}
-
Rohit Rao authored
When the UIRefresh TabGrid is enabled, then this utility method takes a separate codepath that wasn't accounting for the existence of the BVCContainerViewController. This CL fixes that so that the BVC is properly returned instead of its container. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I969ffc62138a189a395d46279dba722670c7ce64 Reviewed-on: https://chromium-review.googlesource.com/1007159Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549912}
-
Christopher Grant authored
Now that frame lifecycle issues have been worked out, we can initialize each element to dirty state when a frame starts, and rely on this state being properly updated. Use this opportunity to set each element's timestamp earlier in the cycle, and update the testapp dump to respect the validity of the information it's dumping. BUG=831191 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b60cc49a09ea89d3e34867445beae6d6d46e76c Reviewed-on: https://chromium-review.googlesource.com/1007322Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549911}
-
Ryan Sleevi authored
net::SSLConfig exposes a policy for configuring whether or not to accept SHA-1 certificates issued by locally-trusted (as opposed to publicly trusted) trust anchors. The default for this policy was to accept these certificates, while anything creating an SSLConfigServiceManager under //components/ssl_config would have these disabled by default, unless overridden by preferences. Change the default to be secure-by-default, as embedders can supply an SSLConfigService that best reflects their desired behaviours (if they do not wish the defaults) as part of the URLRequestContext(Builder,Getter). BUG=831240 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0bcb3474458ca4e0f3e0a554054eec3046a103bb Reviewed-on: https://chromium-review.googlesource.com/1005416Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549910}
-
Rohit Rao authored
This test attempts to tap a "Cancel" button in a mock signin promo view. When the UIRefresh flag is enabled, there are multiple "Cancel" buttons present in the view hierarchy. This CL fixes the issue by adding grey_sufficientlyVisible(). BUG=818742 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id59c25b24b46e83552bafbfa22e6bc96676008c5 Reviewed-on: https://chromium-review.googlesource.com/1007254Reviewed-by:
-
Nate Fischer authored
No change to logic. This simply renames a feature name to be more explicit about what it stands for. WEB_RESOURCE_ERROR -> RECEIVE_WEB_RESOURCE_ERROR Bug: 781764 Test: N/A Change-Id: I1bda04b8fb8d80d9ac28e633b9d94b6428b6801d Reviewed-on: https://chromium-review.googlesource.com/1006178Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Reviewed-by:
-
Michael Thiessen authored
The fallback Android UI path incurs a significant overhead cost to our rendering pipeline when it's active, which used to be 100% of the time. This CL uses a dummy canvas that extends the Android canvas and throws an exception every time something is drawn to it to know whether or not drawing the view tree was a no-op. If not a no-op, it actually draws the view tree into our texture-backed canvas. If the canvas is empty, then we can skip compositing it in our VR rendering pipeline. Bug: 830930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic1c93eeae67485e4d4f450598d6b9690d60d99ba Reviewed-on: https://chromium-review.googlesource.com/999802 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#549907}
-
Alexander Timin authored
Sample 0.01% of the tasks and record task metadata in the ukm. R=haraken@chromium.org,rkaplow@chromium.org Change-Id: I83d5d354726422d13f09fa0ab4fa80b2e3f61478 Reviewed-on: https://chromium-review.googlesource.com/1002178Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549906}
-
Tommy Steimel authored
This CL adds some CSS from the legacy controls into the modern media controls so that the overlay cast button is able to show up. Bug: 831363 Change-Id: I234079b2b789aad4bdc8c27fb0c124810cd18c17 Reviewed-on: https://chromium-review.googlesource.com/1006070 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549905}
-
Gauthier Ambard authored
This CL adds the accessibility trait button to the popup menu cells. It also adds the accessibility trait NotEnabled when the entry is disabled. Bug: 831290 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b7e91c9a7328dbc94a9c1dfff5621ba92b16164 Reviewed-on: https://chromium-review.googlesource.com/1007275 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549904}
-
Eugene But authored
Old dialog had confusing language: "Cancel Download?" "Cancel" | "OK" New dialog has the following language: Stop download?" "Continue | Stop" Bug: 825040 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I293b2897a222291695d2064d796f4b590fa9e90c Reviewed-on: https://chromium-review.googlesource.com/1003312 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#549903}
-
Matt Menke authored
In particular, StoragePartitionImpl::GetNetworkContext() is apparently being called when its url_request_context_ is nullptr. Add a CHECK when this happens, so we crash with a more useful stack trace. Bug: 827928 Change-Id: If206348901fa8c068639d20f532cce7ca7dc7808 Reviewed-on: https://chromium-review.googlesource.com/1005285Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#549902}
-
stkhapugin@chromium.org authored
Removes the dead code that used to handle the standard clear button press in the omnibox before the clear button was replaced with a custom one. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69ee8fc54484c0331d9450edeba37fdce2ac7262 Reviewed-on: https://chromium-review.googlesource.com/1007056 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Gustav Sennton authored
When passing a ServiceWorkerWebSettings object across the support library boundary - reference that object as an Object rather than as a ServiceWorkerWebSettings. The objective of the WebkitToCompatConverter is to convert webkit objects into support library objects. But webkit objects introduced post-L cannot be passed across the support library boundary since whenever we create a Proxy for the interface (WebkitToCompatConverterBoundaryInterface) passing the webkit object, that Proxy needs access to the post-L webkit class (along with all other classes referenced by the interface), which means we'll crash on phones without a definition of the webkit class. Bug: 831554 Change-Id: I12d731994a8d38dda0f69c92917c817ec753cfa4 Reviewed-on: https://chromium-review.googlesource.com/1006960Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the "RequestDesktopSite" and "RequestMobileSite" are enabled when the user agent is correct. It also makes sure that the "Site Information" action is only enabled when the page is a web page. Bug: 824210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I499979423cc58d2f5f4153a13a39e878bc312edc Reviewed-on: https://chromium-review.googlesource.com/999599 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549899}
-
Michael Thiessen authored
VR is disabled on standalone devices, but the intent handling and 2D-in-VR support paths don't account for this and erroneously turn on VR mode, or try to launch Chrome in VR, leaving the user stuck on a black screen. This CL ensures that we never set VR mode on standalone devices, and forward VR intents back to the 2D launcher on these devices. Change-Id: I3f8d41f66549f4c24e3056253299c10486f468df Reviewed-on: https://chromium-review.googlesource.com/1003112 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Rob Dodson authored
Previously the Lighthouse audit wasn't waiting long enough before trying to linkify the node paths, creating a race condition. The fix is to wait a bit longer, for the load event, instead of main frame navigated. Change-Id: I8c57e894bfa76ed50fa4c41bbaf2b3c49b0db211 Reviewed-on: https://chromium-review.googlesource.com/1006116Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Rob Dodson <robdodson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549897}
-
Esmael El-Moslimany authored
Bug: 495875 Change-Id: I2f4ac42ea9e497c0865ba817c429b094e08b15c0 Reviewed-on: https://chromium-review.googlesource.com/1005839Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#549896}
-
Ryan Daum authored
https://chromium-review.googlesource.com/976333 was accidentally reverted by my other changes in https://chromium-review.googlesource.com/978653 Bug: b/75978731 Test: manual test Change-Id: I506c83d1d9f44434d41b70536e7d39ef1100eede Reviewed-on: https://chromium-review.googlesource.com/1007097Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#549895}
-
Peter Wen authored
Split up the .dex section into finer grain sections. Also fix bytes that were uncategorized for in overhead due to --defined-only being passed to apkanalyzer. Now it is easy to see how many methods a specific directory contributes to the overall dex method limit. Bug: 827193 Change-Id: Id540955b8e5c3282f356b5c9fbc4dcc54a84374f Reviewed-on: https://chromium-review.googlesource.com/998825 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#549894}
-
Scott Violet authored
And wires it up for an example app (ash_shell_with_content). BUG=none TEST=hopefully covered by existing tests Change-Id: I66893ebcbf53681a5fcd5e13c4d9cc87fd517cda Reviewed-on: https://chromium-review.googlesource.com/1005567 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549893}
-
Tibor Goldschwendt authored
First CL in a row of refactors to separate view code into PageInfoView. Change-Id: I61101d9d0c13ae085edc8f00a5cb28ddfcb5620d Reviewed-on: https://chromium-review.googlesource.com/1005733 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549892}
-
Bernhard Bauer authored
Bug: 814365 Change-Id: I34a05ddbf20c74efeffc2c1081cbc79ed60b49db Reviewed-on: https://chromium-review.googlesource.com/1005034Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549891}
-
Katie D authored
In https://chromium-review.googlesource.com/c/chromium/src/+/794511/6/ui/accessibility/ax_tree.cc#275, I renamed |clipped| to |intersection| (and introduced a new |clipped| var with a slightly different meaning). I missed renaming the comment about |clipped|, so doing that in this change. NOTRY=true Change-Id: I5ed9bce774da738950f1199ce9138f51c25beaee Reviewed-on: https://chromium-review.googlesource.com/1005907Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549890}
-
Bence Béky authored
Do not call deprecated QuitCurrentWhenIdleDeprecated() in net/http/http_stream_factory_impl_unittest.cc. The relation to https://crbug.com/829429 is that because of presubmit rules, this is blocking the rename of net/http/http_stream_factory_impl_unittest.cc at https://crrev.com/c/1000487. Bug: 829429 Change-Id: Id05bca35788d013794c177e606334bad3e37290f Reviewed-on: https://chromium-review.googlesource.com/1005110 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549889}
-
vitaliii authored
This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/986514. After that CL, UserEventSyncBridge does not delete user consent events when sync is disabled, instead they are persisted in the store. In this CL, these user consent event are resubmitted to sync when sync is reenabled (based on OnSyncStarting call). This is done to avoid losing consents, especially in DICE where sync may be disabled frequently. On the other hand, it is allowed to record the same consent multiple times and this is heavily utilized in this CL. One could potentially come up with something simpler, however, later we will have to avoid syncing events emitted from a different account. Due to this requirement, the approach in this CL could not be simplified further. Bug: 781765 Change-Id: Ia1278d716b0ace05084f1de56f0647e149fd0e5e Reviewed-on: https://chromium-review.googlesource.com/1004896 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549888}
-
Joshua Pawlicki authored
Bug: 831284 Change-Id: I84d27cfb61725524d1ec9b12ffaa1bda221529ff Reviewed-on: https://chromium-review.googlesource.com/1005797Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#549887}
-
Michael Thiessen authored
This reverts commit f2ccbfd1. Reason for revert: Speculative revert for crbug.com/831589 Original change's description: > VR: Clean up WebVR headset insertion. > > This CL makes it explicitly clear when we care about whether the page > was listening for activate before pause, and when we should autopresent > on entering VR (for headset insertion). > > This also removes the workaround in vr_display_impl that allowed pages > without focus to handle displayActivate, favoring handling this case > more correctly in VrShellDelegate. > > Bug: 829513 > Change-Id: Ie19c55305d0c59ec3f576010ded0f61ae906a084 > Reviewed-on: https://chromium-review.googlesource.com/1004927 > Reviewed-by: Yash Malik <ymalik@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549736} TBR=mthiesse@chromium.org,ymalik@chromium.org Change-Id: I92a56254e933381770a56495553facfbcb2e5c59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829513 Reviewed-on: https://chromium-review.googlesource.com/1007374Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#549886}
-
chaopeng authored
In this CL, we save the kPrecisionTouchpadScrollPhase state in HWNDMessageHandler to avoid query the state of kPrecisionTouchpadScrollPhase on each direct manipulation events. Bug: 779372 Change-Id: Ie97f4cbe180a5f01c7b513263ecb310d7df4b66f Reviewed-on: https://chromium-review.googlesource.com/1005500Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549885}
-
kylechar authored
It looks like int8_t was getting converted to int before being printed as unsigned so negative values were much larger than necessary. Convert the values uint_8 before printing them. Also print in hex so each byte is two characters. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib115475b585ef726e4276a22388dd3b7e5b08a11 Reviewed-on: https://chromium-review.googlesource.com/1005881Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549884}
-
Brian Salomon authored
Use direct maxTextureSize() getter instead. This will allow removal of GrCaps from Skia's public API. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I11e8aa4d6327b72b9882744584d0efae3d9145c5 Reviewed-on: https://chromium-review.googlesource.com/1001709Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549883}
-
Ethan Kuefner authored
We're ready to try again with enabling some chromium.perf benchmarks to upload histograms to the perf dashboard, so let's try with blink_perf. Bug: 744736 Change-Id: I859b63a27ad0b3aaa825a520a20d00bd7afe1ab4 Reviewed-on: https://chromium-review.googlesource.com/1005674Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#549882}
-
David Reveman authored
These shortcuts are useful to some applications (e.g. emacs). Test: ctrl+space is recognized by weston-eventdemo Change-Id: I707d191d5ad7a9e9aa1b96125ace3e8225e478f3 Reviewed-on: https://chromium-review.googlesource.com/1001727 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#549881}
-
Danyao Wang authored
CRWWebController sometimes needs to remove WKWebView (e.g. crbug/770914) and this obliterates the session history when WKBasedNavigationManager is used. This CL adds the ability for WKBasedNavigationManager to temporarily be detached from the web view. Major parts to this CL: 1. NavigationManagerImpl::DetachFromWebView() is a new API that CRWWebController uses to notify the navigation manager before removing the web view. 2. WKBasedNavigationManager implements this API with the help of a new nested class WKWebViewShim. It knows how to cache the items when detaching from a web view and service getter calls in detached mode. 3. Added overrides for FinishReload(), FinishLoadURLWithParams() and LoadIfNecessary() in WKBasedNavigationManager so it can switch back to attached mode when a new navigation starts by restoring the cached navigation items. Also cleaned up unneeded APIs from CRWWebViewNavigationProxy. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b1796731964f021df8c0489d3a6ef56ae390e04 Bug: 815248 Reviewed-on: https://chromium-review.googlesource.com/999054 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549880}
-
stkhapugin@chromium.org authored
Replaces custom clear button with the system one. Bug: 821803 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I870db4da6529ebcca757c5728a4e73658d14e15a Reviewed-on: https://chromium-review.googlesource.com/964422Reviewed-by:
-
Martin Sramek authored
Static variables should use const char[] rather than std::string. This change also uncovered the fact that some of them are actually not used, as most of the tests simply use those strings directly. Bug: None Change-Id: I9b520c08feb5552af453455e42f3db5b0ef5ba75 Reviewed-on: https://chromium-review.googlesource.com/1004957Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#549878}
-
Ian Vollick authored
These previously thought they were clean when they weren't causing stale positions to be applied after repositioning. Bug: 831410,831402 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7b5e1a8023f2231ff68452a43bbb372426b9f2f Reviewed-on: https://chromium-review.googlesource.com/1006355Reviewed-by:
-
Charlie Harrison authored
This CL should not change behavior. Bug: 829992 Change-Id: I29ab5dd2702b32e160b04bd341183d36fefe1bc9 Reviewed-on: https://chromium-review.googlesource.com/999995 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549876}
-
Rohit Rao authored
This allows tests to disambiguate between the Settings button and other navigation bar buttons that happen to also say "Done". This is necessary now because the TabGrid also has a "Done" button, and some tests are confusing that for the Settings "Done" button. BUG=818742 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0db7221f18975277e46fb15ecd781d2b65370ea6 Reviewed-on: https://chromium-review.googlesource.com/1005858 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
