GitLab

This upstreams service worker tests:
chromium/extendable-message-event.html
chromium/unregister-on-detached-iframe.html

These tests are useful as a WPT as it tests web-exposed behavior.

Expand the tests and upstream them as detached-context.https.html.

Bug: 688116, 603817, 543198
Change-Id: I2b9798e19a1b1ec76d9a4472f412acb324a50e0c
Reviewed-on: https://chromium-review.googlesource.com/759136Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515070}

Bug: None
TBR: sky@chromium.org
Change-Id: I155d1cb27ad13253702d152517aa9718ae48bacb
Reviewed-on: https://chromium-review.googlesource.com/752964Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515069}

Also refactor fuchsia_executable_runner to accept data_deps values
from the invoker.


Bug: 
Change-Id: I039548d80b98538692df8b04b4410b09474ad4d8
Reviewed-on: https://chromium-review.googlesource.com/758968Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515068}

Developers using devtools to simulate add to home screen currently receive
no feedback if the site they are testing on suppresses the app banner.
This can make it seem like the devtools functionality is flaky. This CL adds
console logging for this situation, to help developers understand why the
install banner has been suppressed.

Bug: 739344
Change-Id: Iaebbee3a6b7e01b0956112d9bdcf42043b179128
Reviewed-on: https://chromium-review.googlesource.com/743141
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515067}

In the launcher, suggested apps and search results share a class,
SearchResultTileItemView.

The code path for launching a suggested app and a SearchResult is the
same,and we were recording SuggestedApp clicks as SearchResult clicks.

This CL modifies the code path to consider if the
SearchResultTileItemView is a suggested app before recording metrics.

I also included a UMA test in AppsGridViewTest.

Bug: 779654
Change-Id: Ia059879c097b5845021bb9ed4050da51e70ac007
Reviewed-on: https://chromium-review.googlesource.com/751961
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515066}

When using ProfileIOData::SetCertVerifierForTesting, the test verifier is wrapped in a per-profile object that queries the shared verifier. The lifetime requirements are unchanged (the test cert verifier must outlive any profiles using it).

Bug: 780611
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9be3d8e7591cf55a03d08382a82ef2f8124152a2
Reviewed-on: https://chromium-review.googlesource.com/756016
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515065}

Bug: 693114
Change-Id: I8b3c0ef0342009794a97c0c9afdcdb417710aee4
Reviewed-on: https://chromium-review.googlesource.com/752075
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515064}

Bug: 
Change-Id: I9a0372f0eb4f57d73b8ec24ba0255b39e6b3dbf2
Reviewed-on: https://chromium-review.googlesource.com/729212Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515063}

Previously, we would use a CoreFoundation-based version of these
functions implemented in time_mac.cc because time_t on Mac was
capped at year 2038. However, with 64-bit that is no longer the
case and we can just use time_exploded_posix.cc.

From UMA sampling profiler data (see bug), we know that the
CoreFoundation versions of these functions are slow and currently
account for around 80ms cost during startup. After this change
is submitted and makes it to Canary, we can see how the POSIX
versions of these functions perform - hopefully much faster than
the CoreFoundation ones.

Some code in net/ had assumptions around the min and max years
that are supported on different platforms by these functions. To
make that logic a bit cleaner, this CL introduces two constants
in time.h specifying the platform-specific limits - so that
downstream code like net can use them instead of baking their
own assumptions. Some net error codes are changing as a result
of this clean up - which can be seen in the updated net tests.

BUG=781601

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2cf030fd4d3ed8da87e41bc8ba3dc3b1b99e8f6d
Reviewed-on: https://chromium-review.googlesource.com/754079
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515062}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug: 782780
Change-Id: I419786e99fa6f794d5c84041f131254588328d9f
Reviewed-on: https://chromium-review.googlesource.com/758721
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515061}

This patch enables us to be able to use linux fonts in oop raster mode, with
the exception of webfonts. The changes are summarized below:

- Introduce PaintTypeface, a Paint equivalent of SkTypeface
- Introduce PaintTextBlob, a Paint equivalent of SkTextBlob
- Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder
- Introduce PaintFont, a Paint equivalent of some of the SkPaint flags
  that deal with fonts.
- Serialize and deserialize drawTextBlobOp
- Update platform/fonts to use PaintTypeface in places that end up being painted
  - Update FontPlatformData to use PaintTypefaces

The difference from the initial patch is that we initialize allocated run
buffers in the unittests.

TBR=enne@chromium.org

Bug: 777631
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6a019a993c72938c47ecb3be27bb9a79f5fdc9dc
Reviewed-on: https://chromium-review.googlesource.com/756213Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515060}

Files from third_party/WebKit/Source/core that included Vector.h but
weren't using Vector<>.

This is the last batch for Vector.h.

Also added the include Vector.h to WebDevToolsAgentImpl.cpp and
ObjectPainter.cpp because they use Vector but weren't including.

Bug: 398455
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I43af2eb8231d35c65ec64883acc80d9aff2e18af
Reviewed-on: https://chromium-review.googlesource.com/756173
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515059}

This reverts commit df214af3.

Reason for revert: Failing on chromium.chromiumos waterfall: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/46590

Original change's description:
> Content_Browsertest with --enable-viz
> 
> This will enable content_browsertests --enable-viz on the
> chromium_chromeos_rel_ng bot.
> 
> The filter file is a list of tests which fail, as they traditionally rely on
> information that is now in a different process. We'll bring more online as we
> create the appropriate test apis.
> 
> TBR=sky@chromium.org
> TEST=viz_content_browsertests
> 
> Bug: 760181
> Change-Id: I4e015d93aec3526c0f0fe2aa0cccafff998fc5a7
> Reviewed-on: https://chromium-review.googlesource.com/758603
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514969}

TBR=sky@chromium.org,jonross@chromium.org

Change-Id: Iffeb787272a63c3fb447e2f149c01274e7c6675d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760181
Reviewed-on: https://chromium-review.googlesource.com/759656Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515058}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/browser/sessions

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 781352
Change-Id: Ie28ff95630b68ff5dc11c920f652fd721920af63
Reviewed-on: https://chromium-review.googlesource.com/758929
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515057}

When traversing the |deferred_page_unloads_| list and handling the
unloads it's possible for new pages to get added to the list which will
invalidate the iterator.

This CL swaps the list with an empty list and does the iteration on the
list copy. New items that are unloaded while handling the defers will be
unloaded at a later point.

Bug: 780450
Change-Id: Ic7ced1c82227109784fb536ce19a4dd51b9119ac
Reviewed-on: https://chromium-review.googlesource.com/758916
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515056}

This lets the code dispatch to LocalFrame or RemoteFrame as
appropriate.

Bug: 608780
Change-Id: I95f4c5298461f907959124169fd01cee06659df9
Reviewed-on: https://chromium-review.googlesource.com/748031
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515055}

This patch adds these histograms:

Compositing.{Browser,Renderer>.CachedImagesCount.{Gpu,Software}

To measure the maximum amount of images that we cache over the lifetime
of the cache. This is meant to guide the maximum number of images we
would keep in software and overall a data point to understand image
usage on the web.

R=ericrk@chromium.org, khushalsagar@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice882e68f8b1d536bd8a4b072c55c0f0a0081a4f
Reviewed-on: https://chromium-review.googlesource.com/758820Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515054}

Previously when we need to simulate clock ticks in tests, we need each
indivisual components like PageCoordinationUnitImpl to carry its own tick
clock, and we have to create helper functions to set the clock properly among
different components. This is fragile and redudant. This patch introduces a
ResourceCoordinatorClock which provides 4 helper methods to manipulate clock in
testing across components.

There's also a recent patch adding timing functions to
chrome/browser/resource_coordinator:
https://chromium-review.googlesource.com/c/chromium/src/+/723674

BUG=775691

Change-Id: I05e5d1fd688aaa35c8d8abcc4707439f00d9c958
Reviewed-on: https://chromium-review.googlesource.com/756211
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515053}

This change moves daydream-specific assets to a vr_daydream_resources.grd,
which is processed on all enable_vr builds, but only included in Chrome on
enable_gvr_services builds.  Test code can still depend on these assets
even if running on desktop.

BUG=743687

Change-Id: Ie2516ae2534858044c00f281eb2f71d0cccd8aef
Reviewed-on: https://chromium-review.googlesource.com/752035
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515052}

NetLog is going to be moved into the network service process.
We should switch to traceevent for logging purpose instead.

BUG=767450

Change-Id: Ic81994a1685057f73716fa7b33a366f94d50dd26
Reviewed-on: https://chromium-review.googlesource.com/750050
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515051}

Bug: 782858
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If4a5bc70f8a9eac788960abfb3e2b4db5eec2438
Reviewed-on: https://chromium-review.googlesource.com/755214Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515050}

This CL is the third CL of implementing OfflinePageModelTaskfied.
It contains:
- GetPages* workflow, with GetOfflineIdByClientId.
- Related tests for GetPages* workflow.

More details: go/offline-page-model-migration

Bug: 753595
Change-Id: Ie95389fdb7ac6bfa61fb1ed663f0aa3583c3d11d
Reviewed-on: https://chromium-review.googlesource.com/752688Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515049}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ba9cf60e..ad1474a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I159eaadcac569a24b382f2f239da50c4df070ae6
Reviewed-on: https://chromium-review.googlesource.com/758919Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515048}

This change sets the 'toolbar ready for captute' flag when a tab is
shown rather than waiting for the URL to be updated. When a tab is
reparented for Chrome Home, the activity restarts and resets the flag.
Since the URL of the tab technically hasn't changed, the onUrlUpdated
even is not called and the URL bitmap is therefore never updated.

BUG=781692

Change-Id: I209f81d4f9bed0e2566d7a42c84294c8af1b863e
Reviewed-on: https://chromium-review.googlesource.com/757816Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515047}

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 781352
Change-Id: I2c2c6cb8f19d5c3163c0a0012df38d67822dbf42
Reviewed-on: https://chromium-review.googlesource.com/758930
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515046}

Fixes bug where detect minified code would expect the string to always
exist on content for UISourceCode. We now check it's nullcase.

R=lushnikov,einbinder
BUG=None

Change-Id: Ie3c28d246017075549b0fca6c262b2f84bc77bff
Reviewed-on: https://chromium-review.googlesource.com/758746Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515045}

This CL adds |chromeos_board| Gaia URL parameter.

Bug: 782641
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib9980437bc95c5ca0287721798cd93f32ef87970
Reviewed-on: https://chromium-review.googlesource.com/758716Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515044}

UseRenderPass() has two use cases, either to set up a render pass
as the framebuffer for drawing at the start of the draw, or to restore
us back to that state after making some intermediate change to which
framebuffer is bound.

UseRenderPass() has some optimizations where it can return false and
not do anything, if it detects that we don't want to draw the render
pass. The first use case, in DrawRenderPass() makes use of this return
value to avoid drawing anything.

Other callers to UseRenderPass() do not check the return value because
we're already drawing the pass and they are trying to restore state. If
it early outs for these it would be unexpected and produce bugs.

Currently DecideRenderPassAllocationsForFrame modifies render passes to
try avoid such bugs, but there are other ways to encounter the bug.

This changes UseRenderPass() to never early out so the latter cases will
not avoid resetting the framebuffer. The former case can avoid
UseRenderPass() entirely by checking CanSkipRenderPass(). If it is true,
then it does not need to be drawn.

Also, we will now ensure that UseRenderPass() is called after using a
ScopedUseGrContext when drawing a RenderPassDrawQuad. Currently on errors
it would early out before restoring the framebuffer, which could cause
bugs for the next quads in the RenderPass. This was introduced when the
UseRenderPass() call was moved out of the ~ScopedUseGrContext()
destructor in https://codereview.chromium.org/2203033005.

This all came up via https://chromium-review.googlesource.com/c/chromium/src/+/757027#message-b6e905925e834419ff448e2093a392053d5d321a

R=enne@chromium.org, wutao@chromium.org

Bug: 782044, 738190, 782042
Change-Id: Ib4662c5fee3f326642add12bbfe3d51e51dff1c9
Reviewed-on: https://chromium-review.googlesource.com/757049
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515043}

This is dead code as cairo is no longer used.

No functional change.

Change-Id: I7d7f207d604de8c8f9bbf1098b7ecb1f91fa5685
Reviewed-on: https://chromium-review.googlesource.com/755656Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515042}

If exclude list parameter is provided during the registration process,
then all the devices are checked for duplicate registration by calling
'check-only' sign to device. If any one of the device response with
success, this means that there is duplicate registration and process is
terminated after waiting for user presence verification and response
code U2fReturnCode::CONDITIONS_NOT_SATISFIED is returned to the caller.
If all devices pass the duplication registration check, then we proceed
to normal registration process.

Bug: 664630
Change-Id: Iaa70490084c7086185e721b5e22d30f73ee9b66d
Reviewed-on: https://chromium-review.googlesource.com/739927
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515041}

Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
https://github.com/w3c/web-platform-tests/pull/7915
https://github.com/w3c/web-platform-tests/pull/7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug: 734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
Reviewed-on: https://chromium-review.googlesource.com/731225Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515040}

Plumb serialization/restore logic for the scroll anchor selector, offset, and
simhash.
Add declarations of SerializeAnchor, RestoreAnchor, and SerializedAnchor
struct.
Add dummy implementations of serialize/restore.
Add a runtime flag.

BUG=734679
R=skobes@chromium.org,creis@chromium.org

Change-Id: I68171d0ed3a63e44e4afc6ec8766170beb4508e0
Reviewed-on: https://chromium-review.googlesource.com/611058
Commit-Queue: Patrick Noland <pnoland@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515039}

Bug: 746953
Change-Id: I4de7e03f07fa19b0d7c136f2ca6021c8dd8cdd3d

TBR=dpranke@chromium.org

Change-Id: I4de7e03f07fa19b0d7c136f2ca6021c8dd8cdd3d
Reviewed-on: https://chromium-review.googlesource.com/755717
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515038}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ppapi/proxy

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=piman@chromium.org

Bug: 781352
Change-Id: I3900a4cb18da2d78bf6815a582bc69460fe18423
Reviewed-on: https://chromium-review.googlesource.com/758659
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515037}

Originally reviewed on https://chromium-review.googlesource.com/740621

This is relanding plus fixing the racing documented in crbug.com/781349

BUG=744658,781349
TEST=bots
R=danakj@chromium.org,piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If050057299a17ab76ee247c5c790a4e159ffef9d
Reviewed-on: https://chromium-review.googlesource.com/755520
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515036}

Currently there is logic which ensures the geolocation permission is
displayed in Site Details for the default search engine when the
location link is clicked from Settings>Search Engines. Since we've
enabled location consistency, this logic isn't needed as the location
setting will always be set and displayed appropriately.

Bug: 780344
Change-Id: Ie04f096194b4ee3ebd6ecb601db2fa8f744cb663
Tbr: finnur@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/758017
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515035}

Bug: 774623
Change-Id: I45cfb7bbc9ce13a29dc084d86f9624f8a8744e49
Reviewed-on: https://chromium-review.googlesource.com/758613Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515034}

We should not be updating the ChildFrameCompositingHelper's primary SurfaceInfo
unless some synchronized property has changed.

Updating the primary SurfaceInfo induces a commit when nothing might've changed.

Furthermore, Blink gets confused a change is triggered on scroll, and hits a
document lifecycle DCHECK. This CL addresses this by avoiding updating the
SurfaceLayer of the OOPIF/BrowserPlugin unless the size or ScreenInfo has
changed.


Bug: 672962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I776990691beb2f58b0178c08da617b4bdb6df468
Reviewed-on: https://chromium-review.googlesource.com/759128
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515033}

When dragging one TabbedPane tab past another, we reorder the elements
in DOM, leading to a frame rendered without the ':hover' style and
flickering.

This CL ensures the hover-style is applied while dragging.

Screenshot: https://imgur.com/a/REtNp

Bug: 772298
Change-Id: Ib8a54cd6c6358d8d569aa94cf8e5c68aa2822037
Reviewed-on: https://chromium-review.googlesource.com/747079
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515032}

r514562 disabled DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter on
windows debug bots since the test was flaky. It seems that the test was timing
out most of the times.

This CL splits out DeclarativeNetRequestBrowserTest.BlockRequests_Separator
from it, to decrease its running time and re-enables the test.

BUG=782326, 696822

Change-Id: I4932cd9be67cad267ffa085a38d0a551cc8702ab
Reviewed-on: https://chromium-review.googlesource.com/757830Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515031}