GitLab

R=esprehn@chromium.org,thestig@chromium.org
BUG=511486

Review URL: https://codereview.chromium.org/1246253002

Cr-Commit-Position: refs/heads/master@{#339814}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/10b371c..c71239b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
c71239b herb@google.com Change the GlyphCache to use a hash table instead of doing its own ad-hoc hashing. This change appears to be performance neutral. BUG=skia:

Review URL: https://codereview.chromium.org/1250793006

Cr-Commit-Position: refs/heads/master@{#339813}

To prevent spurious coded frame processing discontinuity detection for
potentially incorrect streams with coded frames having decode time >
presentation time, this change updates DTS by the same delta as PTS
during partial append window trimming.
This change is option 2 from comment 9 in bug 511128.

BUG=511128
R=dalecurtis@chromium.org
TEST=*/FrameProcessorTest.PartialAppendWindowFilterNoDiscontinuity_DtsAfterPts

Review URL: https://codereview.chromium.org/1240323003

Cr-Commit-Position: refs/heads/master@{#339812}

Flaky on Linux ChromiumOS bots.

TBR=nkostylev@chromium.org
NOTRY=true
BUG=512648

Review URL: https://codereview.chromium.org/1249783003

Cr-Commit-Position: refs/heads/master@{#339811}

BUG=

Review URL: https://codereview.chromium.org/1243233002

Cr-Commit-Position: refs/heads/master@{#339810}

a browser window that are shown on the given |profile|'s desktop to prevent returning
a browser window on other users' desktop.

Also clean up and refactor codes related to TestBrowserWindowAura class. There were
multiple files defining TestBrowserWindowAura that were almost identical. Extracted this class to
test_browser_window.h .cc files and added helper function CreateBrowserWithAuraTestWindowForParams()
to handle its lifetime.

BUG=500027

Review URL: https://codereview.chromium.org/1198313003

Cr-Commit-Position: refs/heads/master@{#339809}

As previously discussed, DownloadResouceThrottle is the best place to handle file access requests.
This CL moves that logic from DownloadTargetDeterminer to DownloadResourceThrottle.
Unit test is also added for DownloadResourceThrottle.

BUG=501606

Review URL: https://codereview.chromium.org/1229933010

Cr-Commit-Position: refs/heads/master@{#339808}

Extension profile extender for profile generator and a new benchmark for
startup time on a profile that loads extensions. Also for this purpose, a
script to maintain a static set of extensions in cloud storage, and small
additions to python gsutil wrapper (cloud_storage).

BUG=444230
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect

Review URL: https://codereview.chromium.org/1240703003

Cr-Commit-Position: refs/heads/master@{#339807}

Adding a flag to enable the use of the newly rewritten implementation of
the task manager.

BUG=471006

Review URL: https://codereview.chromium.org/1248823004

Cr-Commit-Position: refs/heads/master@{#339806}

BUG=505040
TEST=None
TBR=aurimas
NOTRY=true

Review URL: https://codereview.chromium.org/1243273002

Cr-Commit-Position: refs/heads/master@{#339805}

This patch changes how MB will generate the .isolate files
for a GN build:

First, we rename 'ninja_to_gn.pyl' to 'gn_isolate_map.pyl',
and change it from a straight compile_target -> gn_label map to
a map of compile_target -> { "label": gn_label, "type": string,
"args": optional list<string> }.

Valid values for "type" are
"windowed_test_launcher"
: the test is a gtest-based test that uses the
  'brave-new-test-launcher' from //base/test:test_support and
  needs to run under Xvfb if run on an X11-based platform
  (i.e., if use_x11=true in GN).
"console_test_launcher"
: the test is a gtest-based test that uses the
  'brave-new-test-launcher' from //base/test:test_support but does
  not need Xvfb.
"raw"
: the test is just an executable and may take an optional list
  of command-line arguments (specified in the 'args' key),
  but does not need any extra files or other special processing.
"unknown"
: (the default), which indicates that we don't know what the command
  line needs to be (this is a fatal error).

Second, we read the new file in, and build a lookup map of test
types to command lines. We will probably need to keep iterating
on the list of test types and command lines, and perhaps provide
some escape hatches so that we can handle the full variety of tests.

TBR=maruel@chromium.org
BUG=503942, 504079

Review URL: https://codereview.chromium.org/1239343003

Cr-Commit-Position: refs/heads/master@{#339804}

Using ClipDrawable progress bar helps future changes for
http://crbug.com/461148 as we only need pass to color parameters.

Also it has minor performance benefit.

Note: second landing attempt as the previous one made Chrome shell tests
      flaky. https://codereview.chromium.org/1170843002/

TBR=tedchoc@chromium.org
BUG=466140, 455891, 461148

Review URL: https://codereview.chromium.org/1245333002

Cr-Commit-Position: refs/heads/master@{#339803}

Revert of gpu: Use shader cache on ES3 (patchset #2 id:20001 of https://codereview.chromium.org/1223393003/)

Reason for revert:
This codepath is actually flaky.

OnLoadedShader() races with dynamic GL binding initialization. Previously it meant that we just might not end up loading this shader (as long as b_GL_OES_get_program_binary etc. default to false), but the GetGLVersionInfo() might actually crash.

Original issue's description:
> gpu: Use shader cache on ES3
>
> The ES3 core specs supports gl(Get)ProgramBinary().
> BUG=510172
>
> Committed: https://crrev.com/809d9b979c0edd3976132eaaf77fc4740fcee019
> Cr-Commit-Position: refs/heads/master@{#339369}

TBR=dyen@chromium.org,zmo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510172,512464

Review URL: https://codereview.chromium.org/1247233002

Cr-Commit-Position: refs/heads/master@{#339802}

When a session is suspended by the UI from the media notifications, it
does not release the audio focus and might receive focus loss/gain
messages from the system. It shouldn't try to resume the session when
the focus is gained back in such case.

BUG=511921

Review URL: https://codereview.chromium.org/1243683003

Cr-Commit-Position: refs/heads/master@{#339801}

In L apps are able to extend itself under the navigation bar. Yet this
feature is not needed in enhanced bookmarks, and it caused a UI bug with
snackbar.

BUG=508873

Review URL: https://codereview.chromium.org/1250853005

Cr-Commit-Position: refs/heads/master@{#339800}

Introduce a queue in TabDelegate for creating multiple Tabs in a row.
This prevents triggering some issue in Android's ActivityManager that
causes it to throw away the tasks for Activities after it launches them,
which in turn causes Android to destroy our Activities.

BUG=498920

Review URL: https://codereview.chromium.org/1229853006

Cr-Commit-Position: refs/heads/master@{#339799}

Hooks up the allocator shim on Windows. The GN build uses the Windows heap like GYP does.

This makes tcmalloc actually compile on Windows if you manually request it, although it doesn't actually seem to work correctly. I added an assert noting this if you try to set the flag on Windows. Note that this is never run by default on GYP and we may never want it.

This sets the ALLOCATOR_SHIM for the one media file that uses it.

Review URL: https://codereview.chromium.org/1246083005

Cr-Commit-Position: refs/heads/master@{#339798}

direct_dependent_configs is the deprecated name for public_configs,
and public_configs is already handled.

gn-dev thread:
https://groups.google.com/a/chromium.org/d/topic/gn-dev/h9N85MIx_Bk/discussion

BUG=None
TEST=gn gen out-gn/Debug
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1246183002

Cr-Commit-Position: refs/heads/master@{#339797}

BUG=None
R=bengr@chromium.org

Review URL: https://codereview.chromium.org/1244923002

Cr-Commit-Position: refs/heads/master@{#339796}

Previously, this member was assigned ad-hoc during initialization of a
RenderWidget. Since there are different initialization paths for
different kinds of RenderWidgets, this led to some strange-looking code:
for example, the initialization of a frame widget would double-assign
CompositorDependencies.

BUG=none
TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1245863003

Cr-Commit-Position: refs/heads/master@{#339795}

closing the connection instead when a packet cannot be serialized.

This could help fixing Chromium BUG=479880. Will land after
https://codereview.chromium.org/1247563002/ is committed.

Merge internal change: 98506577
R=rch@chromium.org
BUG=479880,512446

Review URL: https://codereview.chromium.org/1246093003

Cr-Commit-Position: refs/heads/master@{#339794}

The browser compositor contents and renderer contents are each put into separate
layers which are aggregated together by a Display.

BUG=449319

Review URL: https://codereview.chromium.org/1147193005

Cr-Commit-Position: refs/heads/master@{#339793}

On iOS, |root.children| was undefined for IDR_NET_ERROR_HTML webui,
which prevented the further conversion of i18n nodes.

BUG=512085

Review URL: https://codereview.chromium.org/1246633007

Cr-Commit-Position: refs/heads/master@{#339792}

Follow-on CL from https://codereview.chromium.org/1226643002

BUG=511859
TEST=browser_tests --gtest_filter=SupervisedUserBrowserCreatorTest.StartupSupervisedUserProfile

Review URL: https://codereview.chromium.org/1247063007

Cr-Commit-Position: refs/heads/master@{#339791}

Also add BaseDevice, BatteryDevice, GlucoseDevice and HeartRateDevice

Three sided patch because we need to change the reference to MultiDeviceAdapter in blink:

 [1] This patch.
 [2] http://crrev.com/1232123010
 [3] http://crrev.com/1244603002

Design doc: https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit#

BUG=499552

Review URL: https://codereview.chromium.org/1230023010

Cr-Commit-Position: refs/heads/master@{#339790}

BUG=505040

Review URL: https://codereview.chromium.org/1247163002

Cr-Commit-Position: refs/heads/master@{#339789}

BUG=

Review URL: https://codereview.chromium.org/1244783006

Cr-Commit-Position: refs/heads/master@{#339788}

RTCVideoDecoder allocates SHM buffers up to kMaxNumSharedMemorySegments,
using the currently requested size. However, if, after allocating
kMaxNumSharedMemorySegments, an input buffer arrives with a size larger
than the previously allocated, we will never allocate any more buffers
to fit the new size, and will not decode anymore, waiting forever for
new SHM buffers

Separately, we allow 300 input buffers to be pended and expect to be able
to catch up later on. However, if we are already 300 buffers behind, it is
very unlikely that we ever would. Moreover, it's better for user
experience to just catch up as fast as possible, dropping pending buffers.

This modifies SHM buffer allocation to always allocate a fixed number of
buffers, based on the currently requested size. If larger buffers are
needed later on, we wait for all SHM buffers to be returned and reallocate
with the new size.

Also, allow only 8 pending buffers. This, together with 16 decode buffers,
should be a deep enough pipeline.

BUG=496349
TEST=apprtc, large Hangouts

Review URL: https://codereview.chromium.org/1236663003

Cr-Commit-Position: refs/heads/master@{#339787}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/db0b1e7..10b371c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
10b371c hendrikw@chromium.org ANGLE deps roll
b7069e9 bungeman@google.com Compile with VS2015.
7a787b4 ericrk@chromium.org Revert of Bilinear optimization for 1D convolution. (patchset #5 id:200001 of https://codereview.chromium.org/1216623003/)
cd94d73 hendrikw@chromium.org Revert of skia: ANGLE deps roll (patchset #1 id:1 of https://codereview.chromium.org/1244843003/)

Review URL: https://codereview.chromium.org/1248683003

Cr-Commit-Position: refs/heads/master@{#339786}

WebLayerTreeViewImpl needs to destroy LayerTreeHost early on as
otherwise it's possible for the compositor thread to be accessing
WebLayerTreeViewImpl while WebLayerTreeViewImpl is part way through
the destructor and in a bad state.

BUG=none
TEST=none
R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/1247803006

Cr-Commit-Position: refs/heads/master@{#339785}

All libraries and example now build with the ARM glibc
toolchain.  No tests are run yet.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=505885

Review URL: https://codereview.chromium.org/1243823002

Cr-Commit-Position: refs/heads/master@{#339784}

When the quota database is asked for the least recently used origin for
eviction it should not return any origins that have been granted the
durable storage permission.

Note that there is no easy way for a user to set this permission yet.
That is coming in https://codereview.chromium.org/1164073005/ and
https://codereview.chromium.org/1154573005/

BUG=482814

Review URL: https://codereview.chromium.org/1229933007

Cr-Commit-Position: refs/heads/master@{#339783}

Before this patch, there is no way to know result of purging stale resources.

BUG=n/a

Review URL: https://codereview.chromium.org/1232923003

Cr-Commit-Position: refs/heads/master@{#339782}

In a previous CL top level group markers were converted to using
chromium traces:

https://codereview.chromium.org/780653007/

The initial thought was that we would standardize on a single trace
type. This is a transitional step which moves the debug marker
manager to be set in the chromium traces, and also makes the group
marker calls mimic the chromium trace calls. Eventually the group
marker calls should be deprecated.

R=sievers@chromium.org, vmiura@chromium.org
BUG=242999, 503166
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1132283003

Cr-Commit-Position: refs/heads/master@{#339781}

ServiceFactory is an interface used to create media services. Services created
in one factory instance are isolated from services created in another factory
instance. This is used in Chromium to isolate media services for different
RenderFrames.

BUG=510653
TEST=Plays the same EME test page in 2 tabs.

Review URL: https://codereview.chromium.org/1230313010

Cr-Commit-Position: refs/heads/master@{#339780}

BUG=512105
TEST=Manually tested by checking about://tracing and about://histograms.

Review URL: https://codereview.chromium.org/1241263002

Cr-Commit-Position: refs/heads/master@{#339779}

Previously GN's runtime deps computation would only count a target once, but
this ignores the fact that whether a target is a data dependency or a regular
one affects how it's added.

This patch revisits a target if it's depended on in a data dependency
even if it's already been seen as a regular dependency.

Enhance the runtime deps documentation.

Review URL: https://codereview.chromium.org/1250883002

Cr-Commit-Position: refs/heads/master@{#339778}

Revert of Call EnsureWebKitInitialized() before registering extensions (patchset #3 id:40001 of https://codereview.chromium.org/1182083006/)

Reason for revert:
This seems the cause of many crashes

Original issue's description:
> Call EnsureWebKitInitialized() before registering extensions
>
> Blink needs to be initialized before registering an extension because:
> - WebScriptController::registerExtension() allocates an WTF::Vector on the first
>   call.
> - WTF::Vector uses PartitionAlloc.
> - PartitionAlloc's partitions needs to be initialized before allocating memory.
>   Blink initialization does the job.
>
> Before this CL, partitions are initialized lazily but lazy initialization
> doesn't provide proper histogram function, which might be the cause of missing
> report for PartitionAlloc.CommittedSize UMA.
>
> BUG=501171
>
> Committed: https://crrev.com/0d244fa5e106b3d146655a2c623539a3e1900831
> Cr-Commit-Position: refs/heads/master@{#339200}

TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501171

Review URL: https://codereview.chromium.org/1244243003

Cr-Commit-Position: refs/heads/master@{#339777}

BUG=490430
R=ortuno@chromium.org

Review URL: https://codereview.chromium.org/1241283003

Cr-Commit-Position: refs/heads/master@{#339776}

BUG=45650

Review URL: https://codereview.chromium.org/1224283006

Cr-Commit-Position: refs/heads/master@{#339775}