GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=169505

BUG=352050
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/196343029

git-svn-id: svn://svn.chromium.org/blink/trunk@169522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL also fixes the -expected file with the correct expectations (PASS),
though this test rarely passes.

As noted in the bug, the test has been confirmed correct, and we need to fix
our behavior. At that time, we can remove the TestExpectations entry.

BUG=306249

Review URL: https://codereview.chromium.org/204003004

git-svn-id: svn://svn.chromium.org/blink/trunk@169521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/204183002

git-svn-id: svn://svn.chromium.org/blink/trunk@169519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

messageHandlerInMainThread can be invoked while we're initializing a window (See stack traces in the bugs). In that half-baked situation, we don't have a valid context nor a valid world, so we should return immediately.

BUG=345014,352179
NOTRY=true

Review URL: https://codereview.chromium.org/203123006

git-svn-id: svn://svn.chromium.org/blink/trunk@169518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

core/ and v8/ only use |impl|, while bindings/ uses half |imp|
and half |impl|.
This regularizes bindings to |impl|.

BUG=345503
R=haraken

Review URL: https://codereview.chromium.org/202203009

git-svn-id: svn://svn.chromium.org/blink/trunk@169517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add the implementation for V8 Promises in ScriptPromise and ScriptPromiseResolver so that:
 - They can handle V8 Promises correctly.
 - ScriptPromise creates a V8 Promise if ScriptPromiseOnV8Promise turns on.

Add ScriptPromiseOnV8Promise runtime enabled flag which is always off.
Add Layout tests for ScriptPromise.

BUG=352552

Review URL: https://codereview.chromium.org/197213007

git-svn-id: svn://svn.chromium.org/blink/trunk@169516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169478

BUG=345027
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/204273002

git-svn-id: svn://svn.chromium.org/blink/trunk@169515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit r169269. This is a speculative fix for the performance
tests timing out on the Win8 bot.

BUG=353275

Review URL: https://codereview.chromium.org/203463008

git-svn-id: svn://svn.chromium.org/blink/trunk@169514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169472

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/204263002

git-svn-id: svn://svn.chromium.org/blink/trunk@169513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is a followup to [1] to cleanup the dependencies on
the old text autosizer. The largest change in this patch is to
remove the "container" concept and rely only on clusters and
blocks in the FastTextAutosizer.

The big changes in this patch include:
* formInputTags vector -> isFormInput(const Element*)
    Passing around a static vector was unnecessarily confusing. This
    patch refactors the formInput statics into a single function:
    isFormInput.
* isAutosizingContainer -> !isExemptFromAutosizer
    The logic of isAutosizingContainer has been switched in
    isExemptFromAutosizer and I think the new name better reflects
    what this function does.
* containerIsRowOfLinks -> blockContainsRowOfLinks
* contentHeightIsConstrained -> blockHeightConstrained
* containerContainsOneOfTags -> blockContainsFormInput
* containerShouldBeAutosized -> !blockPreventedFromAutosizing
    The logic of containerShouldBeAutosized has been switched in
    blockPreventedFromAutosizing. I think this better reflects what
    this function does.
* blockMightBecomeAutosizingCluster has been added.
* isFingerprintingCandidate has been removed in favor of
    blockMightBecomeAutosizingCluster

[1] https://codereview.chromium.org/200603002

BUG=302005

Review URL: https://codereview.chromium.org/197883013

git-svn-id: svn://svn.chromium.org/blink/trunk@169511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We currently don't know how common xpath usage
is in the wild, but we should.

Review URL: https://codereview.chromium.org/204003003

git-svn-id: svn://svn.chromium.org/blink/trunk@169510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this case, the frame isn't done loading, and we may attempt to print something bogus.

BUG=339075
TEST=Manually, on a google presentation with --enable-print-preview

Review URL: https://codereview.chromium.org/196833005

git-svn-id: svn://svn.chromium.org/blink/trunk@169509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345027

Review URL: https://codereview.chromium.org/196353013

git-svn-id: svn://svn.chromium.org/blink/trunk@169508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per a discussion on www-style [1], FontFace#ready is removed from the
spec [2], and FontFace#load() is changed to return a Promise which
fulfills when the font is ready.

[1] http://lists.w3.org/Archives/Public/www-style/2014Mar/0069.html
[2] http://dev.w3.org/csswg/css-font-loading/

TEST=fast/css/fontface-methods.html
BUG=53213

Review URL: https://codereview.chromium.org/184633005

git-svn-id: svn://svn.chromium.org/blink/trunk@169507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EventTarget has special-cased bindings generation, with several bugs.

This CL corrects and simplifies it in a few ways:
1. Remove duplicate |EventTarget* imp| initialization
Currently EventListener has |EventTarget* imp| initialized twice.
(With different names, |impl| and |imp|, so this compiles.)

Also rearranges the template code so that the special case
is more narrowly focused (instead of overall),
and check the interface name, not just method names,
which clarifies the special case.
(This also means we can remove the test cases,
as it's just a special-case for one interface.)

This does *not* change web behavior:
Unlike all other methods, addEventListener and removeEventListener do not check arguments length.
This is apparently required for legacy calls,
so I've opened a separate bug for this:
https://code.google.com/p/chromium/issues/detail?id=353484

Previously EventTarget skipped this, due to having an overall special case,
instead of just special-casing the method call itself;
we now have an explicit special-case in the template.

This was hit by 3 tests:
fast/dom/node-legacy-event-listener.html
fast/dom/XMLHttpRequest-legacy-event-listener.html
fast/dom/Window/window-legacy-event-listener.html
(More details at the bug.)

I've added more detailed tests on behavior, and other argument handling.

Follow-up CL:
* further reduce special case (use usual argument handling)

TBR=haraken
BUG=345503
BUG=353484

Review URL: https://codereview.chromium.org/201603002

git-svn-id: svn://svn.chromium.org/blink/trunk@169506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The logic was just plain wrong: during a position movement layout,
we have to invalidate the old and new position as we are shifted.
The current code would generate incremental invalidation as it
fell down the wrong path.

Refactored the code to do what it's supposed to do and added
an invalidation test to cover a case where incremental
invalidation failed.

BUG=352050

Review URL: https://codereview.chromium.org/202433003

git-svn-id: svn://svn.chromium.org/blink/trunk@169505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

broke maps_pixel_test on gpu debug bots (so far mac and linux, probably win also)

one exampel: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7%20%28dbg%29/builds/23223

> HTML Imports: Send credentials for same origin requests
> 
> This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
> The essential part of the change is in HTMLImportsController.cpp.
> Anything else is to make it work with redirect.
> 
> The problem here is that allowCredentials flag is held both
> by ResourceLoaderOptions and ResourceRequest and these two
> can go out-of-sync. This change tries to make them in sync.
> 
> Such a state duplication should be resolved eventually, but
> that is another story.
> 
> BUG=348671
> TEST=import-cors-credentials.html
> R=abarth, dglazkov@chromium.org
> 
> Review URL: https://codereview.chromium.org/196043002

TBR=morrita@chromium.org

Review URL: https://codereview.chromium.org/203593008

git-svn-id: svn://svn.chromium.org/blink/trunk@169504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Throw an exception as required when the sample rate of the convolver
node buffer does not match the sample rate of the audio context.

Added test for this case.

BUG=352776

Review URL: https://codereview.chromium.org/200543005

git-svn-id: svn://svn.chromium.org/blink/trunk@169501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch modifies KeyframeEffectModel's implementation such that
an InterpolationEffect is generated after Keyframe normalization. The
InterpolationEffect then handles sample generation, and Interpolations are
plumbed down through the style resolution pipeline instead of
CompositableValues.

BUG=346495

Review URL: https://codereview.chromium.org/194673002

git-svn-id: svn://svn.chromium.org/blink/trunk@169500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also disabling JavaScript for MHTML documents.
Because JavaScipt is now disabled, MHTML layout tests had to be changed
not to use JavaScript anymore.

BUG=330663
TEST=Run MHTML layout tests.
R=abarth@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/161383002

git-svn-id: svn://svn.chromium.org/blink/trunk@169499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353792
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203493006

git-svn-id: svn://svn.chromium.org/blink/trunk@169498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On linux and windows

BUG=353790
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203483006

git-svn-id: svn://svn.chromium.org/blink/trunk@169497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
The essential part of the change is in HTMLImportsController.cpp.
Anything else is to make it work with redirect.

The problem here is that allowCredentials flag is held both
by ResourceLoaderOptions and ResourceRequest and these two
can go out-of-sync. This change tries to make them in sync.

Such a state duplication should be resolved eventually, but
that is another story.

BUG=348671
TEST=import-cors-credentials.html
R=abarth, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/196043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correcting placement and clipping of sub-pixel offset
composited layers by properly adding the accumulated sub-
pixel offset from composited parents.

BUG=347521

Review URL: https://codereview.chromium.org/204053002

git-svn-id: svn://svn.chromium.org/blink/trunk@169495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The assert was a result of an off-by-one error in both the array's definition and the assert itself.

BUG=353577

Review URL: https://codereview.chromium.org/203343004

git-svn-id: svn://svn.chromium.org/blink/trunk@169494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(Left overs from 3-sided patches)

BUG=245025

Review URL: https://codereview.chromium.org/198483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html flaky on Linux
fast/files/workers/worker-read-blob-async-crash.html times out randomly

BUG=353770,353208
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203303005

git-svn-id: svn://svn.chromium.org/blink/trunk@169492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SelectorCheckingContext.elementStyle is used to store the RenderStyle for
the element we are currently computing styles for. It is among other things
used for setting flags on the RenderStyle if we may match :hover,
:first-child, or some other pseudo classes. When we go past a combinator
during matching, we set the elementStyle to null to tell we are not
currently looking at the target element for the selector matching.

The :ancestor pseudo is a special case in the sense that it will select
styles for the shadow host element, but its sub-selectors may actually match
ancestor elements of the host element, behaving as if we had a descendant
combinator. This CL resets elementStyle to 0 when matching ancestors of a
shadow host for the :ancestor pseudo class in order to set flags for :hover,
:first-child, etc on the correct RenderStyle objects.

R=dglazkov@chromium.org
BUG=353503

Review URL: https://codereview.chromium.org/201573003

git-svn-id: svn://svn.chromium.org/blink/trunk@169491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169467

BUG=350978
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/195893040

git-svn-id: svn://svn.chromium.org/blink/trunk@169490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block.html flaky

BUG=353763
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203293008

git-svn-id: svn://svn.chromium.org/blink/trunk@169489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203593006

git-svn-id: svn://svn.chromium.org/blink/trunk@169488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245644
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/204083002

git-svn-id: svn://svn.chromium.org/blink/trunk@169487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345027

Review URL: https://codereview.chromium.org/203623006

git-svn-id: svn://svn.chromium.org/blink/trunk@169486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark two flaky tests:
fast/scrolling/hover-during-scroll.html
http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block.html

BUG=353751,353754
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/201153017

git-svn-id: svn://svn.chromium.org/blink/trunk@169485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203693005

git-svn-id: svn://svn.chromium.org/blink/trunk@169484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353746
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203223011

git-svn-id: svn://svn.chromium.org/blink/trunk@169483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It fails on platforms other than debug from time to time

BUG=352377
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/204023003

git-svn-id: svn://svn.chromium.org/blink/trunk@169482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It times out on linux from time to time

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203983003

git-svn-id: svn://svn.chromium.org/blink/trunk@169481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/select/listbox-appearance-basic.html

These two fail consistently on this bot only, not the WebKit Linux ToT bot.

BUG=353736
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203443006

git-svn-id: svn://svn.chromium.org/blink/trunk@169480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/194073002

git-svn-id: svn://svn.chromium.org/blink/trunk@169479 bbb929c8-8fbe-4397-9dbb-9b2b20218538