GitLab

Strictly speaking this flag isn't here to force a deterministic build, it's here to help us to make sure that no build metadata ends up in the build artifacts to help us guarantee a deterministic build.

(See the discussion in https://codereview.chromium.org/324403006/ for more details)

FTR, Nico said he'll take care of getting rid of __DATE__ and __TIME__ so this
new define will not be necessary for that.

On the other hand we may have issues with absolute path in __FILE__ and whatever
unforeseen C++ issue. This would require #ifdef'ing them out. This is not
something devs would want to do normally so this flag is off by default.

Eventually we'll want to fix the build system to not have to hack __FILE__ out
by ensuring they are *always* relative paths but until then, this variable can
be used to make progress


R=maruel@chromium.org, thakis@chromium.org
TBR=brettw@chromium.org

BUG=314403

Review URL: https://codereview.chromium.org/330813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278053 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278052 0039d316-1c4b-4281-b951-d872f2087c98

1928: use all processors instead of hard-coded 8.
1929: Fix msvs-ninja clean build command / target.
1930: ninja: Add option for link concurrency.
1931: Add unittest for 'AR' in 'make_global_settings'
1932: Override the user's language settings during tests
1933: ninja win: Remove old comment, check cc/cxx are always overridden
1934: Use context manager to manage OS environment in tests
1935: Teach Ninja generator about 'AR' in 'make_global_settings'
1936: First crack at adding a GYP_GENERATOR for determining various things
1937: Add unittest for 'LD' in 'make_global_settings'
1938: Remove unused parameters from test code.
1939: Revise unittest for 'LD' in 'make_global_settings'
1940: Revise unittest for 'AR' in 'make_global_settings'
1941: ninja: Read 'LD'/'LD.host' from 'make_global_settings_ld'.
1942: ninja: Read 'AR.host' from 'make_global_settings'.
1943: [gyp][Android] Implement TestGypAndroid.run_built_executable.
1944: ninja: Pass .so files outside of --start-group/--end-group.

BUG=362075,skia:2439,gyp:434
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/332683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278051 0039d316-1c4b-4281-b951-d872f2087c98

Inform the adapter when a new, potentially unpaired device connects.
In addition to notifying any observers of this event, this prevents a
NULL pointer dereference in the existing logic.

BUG=385493
TEST=Establish a Bluetooth connection from an unpaired device.
     chrome.bluetooth.onDeviceAdded() should be called.
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/341433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278050 0039d316-1c4b-4281-b951-d872f2087c98

- Remove local test timeouts;
- Add page flip history to PageFlipWaiter and use that for test expectations
  to solve the problem that a single Wait returns with multiple page flipping
  happened on valgrind;

BUG=385167

Review URL: https://codereview.chromium.org/339933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278047 0039d316-1c4b-4281-b951-d872f2087c98

The seek timestamp should always be adjusted by the start time,
though this manipulation should not be visible to external (web)
clients.

Since this is an FFmpeg only problem, I've removed the concept
of start time from the Demuxer interface in favor of local method
only for FFmpegDemuxer.  FFmpegDemuxerStream's will now use this
value to adjust timestamps such that external clients always see
a zero based timeline.

Doing so required moving some of our ogg vorbis discard code into
the FFmpegDemuxerStream, which actually makes it more accurate and
more narrowly scoped to ogg w/ vorbis instead of all vorbis.

These changes subtly change how we handle seeking.  Previously we
would let FFmpeg choose the stream to perform seeking within.  Now
we will use the video stream only if it contains the seek timestamp,
if none exists or does not contain the seek timestamp, we'll use
the stream with the lowest start time.

I've extended the tests around non-zero start times to verify the
new behavior.

An FFmpeg DEPS roll is required for the new tests to pass:
5c3de80 Pass remaining command-line arguments to ffmpeg's configure
de80875 Change the sigs file to use c-style comments.
cb19b2d Update ffmpeg's GN build to use new yasm assemble format.
9c12290 Revert "avformat/mp3dec: fix start time in light of initial skip samples"
1e661a6 avcodec/vorbisdec: Reset first_frame
7d88be4 avformat/oggparsevorbis: Dont attempt to calculate timestamps from gp=0

BUG=377295
TEST=New unittests.  Demo page from bug works.  Layout tests pass.

Review URL: https://codereview.chromium.org/335273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383947

Review URL: https://codereview.chromium.org/326963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375545
TEST=try to edit an address to add address line 3 in chrome://settings

Review URL: https://codereview.chromium.org/332213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278044 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).

BUG=303491

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186

Review URL: https://codereview.chromium.org/290803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278043 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/323693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=-
TEST=none

Review URL: https://codereview.chromium.org/337423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278041 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an optional argument to "tools/perf/run_benchmark help"
to show help for a specific test_runner.py command.

Review URL: https://codereview.chromium.org/309553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278040 0039d316-1c4b-4281-b951-d872f2087c98

They're not used anymore.

R=abarth@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/333293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278039 0039d316-1c4b-4281-b951-d872f2087c98

TemplateURLService::fallback_search_engines_disabled only affects the behavior of DefaultSearchManager.
Move it to DefaultSearchManager.

BUG=371535
TEST=git cl try

Review URL: https://codereview.chromium.org/340553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278038 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278037 0039d316-1c4b-4281-b951-d872f2087c98

This patch stops updating chrome/app/address_input_strings.grdp when
running 'gclient runhooks'. This is necessary to enable checking in a
static version of chrome/app/address_input_strings.grdp.
https://codereview.chromium.org/337163002/ needs this patch to land.

BUG=327046

Review URL: https://codereview.chromium.org/341533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381325

Review URL: https://codereview.chromium.org/339003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278035 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the 'about_page' API key is only enabled on dev channel. Once
this is OK to launch, enable it on the stable channel.

BUG=381280

Review URL: https://codereview.chromium.org/336423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278034 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278032 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176347:176359&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278031 0039d316-1c4b-4281-b951-d872f2087c98

We want to keep this histogram for a while.

BUG=286681

Review URL: https://codereview.chromium.org/335123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384696

Review URL: https://codereview.chromium.org/341733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278029 0039d316-1c4b-4281-b951-d872f2087c98

The tabstrip now tries to ensure that if tabs would encroach on the New Tab
button area or be clipped by the edge of the strip, they're made invisible
instead.  This prevents glitchy-looking overflow, modulo some existing bugs (on
file) where the strip doesn't recalculate widths correctly.

This also hides the tab next to the New Tab button if it can be shown when not
selected, but might be hidden when it (or a prior tab) is selected.  This
prevents having this tab toggle in and out as the active tab changes.

BUG=62510
TEST=Spawn lots of tabs and shrink the window to a narrow width.  Once the tabs hit their min size they should start hiding at the right edge instead of drawing atop the New Tab button.

Review URL: https://codereview.chromium.org/339923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278028 0039d316-1c4b-4281-b951-d872f2087c98

With --enable-settings-window, About should behave the same way Settings
does.

BUG=385496
R=stevenjb@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/339153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278027 0039d316-1c4b-4281-b951-d872f2087c98

Makes the background color meet minimum accessibility (contrast) requirements by deepening the shade of red.

BUG=381260

Review URL: https://codereview.chromium.org/339183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278026 0039d316-1c4b-4281-b951-d872f2087c98

Disable WebLayerImplFixedBoundsTest.CompareToWebLayerImplComplex and CompareToWebLayerImplComplex on lsan.
These two tests are not new but are run under content_unittests as of r277988.
https://codereview.chromium.org/317163002

BUG=386080

TBR=amogh.bihani@samsung.com,

Review URL: https://codereview.chromium.org/340723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278025 0039d316-1c4b-4281-b951-d872f2087c98

This CL is a small refactor of ContentsView::ShowSearchResults()
which avoids resetting the start page before showing the search results
in the experimental app list.

BUG=349727

Review URL: https://codereview.chromium.org/331413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278024 0039d316-1c4b-4281-b951-d872f2087c98

This adds disabled-by-default-devtools.timeline* to the category filter
to follow the new category name pattern used by timeline on the blink
side. See also: https://codereview.chromium.org/337143002

BUG=381548

Review URL: https://codereview.chromium.org/334293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278023 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org,meacer@chromium.org
BUG=123266, 377607

Review URL: https://codereview.chromium.org/338363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278022 0039d316-1c4b-4281-b951-d872f2087c98

Changes Version3Enabled for the malware interstitial. Default is now v3 unless a flag or field trial say otherwise.

BUG=381260

Review URL: https://codereview.chromium.org/331133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278021 0039d316-1c4b-4281-b951-d872f2087c98

Move telemetry/core/timeline and timeline_data  to telemetry/timeline. This package handles trace parsing and it should be a standalone package.

BUG=

Review URL: https://codereview.chromium.org/332213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278020 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278019 0039d316-1c4b-4281-b951-d872f2087c98

This broke virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow.html


> roll skia to db6346a5b1d76b150920a5dce47c436fee9c6281
> 
> TBR=
> 
> Review URL: https://codereview.chromium.org/341603006

TBR=reed@chromium.org

Review URL: https://codereview.chromium.org/340023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114092

Review URL: https://codereview.chromium.org/308833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374520

Review URL: https://codereview.chromium.org/336313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278015 0039d316-1c4b-4281-b951-d872f2087c98

On failure, future transport writes should synchronously return. This is
important on Chrome OS and Linux where we have a separate NSS task runner.
If we query the transport each time (in hopes that it will return the error
code) it becomes an asynchronous error and so the state machine keeps pumping
itself in response to the state change. (It alternates between "write pending"
and "write failed".)

Add a test that asserts we do not keep trying to write to the transport in a
loop.

This fixes one of the infinite loops in bug #381160, but not the other.

BUG=381160

Review URL: https://codereview.chromium.org/337823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382931
TEST=Build sandbox twice. The second time it says "no work to do".

Review URL: https://codereview.chromium.org/332403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278013 0039d316-1c4b-4281-b951-d872f2087c98

I still have to rename MOJO_WAIT_... and MojoWaitFlagsState, but I'll do
that separately.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/345463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278012 0039d316-1c4b-4281-b951-d872f2087c98

This duplicates the accessibility enums between accessibility and automation converting to camel casing. It also cleans up some of the idl

For the sake of record, attempts to share the same enum ran into the following issues:
- the docs generator assumes a one-to-one (save camel/snake/unix casing) correspondance between filenames and idl namespaces.
- the handlebar templating language does not allow for logical string comparisons/equality checks or passing in-line string literals, so attempting to in-line names was unsuccessful.
- references to the enums (which were cased for the sake of cpp enums), were incorrect for the docs (which want camel casing).

A local cl with the change is still available  but suffers
from odd filename, casing conflicts, and AX* naming issues.

BUG=309681

Review URL: https://codereview.chromium.org/335923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278011 0039d316-1c4b-4281-b951-d872f2087c98