GitLab

GeolocationProviderImpl is a singleton that directly references
GetContentClient()::browser() on ctor, to retrieve an embedder-
provider GeolocationDelegate. This blocks moving Geolocation
out of content/

This CL changes that mechanism: the GeolocationDelegate
is injected in BrowserMainLoop::PostMainMessageLoopStart()
(so it won't affect startup time IIUC), and kept in a variable
until the singleton construction.

This CL is the last blocking factor before taking Geolocation
out of content/browser and into device.

BUG=612334
TEST=./out/gn/browser_tests --gtest_filter="GeolocationBrowserTest.*"

PS:
A note about shell_content_browser_client.cc: Changing
GeolocationDelegate to injected, causes component's
AutofillRiskFingerprintTest  to start failing because
ShellGeolocationDelegate was initialized too early
and could not get a correct ShellBrowserContext*.
This CL also changes the ShellGeolocationDelegate to get
the browser_context() when is needed.

Review-Url: https://codereview.chromium.org/2127973002
Cr-Commit-Position: refs/heads/master@{#407015}

The Mojo PermissionService can be used directly from Blink. Creating
separate pipes for workers also removes the need to implement an
additional thread-hopping layer.

BUG=561879

Review-Url: https://codereview.chromium.org/2108003002
Cr-Commit-Position: refs/heads/master@{#407014}

Things I wanted clarified while investigating https://crbug.com/625042

BUG=625042

Review-Url: https://codereview.chromium.org/2149273003
Cr-Commit-Position: refs/heads/master@{#407013}

(version 4f58244457f8e785c5fbfa9db2735473f9e74ccf of https://github.com/w3c/webcrypto)

Review-Url: https://codereview.chromium.org/2167883003
Cr-Commit-Position: refs/heads/master@{#407012}

As of CUPS 1.6, CUPS has moved away from PPD attributes to IPP attributes.  This new backend uses the IPP APIs and will be better suited to use with CUPS going forward.  Until we can bump our minumum CUPS version to 1.7, the only client will be Chrome OS where the version is 2.1.3.

BUG=607668

TEST=With --enable-native-cups enabled, print dialog will show available CUPS printers if any are configured.

Review-Url: https://codereview.chromium.org/2105463002
Cr-Commit-Position: refs/heads/master@{#407011}

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2166953006
Cr-Commit-Position: refs/heads/master@{#407010}

Hide sign in guide in guest mode and show 'no synced tabs'.

BUG=628102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2171513004
Cr-Commit-Position: refs/heads/master@{#407009}

Allows content shell to run context menu handling code in
WebContentsViewAura, including touch selection code. This is needed to
be able to properly test long press touch selection behavior.

BUG=594101

Review-Url: https://codereview.chromium.org/2132983002
Cr-Commit-Position: refs/heads/master@{#407008}

R=stevenjb@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true  # android bots keep failing, this code doesn't even run on android...

Review-Url: https://codereview.chromium.org/2164223002
Cr-Commit-Position: refs/heads/master@{#407007}

R=nick@chromium.org,dominicc@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2163373006
Cr-Commit-Position: refs/heads/master@{#407006}

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).

Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488

Review-Url: https://codereview.chromium.org/1894913002
Cr-Commit-Position: refs/heads/master@{#407005}

TBR=brettw@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=627637

Review-Url: https://codereview.chromium.org/2176433002
Cr-Commit-Position: refs/heads/master@{#407004}

Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ )

Reason for revert:
Speculative revert for failing WebView tests on Lollipop:

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054

Both phone and tablet started failing and this is the most "suspicious" change.  boliu@ can help investigate further assuming this holds true.

Original issue's description:
> Default enable main frame before activation and remove finch experiment.
>
> The finch experiment hasn't revealed any regressions other than in page
> load times which has been deemed a blink scheduler issue (see
> crbug.com/614482).
>
> R=piman@chromium.org,rkaplow@chromium.org
> BUG=612596
>
> Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed
> Cr-Commit-Position: refs/heads/master@{#406916}

TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612596

Review-Url: https://codereview.chromium.org/2170233002
Cr-Commit-Position: refs/heads/master@{#407003}

Revert of Update the MB builder mapping w/ a few changes. (patchset #1 id:1 of https://codereview.chromium.org/2167033002/ )

Reason for revert:
restore cronet entry.

Original issue's description:
> Update the MB builder mapping w/ a few changes.
>
> A couple of builders have been removed, and one has been added
> but it doesn't do compiles.
>
> TBR=brettw@chromium.org
> BUG=
>
> Committed: https://crrev.com/cc19e4cf151fec79f7c7052598666de61b20b946
> Cr-Commit-Position: refs/heads/master@{#406939}

TBR=brettw@chromium.org,smut@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2169233002
Cr-Commit-Position: refs/heads/master@{#407002}

In this particular path (WebFrameClient::didDisplayContentWithCertificateErrors and didRunContentWithCertificateErrors), the information needed is mostly from net's SSLInfo. I removed content::SecurityStyle from the IsContentWithCertificateErrorsRelevantToUI check since it's based on other members from SSLInfo that are compared. This allows future changes to not send content::SSLStatus to the renderer process.

Also stop sending the serialized security_info string to the browser since it's not used.

BUG=598073

Review-Url: https://codereview.chromium.org/2167773002
Cr-Commit-Position: refs/heads/master@{#407001}

R=rockot@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2172673002
Cr-Commit-Position: refs/heads/master@{#407000}

This uses the new tool in //tools/mac/show_mod_init_func.py to display the
function names.

BUG=628052
R=mark@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2163373008
Cr-Commit-Position: refs/heads/master@{#406999}

BUG=611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2164903002
Cr-Commit-Position: refs/heads/master@{#406998}

BUG=630452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
R=zmo@chromium.org
TBR=piman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2170153002
Cr-Commit-Position: refs/heads/master@{#406997}

This is hoping to achieve better build performance.

BUG=627637

Review-Url: https://codereview.chromium.org/2173443003
Cr-Commit-Position: refs/heads/master@{#406996}

BrowserThreads forget their identity during shutdown, causing
nonsensical errors like
"Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO).
Must be called on Chrome_IOThread; actually called on Chrome_IOThread."
if DCHECK_CURRENTLY_ON is used in something that is called from a
MessageLoop shutdown observer.

This CL fixes this problem in DeviceSensorHost by using a ThreadChecker
instead.

BUG=625988

Review-Url: https://codereview.chromium.org/2160913005
Cr-Commit-Position: refs/heads/master@{#406995}

This patch updates the code to prevent auto deducing to a raw pointer.

R=sievers, danakj, dcheng
BUG=554600
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2101943004
Cr-Commit-Position: refs/heads/master@{#406994}

BUG=402536

Review-Url: https://codereview.chromium.org/2156213002
Cr-Commit-Position: refs/heads/master@{#406993}

If a merge is in progress and the Activity gets killed, there could
be two tab metadata files that contain some duplicate tab IDs.
When merging these two metadata files on application cold start,
ignore tabs with duplicate ids.

BUG=602498

Review-Url: https://codereview.chromium.org/2166123002
Cr-Commit-Position: refs/heads/master@{#406992}

This CL implements classes for drawing cursor and cursor feedback on the
OpenGL canvas. This is part of the project of using OpenGL to render
remoting host on Android.

BUG=385924

Review-Url: https://codereview.chromium.org/2148743005
Cr-Commit-Position: refs/heads/master@{#406991}

BUG=611781
COMPONENT=Chrome OS, HaTS

Review-Url: https://codereview.chromium.org/2170113002
Cr-Commit-Position: refs/heads/master@{#406990}

https://chromium.googlesource.com/chromium/src/+/098ef3d2d

BUG=629075
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2174583002 .

Cr-Commit-Position: refs/heads/master@{#406989}

Currently, the panner node checks to see if the HRTF database is
loaded and does the copy of the input if necessary.  This is the wrong
abstraction; the HRTF panner should copy the input if the database is
not ready.

In this way, the panner doesn't need to know about this implementation
detail, and we also get the correct distance and cone gains applied.

BUG=629858
TEST=

Review-Url: https://codereview.chromium.org/2170973002
Cr-Commit-Position: refs/heads/master@{#406988}

This is part 4 of matching WebBluetooth chooser views to mocks.

This CL adds:
1. a spinner that starts when the chooser scans for Bluetooth devices
and stops when the scan completes.
2. a status text:
"Scanning for devices..." when chooser is scanning for Bluetooth devices.
3. a Re-scan button which user can click it to re-scan Bluetooth devices.

The screenshots were uploaded on the issue page.

BUG=583452

Review-Url: https://codereview.chromium.org/2169513004
Cr-Commit-Position: refs/heads/master@{#406987}

BUG=588311
TEST=mash_unittests + manual

Review-Url: https://codereview.chromium.org/2150933003
Cr-Commit-Position: refs/heads/master@{#406986}

BUG=629718

Review-Url: https://codereview.chromium.org/2170073002
Cr-Commit-Position: refs/heads/master@{#406985}

Code to wait for shell to load and set up and tear down the http
server can live here.

BUG=

Review-Url: https://codereview.chromium.org/2166043004
Cr-Commit-Position: refs/heads/master@{#406984}

BUG=627072

Review-Url: https://codereview.chromium.org/2163173004
Cr-Commit-Position: refs/heads/master@{#406983}

Revert of Check that all RenderProcessHost(s) are terminated. (patchset #3 id:40001 of https://codereview.chromium.org/2133813002/ )

Reason for revert:
This was temporarily added to collect data for diagnosing crbug.com/608049. We have enough data points now to study. This can now be reverted.

BUG=628192

Original issue's description:
> Check that all RenderProcessHost(s) are terminated.
>
> BUG=608049
>
> Committed: https://crrev.com/3d47eced8c022d3fd666c005c7a8b3f26f8c773e
> Cr-Commit-Position: refs/heads/master@{#405320}

TBR=dalecurtis@chromium.org,jam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=608049

Review-Url: https://codereview.chromium.org/2169103002
Cr-Commit-Position: refs/heads/master@{#406982}

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2164613003
Cr-Commit-Position: refs/heads/master@{#406981}

This is a flag for the experimental offline page sharing feature. It defalts to off.
Will update the bug number once get approval from dimich to issue a bug for the project.

BUG=622139

Review-Url: https://codereview.chromium.org/2068393002
Cr-Commit-Position: refs/heads/master@{#406980}

- Generate xcode project using cr_cronet.py gn
- Use fat binary, stripping and dsym support in package_ios.py

Review-Url: https://codereview.chromium.org/2170643002
Cr-Commit-Position: refs/heads/master@{#406979}

R=tsergeant@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2169433003
Cr-Commit-Position: refs/heads/master@{#406978}

Review-Url: https://codereview.chromium.org/2168133003
Cr-Commit-Position: refs/heads/master@{#406977}

This CL cleans up unnecessary build configuration to facilitate
Chrome build.

BUG=630113
TEST=gclient sync, make

Review-Url: https://codereview.chromium.org/2169843002
Cr-Commit-Position: refs/heads/master@{#406976}