GitLab

This works for touch events, but not for wheel events. Use the existing
touch latency machinery to enable logging of wheel events.

Update ComputeInputLatencyHistograms to report latency of
INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT in the absence of a
INPUT_EVENT_LATENCY_UI_COMPONENT, as it is still valid.

BUG=224781

Review URL: https://codereview.chromium.org/681763003

Cr-Commit-Position: refs/heads/master@{#302518}

BUG=419586
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/697533002

Cr-Commit-Position: refs/heads/master@{#302517}

Review URL: https://codereview.chromium.org/695273002

Cr-Commit-Position: refs/heads/master@{#302516}

BUG=

Review URL: https://codereview.chromium.org/684373002

Cr-Commit-Position: refs/heads/master@{#302515}

BUG=none
R=kelvinp@chromium.org

Review URL: https://codereview.chromium.org/694363002

Cr-Commit-Position: refs/heads/master@{#302514}

Even though it's having WebContents without a ContentViewCore
is a support scenario in //content, it's not a well tested
path, especially the webview only code. This makes sure
ContentViewCore and WebContents are destroyed together.

Instead of posting on native side to destroy WebContents,
post on Java side and have one call destroy both Java and
native side.

More specific details:
* All caller except destroy to AwContents.destroyNatives
  either have already detached webview so ok to move detach
  to destroy.
* Need to remove some asserts that objects are null when
  mIsDestroyed is true.
* Reordered some native AwContents members so they are
  naturally destroyed in the correct order.

BUG=

Review URL: https://codereview.chromium.org/690553002

Cr-Commit-Position: refs/heads/master@{#302513}

This is temporary - will be removed once we pin down the crash.

BUG=424024
TEST=
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/699043002

Cr-Commit-Position: refs/heads/master@{#302512}

If an extension desires to act, it should pop itself out of
the overflow menu.  There should also be a visual queue for
extensions that are already visible, but what exactly that
should be is still being discussed.

BUG=417441

Review URL: https://codereview.chromium.org/675023002

Cr-Commit-Position: refs/heads/master@{#302511}

Failure to do so causes UI issues on some sites, and causes form submission
to fail on Yahoo.

BUG=159043

Review URL: https://codereview.chromium.org/680413004

Cr-Commit-Position: refs/heads/master@{#302510}

If the user entered name is accepted and saved, then the entire view is refreshed and the
new name is displayed. Automatically committing the name is too eager, since
UpdateProfileName might reject the name in some cases (if it's identical to the original
one), and we might ignore the display rules around single profiles and "You".

BUG=428683
TEST=Start Chrome with --enable-new-avatar-menu. Make sure you only have one, brand new
profile. Open chrome://settings and in the avatar bubble (which should display "You")
enter the same name that the profile has in chrome://settings (like Person 1). The name
displayed in the bubble should stay as "You"

Review URL: https://codereview.chromium.org/698993002

Cr-Commit-Position: refs/heads/master@{#302509}

Galaxy Core rendered incorrectly on image search.  This is an Adreno 203
device.  Also remove Galaxy Win which has the same GPU.

NOTRY=true
BUG=428401

Review URL: https://codereview.chromium.org/697763003

Cr-Commit-Position: refs/heads/master@{#302508}

This initial implementation does nothing. Eventually it will talk to privet
and buffet to determine setup state and show progress.

BUG=428853
TEST=app_shell_unittests

Review URL: https://codereview.chromium.org/690093002

Cr-Commit-Position: refs/heads/master@{#302507}

EglSwapInterval doesn't take any effect when using a Surfacless
Context and will just return EGL_BAD_SURFACE in this case. This
patch adds checks to track if the current context is surfaceless
and ignores swap interval call in that case.

Tested by building Chromium with ChromesOS and
Ozone builds options and by launching chromium with the
following run time options:
chrome --no-sandbox --ozone-platform=gbm --ozone-use-surfaceless

After this change, I don't see any more EGL error as result of setting the SwapInterval
with surfaceless context during the launch time.
i.e. libEGL debug: EGL user error 0x300d (EGL_BAD_SURFACE) in eglSwapInterval

BUG=380861

Review URL: https://codereview.chromium.org/693313002

Cr-Commit-Position: refs/heads/master@{#302506}

histograms.xml is also updated. This update includes the ones for PLT measurement.

BUG=405690, 406200

Review URL: https://codereview.chromium.org/632033002

Cr-Commit-Position: refs/heads/master@{#302505}

Without this, the browser may get created with old finder_options because FindBrowser has a caching decorator.

This should fix flakiness of telemetry/page/page_runner_unittest/PageRunnerTests/testUserAgent.

http://build.chromium.org/f/chromium/flakiness/
[test type: telemetry_unittests]

BUG=428967

Review URL: https://codereview.chromium.org/688903002

Cr-Commit-Position: refs/heads/master@{#302504}

BUG=

Review URL: https://codereview.chromium.org/672813002

Cr-Commit-Position: refs/heads/master@{#302503}

Making all implementations except for ash's use the new default base class.

I left the ash's implementation as is, since I am not sure if the display origin
is always the same as the root window origin. My suspicion is that it's not..

BUG=NONE

Review URL: https://codereview.chromium.org/686513004

Cr-Commit-Position: refs/heads/master@{#302502}

Cr-Commit-Position: refs/heads/master@{#302501}

BUG=

Review URL: https://codereview.chromium.org/684633002

Cr-Commit-Position: refs/heads/master@{#302500}

net: batch of (manual) HSTS updates.
Cr-Commit-Position: refs/heads/master@{#302499}

This helps investigate the root cause of the BUG.

BUG=427624

Review URL: https://codereview.chromium.org/694153002

Cr-Commit-Position: refs/heads/master@{#302498}

BUG=429393

Review URL: https://codereview.chromium.org/692303002

Cr-Commit-Position: refs/heads/master@{#302497}

This patch removes another service from ExtensionSystem that can easily
be its own browser context keyed service. If the ExtensionPrefs
dependency Blacklist can be removed it could be promoted to a true
singleton.

BUG=

Review URL: https://codereview.chromium.org/698553002

Cr-Commit-Position: refs/heads/master@{#302496}

BUG=422621

Review URL: https://codereview.chromium.org/698633002

Cr-Commit-Position: refs/heads/master@{#302495}

BUG=

Review URL: https://codereview.chromium.org/696923002

Cr-Commit-Position: refs/heads/master@{#302494}

BUG=429322

Review URL: https://codereview.chromium.org/693893005

Cr-Commit-Position: refs/heads/master@{#302493}

The log showed that the sum across all C-states didn't change, but C0 went down and WFI went up. AFAIK it shouldn't be possible for any of them to go down, so we'll just drop the data in this case.

BUG=426430
TEST=None.
TBR=tonyg

Review URL: https://codereview.chromium.org/679813002

Cr-Commit-Position: refs/heads/master@{#302492}

This reverts commit 07a90a91.

Revert "Fixes bug in Media.AudioInputCbErrorMac histogram."

This reverts commit beaa161b.

Rationale: appears to make AppRTC hang on Mac. This looks like the
only related CL in the blamelist, speculatively reverting.

BUG=428706
TBR=xians@chromium.org

Review URL: https://codereview.chromium.org/695393002

Cr-Commit-Position: refs/heads/master@{#302491}

The name attribute is repeated in AX tree formatter on Windows
because WriteAttrubute() is called twice for the name attribute.
This patch makes formatter write it only once.

BUG=N/A

Review URL: https://codereview.chromium.org/688653002

Cr-Commit-Position: refs/heads/master@{#302490}

GetCmdStatusAndOutputWithTimeout in cmd_helper should log the commands
run, like GetCmdStatusAndOutput does.

BUG=429766

Review URL: https://codereview.chromium.org/695403002

Cr-Commit-Position: refs/heads/master@{#302489}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=plundblad@chromium.org

Review URL: https://codereview.chromium.org/683583003

Cr-Commit-Position: refs/heads/master@{#302488}

Device info is always enabled, regardless of sync everything state.

BUG=429217

Review URL: https://codereview.chromium.org/694903002

Cr-Commit-Position: refs/heads/master@{#302487}

Similar UI has already been added to mobile platforms. Functionality is hidden behind a flag until the passwords website launches.

BUG=426508
R=estade@chromium.org, isherman@chromium.org, mkwst@chromium.org, nyquist@chromium.org

Review URL: https://codereview.chromium.org/682133003

Cr-Commit-Position: refs/heads/master@{#302486}

BUG=426252
TEST=compiles, verified version number shows up on Windows

Review URL: https://codereview.chromium.org/681983004

Cr-Commit-Position: refs/heads/master@{#302485}

R=dmazzoni@chromium.org
BUG=428156

Review URL: https://codereview.chromium.org/701583002

Cr-Commit-Position: refs/heads/master@{#302484}

BUG=105388

Review URL: https://codereview.chromium.org/678263003

Cr-Commit-Position: refs/heads/master@{#302483}

CodeGen doesn't do anything fancy like fork() or ptrace(), so it's
safe to test using just plain gtest. That also allows us to convert
the tests to use parameterized tests, so we can easily run each test
independently.

While here, also invert the structure a bit because I expect once I
rewrite and simplify CodeGen, a lot of the ProgramTestFuncs to go
away.

Lastly, for simplicity I'm leaving a lot of statements as ASSERT_TRUE
even if they could use ASSERT_EQ, etc.  Again, I'm expecting some of
those to go away, so I'll worry about cleaning them up once the
unneeded asserts are gone.

BUG=414363

Review URL: https://codereview.chromium.org/687813003

Cr-Commit-Position: refs/heads/master@{#302482}

If the user navigates away from a distilled web page or the
renderer crashes while the DomDistillerViewerSource is still
active, a request can still come in. However, using the
render_process_id and render_frame_id to find the live renderer
(RenderFrameHost) might fail.

That case used to be a DCHECK, but since this happens in the
wild and is reproducible, this CL removes the DCHECK and instead
just bails out early if that happens, since there is no renderer
to send the data to.

It also fixes another place in the same method where the
RenderFrameHost used to be looked up again, but now the one that
has been already found is just reused.

BUG=421949

Review URL: https://codereview.chromium.org/693053002

Cr-Commit-Position: refs/heads/master@{#302481}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/690403002

Cr-Commit-Position: refs/heads/master@{#302480}

In OnSwapBuffersComplete we call PageFlipComplete in BufferQueue, which ensures
the buffers are recycled properly.
However, GpuSurfacelessBrowserCompositorOutputSurface::OnSwapBuffersComplete is
never called as GpuBrowserCompositorOutputSurface directly calls the base class
implementation. This CL fixes it.

BUG=380861

Review URL: https://codereview.chromium.org/697823002

Cr-Commit-Position: refs/heads/master@{#302479}