GitLab

This is on similar lines as Windows 8. The difference being launching into ASH on Windows 8 launches
ASH into Windows 8 metro environment.

Reused the existing tunneling we have via delegate_execute to ensure that the calling process is terminated
before launching the browser into the other environment.

Removed the erstshile Open Ash Desktop and Close Ash Desktop menu options as they are no longer needed and they
don't work correctly anyways.

BUG=356475

Review URL: https://codereview.chromium.org/498573003

Cr-Commit-Position: refs/heads/master@{#292464}

Revert of Revert of Remove the last piece of deprecated synchronous IO code. (patchset #1 of https://codereview.chromium.org/509893002/)

Reason for revert:
https://codereview.chromium.org/510893003/ fixed the ledger bot, so I am going to revert this revert CL.

Original issue's description:
> Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)
>
> Reason for revert:
> Build failure on Google Chrome ChromeOS:
>
> http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164
>
> Original issue's description:
> > Remove the last piece of deprecated synchronous IO code.
> >
> > BUG=337096
> > TEST=bots
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193
>
> TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org
> NOTREECHECKS=true
> BUG=337096
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3e8c19c89c16fe8a7c2dfe0cae2990cd4a004339

TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,tnagel@chromium.org
NOTREECHECKS=true
BUG=337096

Review URL: https://codereview.chromium.org/518433002

Cr-Commit-Position: refs/heads/master@{#292463}

More-or-less consolidate calls to show an ExtensionAction's
popup into ExtensionActionAPI. This has the happy effect of
reducing the amount of piping we have to do in the UI code
(cutting a few steps out of the Browser -> BrowserWindow ->
Toolbar -> BrowserActionsContainer -> BrowserActionView chain),
and, more importantly, lets page action command executions
happen in the BrowserActionsContainer when the redesign is
enabled.

Hopefully, this means that we can stop showing page actions
in the location bar with the switch enabled - but that's
another patch.

BUG=397259
TBR=sky@chromium.org (minor changes to test_browser_window)

Review URL: https://codereview.chromium.org/489183005

Cr-Commit-Position: refs/heads/master@{#292462}

https://skia.googlesource.com/skia/+log/dc53701216c0e9f98eacf6c0cda769ebbd200b59..60cc7d353b2adc8fcc1712e1f7a965e70121ebcc

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/510393002

Cr-Commit-Position: refs/heads/master@{#292461}

1. URLLoaders can't be reused, so we need to construct one
   per-load. This became too gnarly to handle with callbacks
   so I put it back to having a loader object that owns the
   URLLoader.

2. The relevant URLLoader needs to be passed to
   ContentHandler::OnConnect() so that it stays alive long
   enough to read the entire response.

BUG=

Review URL: https://codereview.chromium.org/513573002

Cr-Commit-Position: refs/heads/master@{#292460}

They were disabled because they flakily time out.  Now with the switch
to Aura, I don't see timeouts anymore.  All the tests I enable in this
changelist pass 10/10 on my machine.

Trybots seem okay with it.

BUG=131179,165765

Review URL: https://codereview.chromium.org/517683002

Cr-Commit-Position: refs/heads/master@{#292459}

It seems that the cons are fairly weak and the benefits might be worth it.
This flag breaks WebView builds.

BUG=None

Review URL: https://codereview.chromium.org/502743002

Cr-Commit-Position: refs/heads/master@{#292458}

This change excludes libvpx from linking if it is disabled. This is
needed to enable linking Chrome with GN, since libvpx is not building
with GN yet.

Review URL: https://codereview.chromium.org/501153003

Cr-Commit-Position: refs/heads/master@{#292457}

BUG=407858

Review URL: https://codereview.chromium.org/504413004

Cr-Commit-Position: refs/heads/master@{#292456}

Tabbing should navigate through all the visible controls.

I've changed the EditablePhotoButton to actually be a button and
not just an image, so that tabbing and pressing enter actually
works.

BUG=405056

Review URL: https://codereview.chromium.org/489143002

Cr-Commit-Position: refs/heads/master@{#292455}

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180973%3A181040&mode=html

TBR=hclam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/512283002

Cr-Commit-Position: refs/heads/master@{#292454}

Simple rename patch, in preparation for making the DataTypeStatusTable
copy-able and having it track more than just errors.

BUG=368834

Review URL: https://codereview.chromium.org/513543004

Cr-Commit-Position: refs/heads/master@{#292453}

BUG=110610

Review URL: https://codereview.chromium.org/514233002

Cr-Commit-Position: refs/heads/master@{#292452}

BUG=none

Review URL: https://codereview.chromium.org/511253002

Cr-Commit-Position: refs/heads/master@{#292451}

BUG=
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/514143003

Cr-Commit-Position: refs/heads/master@{#292450}

Adding droppedframecount UMA to monitor videoplayback quality. Metric gets logged only if the pipeline has video & has decoded atleast one video frame.

BUG=
R=dalecurtis

Review URL: https://codereview.chromium.org/497913002

Cr-Commit-Position: refs/heads/master@{#292449}

Review URL: https://codereview.chromium.org/512663002

Cr-Commit-Position: refs/heads/master@{#292448}

The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.

This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/505403002

Cr-Commit-Position: refs/heads/master@{#292447}

Our designers generated assets that do not use sRGB color profile
and this makes libpng unhappy. According to jreck@ Android does not use
these profiles. This CL removes all these color profiles using this command:
find . -type f -name "*.png" -exec convert {} -strip {} \;

BUG=394138
R=dtrainor@chromium.org, newt@chromium.org
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/510423002

Cr-Commit-Position: refs/heads/master@{#292446}

Some errors remain but these are circular includes that can't be fixed in the build files only.

Enable views_unittests and wm_unittests now that they compile

BUG=
R=sky@chromium.org, tfarina@chromium.org

Review URL: https://codereview.chromium.org/513313002

Cr-Commit-Position: refs/heads/master@{#292445}

BUG=408429
TEST=none
TBR=miket

Review URL: https://codereview.chromium.org/515313002

Cr-Commit-Position: refs/heads/master@{#292444}

Mac does not use Skia image natively even if TOOLKIT_VIEWS=1.

BUG=378134

Review URL: https://codereview.chromium.org/517723002

Cr-Commit-Position: refs/heads/master@{#292443}

BUG=110610

Review URL: https://codereview.chromium.org/515303002

Cr-Commit-Position: refs/heads/master@{#292442}

Testing clock needs an owner. Put a scoped_ptr<> to where it was first
created.

BUG=400728

Review URL: https://codereview.chromium.org/488133005

Cr-Commit-Position: refs/heads/master@{#292441}

If a CDM calls the wrong Resolved() method to resolve a promise, the
promise is cast to the wrong type and causes a crash. This fixes the
problem by verifying that the promise is the correct type before
casting it.

BUG=408319
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/515753002

Cr-Commit-Position: refs/heads/master@{#292440}

This broke fling.

This reverts commit f1e78836.

TBR=sadrul,alexst
NOTRY=true

Review URL: https://codereview.chromium.org/514303002

Cr-Commit-Position: refs/heads/master@{#292439}

Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/)

Reason for revert:
Speculatively reverting to see if this helps the mac perf bots:
https://code.google.com/p/chromium/issues/detail?id=408673

Original issue's description:
> Fix assorted issues with remote CoreAnimation
>
> These issues came up while running for a few days with the
> flag --enable-remote-core-animation.
>
> Fix flashes of old frames by hooking up the DiscardBackbuffer (which
> happens when being made non-visible) to re-set the CAContext and
> CALayer (so the browser gets a new one with new content for the next
> frame).
>
> Add support for disabling vsync by using setNeedsDisplay to draw.
>
> Change the backpressure mechanism to rely on the browser to apply
> backpressure in its compositor via the cc:: output surface.
>
> Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
> to the real GL API while in the CoreAnimation callback.
>
> BUG=312462
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8

TBR=piman@chromium.org,ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=312462

Review URL: https://codereview.chromium.org/517733002

Cr-Commit-Position: refs/heads/master@{#292438}

It's timing out on some android bots and from a local run, it seems
to just be legitimately slower than the default 60s timeout.

BUG=405381

Review URL: https://codereview.chromium.org/510413002

Cr-Commit-Position: refs/heads/master@{#292437}

BUG=110610

Review URL: https://codereview.chromium.org/513283002

Cr-Commit-Position: refs/heads/master@{#292436}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/512253002

Cr-Commit-Position: refs/heads/master@{#292435}

If this is submitted, then cl/74264031 should also be submitted so that the perf dashboard correctly makes patches.

Any thoughts?

BUG=

Review URL: https://codereview.chromium.org/511043002

Cr-Commit-Position: refs/heads/master@{#292434}

When the browser takes the navigation, the current page doesn’t change, so it makes no sense to change the page id.

This reverts a58db8b0.

BUG=407376
TEST=stuff is green

Review URL: https://codereview.chromium.org/511263002

Cr-Commit-Position: refs/heads/master@{#292433}

BUG=110610

Review URL: https://codereview.chromium.org/514123002

Cr-Commit-Position: refs/heads/master@{#292432}

PRESUBMIT checks for usage of FIXME, so added that to error message.

Review URL: https://codereview.chromium.org/515063004

Cr-Commit-Position: refs/heads/master@{#292431}

BUG=403813
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/516643005

Cr-Commit-Position: refs/heads/master@{#292430}

BUG=110610

Review URL: https://codereview.chromium.org/511153002

Cr-Commit-Position: refs/heads/master@{#292429}

This will make the WebRTC connection work under NTLM/Kerberos using the default credential without prompting the user.

BUG=395614

Review URL: https://codereview.chromium.org/414523005

Cr-Commit-Position: refs/heads/master@{#292428}

compositor-perf team is using these benchmarks for tracking compositor
performance primarily in software raster path, so forcing software raster.

BUG=407927

Review URL: https://codereview.chromium.org/516623002

Cr-Commit-Position: refs/heads/master@{#292427}

The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136

Thus we don't need to scale it again when we paint during the overscroll gesture.

BUG=402280

Review URL: https://codereview.chromium.org/507083002

Cr-Commit-Position: refs/heads/master@{#292426}

This fixes an issue with invalid JSON being generated as example values
for policies on Windows, and points to the documentation for complex
policies on Windows.

BUG=381627

Review URL: https://codereview.chromium.org/511993003

Cr-Commit-Position: refs/heads/master@{#292425}