- 06 Feb, 2019 40 commits
-
-
Ivan Sandrk authored
There was a bug in locked fullscreen where docked magnifier mode wasn't properly cleaning up after being closed - the pinned (fullscreen) window wasn't being restored to it's full height (it kept the smaller height into which the docked magnifier pushed it). Bug: 901485 Change-Id: I4121444506a0da349f8a1ea300c225a7c32b434d Reviewed-on: https://chromium-review.googlesource.com/c/1454629 Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#629581}
-
Andrew Grieve authored
* Add example in docs * Don't store previous sources value (there is none) Change-Id: I5b876905d4117a7f9d1966a70ce7134aef3110b8 Reviewed-on: https://chromium-review.googlesource.com/c/1455340 Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#629580}
-
Michael Spang authored
- Paths intererpreted by GN such as paths in inputs, sources, lib_dirs, etc should either be relative to BUILD.gn, or GN-absolute (relative to source root and start with "//"). They should not be rebased as system-absolute paths; those are only needed for paths that are actually outside the source tree. If paths are used in multiple contexts, rebasing should be deferred until they are used in a context where rebased paths are required. - Paths passed as arguments to scripts should be rebased on root_build_dir, which is the current working directory of the build. They should not be rebased on root_out_dir, as that is only the current working directory for the default toolchain. Using root_out_dir in place of root_build_dir breaks cross compilation. They should also not be resolved to system-absolute paths, as that introduces an undesired dependency on the location of the source tree. - The 3rd argument to rebase_path has no effect for GN-absolute paths, which includes all paths built by appending to predefined variables such as root_out_dir. Change-Id: I54ff2d9fed0daadacf5bd1bd8fdadc561c3a2882 Reviewed-on: https://chromium-review.googlesource.com/c/1448694 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629579}
-
Tim Volodine authored
Disable failing test due to permission model change. Failing on WebView M and N bots. (filed crbug.com/929129 to track this issue) BUG=927055,929129 NOTRY=true TBR=ntfschr@chromium.org,toyoshim@chromium.org Change-Id: I9dd4e11036b5a2bc4205da551008423b6ce40350 Reviewed-on: https://chromium-review.googlesource.com/c/1456576Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Auto-Submit: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629578}
-
sebsg authored
external/wpt/html/dom/interfaces.worker.html is failing consistently. Tbr: tkent@chromium.org Bug: 929122 Change-Id: Ic11fbea14f6b0ce84cc3d34c93af6b33922ead32 Reviewed-on: https://chromium-review.googlesource.com/c/1456282Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#629577}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1a51a5b4a6bdf7ee11b443f21f08dc2ba2de9815..70fe6105565e71e44e0a2a4ee617a26fd8fdcd96 The following commits have Chromium bugs associated: d7266ecc9 Enforce key usage for RSA keys in TLS 1.2. Bug: 795089 Change-Id: Icd7b0f0e2bf96fdd56b1a740766576d2d6484265 Reviewed-on: https://chromium-review.googlesource.com/c/1455639 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#629576}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/484d74fa21a5..c4cf541859e6 git log 484d74fa21a5..c4cf541859e6 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c4cf541859e6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idd6673eb41507a2d9e871bb5fd296c135f5f1e71 Reviewed-on: https://chromium-review.googlesource.com/c/1456396Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629575}
-
Roman Aleksandrov authored
Currently in Chrome OS the upgrade_detected_time is reset on each new update downloaded. It causes RelaunchNotificationPeriod policy could never force install new version of Chrome OS. upgrade_detected_time should be set once when first upgrade downloaded and becomes null due ChromeOS relaunch to install new upgrade. Bug: 928266 Change-Id: Ibd7c8829685e278e5579c08a11e70cc848bec426 Reviewed-on: https://chromium-review.googlesource.com/c/1452168Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#629574}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f408d006a60..38c83b97138a git log 3f408d006a60..38c83b97138a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 solenberg@webrtc.org Remove unused file. Created with: gclient setdep -r src/third_party/webrtc@38c83b97138a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b5086d806c09b18b7951edb98f87613abdf7c31 Reviewed-on: https://chromium-review.googlesource.com/c/1456197Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b0d7bc961a5a..363655366ecf git log b0d7bc961a5a..363655366ecf --date=short --no-merges --format='%ad %ae %s' 2019-02-06 gmeinke@chromium.org cbuildbot: build only specified packages Created with: gclient setdep -r src/third_party/chromite@363655366ecf The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9674178ea321a21990e0d6ca6f9e85c6706dea8c Reviewed-on: https://chromium-review.googlesource.com/c/1456317Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/71b40a07a007..fd60cc8f224d git log 71b40a07a007..fd60cc8f224d --date=short --no-merges --format='%ad %ae %s' 2019-02-06 fmayer@google.com Create /data/nativetest if it doesn't exist. Created with: gclient setdep -r src/third_party/perfetto@fd60cc8f224d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5c3071ab9ddf47de040068116dd725ac62f284f4 Reviewed-on: https://chromium-review.googlesource.com/c/1456336Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37b7d41d01cb..e956049450f6 git log 37b7d41d01cb..e956049450f6 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 brianosman@google.com Fix makeColorSpace on YUV images Created with: gclient setdep -r src/third_party/skia@e956049450f6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: If0e2ba829e8c7c5d60f4178cdd02b16f0c63ea3e Reviewed-on: https://chromium-review.googlesource.com/c/1456190Reviewed-by:
-
Stephen Nusko authored
This allows chromium code to use the native perfetto::DataSourceConfig everywhere rather then having to convert it to a mojo IPC representation. We ignore the other config protos in DataSourceConfig because this is just a mapping inside chromium code so only the chromium proto should be in use. In addition we drop the test_config since this typemap is used in production and we don't need to spend time parsing a test config. Change-Id: I043a93925a5f31e05a46d7d1b0cc594191d7b726 Reviewed-on: https://chromium-review.googlesource.com/c/1425615Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629569}
-
Josh Karlin authored
The TopFrameOrigin of a dedicated worker is the top-frame-origin of the page which created the worker. Implemented by moving GetTopFrameOrigin from FrameFetchContext to BaseFetchContext and implementing the overrides in FrameFetchContext, and WorkerFetchContext. The WorkerFetchContext gets the value from its WebWorkerFetchContext, which is overridden by ServiceWorkerFetchContext and WebWorkerFetchContextImpl. The WebWorkerFetchContextImpl's TopFrameOrigin is set by RenderFrameImpl for dedicated workers, so I had to export Document's TopFrameOrigin() to WebDocument as well so that RenderFrameImpl could access it. It's unclear what the TopFrameOrigin of a service worker and shared worker should be so punting on that to bug 918868. Bug: 910713 Change-Id: Ide068c7e55e37633182bff27774472baec463c64 Reviewed-on: https://chromium-review.googlesource.com/c/1394824Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629568}
-
Vadym Doroshenko authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1422003 made changes in NavigationHandleImpl::HasUserGesture(), namely has_user_gestture is not updated on DidCommitNavigation. This CL implements setting has_user_gesture in RenderFrameHostImpl::DidCommitNavigationInternal. It basically returns the previous logic. The current calculation of HasUserGesture is the reason of failure tests on CL https://chromium-review.googlesource.com/c/chromium/src/+/1451999. Namely HasUserGesture() returns true in cases, when it should be false. Example: In test PasswordManagerBrowserTest.PromptForXHRSubmit navigation is done with clicking Submit() button with JavaScript, thus GetUserGesture() should return false. Bug: None Change-Id: Ibff0ec78267e9bace58f49b35818235dc2cd872d Reviewed-on: https://chromium-review.googlesource.com/c/1455957Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#629567}
-
Eric Seckler authored
To help us debug. Bug: 919187 Change-Id: I9d0ac32d046aef3895025dde559fdc7dadf3e136 Reviewed-on: https://chromium-review.googlesource.com/c/1455898Reviewed-by:
-
Mohamed Amir Yosef authored
This CL changes the following: 1- Make ProtocolEvent.ToValue() a member method instead of a static method. 2- Changes most of the methods in ProtocolEvent to be private since there aren't used outside the class. 3- Replaces some deprecated methods. 3- Some general cleanup here and there in the touched files. I suggest starting the review from protocol_event.h and protocol_event.cc This is mostly a mechanical change. Bug: 929100 Change-Id: I32d86265fa1b1ac63af993ff34ef46df18b0c2ac Reviewed-on: https://chromium-review.googlesource.com/c/1456004 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629565}
-
Benoît Lizé authored
This CL adds an "aging" mechanism to parkable strings, and parks "old" strings, regardless of whether the renderer is in foreground or background. The "aging" terminology and mechanism are similar to the swapping logic in the linux kernel, that is: - A string becomes young when it's accessed - Periodically, young strings become old - Old strings are parked Here, the periodic tick only happens as long as progress is made, ensuring that an idle renderer stays idle, and a string can only become old if there are no "users", that is it is neither locked nor referenced externally. From local testing on Linux x86_64, this reduces memory by ~15MB for an active (logged-out) facebook tab, which is ~10% of Private Memory Footprint on the same tab. Total main thread CPU overhead for ~2min of active use of the page is <50ms. See the linked bug for more details and results. This new behavior is guarded by a feature flag which is disabled by default. Bug: 924164 Change-Id: I6ce59c74fd2608b4a2b543d6220e01e7a9ca1b48 Reviewed-on: https://chromium-review.googlesource.com/c/1426784 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629564}
-
Henrique Ferreiro authored
Remove the usage of the IdentityManager Mojo API in favor of the C++ API for consistency with other //chrome/browser code. Bug: 928184 Change-Id: I263a5fd9e5e2991639430b9d1280f88486c20690 Reviewed-on: https://chromium-review.googlesource.com/c/1456058 Auto-Submit: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629563}
-
Hans Wennborg authored
Bug: 926191 Change-Id: If0dd9569cdcae96ed6e2fb5e7844ad62595ded4b Reviewed-on: https://chromium-review.googlesource.com/c/1451840 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629562}
-
Raphael Kubo da Costa authored
Our WebIDL infrastructure has supported WebIDL's default values for optional arguments since 2015, but we were still using the non-standard [DefaultValue] syntax instead. There is no visible side-effect for users: the generated code in the bindings layer will now just stop converting undefined to a boolean via V8 and be slightly faster in that regard. Bug: 924839 Change-Id: I06853a9d8394fb58b97a64d0af3425d883aaa940 Reviewed-on: https://chromium-review.googlesource.com/c/1456064 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Michael Ludwig authored
Bug: chromium:928859 Change-Id: Iba4d946759fbabb70eafb14168e8ed89f6f495b4 Reviewed-on: https://chromium-review.googlesource.com/c/1455028 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629560}
-
Marek Haranczyk authored
Bug: 784904 Change-Id: I29399a9fd75e023b0289216e51eee8033e65d24c Reviewed-on: https://chromium-review.googlesource.com/c/1454492Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: Iecc7ea0a908fb5db3b782649eca6406f8d3c67f0 Reviewed-on: https://chromium-review.googlesource.com/c/1452779 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#629558}
-
Abhijeet Kandalkar authored
This CL replace the use of SigninManager by IdentityManager and removes unused headers. It also replace LegacyXXX() methods by IdentityTestEnvironment class methods. Bug: 926949 Change-Id: Ie776be3de99e1e544fbe5c17330c923114fff594 Reviewed-on: https://chromium-review.googlesource.com/c/1447992Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#629557}
-
Bruno Santos authored
Icon and progress bar from supervision transition screens shouldn't receive focus when a11y is enabled. Bug: b/123904189 Change-Id: Ia24070596dc88917704545b5edc94772e4c66e8f Reviewed-on: https://chromium-review.googlesource.com/c/1454301 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#629556}
-
Amos Lim authored
Rename QueryParams and MultiQueryParams to CacheQueryOptions and MultiCacheQueryOptions in cache_storage.mojom to make names consistent with names in web idl files. Bug: 927704 Change-Id: I1a8ad870852de34d2fc956f230f2731f21b7c2ff Reviewed-on: https://chromium-review.googlesource.com/c/1449444 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#629555}
-
Rayan Kanso authored
In the delegate proxy refactor (crrev.com/1422158), some if statements where changed to DCHECKs. When aborted, some of the Download Service callbacks can still be received due to race conditions. This CL switches the DCHECKs back to if statements. Bug: 850512 Change-Id: I4154070635d5434819c07b394fbfe323ca9fdb9e Reviewed-on: https://chromium-review.googlesource.com/c/1456063Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629554}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/57b81a51..07a4ab04 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3c7999e08104ae50e803d4ffafb5af1d2fec7f0 Reviewed-on: https://chromium-review.googlesource.com/c/1456218Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629553}
-
Koji Ishii authored
Following bot results are included. 14707 14708 14714 14720 14730 14735 14748 14754 14760 14764 14768 0 lines were removed and 2 lines were deflaked by consecutive results since 14699. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I644eca3b0c6fdb0d2453c0c4d28f24a7f634d34d Reviewed-on: https://chromium-review.googlesource.com/c/1454165Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629552}
-
Sigurdur Asgeirsson authored
This is a reland of 8bd694d0 Original change's description: > RC: Move the graph to chrome/browser/performance_manager. > > This moves the resource coordination graph implementation from > the resource coordinator service into > chrome/browser/performance_manager and redirects users thereof. > This is a first enabling step in refactoring, renaming and > consolidating the resource coordinator implementation. As such, > this CL aims for minimal code churn. > > Bug: 910288 > Change-Id: I322a6a1ee3704384838abc3e1953a885ba038466 > Reviewed-on: https://chromium-review.googlesource.com/c/1446814 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628911} Bug: 910288 Change-Id: I83fda8694af03b845aa49b2ba449a18b6804bc12 Reviewed-on: https://chromium-review.googlesource.com/c/1454798Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#629551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87567217cbdc..27a01705d27f Created with: gclient setdep -r src-internal@27a01705d27f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4985f0597f41a18141a474458d24f79f9fdd1b58 Reviewed-on: https://chromium-review.googlesource.com/c/1456316Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629550}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01c24cd1f469..37b7d41d01cb git log 01c24cd1f469..37b7d41d01cb --date=short --no-merges --format='%ad %ae %s' 2019-02-06 reed@google.com Revert "templatize drawString" Created with: gclient setdep -r src/third_party/skia@37b7d41d01cb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I29dcd7e993850e65f7429e847afc083b458a1f41 Reviewed-on: https://chromium-review.googlesource.com/c/1456198Reviewed-by:
-
Etienne Pierre-doray authored
This reverts commit 2362937c. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 628816 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjM2MjkzN2M2NDk0ZWJiOTIwZjc1MjYxZTlkMzRhOGE5M2U5NDJhOAw Original change's description: > [Task Scheduler]: Merge blocking and non-blocking pools. > > This CL removes blocking worker pools from the task scheduler. > Tasks with MayBlock trait are instead posted to the usual foreground/background pool, > giving us better control over scheduling. > > Bug: 874080, 915769 > Change-Id: I9baca2a57080c033f72ed0abd10328d2ff74c912 > Reviewed-on: https://chromium-review.googlesource.com/c/1359302 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628816} TBR=gab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874080, 915769 Change-Id: If56ea01eefea5df3e59e9680489891cbf80d97fe Reviewed-on: https://chromium-review.googlesource.com/c/1455118 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#629548}
-
Jochen Eisinger authored
Code changes from Nate Chapin <japhet@chromium.org> Bug: 926105 Change-Id: I098599394e6ebe7d2fce5af838014297a337d294 Reviewed-on: https://chromium-review.googlesource.com/c/1454962Reviewed-by:
-
arthursonzogni authored
No new navigations are allowed to be created in a pending deletion frame. Something has been forgotten: removing the pending navigations when a frame becomes pending deletion. I wasn't able to reproduce the stacktraces of bug 927705 and bug 926820, but there is a good change this CL will fix them. Bug: 926820, 927705 Change-Id: Ifb97ddc7b233aca827a3c09bd4db4c4b79fa61f7 Reviewed-on: https://chromium-review.googlesource.com/c/1450256Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Internal settings are ScriptWrappable and thus may retain documents depending on whether the garbage collector(s) are able to find the settings object through the Page supplement. Bug: 843903, 928781 Change-Id: I53458c6eb761a98ddc0e437174a233682e442586 Reviewed-on: https://chromium-review.googlesource.com/c/1456001Reviewed-by:
-
Robert Liao authored
Menus on Windows use the Aura colors. BUG=928378 Change-Id: Ib49917e4902f06e2423048a07bea4447e07ecf10 Reviewed-on: https://chromium-review.googlesource.com/c/1455625 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#629544}
-
Antonio Gomes authored
Actual work has been done in https://crrev.com/c/1396240, but a method named OnGaiaAccountsInCookieUpdated is still around (although it does not override GSSM::Observer), which is confusing. This CL unify both AccountInvestigator::OnAccountsInCookieUpdated and AccountInvestigator::OnGaiaAccountsInCookieUpdated methods, eliminating this confusion. BUG=926884 Change-Id: Ifbe0eb301aae966cfbd04ee6cbfcb41f149eb0a0 Reviewed-on: https://chromium-review.googlesource.com/c/1454305 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Ioana Pandele authored
This change adds a controller that is responsible for mediating communication between ChromePasswordManagerClient and PasswordAccessoryController for password generation. It is also responsible for managing the modal dialog used to present the generated password. In the future it will make it easier to add manual generation to the password accessory. Bug: 845458 Change-Id: I0adbb2de9b9f5012745ae3963154f7d3247b3051 Reviewed-on: https://chromium-review.googlesource.com/c/1448181 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#629542}
-
