- 27 Apr, 2017 40 commits
-
-
sdefresne authored
Duplicates configs defined in //build/config/mac/BUILD.gn that are shared with iOS to //build/config/ios/BUILD.gn. Remove all conditions testing "is_mac" or "is_ios" (as they are now known from the filename). Change dependencies on previously shared targets to select the correct target based on the "target_os". BUG=635745 Review-Url: https://codereview.chromium.org/2843493002 Cr-Commit-Position: refs/heads/master@{#467680}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/594d9c9e..3338869a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2845933003 Cr-Commit-Position: refs/heads/master@{#467679}
-
msarett authored
TBR=reed@google.com NO_TRY=true BUG=skia:6464 Review-Url: https://codereview.chromium.org/2844223003 Cr-Commit-Position: refs/heads/master@{#467678}
-
Robert Sesek authored
Don't do work in DCHECKs. BUG=715792 R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2847573002 . Cr-Commit-Position: refs/heads/master@{#467677}
-
xiaochengh authored
There are some valid DOM positions (*) that do not have corresponding valid flat tree positions. This patch adds special handling of such DOM positions, so that when computing VisibleSelectionInFlatTree from SelectionInDOMTree, such positions are converted to NULL instead of invalid flat tree positions, so that the renderer does not crash. (*) If NODE is a direct child of a shadow host but is not distributed into the flat tree, NODE@BeforeAnchor and NODE@AfterAnchor are valid Position but invalid PositionInFlatTree. This patch handles these two kind of positions. BUG=702756, 709872, 712984 TEST=FrameSelectionTest.SelectInvalidPositionInFlatTreeDoesntCrash Review-Url: https://codereview.chromium.org/2850443002 Cr-Commit-Position: refs/heads/master@{#467676}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2843583002 Cr-Commit-Position: refs/heads/master@{#467675}
-
lanwei authored
In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 Review-Url: https://codereview.chromium.org/2839103002 Cr-Commit-Position: refs/heads/master@{#467674}
-
cjgrant authored
This change maps VR controller input to non-content UI elements. The content element is treated separately, so that it can handle scrolling and fling-type input (these are currently not useful to other elements). BUG=715554 Review-Url: https://codereview.chromium.org/2840183003 Cr-Commit-Position: refs/heads/master@{#467673}
-
pmeenan authored
HTML Chunks inserted by document.write() are run through a separate instance of the preload scanner from the main document. If the main document scanner has already discovered an image then all scripts discovered by any preload scanner regardless of where they came from would be considered late-body. This behavior causes a regression where a document.write() in the head that includes multiple script tags will discover them but treat them as late-body scripts and only load them one at a time. reland of http://crbug.com/2826213003 Only change from the original was to fix the layout test. Specifically, the URL for the preload image was not re-used for the actual image which caused the test to issue a console warning about the preload not being used but only if the overall test took long enough for the warning to trigger. Patch set #1 is the original CL untouched BUG=713727, 712338 Review-Url: https://codereview.chromium.org/2826213003 Cr-Commit-Position: refs/heads/master@{#467029} Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7 patch from issue 2826213003 at patchset 70001 (http://crrev.com/2826213003#ps70001) Review-Url: https://codereview.chromium.org/2841363002 Cr-Commit-Position: refs/heads/master@{#467672}
-
hjd authored
We want ultimately to move to a model where memory-infra does not have its own custom thread and instead uses base::scheduler. However this is risky at the moment given the tracing entanglement and the various other refactorings going on. For now we change the logic to never kill the background thread. This will simplify the logic of the MemoryDumpManager significantly and pave the way for us to disentangle tracing. BUG=705564 BUG=702289 Review-Url: https://codereview.chromium.org/2836933002 Cr-Commit-Position: refs/heads/master@{#467671}
-
fdoray authored
TestBrowserThread is deprecated. TestBrowserThreadBundle provides all browser threads, a blocking pool and a TaskScheduler. This CL was generated using the script posted on the bug + git cl format + tools/sort-headers.py + some manual adjustments. BUG=272091 R=gab@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2799883003 Cr-Commit-Position: refs/heads/master@{#467670}
-
neis authored
BUG=chromium:714521 Review-Url: https://codereview.chromium.org/2839913002 Cr-Commit-Position: refs/heads/master@{#467669}
-
dullweber authored
I had the issue that vscode didn't notice file changes e.g. by git cl format. Excluding out/ and third_party/ with files.watcherExclude seems to help. Files per folder: 10934 v8 14436 native_client 17478 data 26470 build 37676 chrome 389528 third_party 426532 out BUG= Review-Url: https://codereview.chromium.org/2847723002 Cr-Commit-Position: refs/heads/master@{#467668}
-
vitaliii authored
Disable org.chromium.android_webview.test.PostMessageTest#testMessageCha nnelUsingPendingPort because it is flaky. TBR=sgurun@chromium.org BUG=715960 Review-Url: https://codereview.chromium.org/2845863004 Cr-Commit-Position: refs/heads/master@{#467667}
-
sullivan authored
BUG=715716 Review-Url: https://codereview.chromium.org/2844793002 Cr-Commit-Position: refs/heads/master@{#467666}
-
bnc authored
spdy/platform/*/spdy_ptr_util{,_impl}.h are almost verbatim copies of quic/platform/*/quic_ptr_util{,_impl}.h. Note "util" versus "utils" in the filenames, despite some other headers are pluralized: this is for consistency with //net/quic/platform/quic_ptr_util and //base/memory/ptr_util.h. (Also note that quic/platform/*/quic_ptr_util{,_impl}.h incorrectly uses std::move in return, which potentially prevents return value optimization, so I'm not doing it here.) Also change most naked new's to SpdyMakeUnique, because clearly, naked new is the devil itself. And add #include <new> for most remaining new (except for the ones that I plan to remove in the near future). This CL lands server change 153775072 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2840563003 Cr-Commit-Position: refs/heads/master@{#467665}
-
tzik authored
base::BarrierClosure calls the given callback object only once upon the Nth invocation of resulting wrapper callback. That means, the wrapped callback should be OnceCallback, and the resulting callback should be RepeatingCallback. BUG=714018 Review-Url: https://codereview.chromium.org/2833293004 Cr-Commit-Position: refs/heads/master@{#467664}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2836083003 Cr-Commit-Position: refs/heads/master@{#467663}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bartfab@chromium.org Review-Url: https://codereview.chromium.org/2836133002 Cr-Commit-Position: refs/heads/master@{#467662}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2835313002 Cr-Commit-Position: refs/heads/master@{#467661}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ac0e705af1d6..56de05fec3fa $ git log ac0e705af..56de05fec --date=short --no-merges --format='%ad %ae %s' 2017-04-26 mtklein add #defines to limit SkCpu Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I4f6463f27b702185e8fe23fd112e6a9d33f783b0 Reviewed-on: https://chromium-review.googlesource.com/488461Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467660}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8062a5765bb7..c46500e9c5b7 $ git log 8062a5765..c46500e9c --date=short --no-merges --format='%ad %ae %s' 2017-04-27 lpy [ESLint] Turn on dot-notation. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9ae6aff18aff11e4bfa7639208b935c1208a9be8 Reviewed-on: https://chromium-review.googlesource.com/488481 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467659}
-
vitaliii authored
TBR=fukino@chromium.org BUG=715961 Review-Url: https://codereview.chromium.org/2844263002 Cr-Commit-Position: refs/heads/master@{#467658}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05751f9b..594d9c9e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2847713002 Cr-Commit-Position: refs/heads/master@{#467657}
-
fmalita authored
DrawLineForDocumentMarker() only has one client (InlineTextBoxPainter), so it makes sense for it to be a private helper. Then we can also remove the DocumentMarkerLineStyle GC enum. BUG=424655 R=schenney@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841153002 Cr-Commit-Position: refs/heads/master@{#467656}
-
zakerinasab authored
Currently, ImageBitmapOptions accepts 'none', 'default', 'srgb' and 'linear-rgb' color space conversion modes. This CL adds 'p3' and 'rec2020' to the list according to https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md. This CL also uses ColorCanvasParams to keep the color space settings. BUG=714266 Review-Url: https://codereview.chromium.org/2836793002 Cr-Commit-Position: refs/heads/master@{#467655}
-
bratell authored
Some "using" statements that were no longer used lingered in the source code so let us remove them. Review-Url: https://codereview.chromium.org/2841923002 Cr-Commit-Position: refs/heads/master@{#467654}
-
vitaliii authored
Because flaky. TBR=nednguyen@google.com BUG=715962 Review-Url: https://codereview.chromium.org/2849513002 Cr-Commit-Position: refs/heads/master@{#467653}
-
lod authored
TBR=marq@chromium.org, eugenebut@chromium.org NOPRESUBMIT=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2845993002 Cr-Commit-Position: refs/heads/master@{#467652}
-
fdoray authored
Protocol handlers are used for navigation. BUG=667892 Review-Url: https://codereview.chromium.org/2845683002 Cr-Commit-Position: refs/heads/master@{#467651}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bartfab@chromium.org Review-Url: https://codereview.chromium.org/2836143002 Cr-Commit-Position: refs/heads/master@{#467650}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=dewittj@chromium.org TBR=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2840643002 Cr-Commit-Position: refs/heads/master@{#467649}
-
wnwen authored
clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 Review-Url: https://codereview.chromium.org/2839753007 Cr-Commit-Position: refs/heads/master@{#467648}
-
rhalavati authored
Network traffic annotation is added to network request of: storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc storage/browser/fileapi/file_system_url_request_job_unittest.cc storage/browser/fileapi/file_writer_delegate_unittest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2845073002 Cr-Commit-Position: refs/heads/master@{#467647}
-
rego authored
Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg BUG=617371 Review-Url: https://codereview.chromium.org/2840183002 Cr-Commit-Position: refs/heads/master@{#467646}
-
tnagel authored
In https://chromium-review.googlesource.com/#/c/32606/ VPD cache files have been migrated to unencrypted stateful and symlinks have been placed in the original locations for backward compatibility. This CL updates the file locations inside Chrome so that we may eventually get rid of the symlinks and can drop the exceptions for them, cf. https://crbug.com/655606. BUG=none Review-Url: https://codereview.chromium.org/1736493002 Cr-Commit-Position: refs/heads/master@{#467645}
-
vitaliii authored
TBR=yoshiki@chromium.org BUG=715963 Review-Url: https://codereview.chromium.org/2848613002 Cr-Commit-Position: refs/heads/master@{#467644}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2841643003 Cr-Commit-Position: refs/heads/master@{#467643}
-
dvadym authored
This CL has only interface for saving sync passwords in PasswordStore and passing this call to PasswordReuseDetector. Implementation is complex and probably will consist of many CLs, but having interface unblocks other parts. Tests will be added with implementation. BUG=657041 Review-Url: https://codereview.chromium.org/2846823002 Cr-Commit-Position: refs/heads/master@{#467642}
-
fdoray authored
[The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Original-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467641}
-