GitLab

CFNetworkExecuteProxyAutoConfigurationURL run loop sources are not
thread safe. Therefore, the following source events should be
synchronized:
1. Adding the source to the run loop.
2. Handling the result of proxy resolution.
3. Removing the source from the run loop.

This change does not prevent the parallel resolution of proxies for
multiple URLs but only prevents concurrent execution of the above
mentioned event, which are supposed to be lightweight operations.

BUG=166387

Review-Url: https://codereview.chromium.org/2094373002
Cr-Commit-Position: refs/heads/master@{#403284}

This jar is a dependency for Robolectric 3.0

BUG=522043

Review-Url: https://codereview.chromium.org/2049543002
Cr-Commit-Position: refs/heads/master@{#403283}

Autofill table:
  * Added billing_address_id column to masked_credit_card table.
  * Bumped version to 67.

Sync:
  * Do not overwrite user's preferred billing address for their server
    card when downloading masked credit cards from the server.

Personal data manager:
  * Added an UpdateServerCreditCardBillingAddress() method to support
    changes from settings.

Android autofill settings:
  * Let users change the billing address of their server credit card.
  * Local and server credit card settings have a common parent and
    re-use common UI elements.

BUG=602663

Review-Url: https://codereview.chromium.org/2109643003
Cr-Commit-Position: refs/heads/master@{#403282}

This CL adds closure compilation to the settings menu directory.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111023002
Cr-Commit-Position: refs/heads/master@{#403281}

BUG=619770

Review-Url: https://codereview.chromium.org/2115653002
Cr-Commit-Position: refs/heads/master@{#403280}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a9f8ed16a47c..44fb68ed1d6d

$ git log a9f8ed16a..44fb68ed1 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2109613006
Cr-Commit-Position: refs/heads/master@{#403279}

its value is the string forced.

BUG=624187,b/29833682

Review-Url: https://codereview.chromium.org/2107033002
Cr-Commit-Position: refs/heads/master@{#403278}

Instead of wrapping the InterfaceRequest<>s in a unique_ptr<> and storing
that in a vector, just store the requests directly.

BUG=none

Review-Url: https://codereview.chromium.org/2107383003
Cr-Commit-Position: refs/heads/master@{#403277}

These jars are dependencies for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2049563002
Cr-Commit-Position: refs/heads/master@{#403276}

This is more accurate terminology. A color space can be represented
by ICC profile. There isn't really such a thing as a "color profile".

BUG=622133

Review-Url: https://codereview.chromium.org/2106303002
Cr-Commit-Position: refs/heads/master@{#403275}

Download was cancelled when a dangerous download infobar is dismissed.
We missed it in the previous CL.

BUG=618864

Review-Url: https://codereview.chromium.org/2111983002
Cr-Commit-Position: refs/heads/master@{#403274}

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this purpose.

BUG=578168

Review-Url: https://codereview.chromium.org/2116593002
Cr-Commit-Position: refs/heads/master@{#403273}

Refactorization CL preparing for OpenGL rendering on Android. Currently
JniDisplayHandler is owned and managed by the Java display object, which
requires passing pointer of the display handler back and forth and makes the
lifetime management of the display handler not very straightforward. This CL
makes JniClient own JniDisplayHandler and makes JniDisplayHandler control
the lifetime of the Java display object instead of the other way around.

BUG=385924

Review-Url: https://codereview.chromium.org/2100943004
Cr-Commit-Position: refs/heads/master@{#403272}

Callers of GetSystemMetrics occassionally need to get system metrics in the
using the HWND's DPI. An example is calculating the client frame using
SM_CXSIZEFRAME. This will be different depending on the DPI of the display.

BUG=426656

Review-Url: https://codereview.chromium.org/2110313002
Cr-Commit-Position: refs/heads/master@{#403271}

BUG=623927

Review-Url: https://codereview.chromium.org/2026483003
Cr-Commit-Position: refs/heads/master@{#403270}

Native heap profiling captures C/C++ backtraces for allocations, but
requires a special build (and a symbolization step).

BUG=602701

Review-Url: https://codereview.chromium.org/2084973002
Cr-Commit-Position: refs/heads/master@{#403269}

Revert of Remove calls to MessageLoop::current() in content. (patchset #1 id:1 of https://codereview.chromium.org/2105173004/ )

Reason for revert:
Failed Browser tests and webkit tests.

Browser tests failed:
DevToolsSanityTest.AutoAttachToWindowOpen
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/26458

webkit tests failed:
inspector/sources/debugger-pause/debugger-pause-on-promise-rejection.html
inspector/sources/debugger/live-edit-no-reveal.html
inspector/sources/debugger-step/debugger-step-out-document-write.html
inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
inspector/sources/debugger-console/debug-console-command.html
inspector/sources/debugger-frameworks/frameworks-sourcemap.html
inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
inspector/sources/debugger-step/debugger-step-over-document-write.html
inspector/sources/debugger-step/debugger-step-out-event-listener.html
inspector/sources/debugger-console/debugger-command-line-api.html
inspector/sources/debugger-step/debugger-step-into-event-listener.html
inspector/sources/debugger-breakpoints/dom-breakpoints.html
inspector/sources/debugger/debugger-return-value.html
inspector/sources/debugger-ui/debugger-inline-values.html
inspector/sources/debugger-ui/reveal-not-skipped.html
inspector-protocol/debugger/stepping-with-blackboxed-ranges.html
inspector/sources/debugger-step/debugger-step-in.html
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html
inspector/sources/debugger-step/debugger-step-into-across-timeouts.html
inspector/sources/debugger-frameworks/frameworks-step-from-framework.html
inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html
inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
inspector/sources/debugger/mutation-observer-suspend-while-paused.html
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
inspector-protocol/debugger/postMessage-on-pause.html
inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
inspector/sources/debugger/live-edit.html
inspector/sources/debugger-frameworks/frameworks-steppings.html
inspector-protocol/debugger/continueToLocation.html
inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
inspector/sources/debugger-step/debugger-step-into-document-write.html
inspector-protocol/debugger/updateCallFrameScopes.html
inspector/sources/debugger-step/debugger-step-over.html
inspector/sources/debugger-frameworks/frameworks-jquery.html
inspector-protocol/debugger/debugger-setBlackboxPatterns.html
inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
inspector/sources/debugger-step/debugger-step-over-across-timeouts.html
inspector/sources/debugger-step/debugger-step-through-promises.html
inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks.html
inspector-protocol/debugger/step-over-caught-exception.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/6394

Original issue's description:
> Remove calls to MessageLoop::current() in content.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
>
> Committed: https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7
> Cr-Commit-Position: refs/heads/master@{#403228}

TBR=jochen@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447

Review-Url: https://codereview.chromium.org/2116643002
Cr-Commit-Position: refs/heads/master@{#403268}

For non-users of Data Saver, show a promotional InfoBar if the following are true:

The user in the DataReductionProxyInfobarPromo field trial.
The user doesn’t have the Data Reduction Proxy enabled.
The user saw the promo in a version >= M51.
The user didn’t opt out of the FRE promo card.
The current version is at least two milestones after the last promo was displayed.
The infobar has never been shown and dismissed before.
The request is HTTP.

BUG=610757

Review-Url: https://codereview.chromium.org/2022313002
Cr-Commit-Position: refs/heads/master@{#403267}

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556

Review-Url: https://codereview.chromium.org/2100653002
Cr-Commit-Position: refs/heads/master@{#403266}

This jar is required to process Roboletric templated code.

BUG=522043

Review-Url: https://codereview.chromium.org/2049503003
Cr-Commit-Position: refs/heads/master@{#403265}

This aligns Chrome with the latest change to the webpush-encryption
specification: https://github.com/webpush-wg/webpush-encryption/pull/7

BUG=

Review-Url: https://codereview.chromium.org/2114703002
Cr-Commit-Position: refs/heads/master@{#403264}

This CL resolves comments in 2055143002 after CL being committed:

* Move Initialize() function to protocol::VideoRenderer interface
* Rename JniFrameConsumer to JniVideoRenderer
* Resolves other comments

BUG=385924

Review-Url: https://codereview.chromium.org/2101833002
Cr-Commit-Position: refs/heads/master@{#403263}

We want IsSet(), not Get(). Get() DCHECKs if null.

BUG=
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2118523002
Cr-Commit-Position: refs/heads/master@{#403262}

- Implements UI for opt-in flow to add checkbox for backup and
  restore.
- Adds a new preference flag to store the user preference for backup
  and restore. This will later on be sent to android via arc bridge
  service.
- Adds strings to be displayed.

BUG=624868
COMPONENT=CrOS Strings, Arc, Arc Opt-In UI, Preference
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2104893003
Cr-Commit-Position: refs/heads/master@{#403261}

BUG=539674

Review-Url: https://codereview.chromium.org/1740243003
Cr-Commit-Position: refs/heads/master@{#403260}

The chromium.mojo.json file no longer exists.
It was folded into chromium.fyi.json in:
  https://codereview.chromium.org/2114453002/

BUG=619128
TEST=NONE
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2111463005
Cr-Commit-Position: refs/heads/master@{#403259}

Intent to ship: http://bit.ly/295ZVHZ

BUG=591394

Review-Url: https://codereview.chromium.org/2108723003
Cr-Commit-Position: refs/heads/master@{#403258}

We were using GN's ordering of libraries, but GN isn't actually
providing them in dependency order. This change adds a TODO to add this
feature to GN, and in the meantime uses readelf to determine library
dependency order (as we used to do).

BUG=624791

Review-Url: https://codereview.chromium.org/2111233002
Cr-Commit-Position: refs/heads/master@{#403257}

I repeatedly find myself looking for constructors taking flags through
unsigned before realizing this is actually a pointer.

Review-Url: https://codereview.chromium.org/2101143005
Cr-Commit-Position: refs/heads/master@{#403256}

- Added links to Android build with information on how to pull Android parts of
  Chromium repo.
- Reordered running instruction to follow the order in which one would use.
- Added infomration on the underlying adb command to use instead of build
  scripts.
- Added information on running the Blimp client in an Emulator.

BUG=

Review-Url: https://codereview.chromium.org/2104003003
Cr-Commit-Position: refs/heads/master@{#403255}

Also records the package names of the apps that cause external navigations
and package names for which the user chose Chrome to handle the URL over
the native application.

BUG=622906

Review-Url: https://codereview.chromium.org/2096073002
Cr-Commit-Position: refs/heads/master@{#403254}

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633

Review-Url: https://codereview.chromium.org/2105843002
Cr-Commit-Position: refs/heads/master@{#403253}

Add a flag for disable fatal linker warnings. The
flag corresponds to the GYP fatal_linker_warnings
option. By default fatal linker warnings are enabled.

BUG=

Review-Url: https://codereview.chromium.org/2119593002
Cr-Commit-Position: refs/heads/master@{#403252}

It's possible that NotifyError() is called between Initialize() and
CompleteInitialization() which would previously result in a null pointer
dereference. Now initialization is completed with an error.

BUG=623740

Review-Url: https://codereview.chromium.org/2109343002
Cr-Commit-Position: refs/heads/master@{#403251}

1) The API works only on text fields
2) ENTER et al. works only on http:, https: etc.
3) onKeyEvent no work in password field.

BUG=517773
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2077783002
Cr-Commit-Position: refs/heads/master@{#403250}

As the bug describes, since ItemChooserLabels' members are public so
their names shouldn't start with m. This CL changes it.

BUG=588158

Review-Url: https://codereview.chromium.org/2109283002
Cr-Commit-Position: refs/heads/master@{#403249}

Move LayoutMenuList's height calculation logic to styleDidChange method as we need to recalculate the height if the page zoom is changed.

BUG=624269
TEST=LayoutTests/transforms/2d/zoom-menulist.html

Review-Url: https://codereview.chromium.org/2108043003
Cr-Commit-Position: refs/heads/master@{#403248}

Autofill_FormSubmitted_NonFillable
Autofill_FormSubmitted_FilledAll
Autofill_FormSubmitted_FilledSome
Autofill_FormSubmitted_FilledNone_SuggestionsShown
Autofill_FormSubmitted_FilledNone_SuggestionsNotShown

BUG=624831

Review-Url: https://codereview.chromium.org/2110393003
Cr-Commit-Position: refs/heads/master@{#403247}

In this case the match exists in native, but not in Java. Ensure we don't
throw in this case.

BUG=624703

Review-Url: https://codereview.chromium.org/2114723002
Cr-Commit-Position: refs/heads/master@{#403246}

Reland of Apply Referrer-Policy header when following redirects (patchset #1 id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17 id:320001 of https://codereview.chromium.org/2100583002/ )
>
> Reason for revert:
> Broke msan tests https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/17218/steps/net_unittests%20on%20Ubuntu-12.04/logs/URLRequestJob.RedirectTransactionWithReferrerPolicyHeader
>
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan: https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg3g/edit
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
>
> TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
>
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chromium.org
BUG=619228

Review-Url: https://codereview.chromium.org/2111623003
Cr-Commit-Position: refs/heads/master@{#403245}