- 05 Nov, 2020 40 commits
-
-
Elly Fong-Jones authored
This change causes menu widgets to be become the active widget if the menu was shown by keyboard. This ensures that the menu widget is announced by screenreaders. There is one special case: editable combobox menus, even if opened by keyboard, never activate since that would pull keyboard focus away from the editable combobox itself. To support that, this change also: * Adds Widget::Predicate, a type for predicates that accept a Widget; * Adds support to MenuCocoaWatcherMac for ignoring certain widget activations; * Adds an IsNotMenuWidget predicate to MenuController for use with MenuCocoaWatcherMac Bug: 1097769 Change-Id: I4f5289d66428f97e75c38e4e887b8ce9061dada8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520141 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824630}
-
Xiaocheng Hu authored
This patch adds an empty StyleRuleCounterStyle class and allows CSS parser to parse @counter-style blocks into the new class. Follow up patches will add the remaining implementation (descriptor parsing, invalidation, resolution, etc). Bug: 687225 Change-Id: Ib78f70763eaf419ba004f17e36deff3636202651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515788 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#824629}
-
Ken Buchanan authored
Initial WebID CL. This adds the JS bindings, mojo pipe, and a minimal handler for a federated sign-in request which inherits FrameServiceBase. Explainer: https://github.com/WICG/WebID/ Intent to Implement: https://groups.google.com/a/chromium.org/g/blink-dev/c/2B4TJ7j2U4M/m/1X5T3OszCAAJ To view a tentative implementation of the Mojo method introduced here, see: https://chromium-review.googlesource.com/c/chromium/src/+/2134593/ Bug: 1141125 Change-Id: Ie492d86af66b6853141a47362ea3d0c191dad548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134202 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824628}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/AcCtRanvaMTsszg Bug: 889763 Change-Id: I10a3921e566a3764199f64ae6ad78365a267666d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517163 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824627}
-
Tibor Goldschwendt authored
Third-party NTPs should be committed to site instance of chrome-search://remote-ntp. Bug: 1075714 Change-Id: I63fc559dd0a0e75483d35c0b16465c7bf3ac187c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515224Reviewed-by:
-
dpapad authored
Previously scrollbars always appeared light, even if a WebUI page was otherwise respecting dark mode. The upcoming FormControlsDarkMode feature allows webpages to specify whether scrollbars should follow the system's theme, by specifying a new <meta name="color-scheme"> tag. Repro instructions 1) Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode 2) Go to chrome://inerstitials and open any interstitial category, observe scrollbars. 3) Go to a non-existing page (eg chrome://foo), observe scrollbars. Bug: 1142291 Change-Id: If85d49dcfe7eeb404eb4a472ce8a1dee135e57ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521219 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#824625}
-
Xiaodan Zhu authored
This CL changes the direction of switching desk gestures when enhanced desks animation is enabled. The alert toast is shown when the user performs the wrong gestures on the first and last desks. Test: manual. Bug: 1140242 Change-Id: Ie67e3fb8ff4cea9afc6417e70046533077e09750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520238Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824624}
-
Piotr Bialecki authored
Change-Id: I90e2042346f60df180f1e7a5d310ef945e40f44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521222 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824623}
-
Scott Lee authored
urllib2 doesn't support connection pooling. Therefore, each of sink() invocation creates a new TCP connection established. It seems that Linux and Mac establish TCP connections much quicker than Windows. However, creation of TCP connections added a significant amount of delays to blink web test runs in Windows bots. This CL solves it by using requests, which uses urllib3 and supports connection pooling. R=robertma@chromium.org CC=chanli@chromium.org,bpastene@chromium.org,nodir@chromium.org,zhaoyangli@chromium.org Bug: 1141606 Change-Id: I5fc63894ed31867db1ae1b4eac5a44b5e0921c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520088 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#824622}
-
Dirk Pranke authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/843b5003..53d92014 53d92014 Apply path search logic more generally Tbr: brucedawson@chromium.org Bug: 1112471 Change-Id: I782479528ecf78b8a74c2f1b89e83797c3b136ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522192Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#824621}
-
Peter Kvitek authored
NO_WIN_FLAKES #ifdef replaced OS_WIN #ifdef when major stability issue that affected significant amount of tests on Windows was identified and fixed. Since tests appear to be stable for more than a month, it's time to remove this leftover define. Bug: 1045971,1045980,1090801,954398,867447,884095 Change-Id: I10b534799b1fc6bee1b11a23a0897e28fb7ec8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522313Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824620}
-
Chris Cunningham authored
Bitstream conversion is not currently needed. Leaving some breadcrumbs about why and a dcheck to catch any changing needs. Bug: 1119947 Change-Id: I20ba56bdde467c25461b687049f7a143185c7ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521348 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#824619}
-
Changwan Ryu authored
Design doc (internal): go/cursor-control-magnifier 1) Plumbing to forward cursor control gesture to RWHVA. 2) Temporarily hide insertion handles when magnifier is showing. Note that we are not calling SetAlpha() since OnInsertionChanged() will reset the alpha before the cursor control ends. 3) Reuse existing logic for selection popup controller to enable magnifier and haptic feedback. Bug: 1134492 Change-Id: I2312283a4baa775ac70d89431d444d48fff7b242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424900Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824618}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac59b0e049f7..5689d6741bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id97167c9ee3a5a0ae1829a56d00fe2d9c96533c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824617}
-
Sammie Quon authored
This gives a general idea of how long the videos saved on file are. I looked into adding a test (ps1), but with the multi-threading and async operations I'm afraid it would be flaky, plus it saved some recording files locally. Test: manual Bug: 1140182 Change-Id: Ib471d6eae0a8c49321984d941fb0775f49ca11a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519853Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#824616}
-
Devlin Cronin authored
Pull the logic to load and localize a file out from ExecuteCodeFunction. This will be useful in the upcoming scripting.executeScript() API. This CL has no functional changes. Bug: 1144839 Change-Id: I587aa928a9526ae494a6208ba5debb7789f5c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518113 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824615}
-
Devlin Cronin authored
GetOverrideChannelForActionType() was used to generate a channel override if one was needed for a given action type, which was necessary when the "action" key was channel-restricted. Since it's now available on all channels, we can remove this method. Bug: 893373 Change-Id: I6a47eb93c2becf6df3cdcaef76b29ff7e75387ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473063 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad54c71632cc..3476ca348bd0 2020-11-05 amaiorano@google.com Subzero: fix invalid arg access on Windows x86 for split variables 2020-11-05 amaiorano@google.com Subzero: fix non-deterministic stack layout and code-gen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1e03d21535681fdbdf25360d7399803325e32c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521992Reviewed-by:
-
Xida Chen authored
Currently the canvas and JSAnimation tracker isn't reporting to UMA. The problem is that after we set HasCanvasInvalidation and HasJSAnimation on the main thread, we didn't push to the impl thread, and thus there is no tracker started. This CL fixes the problem, also added to UKM so that we will also receive data for UKM. The original doc for collection UKM is here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit#heading=h.k5jx6iluw4yt Bug: 1141901 Change-Id: I0e1b0aaad8e35e2e8ab77356a81487782ad9ebde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497464Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824612}
-
Mikel Astiz authored
The metrics continue to be relevant to monitor the reuploading of bookmarks. Change-Id: I330b96ab95402b701cea5540fddaf35c925d6d8e Bug: 1104998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518046Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824611}
-
Eugene But authored
This CL adds 2 new histogram. One for cert policy cache stored for Tab and one for all Tabs. Bug: 1140990 Change-Id: I03de0330759915974b4c89ceb7ee929d0118a53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519153 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824610}
-
Peter Boström authored
This experiment is default-enabled and being launched to 100% stable. Bug: 1002162 Change-Id: I1b0927ceb51d41fd298d94f4e0e2fdcd31205168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520813 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824609}
-
Torne (Richard Coles) authored
This is a reland of cdc6f38e Original change's description: > android: upstream missed manifest changes for Q/R. > > On Q+ we disabled audio capture as we have no way to selectively disable > it for incognito tabs, but this was missed when upstreaming Q. > > Chrome needs QUERY_ALL_PACKAGES permission on R+ to check for any > possible intent handler for URLs. This was added downstream but missed > while upstreaming R support; add it now. > > Bug: 948282, 1042023 > Change-Id: I4136beddcba0227ef6cfc2073f90d645151ce6bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507575 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823642} Bug: 948282 Bug: 1042023 Change-Id: I1eafcc9cf9398d2ae9c2e4ee3bcc5891354f954e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521077 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#824608}
-
Katie Dillon authored
Currently you can request a reference to the MainThreadTaskQueue as well as the underlying TaskQueue from the SchedulerHelper. In all cases, the TaskQueue is only used to directly get the TaskRunner. We don't need to return the TaskQueue here so this change returns a reference to the TaskRunner instead. This CL is a follow-up to this CL[1] and removes a spot where we need to return a raw pointer to the underlying TaskQueue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Bug: 1143007 Change-Id: I40e751f77447c54961c0102ddb596ddcfb035f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519718Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#824607}
-
Morten Stenshorne authored
Fixed by CL:2519715 TBR=ikilpatrick@chromium.org Bug: 829028, 1091797 Change-Id: I9fc33e490b1990fddd72b7321052c90e28d35597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522073Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824606}
-
Sean Harrison authored
Add new flag for the cookies page redesign. Change-Id: Ia1b98c74f77c34c9169282b2a981a7006a444c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510272Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Brad Lassey <lassey@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#824605}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5689d6741bc4..e3fee63a19d6 2020-11-05 treehugger-gerrit@google.com Merge "tracing: Deflake QueryServiceState test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7cf0b24377cbf55c969f85f7f7773c37aa9892aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521995Reviewed-by:
-
Michael Hansen authored
FastInitiationManager causes a crash when StopAdvertising() is called because we move the callback parameter twice. This fixes the issue by storing the callback as an instance variable. Bug: 1145850 Change-Id: I5d5f305b558e60e55d0df248305c6da03e15378e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521837Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#824603}
-
Nohemi Fernandez authored
Adds a notification showing the user's email and avatar when cookies have been re-generated for their account. Bug: 1145592 Change-Id: I4a74c38f15a17ef9ec8d85632ca8b95dbca3fed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520996 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#824602}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26705ac9bdf3..f6834b901326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145307 Tbr: xialinyan@google.com,smcgruer@google.com Change-Id: I819e51c0549a1d6cecb13a578f44c53a9479dd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521996Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824601}
-
Liquan (Max) Gu authored
Changes: * Corrected 2 typos. * Removed unused methods in PaymentUiService. * Turned ChromePaymentRequestService.mIsOffTheRecord into a local variable. * Simplified triggerMinimalUI control flow. Change-Id: I142e7d9e807419fae71e05d00b92a6ff50d30c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519899 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824600}
-
Yuheng Huang authored
Doc: https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc Usage: tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#824599}
-
Stefan Zager authored
During a BeginMainFrame(), LocalFrameView::UpdateAllLifecyclePhases will always be called while a DocumentLifecycle::AllowThrottlingScope is on the stack. Outside of a BeginMainFrame(), there are situations where we do a "force-unthrottled" lifecycle update, meaning that throttled frames are forced to run the update because there is no AllowThrottlingScope on the stack. We do this, for example, when performing a hit test that requires up-to-date layout, even in throttled frames. The thesis of this patch is: a force-unthrottled update should never paint. It may update the lifecycle to any state prior to paint, but it should not paint. This is an important axiom, because it enables a nice optimization: during a force-unthrottled update, a frame that would be throttled during a full, throttling-allowed update can skip paint invalidation. This is true because a force-unthrottled update *cannot* paint, so paint invalidation is unnecessary. This patch adds AllowThrottlingScope to LocalFrameView::UpdateAllLifecyclePhases, and it prevents side-channel violation of the only-paint-when-throttling-allowed axiom by adding this to LocalFrameView::UpdateLifecyclePhases: DCHECK(DocumentLifecycle::ThrottlingAllowed() || target_state < DocumentLifecycle::kPaintClean); The bulk of the code change is updating our test code to be more consistent with how we run lifecycle updates. In particular, any call to UpdateAllLifecyclePhases in test code should mirror, as closely as possible, the behavior of a full BeginMainFrame(), which means that LocalFrameView::RunPostLifecycleSteps() should also run. This patch adds LocalFrameView::UpdateAllLifecyclePhasesForTest(), and updates all call sites in test code to use it consistently. Finally, this CL cleans up the usage of AllowThrottlingScope, by removing unnecessary instances of it and getting rid of the DocumentLifecycle& parameter to the constructor, since it is unused. Change-Id: I64b6e19e983f5882e035824f995cb0bfc5f4e2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518095Reviewed-by:Yi Xu <yiyix@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#824598}
-
Javier Fernández García-Boente authored
The CSS Text 3 specification states on its 'Phase II: Trimming and Positioning' section: https://www.w3.org/TR/css-text-3/#white-space-phase-2 3- A sequence at the end of a line of collapsible spaces is removed, as well as any trailing U+1680 OGHAM SPACE MARK whose white-space property is normal, nowrap, or pre-line. 4- If there remains any sequence of white space and/or and/or other space separators, at the end of a line: If white-space is set to pre-wrap, the UA must hang this sequence. It may also visually collapse the character advance widths of any that would otherwise overflow. Summarizing, other space separator are not considered as collapsible spaces and should be hang, or broken in case of 'break-spaces', according to the value of the 'white-space' property. This CL tries to implement such behavior, since we were not considering this kind of spaces in the hanging/collapsing logic. For now this change affects LayoutNG only, but it'll be implemented for Legacy in a different CL. Bug: 972952 Change-Id: Idb0aff05f7f423f5b62f5169177c0240917435a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687411Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#824597}
-
Andre Le authored
Ensure we don't accidentally log PII by only logging the size. Bug: 1106937 Change-Id: I428ac50ea33b6bc5780fcf0fc47ca92cb151a612 Fixed: 1143033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522190 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824596}
-
Dale Curtis authored
Finally got around to generating test media for this issue... and it looks like the original fix was incomplete! We didn't read the full box header before parsing CoLL and SmDm atoms. R=cassew Fixed: 1123430 Test: Updated unittest. Change-Id: I7aca462f623cd12cb4842c2cfa1b0b9758ba2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518898 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824595}
-
Bo Liu authored
kWebViewEnableVulkan is renamed to kWebViewDrawFunctorUsesVulkan. It is set automatically when webview detects on start up that hwui is using vulkan composite. This flag is then passed to renderer and gpu processes. Add kWebViewVulkan and default to true, and add it to webview dev ui. This only takes effect if kWebViewDrawFunctorUsesVulkan is set, and controls whether to use gl interop or vulkan composite. So with this patch, the control is mainly in hwui. If hwui uses vulkan, then webview will use vulkan composite. But it also allows the user to manually fallback to gl-interop path. Also force enable skia renderer and viz if hwui uses vulkan. Bug: 1141683 Bug: 1141686 Change-Id: I53b7ae0da22884fab3cd1a401baec057c4eda241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513786 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824594}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e5e8e66e9b4f..a2d6b31f66f5 2020-11-05 ethannicholas@google.com Additional SkSL benches 2020-11-05 michaelludwig@google.com Use GrTBlockList instead of SkAutoSTMalloc to reduce GrAtlasTextOp size 2020-11-05 johnstiles@google.com Allow constant propagation for negated constant-vectors and ints. 2020-11-05 michaelludwig@google.com Compact fixed state tracked in GrAtlasTextOp 2020-11-05 fmalita@chromium.org [svg] Minor parser tweaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Ie75d6dea0f30a224c706d01c0157b76b183da114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521774Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c07bd2f23d7e..56ea854ec5e7 2020-11-05 lexa.knyazev@gmail.com Metal: Allow unswizzled BC1 RGB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I21110865b4ce509359c163a64b039795af0a50b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521634Reviewed-by:
-
Mason Freed authored
This CL implements most of the suggestions from [1], which effectively block declarative Shadow DOM from being used by any fragment parser entry point, unless an explicit opt-in is toggled. The opt-ins include: - DOMParser.allowDeclarativeShadowDom = true; - HTMLTemplateElement.allowDeclarativeShadowDom = true; - XMLHttpRequest.allowDeclarativeShadowDom = true; - DocumentFragment.allowDeclarativeShadowDom = true; - Document.allowDeclarativeShadowDom = true; // For innerHTML - A new <iframe> sandbox flag: allow-declarative-shadow-dom This mitigates the potential client-side XSS sanitizer bypass detailed in the explainer and at [1]. Assuming these changes are functional, and mitigate the issue, this new behavior will be folded into the spec PRs at [2] and [3]. But given the security implications of the existing code, I'd like to get this landed first. [1] https://github.com/whatwg/dom/issues/912#issue-733465826 [2] https://github.com/whatwg/html/pull/5465 [3] https://github.com/whatwg/dom/pull/892 Bug: 1042130 Change-Id: I088f28f63078a0d26e354a4442494c0132b47ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513525 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824591}
-
