- 08 Jan, 2020 19 commits
-
-
Hiroki Sato authored
http://crrev/c/1978202 fixed the scaling computation, but ArcAccessibilityHelperBridge::OnGetTextLocationDataResult left unchanged. This method is used in Select-to-Speak to get text location, so we also need to fix it. This CL also refactors bounds computation and adds a new file geometry_util. Bug: b:129680977 Test: manual. (ChromeVox, HighlightInputFocus and S2S with various scale) Change-Id: I091d5a91e083d160b4c20af0529744b9b0613eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980265 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#729166}
-
Jarryd authored
Give an option for users to delete all site data with two button clicks instead of having to go through the entire list and deleting site data for each siteGroup individually. Bug: 997258 Change-Id: I41d655eaa8dc0d5f4e6bd440658f0bc79f6921cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902240 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729165}
-
Sebastien Marchand authored
This changes the traits of the task posted on Windows in SysInfo::GetHardwareInfo to make sure that this task doesn't block shutdown. On Windows this task relies on WMI which can take a really long time to initialize (several minutes in some situations) and so it's better to use the CONTINUE_ON_SHUTDOWN traits. Bug: 1035617 Change-Id: Iaba73c20d3e20a1affbb05bb89b5cd08e2618f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988223 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#729164}
-
nancy authored
Update ChromeLauncherController::GetArcWindows to use app_service_app_window_controller_'s GetArcWindows to get the ARC windows. b: 146758198 Change-Id: I12626c31f8e297a10c35d7e4d0e9de77815e6982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989291 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729163}
-
Xianzhu Wang authored
Same as blend mode, backdrop filter also uses the backdrop as an input, so when we synthesize a mask clip for a backdrop filter, we also need to move the backdrop filter up to the outermost mask isolation effect node. Now use the same code path previously for delegated blend modes also for backdrop filters. Different from blend mode, a backdrop filter has geometry which needs a proper transform space which may be different from the transform space of the synthesized clip. To deal with this, the synthesized clip layer needs to transform the clip operations. Bug: 923429 Change-Id: I6294dc6ec68a6fe0e7966bdae69fd5b5754fb965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977892Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729162}
-
Avi Drissman authored
Bug: 1037126, 1037495, 1037496 Change-Id: I5d0a48748b7c7f1ef8491a67d3a0651ca678c468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987291 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#729161}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5147e51f226..d065442915f4 Created with: gclient setdep -r src-internal@d065442915f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1031642 Tbr: jbudorick@google.com Change-Id: I9a04f71e88dcac08fdcf2d4b65ff7e055fa220f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990407Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729160}
-
Jing Wang authored
1. Every time we add a keyset string to hash tags, we remove any existing keyset string. 2. Because of the change 1, we may produce exact same hash tags for two consecutive calls, which may result in frondend not reloading the correct layout. Therefore, we add a timestamp at the end to make sure frondend will always reload. 3. Update tests as well. crbug/968027 is fixed. Bug: 968027 TEST: Tested with local ChromeOS emulator run on Linux, verified that Change-Id: I223bcf80130bf0a67ee67015b853024a793a1e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980250 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729159}
-
Xiaohui Chen authored
This reverts commit dabaa28e. Reason for revert: UX wants a different behavior BUG: http://crbug.com/1039787 Original change's description: > Fix in app shelf style for Assistant launcher UI > > With the Assistant launcher UI and new shelf design feature turned on, > if the Assistant is triggered in tablet mode the shelf style will be > changed back to "home shelf". > > Added an additional check in ShelfConfig for the Assistant state to > handle this case. > > Bug: 1026727 > Test: Manual Test > Change-Id: Ie9ca0980583117e5b17d21fa9257f91f3ebe5647 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975114 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726929} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1026727 Change-Id: Iaae20490e2db0154985d692f96f09f922a7b05ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990261Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ifbf30f525f2d3ba72d8664af1a67d7d3d1c0d154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973816 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#729157}
-
Jesse Schettler authored
Remove base::BindLambdaForTesting() and simply use QuitClosure() in PrintPreviewHandlerTest. Test: PrintPreviewHandlerTest Change-Id: I45ba2b31b6ec519d9ec332d9fa24cbab7e27de51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989856Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#729156}
-
Markus Handell authored
I looked for usage of parameters named _callback and _cb and found that the usage of _cb surpassed the use of _callback with 56 occurrences compared to 42 for _callback. This change standardizes all callback parameter names to be suffixed with _cb. Bug: 1013590 Change-Id: I438c1f571d6c0064787c0bec416aefbdf450b0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978800 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#729155}
-
Devlin Cronin authored
The time has come. Bug: None Change-Id: Ia6c1076a5aa9bf1c98277158ee86e826a316916c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988566Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729154}
-
Stephen Nusko authored
This reverts commit 37d4e0ca. Reason for revert: Pinpoint can't repro and it did go green right before disable. Original change's description: > Disable linkedin tests on rendering.mobile benchmarks for android. > > rendering.mobile/linkedin_mobile_2018 > rendering.mobile/linkedin_mobile_pinch_2018 > rendering.mobile/linkedin_pathological_2018 > > NOTRY=true > TBR=crouleau@chromium.org > CC=sadrul@chromium.org,vmiura@chromium.org > BUG=1039281 > > Change-Id: I9bea0c7a94a7304deddda4ab551e0f5f5a98c358 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988357 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728544} NOTRY=true TBR=crouleau@chromium.org,nuskos@chromium.org BUG=1039281 Change-Id: I52bac85509b511a32cea26db227cf4c37c0b6d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989751 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#729153}
-
Mitsuru Oshima authored
* Changed FillLayoutManager so that it only update the bounds if the window is set to be maximizable. * Make WallpaperWidget maximizable. Bug: 1036047 Test: covered by unittets Change-Id: I926ebfa0e890500b9a54603959c0a6702e6d0b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978557Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729152}
-
Alison Maher authored
Mac has a different meaning for high contrast than Windows forced colors mode. As such, forced colors on Mac should not be based off of the value of high contrast within NativeTheme. Bug: 1039737 Change-Id: I1e400a3102efc1090ab2486457cf287dc10044fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988296 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729151}
-
Miguel Casas authored
This CL adds expire-never to the Media.MojoVideoDecoder.Decode histogram since they are used in ChromeOS test infrastructure: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/platform/tast-tests/src/chromiumos/tast/local/bundles/cros/graphics/webrtc_video_playback_delay.go;l=79?q=webrtc_video_playback_delay.go Bug: 1039553 Change-Id: I3b10744eedd78a4a2c6d593045022a4c12a425e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989509 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#729150}
-
Gauthier Ambard authored
This CL changes the expiration dates of the histograms, as they are still relevant. It also updates the owners as mrsuyi is no longer in the team. Fixed: 1036907, 1037372, 1037605, 1037373 Change-Id: Icbecd3ca793d3e536c1a866644a2715528dbb4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982547 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Bug: 1037209 Change-Id: I015d43ff6426a7fc1d58dfbe723e432fcc57fb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990246Reviewed-by:
-
- 07 Jan, 2020 21 commits
-
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1023677 Change-Id: Icbc9147a773af0b6b7d440250c348d8baf9e6d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957536 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729147}
-
Peter Boström authored
Adds ExtensionsToolbarContainer::ShowWidgetForExtension which pops out the corresponding extension icon before anchoring and showing the widget. Follow-ups will consolidate other bubbles to use this call site as well, this is intended to be the funnel through which all extension-related widgets show. Bug: chromium:943702 Change-Id: I86e885583e0f3295c964c6eeebf26c2b541d472b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978849 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1961043388e6..3a797afd61ff git log 1961043388e6..3a797afd61ff --date=short --first-parent --format='%ad %ae %s' 2020-01-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@3a797afd61ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0fa1b74d305290a645bb470fa257745ef35a6c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729145}
-
Daniel Murphy authored
R=enne@chromium.org Bug: 1039446 Change-Id: Iac1a5e227639441831510c7fd74b5c74bf98fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989987 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#729144}
-
Hitoshi Yoshida authored
Default empty dictionary "{}" for optional argument with union type was taken as a string value, and it generated union_member.SetString({}) and it is somehow compilable, unfortunately. This CL fixes the behavior. Bug: 907749, 1039604 Change-Id: I6bea082e208bbbe3be156687e3ede916e9a042e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989725 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#729143}
-
Dale Curtis authored
Since we started allowing asynchronous stop of media::PipelineImpl, we have released the DefaultDecoderFactory on the media thread assuming it was safe to continue usage after ~MediaFactory. It turns out this is not the case for the MojoDecoderFactory used by DefaultDecoderFactory. To fix, we now neuter the DefaultDecoderFactory in ~MediaFactory to prevent decoders from being created. This is done under a lock since the decoder creation methods are called from the media thread and ~MediaFactory happens on the render thread at time of ~RenderFrame. R=xhwang Fixed: 1029865 Test: Existing tests all pass. Change-Id: Ie214fb5eee12dd76a1d21e10497d2cb96ed0397a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990200 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#729142}
-
Weiliang Chen authored
Add a helper class to schedule a task directly on the gpu thread. This is to be shared between the output surface and other users (overlay processor in the future). This class should be a thin wrapper around |SingleTaskSequence| in the future when we no longer use a command buffer inside viz. This is CL 1/? for send the overlay candidate directly. R=rjkroege TBR=kylechar@chromium.org, boliu@chromium.org Bug: 979788 Change-Id: Ifc35b49c7211d366a8786680056c71cdd338997a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985299Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#729141}
-
Andrew Grieve authored
Causes "git cl format" and "git cl upload" presubmit checks to format changed lines in a review to adhere to our style guide (PEP-8). Bug: 846432 Change-Id: I5bfcb5df0515e32d8eed71d85f693abf0bf11a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989035 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729140}
-
Jeremy Roman authored
Portals share the outer web contents infrastructure but aren't known to GuestViewBase, so this was previously causing a null pointer dereference when a constrained window, such as for HTTP basic authentication, is required. This affects all desktop platforms, but not Android. Bug: 1038584 Change-Id: I1591b9124012b4573bcff07460d8bb2e04ad1396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986918Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729139}
-
Ian Clelland authored
Bug: 1039813 Change-Id: I21210abdac33eac00fd8f04d9ab556949ac088a9 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990335Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#729138}
-
Vladimir Levin authored
This patch adds two null checks for client_ reference to debug the referenced bug. The justification for the two checks: - If the ctor check triggers, we will know the call site for when we're passing a null reference - If the second check triggers, but not the first, then we'll know that something strange is happening that the reference becomes null after construction - If neither one triggers, but the original crash triggers, we will know that it is not a danging client_ reference (and we can remove the checks) R=pdr@chromium.org Bug: 1033240 Change-Id: Idac43114221950f542bbf138bed9e6c9edc20784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990193Reviewed-by:
-
Maksim Ivanov authored
Add a browser test for the scenario when Chrome is launching without network connectivity and sign-in screen extensions are configured via device policy. This tests the functionality added in https://crrev.com/c/1943146. Bug: 1012892 Change-Id: I4d3e60606f971f84ecc1e0b613c0cd8d7b9afb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986079 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#729136}
-
Karan Bhatia authored
This is no longer used after https://chromium-review.googlesource.com/c/chromium/src/+/1927037. BUG=696822 Change-Id: I7c59ff04222f0a2a8d463aa6216b1bbd551fdb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988768Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729135}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the ChromeContextMenuPopulatorTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). This is a new style of test, where only on Android the native unit test calls up into java to run the java unittest. The main benefit of this is a java unittest that's able to run native code and doesn't restart the Activity between tests so it's really fast. Note that robolectric can't be used for tests of this style, so it can't be used for everything. I also fix various erroneous test expectations caused by the UrlUtilities mock returning the wrong values for various URLs. Bug: 783819 Change-Id: Id490571f7b7debce7280311f091dc4f2696edab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965918 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729134}
-
Haiyang Pan authored
This reverts commit d0f4dea2. Reason for revert: Caused flaky test results in chromeperf (crbug.com/1039259) Original change's description: > [perf] Switch pixel2 webview to Android App Bundles > > Bug: 986990 > Change-Id: Ie86239ed57a6cbdc77aed65924c256fd2af21dc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959661 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#728993} TBR=crouleau@chromium.org,hypan@google.com Change-Id: Icbb1dcad946d3bdc6a04e3fe32808e5ae01a537b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989999Reviewed-by:
-
Karan Bhatia authored
It just shares some of the function names but doesn't use the capabilities provided by RulesetMatcherBase. Also, we are planning to introduce some pure virtual functions to RulesetMatcherBase which don't make sense for RulesetMatcher. BUG=696822 Change-Id: Ib0d72ab1e98dec72709673e5636bd72628a82b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989225Reviewed-by:
-
Bence Béky authored
Change-Id: I3f8a2040b36d74dc362c33b778bab5ea6d2be207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988938 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#729131}
-
Daniel Cheng authored
Change-Id: I30f0bc091ba69de0e9933d663546e9712a2a349b Bug: 974061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977696 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729130}
-
Ian Clelland authored
An incorrect assumption about the possibility of seeing these thread priorities on pre-10 Windows led to several tests crashing on the Win7 debug bots. Bug: 1039698 Change-Id: Idada66b9faa3b5e43199dbed1a339cdd5af9e6a5 TBR: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990192Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 14ac66bd. With Chromium commits locally applied on WPT: 9d172709 "[webnfc] NDEFScanOptions#mediaType being undefined means do not filter" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idc02e78a430ebbddbab16be00114ad613d74ee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989928Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729128}
-
Eugene Zemtsov authored
Added metrics: Media.MojoVideoDecoder.InitialPlaybackErrorCodecCounter Media.MojoVideoDecoder.InitialPlaybackSuccessCodecCounter Change-Id: I190445314b4c5b3a0f587031c86a94cbde1e02b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981129 Commit-Queue: Eugene Zemtsov <ezemtsov@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#729127}
-
