- 20 Nov, 2017 40 commits
-
-
jdoerrie authored
This change replaces usages of the deprecated base::Value::GetType() in //chrome with base::Value::type(). Bug: 646113 Change-Id: I530efad268c056156874689d8c1c1088ec7dffac Reviewed-on: https://chromium-review.googlesource.com/779187 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517899}
-
Peng Huang authored
For Classic Ash, ArcVideo*Accelerator and ProtectedBufferManager interfaces are implemented in GPU process and requested from browser process. And the the message pipes for ArcVideo*Accelerators interfaces can be forward from the browser process into ARC container. This CL adds CreateArcVideo*Accelerator() and CreateProtectedBufferManager() methods in viz::mojom::GpuService. Those methods can only be used by the ui(window server) process via the viz::mojo::VizMain interface. This CL also adds a new ui::mojom::Arc interface. It is exposed from ui process, and can only be used by browser process. For mushrome, the workflow is, ARC requests ArcVideo*Accelerator interfaces from browser process, and then browser process requests ui::mojom::Arc interface exposed by ui process and then uses the ui::mojom::Arc to create the ArcVideo*Accelerators interfaces implemented in viz process, and then forwards the message handle for ArcVideo*Accelerator interface to ARC. The workflow looks like: [ARC]<--arc.mojom.ArcBridgeHost-->[browser]<--ui.mojom.Arc-->[ui]<--viz.mojom.GpuService-->[viz] Test: Test ARC youtube on device Bug: 769755 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If8ff4aeeffc378d12bd86161bf705497bcfc28e5 Reviewed-on: https://chromium-review.googlesource.com/759092Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#517898}
-
Scott Violet authored
A couple of bounds calculations used bounds().x(). bounds() is relative to the parent, where as these calculations are meant to be relative to the tree. So, they shouldn't use bounds().x() and should instead always be 0 based. BUG=779983 TEST=none Change-Id: I92ffd99c9c7caef25b06bb7bdf3c05bbae466775 Reviewed-on: https://chromium-review.googlesource.com/777768Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#517897}
-
Evan Stade authored
more place in NativeNotificationDisplayService Bug: 786866 Change-Id: I908f8db4e75f5fba6d1082c98e4a491da0dc148e Reviewed-on: https://chromium-review.googlesource.com/779759Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#517896}
-
Xiaocheng Hu authored
This patch wraps code in ComputeInlineBoxPosition into a new function, so that the code flow becomes clearer. Bug: 771398 Change-Id: I6b702f736fe7e21b454aa207180aebadeba63699 Reviewed-on: https://chromium-review.googlesource.com/777702Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517895}
-
Hidehiko Abe authored
BUG=739622 TEST=Ran trybots. Change-Id: I6b2d0fc454c6915449c3955b83c5b954119b0626 Reviewed-on: https://chromium-review.googlesource.com/768928Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517894}
-
Ian Vollick authored
With these CL the permission indicators have their colors and visibility determined by bindings to model properties. Bug: 768512 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4aff56e1a5e986ad11cb157f47b5e86a800c5084 Reviewed-on: https://chromium-review.googlesource.com/779240Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517893}
-
Mostyn Bramley-Moore authored
The markdown renderer used here fails to handle this non-ascii character: https://chromium.googlesource.com/chromium/src/+/3224cfecf5bcdd37378f54ec1751d790c79cb00f/docs/new_port_policy.md TBR=jam@chromium.org Change-Id: I82511db8e377488d87be767fe0b15dbcacb7e04e Reviewed-on: https://chromium-review.googlesource.com/779124 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#517892}
-
Lei Zhang authored
By spamming it with DCHECK_CURRENTLY_ON() everywhere. Since no DCHECKs failed, delete the lock and all the related code that assume the class can be accessed on other threads. Add threading checks to ZoomController as well. Change-Id: I04f8315eaebd5839889a771fd5c13bf43c4d8f31 Reviewed-on: https://chromium-review.googlesource.com/762529Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517891}
-
Peter Wen authored
Only increment stability proto renderer crash rate if the crash dump is valid. BUG=786992 Change-Id: I63e4d24bdd9d258775bba21b611414770424d57c Reviewed-on: https://chromium-review.googlesource.com/779480 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517890}
-
Brian Sheedy authored
This reverts commit fdb31883. Reason for revert: Causing VR segfaults https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_VR_Tests%2F13834%2F%2B%2Frecipes%2Fsteps%2Fstack_tool_with_logcat_dump%2F0%2Fstdout Original change's description: > Use the LegacyLinker instead of the ModernLinker > > Remove the ModernLinker since it becomes unused. Also remove the possibility to > set the linker differently in tests. > > Public document explaining the motivation: https://goo.gl/kWnHYr > > BUG=719977 (google-internal) > > Change-Id: I5b9b85817093b36127fa4a607bced57b4350a5b8 > Reviewed-on: https://chromium-review.googlesource.com/538582 > Commit-Queue: Egor Pasko <pasko@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517838} TBR=pasko@chromium.org,yfriedman@chromium.org,torne@chromium.org Change-Id: I638bd3223567a5a40babd036feca310257deaa6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719977 (google-internal) Reviewed-on: https://chromium-review.googlesource.com/779921Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#517889}
-
Lei Zhang authored
Change-Id: Ica3c6123f77f4838fb45b6c05669f90089a861bb Reviewed-on: https://chromium-review.googlesource.com/777980Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517888}
-
Carlos Knippschild authored
This reverts commit 8de2c837. Reason for revert: Likely causing consistent failures in "Mac10.9 Tests (dbg)". See: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/47340 Original change's description: > Improvements to autocomplete suggestion announcements > > Provide friendlier-sounding suggestions that are more efficient for screen reader use. > > Bug: 785436 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e > Reviewed-on: https://chromium-review.googlesource.com/772316 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517851} TBR=ellyjones@chromium.org,flackr@chromium.org,jdonnelly@chromium.org,justincohen@chromium.org,rsesek@chromium.org,bsep@chromium.org,aleventhal@chromium.org Change-Id: I31d7e24d7d7e9c2874763c27e4ecd53f349cdaaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785436 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/779920Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517887}
-
Carlos IL authored
Added is_view_source boolean to VisibleSecurityState. GetSecurityLevelForRequest now checks that flag and returns 'NONE' for pages that would return SECURE or EV_SECURE without the flag. Added tests that validate the new behavior Bug: 712482 Change-Id: Ic23c20ffdb92262987dae2119148932cb9d187a6 Reviewed-on: https://chromium-review.googlesource.com/773218 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#517886}
-
Marc Treib authored
Bug: 718413 Change-Id: I51a6a4b65c51495098778226d8976d2a7136cb78 Reviewed-on: https://chromium-review.googlesource.com/779183 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517885}
-
Jialiu Lin authored
Bug: 783977 Change-Id: Ib9977a73f9f8021bf9204cd594a9e40fd8d03341 Reviewed-on: https://chromium-review.googlesource.com/777553 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517884}
-
Evan Stade authored
Also stop observing the MessageCenter, which is in another process (in --mash). The UMA is a little wonky, even before this change, because manually closing the notification is not explicitly logged. It will need to be reworked in the new style of notifications because if closing doesn't count as "decline" then nothing does. For now this more or less maintains existing behavior. Bug: 783018 Change-Id: I69278c0653d8548ccd1fe6a66015b7cf08a0d08c Reviewed-on: https://chromium-review.googlesource.com/777739Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#517883}
-
Shimi Zhang authored
Since we switched to error prone to do static analysis, fixing warnings introduced by my changes. Bug: None Change-Id: I9b4e2593f217b424658e344957f8f4aadff2d2cd Reviewed-on: https://chromium-review.googlesource.com/777947Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#517882}
-
Antonio Gomes authored
SSIA. This is a follow up of https://crrev.com/c/644946. TBR=spang@chromium.org BUG=786761 Change-Id: I23b278b0e32b00b8fbfccbe0cbc89a5cc9ca4833 Reviewed-on: https://chromium-review.googlesource.com/779779 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#517881}
-
Troy Hildebrandt authored
Currently, InstantAppsSettings.shouldShowBanner will never allow a banner to be shown if the instant app is default, so this change allows the banner to show even if the app is installed. This won't change the behaviour as it stands, because we currently launch the instant app if it's installed before we launch a banner. The shouldLaunchInstantApp method is added for the purpose of overriding downstream to avoid launching an instant app when we want to launch a banner. Bug: 781003 Change-Id: I430e29839f2592517d2583c5d7589d3044b0174e Reviewed-on: https://chromium-review.googlesource.com/772809 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517880}
-
Sidney San Martín authored
Fixes an issue where fullscreen video wasn't positioned correctly in the low power tree for some sites, and a longstanding issue where clipped videos become un-clipped in the fullscreen low power tree. Made possible by two changes: - Black and transparent backgrounds are no longer rendered as IOSurfaces for color correction. For macOS to consider a layer solid black, it needs to actually have a black background color (and no contents). Note: I think we can avoid IOSurface replacement by setting a flag or two on the CAContext. See https://crrev.com/c/742663. - Instead of constructing a new layer tree for fullscreen low power, just make the root layer black and match its size to the background to meet the "opaque black superlayer" requirement for detachment. A nicer solution could be to send the browser a color, since it already has a solid color superlayer, in which case no special handling for fullscreen layer detachment would be needed at all, it would "just work". It still needs to be determined whether that would comply with the HTML fullscreen spec. See https://crbug.com/785001. Bug: 781637 Change-Id: I94abb1ade9c58c218296a27f9a7bc3630d4a0c64 Reviewed-on: https://chromium-review.googlesource.com/775139 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#517879}
-
Dmitry Skiba authored
Attempt to use adb_gdb on an app that is not debuggable fails with cryptic "Could not copy gdbserver to the device!" error. The real cause is failing run-as when getting APP_DATA_DIR. This CL handles run-as errors in that case and fails with more actionable message. Change-Id: I5053c6209425cf3e6321b70ffc6d40015341d2c7 Reviewed-on: https://chromium-review.googlesource.com/777765Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#517878}
-
Matthew Jones authored
BUG= Change-Id: I1a9c81887aa57f5c06f7ba69bfa775a793adb10c Reviewed-on: https://chromium-review.googlesource.com/779705Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#517877}
-
Adithya Srinivasan authored
The only operations carried out on form_controls_ are insertions, removals and iterating through the entire list. Insertion and removal can be done faster with a DoublyLinkedList. Since the nodes for the DoublyLinkedList are Oilpan objects, this CL introduces HeapDoublyLinkedList that uses Member for the head and tail pointers, and traces the pointers. This improves the performance of HTMLInputElement::InsertedInto and HTMLInputElement::RemovedFrom by ~15%. Bug: Change-Id: I5b4cd20737e0276bece2430edfb7ec9609690f04 Reviewed-on: https://chromium-review.googlesource.com/758877Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#517876}
-
Mike Baxley authored
Update call sites that were manually scrolling to find Tools menu items to use this new shared method. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I144e8c5872ae350e2697f8da474bfd110ae145cb Reviewed-on: https://chromium-review.googlesource.com/779040Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#517875}
-
Dave Tapuska authored
Reland commit 26bf6f9f. Fixed the WebContentsVideoCapture device test, it is the only other class directly creating a TestRenderViewHost which caused a CFI failure. SetFocus for non-proxy frames are sent input message over mojo. RenderFrameProxyHost based messages are still sent via InputMsg_SetFocus chrome IPC since there is no widget input handler for these situations. In order to grab the mojo input message we are required to subclass the RenderWidgetHostImpl to be able to provide a mock interface. BUG=722928 TBR=nick@chromium.org Change-Id: I80e2fd8fee12619b87031ea18fe869de70ce01ac Reviewed-on: https://chromium-review.googlesource.com/779242Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#517874}
-
Tarun Bansal authored
Bug: 786074 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I63330a3ababd79f58fb19faa3531411d179122a4 Reviewed-on: https://chromium-review.googlesource.com/768525Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#517873}
-
Mike Baxley authored
ChromeEarlGrey has utilities to navigate back and reload. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I78f7dc7af7e2f9e8a7d1585cafc91987ff6ec2aa Reviewed-on: https://chromium-review.googlesource.com/777603Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#517872}
-
chrome://flags/#enable-parallel-downloadingYannic Bonenberger authored
Bug: Change-Id: Iddc38fc951d51d1c2f1d7f59132ffae9cd209dbc Reviewed-on: https://chromium-review.googlesource.com/779100Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517871}
-
Paul Jensen authored
The test calls ConnectivityManager.getActiveNetwork() which is an Android M API. Bug: 786423 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id26b4eb49294a35129fc9cc300084ee293403ca5 Reviewed-on: https://chromium-review.googlesource.com/777299Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517870}
-
Dominic Mazzoni authored
No user-visible change, just modernizing the code behind the chrome://accessibility Accessibility Internals page. We were calling CallJavascriptFunctionUnsafe, which was unsafe because the page might not have been ready. Switch to using a WebUIMessageHandler so we can call AllowJavascript() when we get a message from the page, indicating we're sure it's ready, then future calls to CallJavascriptFunction will succeed. See https://goo.gl/qivavq for details. Bug: 785493 Change-Id: I1623aae2be16b968ae8d7b17058348980637f02c Reviewed-on: https://chromium-review.googlesource.com/772876Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517869}
-
Jochen Eisinger authored
R=ojan@chromium.org Change-Id: Idbbd5e7bed12d41c8b53dd99233386d502bd8da3 Reviewed-on: https://chromium-review.googlesource.com/778323Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517868}
-
Maria Khomenko authored
CustomNotificationBuilder is not used on N+. BUG=779228 Change-Id: Ic8bf59e6b6e2d58306dbb53eb26a26f878e9b4e8 Reviewed-on: https://chromium-review.googlesource.com/777420Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517867}
-
Marc Treib authored
LogEvent computes the time between the current event and navigation start. It gets the navigation start time from WebPerformance:: NavigationStart() which is a wall time (i.e. base::Time), but before this CL, it got the current time from base::TimeTicks::Now(). This CL fixes that by using base::Time::Now() instead and also cleans up the code a bit. I believe this is a pure cleanup, though I'm not entirely sure if the old way always delivered well-defined results. Bug: 777568 Change-Id: I81ed3e1fae2650a6bbc053ae8a4917a8e6c91f5e Reviewed-on: https://chromium-review.googlesource.com/776854 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517866}
-
Maks Orlovich authored
SimpleCache: Revert temporary DCHECK -> CHECK conversion + extra checks from https://chromium-review.googlesource.com/c/chromium/src/+/728344 It's been a month (and it didn't catch anything), new branch should be coming up soon, and there is some DCHECK-enabled testing happening in canaries, too. Bug: 774652 Change-Id: I1866b49fd0cbe906215555be496cbf9a61df73f9 Reviewed-on: https://chromium-review.googlesource.com/779224Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#517865}
-
Min Qin authored
The initiator is used for checking cookies. And it is mising from the URLRequest when URLLoader is used. For example, DownloadContentTest.DownloadAttributeSameOriginRedirect will redirect a link click to a download with a different origin. Download should pass the initiator in the URLRequest, but missing it causes the wrong cookie to be passed. This CL sets the intiator in the URLRequest so the above test can partially work. BUG=786598 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4efffd41fc9ca26063d853ce03e7c7ff817a917c Reviewed-on: https://chromium-review.googlesource.com/777552Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517864}
-
Milko Leporis authored
Change adds support for installing Debian Stretch sysroot for mips64el. BUG=751812 Change-Id: Iaa32d0b0701b17a49e0ac735134ad85cf746fe23 Reviewed-on: https://chromium-review.googlesource.com/776873Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517863}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f9ec4707ee13..b842703085a9 $ git log f9ec4707e..b84270308 --date=short --no-merges --format='%ad %ae %s' 2017-11-18 benjaminwagner Add Linux IntelHD405 Vulkan jobs. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: If2063ed60838aa9e07ca660f143007f4a511ad8b Reviewed-on: https://chromium-review.googlesource.com/779301Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517862}
-
Alex Clarke authored
This is important because otherwise there will be a race between the virtual time budget expiring and the side effects of asynchronous dom storage methods. Bug: 777763 Change-Id: I41481070958a0e47232c8d5f22fbfbe5894ec605 Reviewed-on: https://chromium-review.googlesource.com/730711 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#517861}
-
Scott Violet authored
This name better matches what we do else where. BUG=none TEST=none Change-Id: I8e820ec89c45b09844caba3f8b450a23449c108f Reviewed-on: https://chromium-review.googlesource.com/775879 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517860}
-