GitLab

Revert of Made text-align property independent. (patchset #2 id:20001 of https://codereview.chromium.org/2628503002/ )

Reason for revert:
Misaligned text elements found in manual testing.

BUG=680009

Original issue's description:
> Made text-align property independent.
>
> Made text-align property independent. Also updated
> independent-inheritance-fast-path.html to include textAlign.
>
> Tested using independent-inheritance-fast-path.html.
>
> BUG=628043
>
> Review-Url: https://codereview.chromium.org/2628503002
> Cr-Commit-Position: refs/heads/master@{#442500}
> Committed: https://chromium.googlesource.com/chromium/src/+/d8b62ea53246ab528786b9a8d312d0a3733e46e9

TBR=sashab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628043

Review-Url: https://codereview.chromium.org/2627833003
Cr-Commit-Position: refs/heads/master@{#443101}

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624043002
Cr-Commit-Position: refs/heads/master@{#443100}

Moved unicode-bidi to be generated in ComputedStyleBase, which uses the
external type platform/text/UnicodeBidi.

Review-Url: https://codereview.chromium.org/2627563002
Cr-Commit-Position: refs/heads/master@{#443099}

In the views tree, dialogs as annotated today are fairly loose semantically.

1. In the Launcher, we're using dialog for bubble views.
Example:
window
  ...
  search text field
...
window
  ...
  dialog
    ...
    dialog
      files app button

The problem arises when trying to wrap. It is not clear if we should wrap based on the inner dialog, the outer dialog, or the outer window.

Furthermore, consider the views tree for app installation

window
  dialog
  ...
    close button
  ...
  dialog
    description text static text
  ...
  install button

Here, we should not wrap for the inner dialog because we'll miss the buttons that come after.

Thus, we need to be far more strict when detecting dialogs as root. In particular, dialogs that are not parented to windows and have siblings that are not all windows or dialogs, should not be a root.

TEST=navigate both app install window and launcher. Verify that wrapping only occurs for the launcher case and not for the install window.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2573203002
Cr-Commit-Position: refs/heads/master@{#443098}

This adds a path for VDAv2 clients to look up a command buffer identified by |command_buffer_id|.

Also in this CL is a method to look up the route ID from the accelerated GPU factories so that it's easy to pass the |command_buffer_id|.

BUG=522298
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2526953003
Cr-Commit-Position: refs/heads/master@{#443097}

Also updated the test to check for the matching full hash in that case.

BUG=679906

Review-Url: https://codereview.chromium.org/2622063002
Cr-Commit-Position: refs/heads/master@{#443096}

The argv list passed to the main method when running a test in a
subprocess was not NULL terminated, something that the gtest launcher
takes advantage of.
This was causing an invalid memory read causing failures on the ASAN
bots.

BUG=680155,680156

Review-Url: https://codereview.chromium.org/2622073004
Cr-Commit-Position: refs/heads/master@{#443095}

Any child classes don't override it.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2624323002
Cr-Commit-Position: refs/heads/master@{#443094}

Review-Url: https://codereview.chromium.org/2624123003
Cr-Commit-Position: refs/heads/master@{#443093}

This patch removes the enum value TransformOperation::None, which is
currently only used in an ASSERT_NOT_REACHED case.

Review-Url: https://codereview.chromium.org/2616863002
Cr-Commit-Position: refs/heads/master@{#443092}

paper-slider uses a fixed size of 200px.
This does not work well with cr-slider when the size of the labels
increases. Instead, set the minimum width of cr-slider to be 200px,
and the width of the embedded paper-slider to 100%.

BUG=679319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628633002
Cr-Commit-Position: refs/heads/master@{#443091}

BUG=679992,653093

Review-Url: https://codereview.chromium.org/2624273003
Cr-Commit-Position: refs/heads/master@{#443090}

The bottom bar was used to let users know they would receive
notifications from the Physical Web.  Now that we don't fire
notifications, we should remove this bottom bar.

BUG=679363

Review-Url: https://codereview.chromium.org/2622743002
Cr-Commit-Position: refs/heads/master@{#443089}

Revert of Adds animated touch point and the hint box for touch calibration UX (patchset #4 id:120001 of https://codereview.chromium.org/2600213002/ )

Reason for revert:
Hoping to clear up issue on builder here:

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/18918

-- sheriff

Original issue's description:
> Adds animated touch point and the hint box for touch calibration UX
>
>  - Adds the circular throbbing touch point view that the user interacts
>    with during touch calibration.
>  - Adds the hint box view that contains the hint message as given in the
>    UX specs.
>    (https://drive.google.com/file/d/0B_2Uyb2Rhx2OU0FIbXUyMkhMZlE/view)
>  - Adds required resource strings for hint box messages.
>
> Working protottpe(The video is the entire prototype. This change only
> involves adding the touch point and hint box.):
> https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1QVR0WFJYdUY2SmZTdWdUVFNSM0F5WDF4YlBn/view
>
> Screenshot of how it looks on different DPI screens:
> https://screenshot.googleplex.com/ND5d9v0799y.png
>
> Screenshot for RTL:
> https://screenshot.googleplex.com/Xd3PyAYbDTV.png
>
> BUG=634166
> COMPONENT=Touch Calibration, ChromeOS, UI Strings
>
> Review-Url: https://codereview.chromium.org/2600213002
> Cr-Commit-Position: refs/heads/master@{#443000}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f631d1860f7dfcf100b5a6bef46263cd7a4e698

TBR=oshima@chromium.org,stevenjb@chromium.org,malaykeshav@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634166

Review-Url: https://codereview.chromium.org/2629003003
Cr-Commit-Position: refs/heads/master@{#443088}

1. Create a BaseBlockingPage in components/safe_browsing, and move
   basic user interaction handling logic into this class
2. Implement BaseUIManager::DisplayBlockingPage to work with
   BaseBlockingPage
3. Make security_interstitials::MetricsHelper a non-abstract class,
   such that it can be instantiated by BaseBlockingPage
4. Adjust unit_tests and browser_tests
5. Rename BaseSafeBrowsingUIManager to BaseUIManager,
   BaseSafeBrowsingResourceThrottle to safe_browsing::ResourceThrottle

Overall, no logic change in
chrome/browser/safe_browsing/SafeBrowsingBlockingPage class

BUG=666100

Review-Url: https://codereview.chromium.org/2623733002
Cr-Commit-Position: refs/heads/master@{#443087}

BUG=649558

Review-Url: https://codereview.chromium.org/2626943002
Cr-Commit-Position: refs/heads/master@{#443086}

This patch adds an ability to request an image decode from
the compositor. The caller should specify which image
(SkImage) to decode and a callback. In return, it gets an
id. When the image is decoded, the callback is issued with
this id. The decode is then kept alive for 2 compositor
frames.

Right now, only unittests are using this functionality.

R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537683002
Cr-Commit-Position: refs/heads/master@{#443085}

BUG=80267

Review-Url: https://codereview.chromium.org/2624553002
Cr-Commit-Position: refs/heads/master@{#443084}

Background: When support for wptserve was originally added [1],
WPTServe had a _stop_running_server to override the version in
ServerBase, which tries to kill the existing process with
Executive.interrupt instead of  Executive.kill_process on non-Windows
platforms.

Later this method was changed in http://crrev.com/2511013002 and
now when interrupt fails to kill the process, there's an infinite
loop which results in the job stalling for days.

But, I'm not sure why it was necessary to use Executive.interrupt
rather than Executive.kill_process. If the overridden method is removed,
then ServerBase._stop_running_server would be used, which is:

    def _stop_running_server(self):
        self._wait_for_action(self._check_and_kill)
        if self._filesystem.exists(self._pid_file):
            self._filesystem.remove(self._pid_file)

[1] https://chromium.googlesource.com/chromium/src/+/0129094b0ad431a2aee9cf5ea9225037283f3c37/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Note, the actual change to behavior here is in webkitpy/layout_tests/servers/wptserve.py -- the rest of the changes are related to unit testing; I could also put those changes in a separate CL.

BUG=669802

Review-Url: https://codereview.chromium.org/2624093003
Cr-Commit-Position: refs/heads/master@{#443083}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/64cff499aefc..dcd70be386e3

$ git log 64cff499a..dcd70be38 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 sullivan Horrible workaround for v8 bug 2830.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2623343002
Cr-Commit-Position: refs/heads/master@{#443082}

Fixed the conversion of timestamps in vr_input_manager

BUG=

Review-Url: https://codereview.chromium.org/2622333002
Cr-Commit-Position: refs/heads/master@{#443081}

Decided we do not ever want to launch print pdf as image on Mac or Win.
Modify tests and print preview UI so that the feature will never appear
on these platforms even after the flag it is behind is removed.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616783002
Cr-Commit-Position: refs/heads/master@{#443080}

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2622103002
Cr-Commit-Position: refs/heads/master@{#443079}

Changes:
Bug happens when v2app like Files is pinned, the ash::ShelfItemType for this case is TYPE_APP_SHORTCUT.

BUG=675032
TEST=emulator test saw bug fixed

Review-Url: https://codereview.chromium.org/2628023002
Cr-Commit-Position: refs/heads/master@{#443078}

On MacViews, the tests ComboboxTest.NotifyOnClickWithSpaceKey and
ComboboxTest.NotifyOnClickWithReturnKey do not terminate currently when run
individually. This only happens on Mac, because on other platforms the combobox
dropdown menu is async (non-blocking). However on Mac, a native NSMenu is used
to show the combobox dropdown, which runs a nested message loop and hence is
blocking.

To solve, install a TestMenuRunner for all the tests using the ComboboxTest
fixture. This ensures that an actual menu is not created.

BUG=679980
TEST= Run out/Default/views_unittests
--gtest_filter="ComboboxTest.NotifyOnClickWithSpaceKey" on Mac. Ensure that the
test terminates normally.

Review-Url: https://codereview.chromium.org/2620963002
Cr-Commit-Position: refs/heads/master@{#443077}

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=679574

Review-Url: https://codereview.chromium.org/2622803002
Cr-Commit-Position: refs/heads/master@{#443076}

https://skia.googlesource.com/skia.git/+log/a5494f117086..8d80bb5f20d8

$ git log a5494f117..8d80bb5f2 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 herb Revert "Introduce SkArenaAlloc - should be fast for POD types and RAII for types with dtors."
2017-01-11 halcanary SkUTF8_CountUnichars(s,l) and SkUTF8_NextUnichar(s,l) now safe.
2017-01-11 bsalomon Fix undefined GrIORef test method on Chrome win bot
2017-01-11 herb Introduce SkArenaAlloc - should be fast for POD types and RAII for types with dtors.
2017-01-11 jvanverth More fixes for distance field paths
2017-01-11 bsalomon Make GrPaints move their GrProcessor ownership into GrPipelineBuilder.
2017-01-11 reed move SkTRegister.h into tools
2017-01-11 bungeman Remove SK_LEGACY_FONTMGR_FACTORY.
2017-01-11 reed remove dead file: PathOpsSkpClipTest.cpp
2017-01-11 mtklein SkSplicer: start on Windows support
2017-01-11 halcanary SkTestTypeface: correct encoding
2017-01-11 halcanary SkTypes.h : move SkAutoMalloc into SkAutoMalloc.h
2017-01-11 jvanverth Revert "More fixes for distance field paths"
2017-01-11 scroggo Make SkColorToHSV and SkHSVToColor "perfect" inverses
2017-01-11 jvanverth More fixes for distance field paths
2017-01-11 kjlubick Revert "SkTypes.h : move SkAutoMalloc into SkAutoMalloc.h"
2017-01-11 bsalomon Add test for processor->resource ref/io counts

BUG=677889,677889,b/33737498,677889

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2623123003
Cr-Commit-Position: refs/heads/master@{#443075}

BUG=678276

Review-Url: https://codereview.chromium.org/2628983003
Cr-Commit-Position: refs/heads/master@{#443074}

Since std::deque is memory inefficient for small numbers of elements,
especially on Android, (see http://crbug.com/674287), this CL replaces
the std::deque in DataReductionProxyEventStore with a simple circular
buffer.

BUG=679603

Review-Url: https://codereview.chromium.org/2619373003
Cr-Commit-Position: refs/heads/master@{#443073}

I suspect that host.options was originally a simple dictionary, and so the cast was safe. When it got upgraded to an object with methods on the prototype it broke, but because the window of opportunity for failure is small (you have to connect without a call to HostList.refresh happening in the interim), it was difficult to track down.

BUG=680302

Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}

This should hopefully get the bots back to green while individual bugs
are being investigated.

BUG=680201, 661725, 680249, 680307
NOTRY=true

Review-Url: https://codereview.chromium.org/2625233002
Cr-Commit-Position: refs/heads/master@{#443071}

When moving from checkboxes -> toggles, I unwrapped the label text of
UIs using

  <paper-checkbox hidden=[[...]]>...</paper-checkbox>

to

  <div>...</div>
  <paper-toggle-button hidden=[[...]]></paper-toggle-button>

I forgot to move the hidden=[[]] bindings, and only the toggle would get
hidden on platforms that don't support the data type.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624203003
Cr-Commit-Position: refs/heads/master@{#443070}

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624503002
Cr-Commit-Position: refs/heads/master@{#443069}

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2630463002
Cr-Commit-Position: refs/heads/master@{#443068}

This is a refactoring change related to, but separate from,
the issue of replacing wdiff and PrettyPatch.rb with a Python
diff module (http://crbug.com/672651), and a follow-up to
adding html_diff.py (http://crrev.com/2580143002).

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so it doesn't really seem to belong in the Port class. (It
seems more similar to the html_diff module in webkitpy/common/.)

Review-Url: https://codereview.chromium.org/2595983002
Cr-Commit-Position: refs/heads/master@{#443067}

chrome/browser/android/data_usage has a few uses of std::deque that
would work just about as well using std::vector, and since std::deque is
memory inefficient for small numbers of elements (see
http://crbug.com/674287), this CL replaces those uses of std::deque with
std::vector.

BUG=679568

Review-Url: https://codereview.chromium.org/2624663002
Cr-Commit-Position: refs/heads/master@{#443066}

Adds BluetoothAdapter::Observer callbacks to Adapter implementation
for tracking changes in Adapter state including:
  AdapterDiscoverableChanged
  AdapterPoweredChanged
  AdapterPresentChanged

Adds adapter page to display details about the current state of the adapter.
Adds ObjectFieldSet interface component for displaying properties of a JavaScript object.

Screenshot: https://goo.gl/photos/dCbsULiydMbiAtiJ9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2567983007
Cr-Commit-Position: refs/heads/master@{#443065}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338

Review-Url: https://codereview.chromium.org/2628093002
Cr-Commit-Position: refs/heads/master@{#443064}

https://chromium.googlesource.com/angle/angle.git/+log/98e3407..008450b

BUG=None

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2627713006
Cr-Commit-Position: refs/heads/master@{#443063}

Debian 8 restricts use of CLONE_NEWUSER to only processes with
CAP_SYS_ADMIN. (https://github.com/semplice/linux/blob/master/debian/patches/debian/add-sysctl-to-disallow-unprivileged-CLONE_NEWUSER-by-default.patch)
Chrome was previously checking if the kernel supported CLONE_NEWUSER
by running clone(CLONE_NEWUSER, ...) with the same capabilities chrome
was launched with.  This leads to 2 scenarios:

1. If Chrome was run as root:
   The check for CLONE_NEWUSER will succeed.  Chrome will then set up
   the namespace sandbox by clone()'ing and dropping CAP_SYS_ADMIN.
   Subsequent clone()'s with CLONE_NEWUSER will then fail.

2. If Chrome was run as a normal user:
   The check for CLONE_NEWUSER will fail.  Chrome will fallback to
   using the setuid sandbox.

The solution is to simply drop CAP_SYS_ADMIN before the check.

In addition, this CL disallows running Chromium as root unless launched
with --no-sandbox.

BUG=638180

Review-Url: https://codereview.chromium.org/2578483002
Cr-Commit-Position: refs/heads/master@{#443062}