- 05 Jun, 2019 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I1e57839dbe9ed8d1887a6f6ecc3686bf275df315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643683Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#666150}
-
Eugene But authored
It is common practice to allow everyone to review BUILD.gn files. Change-Id: I8639deb0ed5920948a9703e34fbf5991f105244e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643841Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666149}
-
Will Harris authored
This reverts commit c3a6c5f3. Reason for revert: Causes bug 969624 Original change's description: > Moved last version cache from the origin-policy throttle to... > > ... the network service origin policy manager. > > This is step 4 of: > https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj > > This also includes a second in memory structure for the actual policy > contents that was not present in the origin policy throttle. > > Bug: 950905 > Change-Id: I493e66f97c68263e1110d9ecfa724cee0ee8310f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627036 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Auto-Submit: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665427} TBR=dcheng@chromium.org,mmenke@chromium.org,vogelheim@chromium.org,alexmos@chromium.org,mkwst@chromium.org,andypaicu@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950905, 969624 Change-Id: Iafe94a7ce9dceb1f073fa3ad9ffd5725a4c0fa30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644176Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#666148}
-
Richard Li authored
This CL change the type of DataElement::buf_ and bytes_ from char to uint8_t, which makes the conversion with its mojom type more convenience. Change-Id: I1c60db81e16137ffe2e0d98d6efbecd8427fa206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636969Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#666147}
-
Jon Mann authored
Adds an UNSPECIFIED entry to the 0 index for all enums within the WifiConfigurationSpecificsData proto. Bug: 966270 Change-Id: I7a6c97bb75463fd4a9346581b5a831003ceda687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642137 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#666146}
-
Shu Chen authored
Bug: 965908 Change-Id: I23bf5a3da2d31161fcbc3ef10385c5c916bebda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642608 Auto-Submit: Shu Chen <shuchen@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666145}
-
Asanka Herath authored
Net.HttpAuthCounts measures the number of authentication sessions started and rejected by HTTP authentication scheme. But we don't have data on how many NTLM sessions that were started had NTLMv2 enabled. The numbers here will guide deprecation efforts for LM/NTLM protocols which will result in the removal of non NTLMv2 codepaths. Bug: 959402 Change-Id: I5263b32e97f97f1ef3fe3fba41067ec7ff779136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641992 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#666144}
-
Luciano Pacheco authored
Fix fakeTouchClick to only issue touch related events when emulating touch in the integration tests. The test helper function fakeTouchClick was issuing "mousedown" and "contextmenu" to make the only test using it to set the desired state. The actual problem in the test is that the fakeMouseRightClick helper function wasn't issuing "click" to trigger the correct event listener to set the desired state. Fix fakeMouseRightClick to issue all mouse events as it happens if real user interactions: * mouseover * mousedown * mouseup * click * contextmenu Refactor fakeMouseClick to receive an optional button to be able to re-use it for right-click. Test: browser_tests --gtest_filter="ContextMenu/FilesAppBrowserTest.Test/checkContextMenusForInputElements" Change-Id: I4eb6d93f46b5602256dc03fd49400b3e8e8aa6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642751 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#666143}
-
Justin Cohen authored
Updates various files with to conform to iOS13 SDK headers changes: Nullability and availability changes Updates security types Updated default values (modalPresentationStyle) Updates objc_zombie with IMP changes (as well as adding the accidentally-omitted tests) TBR=rohitrao Change-Id: I7d88a8c0fbb764484050be67dd33adcd11d343dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642508 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666142}
-
Chih-Yu Huang authored
Originally, we run VEA unittest to verify every Chrome OS board by autotest. We filter known-to-fail test cases at autotest implementation. However, we plan to switch Tast framework. Tast does not allow us to skip the test case according to the board at runtime. Therefore, we decide to skip the test cases inside the test binary. BUG=chromium:957475 TEST=run test binary at Kevin and confirm the test at blacklist is skipped Change-Id: I16e998b1ef89dab751b9e440e53d22dee831209b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635085 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#666141}
-
Daniel Rubery authored
When an Advanced Protection user sees a warning, we should send them to the AP-specific FAQ page, which will include details about what kinds of files show warnings for that population. Bug: 917190 Change-Id: I12156cb502c04c9bd826b112a692e979e4e4d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635206Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#666140}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/40ec586a32ab..a8f7a450950b git log 40ec586a32ab..a8f7a450950b --date=short --no-merges --format='%ad %ae %s' 2019-06-05 thestig@chromium.org Add a pixel test for rendering triangles. 2019-06-04 thestig@chromium.org Roll testing/corpus/ 5a68e8785..db4764592 (1 commit) 2019-06-04 tsepez@chromium.org Move cba_fontmap.{h,cpp} from fpdfsdk/ down to core/fpdfdoc. 2019-06-04 tsepez@chromium.org fuzzers: avoid double initialization in CCodec_ModuleMgr 2019-06-04 tsepez@chromium.org Remove font-related methods from CFX_SystemHandler. 2019-06-04 tsepez@chromium.org Remove one circular .h inclusion from cba_fontmap.cpp. 2019-06-04 thestig@chromium.org Avoid undefined behavior in CFX_ImageStretcher. 2019-06-04 tsepez@chromium.org Remove second stray dependence from xfa/fxfa to fpdfapi. 2019-06-04 thestig@chromium.org Remove unused variable from fixup_pdf_template.py. 2019-06-04 metzman@chromium.org Add pdfium fuzzing stub for LPM fuzzer 2019-06-04 thestig@chromium.org Fix a nit in CPDF_PageContentGenerator::ProcessImage(). Created with: gclient setdep -r src/third_party/pdfium@a8f7a450950b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:725555,chromium:86459,chromium:970137,chromium:964872,chromium:969811 TBR=pdfium-deps-rolls@chromium.org Change-Id: I12fcccdb880193670716f6bf9e8bb3b02c521123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666139}
-
Scott Violet authored
This code dates back to Mandoline and is not used anywhere. BUG=none TEST=none Change-Id: Ieb5ee4c851bc88ffc4b50058ee4665b270eca87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642980Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666138}
-
dpapad authored
These buttons were implemented mostly with the border-image CSS property and reused images that were shared between WebUI and Views. Views no longer uses those images. Instead replacing with a full CSS implementation (without using border-image), allows removing those images. The images are no longer used anywhere after this CL, and will be fully removed in follow up CL. Bug: 522168 Test: Open the feedback app. Cancel and Send buttons should look identical (AFAICT) as before. Change-Id: I6a5d9625f1f042b1fb99a4247b523215f291fc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639341 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666137}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a5cc1c3. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 2257aee3 "Add test for active processing of AudioBufferSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload kojii@chromium.org: external/wpt/css/CSS2/text rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I0098b04913a479e61f8f9e85e37005d553ba9be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644163Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666136}
-
Robert Liao authored
BUG=937566 Change-Id: Ia75b59b0aa04c6bd6247e871478a4c6a35eec043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642744 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666135}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/8d01645e5411..08c3cc4722be git log 8d01645e5411..08c3cc4722be --date=short --no-merges --format='%ad %ae %s' 2019-06-04 codyleeweaver@gmail.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@08c3cc4722be The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Icd22bbf55e335fb117989e32d50dcb1b533ac79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643903Reviewed-by:
-
Clifford Cheng authored
Bug: 968849 Change-Id: I973dbdc6c6fa37881b97dd837ab021fb2aaedb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639737 Auto-Submit: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#666133}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9dff8a104051..e77dbf600358 git log 9dff8a104051..e77dbf600358 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@e77dbf600358 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I03d3c731719500401975f89bce5cf82babb853ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643899Reviewed-by:
-
Lucas Tenório authored
Bug: 958995 Change-Id: Iae48a70689917a8e6bc4cf904a6d2464abe63ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641993 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666131}
-
Min Qin authored
If a downloads ends with content length mismatch errors, Chrome will try to resume it automatically. However, less than half of the downloads actually completes with more data received. This CL adds some UMA for us to understand why the remaining download fail. BUG=968833 Change-Id: Iaf3bec605a96880316ced34437a99e0527978b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637645 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#666130}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dd7a2ceeb49e..3344e16e55cf git log dd7a2ceeb49e..3344e16e55cf --date=short --no-merges --format='%ad %ae %s' 2019-06-04 dalecurtis@chromium.org Fix media video playback metrics. Created with: gclient setdep -r src/third_party/catapult@3344e16e55cf The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:965682 TBR=charliea@google.com Change-Id: Ie6d668d9c61d8e627c58192166d98aeddbcedb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643157Reviewed-by:
-
liberato@chromium.org authored
Bug: 953376 Change-Id: I7c2bf8a54481bb31ead4eeb86c15510228a10988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575818Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#666128}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71c6bc07e67f..d2f31cc65dea git log 71c6bc07e67f..d2f31cc65dea --date=short --no-merges --format='%ad %ae %s' 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d2f31cc65dea The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8e3766af34f528ab9e283f085b4a50e3c4db0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644235Reviewed-by:
-
Nicolás Peña Moreno authored
Bug: 960079 Change-Id: I89a941438cb05163f99dd5b773602e37c2c4ae4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642270Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Tommy C. Li authored
This is a reland of a9d56928 Original change's description: > [omnibox] Rename the ZeroSuggestProvider::ResultType values > > This CL renames the ZeroSuggestProvider::ResultType values to be > more descriptive, and adds more commentary. > > They used to imply that we asked the default search provider for > zero-suggestions, which was sometimes misleading, since that's not > always true. > > Bug: 963173 > Change-Id: I85a55cb57749441d2adfdb53642247fd055b7d9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631903 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665330} Bug: 963173 Change-Id: I206a4fd36189e2400bfd754ac4f0fba4ab076075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640160 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#666125}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I93c43042ae115a7ae363e7c681710bdc51a426d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644234Reviewed-by:
-
Jinsuk Kim authored
This CL drives Favicon visibility with fade-in/out animator. Also keeps the size of favicons consistent. |EphemeralTabLayer::GetLocalFaviconImageForURL| is replaced with the notification via |FaviconDriverObserver|. |GetLocalFaviconImageForURL| provides favicons that are already available in local history db only. Relying soly on it caused a bug not updating favicon for newly visited pages. FaviconDriverObserver addressed the problem. If navigated to a page from a domain different from the current one, 1) reset to a default favicon 2) show the new one as soon as we're notified of the new favicon. Note that these operations do not happen if navigated to a page within a same domain. This is checked by the host name of URL being visited. Bug: 929727 Change-Id: I716f9c03b31c513a7eb00dd286018a7a200cbde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605381 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#666123}
-
Karan Bhatia authored
Enforce CSP checks for fetch in isolated worlds. Also add tests for fetch usage in isolated worlds and its interaction with CSP. This also exposes a bug with the current handling of redirects as far as bypassing the main world CSP is concerned. Since the IsolatedWorldCSP feature is disabled by default, this CL will cause the CSP check to use an empty CSP instead of just bypassing the CSP checks for isolated worlds. In practice, this should cause no behavior change. BUG=896041 Change-Id: I4778112e3c5e7f6fcb2f2849eca6ed7ef384f65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633531 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#666122}
-
Michael Giuffrida authored
Hide Quick Settings feature pods and some top-row shortcuts in Kiosk Next sessions. This also moves the SignOutButton's visibility logic to TopShortcutsView, simplifying the button itself. This is in line with how the other top-row shortcut buttons work. Depending on user feedback, follow-up work might add some feature pods back in, or remove the collapse/expand option. If we start diverging more substantially from the normal Quick Settings, we can create KioskNext versions of these classes instead. Bug: 966890 Change-Id: I4c84e39021f213ca24fe8fcc39dd9b53a3119491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638880 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#666121}
-
Mei Liang authored
This is the first CL for upstreaming TabSelectionEditor. This CL refactors TabGridViewHolder to support creating different ViewHolders for a RecyclerView based on the provided item view type. Change-Id: I94aa3c92875b31b0f9f79d4ce0e0c56b43ef9392 Bug: 970087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642140Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666120}
-
Michael Giuffrida authored
Disables SplitView when KioskNextShell is enabled. Also disables snapping and the drag/snap indicators when split view is disabled. Bug: 966889 Test: run ash_unittests; manually by dragging windows in Overview Mode in a KioskNext session Change-Id: Idb7a6c57ac89144af726ca3480fba5eaae12c3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636907 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666119}
-
Steve Becker authored
Updates NativeFileSystemDirectoryHandleImpl::GetChildURL() to return a base::File::Error for invalid |name| input. |name| must specify a direct child of the current directory. Invalid |name| inputs include: 1. Empty string: '' 2. Current directory: '.' 3. Parent directory: '..' 4. Strings containing path separators like '/' Updates the callers of GetChildURL() to handle errors by immediately running callbacks with the base::File::Error returned by GetChildURL(). Extends existing NativeFileSystem API webtests by adding invalid 'name' input tests for each JavaScript API with a 'name' parameter, including getFile(), getDirectory(), moveTo(), and copyTo(). Bug: 960411 Change-Id: Ida6ebf1cb2d1017e2cafe386c30d5cb65430055c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643984 Commit-Queue: Steve Becker <stevebe@microsoft.com> Auto-Submit: Steve Becker <stevebe@microsoft.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#666118}
-
Donna Wu authored
Now that dictionary can be used as a member of a union type, so this CL changed NDEFRecordData type from "any" to the Spec defined union. Bug: 935912, 520391 Change-Id: Ib6ab361fa6a4087a2e14f4e9eb20b4a949155c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628587Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#666117}
-
Sam McNally authored
Bug: 969600 Change-Id: I3e181e886c2acdb5bc0ffd2cd6ab18d7282bb28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642610 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666116}
-
Doug Arnett authored
The current understat histogram includes reloads (and forward/back nav) but reloads aren't actually candidates for previews now. This adds an understat histogram limited to new navigations that are user initiated so that it will be easier to compare just the new nav impact to the current overall understat. Bug: 965969 Change-Id: Ia3fb766335a9bdf3b4c22eafa08467d5a05c9d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637671Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#666115}
-
Eric Foo authored
Bug: 970122 Change-Id: I68ac5251950a3c218fbc4edfe9aa1c7a05e061f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642947Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666114}
-
Fritz Koenig authored
MESA_framebuffer_flip_y needs the allocated framebuffer to be setup to the same orientation. BUG=964010 TEST=https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2 Change-Id: If7b7aaec176387e47c46c4f7337d686536375e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641666Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#666113}
-
Xing Liu authored
This CL uses the BackgroundTaskCoordinator to scedule background task with platform API. Bug: 963283,930968 Change-Id: I9d6af682cdc456f66dcab88997eee08acab11320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639560 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#666112}
-
Darren Shen authored
- Fix two OWNERS files that pointed to //ui/keyboard instead of //ash/keyboard. - Moved ash/keyboard/ui/OWNERS to ash/keyboard/OWNERS as they just pointed to the same thing. - Added OWNERS to c/b/ui/ash/keyboard that points to ash/keyboard/. Bug: 961568 No-Presubmit: true Change-Id: Iebb1d3bde2e3e22a02fb3216d1967a1abb49abb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638077 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#666111}
-
