Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 27 Sep, 2020 5 commits
    • Reilly Grant's avatar
      serial: Use USB driver name to disambiguate ports · 19e1c500
      Reilly Grant authored 
      On systems with both the built-in serial driver and a third-party driver
the same port can be enumerated more than once. This difference is
visible to the user in the device path shown in the chooser but was
previously ignored when constructing a persistent ID for the port.

This patch replaces the generic persistent ID field with the individual
components that are available on each platform. This should make it
easier to modify these rules over time as the components won't be opaque
to SerialChooserContext. This is a breaking change which will cause
previously granted persistent permissions to be ignored.

On macOS the name of the USB driver (the parent of the BSD serial
port) is now included in the set of fields used to identify a device in
order to differentiate between USB devices with otherwise have the same
USB vendor ID, product ID and serial number.

Bug: 1127535
Change-Id: If1b06ab82a975976e1e3b7d2075216f11afda5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413176
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarJames Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811028}
      19e1c500
    • Antonio Gomes's avatar
      Factor some constants out of ash_constants.h · 1f43abcd
      Antonio Gomes authored 
      Some constants in ash_constants.h are used in
BrowserNonClientFrameViewAsh. In order to make this
class available to lacros, these constants need to be
factored out, once lacros chrome can not link to ash symbols.

The following constants are moved:

 ash::kDefaultFrameColor
 ash::kResizeAreaCornerSize
 ash::kResizeInsideBoundsSize
 ash::kResizeOutsideBoundsSize
 ash::kResizeOutsideBoundsScaleForTouch

now under the `chromeos` namespace.

Also, CL adds a README.md to chromeos/ui directory.

This is phase 2.2 on the design document [1].

[1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/

BUG=1113900
R=jamescook@chromium.org

Change-Id: I01cf20ed5a77f752fee2c72df0d5cb0cf42125a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429441Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#811027}
      1f43abcd
    • Kyle Horimoto's avatar
      [CrOS Settings] Disable flaky OSSettingsLanguagesPageV2Test test · fd31ad10
      Kyle Horimoto authored 
      Bug: 1132577
Change-Id: I8b74aabd4153f18ad823ac4d5384a2c0d47afa7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433063
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: default avatarMy Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811026}
      fd31ad10
    • Mei Liang's avatar
      Fix TabSelectionEditor no show issue after using the system back button · 978a453a
      Mei Liang authored 
      crrev.com/c/2399314 uses a focusable PopupWindow for accessibility
support. The focusable PopupWindow catches the system back button event
and dismisses the PopupWindow directly without going through the
TabSelectionEditorMediator#hide, where it updates the
TabSelectionEditorProperties#IS_VISIBLE property from true to false. The
TabSelectionEditorProperties#IS_VISIBLE remains to be true. Then
TabSelectionEditorMediator#show is called again to show the
TabSelectionEditor has no effects. Since there is no property change,
the binder will not get triggered.

This CL fixes the issue by setting the TabSelectionEditorMediator#hide
as a Runnable to the TabSelectionEditorProperties, then binding it to
the TabSelectionEditorLayout and triggering the Runnable when the
PopupWindow is dismissed.

Everything introduced in this CL is gated by by Finch parameter
"enable_launch_polish" under flag "enable-tab-grid-layout". Most of the
code is verified to be behind the gating function
TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence
checking tool here: http://crrev.com/c/1934235. The changes in
following files can't be verified by the tool, but it is expected and
no-op without the flags:
  * The new property in TabSelectionEditorProperties

Bug: 1132478
Change-Id: I774d13714445e76da9c9ef4573412b62bf042039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432969
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811025}
      978a453a
    • Claude van der Merwe's avatar
      Add WifiSyncFeatureManager to multidevice setup · b4f91407
      Claude van der Merwe authored 
      WifiFeatureManager adds global enable/disable functionality for
Wifi Sync V2.

WifiFeatureManager asynchronously enables/disables WIFI_SYNC_HOST
for a synced device on the back-end, and provides retry logic if the
network request fails by storing the last pending request in prefs.

Bug: 1117619
Change-Id: Ide945c00e5eb060dd86b11b31e1a830aa1fde3ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419332
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarJon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811024}
      b4f91407
  3. 26 Sep, 2020 35 commits