GitLab

Review URL: http://codereview.chromium.org/102020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11264

TBR=dglazkov

Review URL: http://codereview.chromium.org/100235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15021 0039d316-1c4b-4281-b951-d872f2087c98

Stop the location bar from flashing white when navigating from one HTTPS site to another.  To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen.

BUG=11157
TEST=Navigate from one HTTPS site to another and watch the location bar carefully.  It shouln't flash anymore.

Review URL: http://codereview.chromium.org/99247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15020 0039d316-1c4b-4281-b951-d872f2087c98

R=jar

Review URL: http://codereview.chromium.org/99020


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98

- Finally audio playback wired
- Takes into account initial buffer fill change of last week
- Two 'can you hear this?' unit tests added


Review URL: http://codereview.chromium.org/92131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15017 0039d316-1c4b-4281-b951-d872f2087c98

Code coverage now works for Linux.  Unit tests to run passed from
project to coverage_posix.py so deps are correct.


Review URL: http://codereview.chromium.org/100189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15016 0039d316-1c4b-4281-b951-d872f2087c98

1) Add a dependency to the rule that copies the files.
2) Change the directories to have lower case names.  This doesn't matter
on windows which is case insensitive and where some directories are already lower case (e.g., themes and locales).  Mac will probably have to add
some gyp code to move the files to the right place in the bundle.

Review URL: http://codereview.chromium.org/100223


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15015 0039d316-1c4b-4281-b951-d872f2087c98

Most of the new code concerns shaping the widget to be non-rectangular.

Also, sprinkle some "const" qualifiers on NineBox functions.

Review URL: http://codereview.chromium.org/100224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15014 0039d316-1c4b-4281-b951-d872f2087c98

- Bookmark codec now takes in a ctor argument persist_ids
- If it's true, it will serialize IDs of bookmarks when encoding, and
  deserialize already serialized IDs (if present) when decoding.
- During decoding, unique-ify the IDs if they are not unique.
- Add unit tests for all new code.


Coming up in a separate changelist:
- Move ID generation logic to bookmark model, and make it non-static.

Review URL: http://codereview.chromium.org/99217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15013 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15011 0039d316-1c4b-4281-b951-d872f2087c98

After we're sure we can do SDCH compression to a given URL, toss
a 50-50 coin each time we have a chance to advertise SDCH, and
either completely avoid advertisement, or advertise (including
the dictionary).  Histogram both compression download times, as
well as the download times for the "completely avoid" case.

http://crbug.com/11236
bug=11236
r=wtc,openvcdiff
Review URL: http://codereview.chromium.org/100004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15010 0039d316-1c4b-4281-b951-d872f2087c98

Added audio/mpeg and video/mpeg to the list of mime types supported by the Activex shim for media player along with their associated extensions. 

This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source
URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime
and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the
mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin
from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message.

With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player
handling it in Chrome.

I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it.

Added plugin tests for the mp3 and mpe extensions.

Bug=11054


Review URL: http://codereview.chromium.org/100180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15008 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15001 0039d316-1c4b-4281-b951-d872f2087c98

Add empty createHTMLParserQuirks implementation in anticipation of http://trac.webkit.org/changeset/43092.

R=levin
BUG=10898
TEST=0

Review URL: http://codereview.chromium.org/100227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15000 0039d316-1c4b-4281-b951-d872f2087c98

HttpNetworkTransaction (to the Socket class).

This is the first step to remove the blocking call on the
destructor of the network transaction, from IO thread.

BUG=9258
R=wtc

Review URL: http://codereview.chromium.org/87073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14998 0039d316-1c4b-4281-b951-d872f2087c98

WebKit gurus, please review the change carefully, WTF::HashMap interface is not well documented, so I have implement
customized hash functions and HashTraits in order to use StringKey as the hash key.

Review URL: http://codereview.chromium.org/100069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14995 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan
BUG=10892
TEST=0


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14994 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14993 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99245

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14991 0039d316-1c4b-4281-b951-d872f2087c98

overlap between tabs.

TEST=Open a few tabs, try clicking on the right half of the close button that's
to the left of the selected tab.

Review URL: http://codereview.chromium.org/99225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14990 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14989 0039d316-1c4b-4281-b951-d872f2087c98

Add two new master preferences (import_bookmarks and make_default_browser_for_user). make_default_browser_for_user will make Chrome default on the first run of Chrome instead of installer doing it. This will allow Chrome to import user profile data from current default browser, before making Chrome default.

BUG=9708,10912

Review URL: http://codereview.chromium.org/99165


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14988 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=7178

Review URL: http://codereview.chromium.org/99229


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14986 0039d316-1c4b-4281-b951-d872f2087c98

Don't show popups before tabs have been added. Instead, prevent the BrowserView from restoring focus to the tab if the window that contains it isn't visible. This prevents blur events from being fired incorrectly.

http://crbug.com/7991

Review URL: http://codereview.chromium.org/99248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14985 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14984 0039d316-1c4b-4281-b951-d872f2087c98

- Renderers should not use COM

TEST= existing tests suffice
BUG= 11205

Review URL: http://codereview.chromium.org/99230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14983 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/99161

TBR=hamami

Review URL: http://codereview.chromium.org/99228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14982 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14981 0039d316-1c4b-4281-b951-d872f2087c98

test_shell on linux/mac.

Review URL: http://codereview.chromium.org/100216


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14979 0039d316-1c4b-4281-b951-d872f2087c98

When forking a child process, one often wants to move existing file
descriptors to well known locations (stdout, stderr etc). However,
this is a process bedeviled with corner cases. Consider the case where
you open two file descriptors, get assigned fds 1 and 0 for them and
wish to shuffle them so that they end up in slots 0 and 1. Our current
code fails in this case.

We also have a problem where we're currently trying to mark file
descriptors as close-on-exec rather than closing them in the child
process. This is inherently broken in a multithreaded process where
another thread can open a file descriptor and race the loop which is
trying to mark them.

Thus, on Linux we switch to close-after-fork where we known that no
other threads exist in the process. On Mac, the code is sufficiently
different that this simple fix isn't applicable and one of the Mac
folks will need to take a look.

http://codereview.chromium.org/100127
BUG=11174


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14978 0039d316-1c4b-4281-b951-d872f2087c98

This uses FSEvents and supports both recursive and non-recursive modes.

TEST=Make sure that tests matching DirectoryWatcherTest.* from base_unittests pass on Mac.

http://crbug.com/10967

Review URL: http://codereview.chromium.org/99057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11200
R=erikkay

Review URL: http://codereview.chromium.org/100213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14976 0039d316-1c4b-4281-b951-d872f2087c98

This needs to be merged with 2.0 (172.x) branch.

TBR=mal
BUG=11198
Review URL: http://codereview.chromium.org/100218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14975 0039d316-1c4b-4281-b951-d872f2087c98

Xiaomei, I just applied the code that you suggested in your email and it worked.


Review URL: http://codereview.chromium.org/99237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11190

Review URL: http://codereview.chromium.org/99243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14973 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 11175
R= sidchat
TEST= See bug. Also check that the dictionary under Chrome\Application\Dictionaries
is lt-lt-1-3.bdic.
Review URL: http://codereview.chromium.org/99241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14972 0039d316-1c4b-4281-b951-d872f2087c98

Used for gears file drag & drop in chrome, define the values of
the drop effect overrides to match the gears definitions.

BUG=7995

Original patch by Noel Gordon via:
http://codereview.chromium.org/99231

Review URL: http://codereview.chromium.org/102016


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14971 0039d316-1c4b-4281-b951-d872f2087c98

- Add a new target to build just what's needed for the webkit layout bots.
- Roll deps for the needed GYP change.
Review URL: http://codereview.chromium.org/100208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14969 0039d316-1c4b-4281-b951-d872f2087c98

of Windows file & string manipulation, enable plugin tests on the Mac.
Review URL: http://codereview.chromium.org/102014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14968 0039d316-1c4b-4281-b951-d872f2087c98