- 06 Sep, 2018 40 commits
-
-
Fabio Tirelo authored
Difference in tests are due to separators between suggestions and footer are not sent in the suggestions list (we already did that on Android). A follow-up CL will delete the feature and all the code that depends on it. Bug: 831603 Change-Id: If2415782182ea7c0deb6d848ed7ae4f4964216f1 Reviewed-on: https://chromium-review.googlesource.com/1204835Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589155}
-
Marc Treib authored
This adds "PrimaryAccount" to the names (in preparation for supporting secondary accounts), and also makes the SignIn/SignOut names symmetric. TBRing trivial call site update in ukm_browsertest.cc TBR=bcwhite Bug: 871221 Change-Id: I136a4e91154a736d58ca67c060c66a09aed8a458 Reviewed-on: https://chromium-review.googlesource.com/1209605 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#589154}
-
Yutaka Hirano authored
With this CL, some request headers that used to be treated as CORS-safelisted are not CORS-safelisted any more. Specifically, - "accept", "accept-language" and "content-language" have a stronger check on its value - All headers whose value exceeds 128 bytes are treated as not CORS-safelisted - If the sum of value length of CORS-safelisted headers exceeds 1024, then all of them are treated as not CORS-safelisted. This CL also implements https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header. This is for https://github.com/whatwg/fetch/pull/736. Bug: 824130 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e Reviewed-on: https://chromium-review.googlesource.com/1196563 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589153}
-
Andreas Haas authored
This CL re-enables regression tests for WebAssembly.instantiateStreaming. See the bug link for the fixes themselves. R=haraken@chromium.org Bug: chromium:860637 Change-Id: I0aee6004c524f4e81adf68891d78341bacbc2237 Reviewed-on: https://chromium-review.googlesource.com/1209742Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589152}
-
Aldo Culquicondor authored
Hover events don't get processed if the source is not set. This change shouldn't affect scrolling performance metrics. Bug: 880879, 877580 Change-Id: I07ae28fcfdebfee77eab57e5659d1150745b6e9a Reviewed-on: https://chromium-review.googlesource.com/1207651Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589151}
-
Wojciech Dzierżanowski authored
Save for remapping hosts according to the rules, MappedHostResolver should be a transparent wrapper around the "real" resolver. Thus, it must forward all HostResolver methods to the real resolver. Change-Id: I34deed523b3cb690d450599c89bfd7f2184e843d Reviewed-on: https://chromium-review.googlesource.com/1209402 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#589150}
-
Denis Kuznetsov authored
All Non-AD enrollment steps, except for authentication: Device requisition, License type, device attributes Bug: 854101 Change-Id: I36eb5abae6865f3a7b5c73ada4620fbb6a70d352 Reviewed-on: https://chromium-review.googlesource.com/1120527Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589149}
-
Daniel Bratell authored
Quick fix to unbreak jumbo builds. In https://chromium-review.googlesource.com/c/chromium/src/+/1205976 a copy of IsShuttingDown was added and this patch changes the code to instead use the original version. TBR=kinuko@chromium.org,nhiroki@chromium.org Bug: 715632 Change-Id: I2451fcaa009ec6403827cdb05cd3b47112c4681b Reviewed-on: https://chromium-review.googlesource.com/1209703Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589148}
-
Eric Robinson authored
This reverts commit 5e2fc13c. Reason for revert: Discovered that this is flaky under Windows and Linux.memory. Will reproduce there. Original change's description: > Re-enabling Cross Origin Verification. > > I've run this test using the Linux Release (with dcheck) 1000 times locally, > and run 3 dry runs here. I haven't been able to reproduce the flakiness > observed initially. I'm unsure if there was an underlying issue that was fixed > or if I need to run on some additional architecture. I plan to re-enable this > and monitor the run tracker so I have a better idea how to address the > flakiness if it still exists. > > Bug: 874443 > Change-Id: Ic3a839fd28a105b1b761ddffca5363803b357cc9 > Reviewed-on: https://chromium-review.googlesource.com/1203933 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588858} TBR=csharrison@chromium.org,ericrobinson@chromium.org Change-Id: I68c86ba816e4e555eee18fc3e744542d80cf7ec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874443 Reviewed-on: https://chromium-review.googlesource.com/1209983Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589147}
-
Maja Kabus authored
Added Idlharness tests for Trusted Types interfaces. Removed "Worker" from "Exposed=(...)" in TrustedXXX .idl files. Bug: 739170 Change-Id: Id8834affcdded63f3ebb9ebd4d288cfd01ef24a8 Reviewed-on: https://chromium-review.googlesource.com/1204150 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#589146}
-
Boris Sazonov authored
This CL fixes enabling/disabling UMA reporting from UnifiedConsentService. chrome::android::SetUsageAndCrashReporting method is added that calls to Java PrivacyPreferenceManager and updates "metrics_reporting" shared preference that is the source of truth for UMA reporting. Bug: 879546 Change-Id: Ia0e2de860bc46a33b716d827d3101a0e060d2721 Reviewed-on: https://chromium-review.googlesource.com/1199084 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589145}
-
Finnur Thorarinsson authored
Bug: 881109, 734095 Change-Id: Ic530a30c653c202c279bf4074022a122cfcba2ac Reviewed-on: https://chromium-review.googlesource.com/1209485 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589144}
-
Markus Heintz authored
This reverts commit 5bf6f1b1. Reason for revert: "compile" error on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2790 "Android CFI" Original change's description: > [Autofill Assistant] Bind the script tracker with the controller. > > With this change, the controller tells the script tracker to run checks > when necessary, calls the UI controller to choose a script to run and > run the script that was chosen. The implementation of the UI controller > for choosing the script is not included into this change. > > Integration is preliminary, just to get something to get started until > we have a usable UI to try it out. The UI part, implementing script > selection, is missing from this change. > > Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 > Bug: 806868 > Reviewed-on: https://chromium-review.googlesource.com/1194034 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589135} TBR=gogerald@chromium.org,mcarlen@chromium.org,szermatt@chromium.org Change-Id: I260f91338731718a99a91cf96add11311739040e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1209922Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589143}
-
David Roger authored
Bug: 873739, 873644 Change-Id: I02e0819130678a1398106f0d0faf8068456e28dc Reviewed-on: https://chromium-review.googlesource.com/1196451 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589142}
-
Marc Treib authored
- Update some comments for accuracy - Remove unused methods and includes - Add some "const"s Bug: none Change-Id: Ia45237757b101af7ff0886dadff9ef9e622a2cc2 Reviewed-on: https://chromium-review.googlesource.com/1208526 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#589141}
-
Mikel Astiz authored
We agreed to prefer the ShouldXXX convention for new code. This patch renames previously existing tests accordingly, prior to adding new ones in follow-up patches, to avoid violating the local consistency principle. Bug: 830535 Change-Id: Idb9f87f06ff1e4d886f0c4d3d34180e43eca29f2 Reviewed-on: https://chromium-review.googlesource.com/1209483 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589140}
-
Fredrik Söderquist authored
To have a chance of seeing what might be problem here (if it still exists) we need some historical data, since there appear to be no obvious issues with the test as such. Bug: 805292 Change-Id: Iccbb92e2a324533858ee42802eaa2fa7ebc2240c Reviewed-on: https://chromium-review.googlesource.com/1209363Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589139}
-
Daniel Vogelheim authored
(Follow-up to cl 1165351.) Bug: 751996 Change-Id: I37b57e239dced37fc5390d5db4b42cdc8be7466d Reviewed-on: https://chromium-review.googlesource.com/1177607 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#589138}
-
Mythri Alle authored
V8 also stores code caches for inline scripts in the html resources. This cl updates ResourceLoader to fetch cached code for inline scripts in MainResources. Bug: chromium:880212, chromium:812168 Change-Id: I822453b52897aac292444df20e50937d8198064d Reviewed-on: https://chromium-review.googlesource.com/1208391Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589137}
-
David Roger authored
It is suspected (from external data) that calls to Gaia in general, and ListAccounts in particular, have an abnormally high network failure rate. This CL adds Chrome metrics to measure the failure rate of ListAccounts, to see if the phenomenon can be observed through Chrome metrics: "Gaia.AuthFetcher.ListAccounts.NetErrors" Additional histograms are added to track the failure rate of ListAccounts depending on system uptime and process uptime, because one of the hypothesis is that network requests are generally more likely to fail on system or process startup, and ListAccounts requests tend to be done at startup. The Signin.ListAccounts.Failure histogram now also records success, so that it can be used to compute failure rates. "Gaia.AuthFetcher.Multilogin.AuthErrors" is also added to track success rate for OAuth2 multilogin, which needs to be monitored as it is ramped up. Bug: 876306 Change-Id: I3feb3a48ba43b79559fe1aacd78ce51eb0b86a38 Reviewed-on: https://chromium-review.googlesource.com/1195463Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589136}
-
Stephane Zermatten authored
With this change, the controller tells the script tracker to run checks when necessary, calls the UI controller to choose a script to run and run the script that was chosen. The implementation of the UI controller for choosing the script is not included into this change. Integration is preliminary, just to get something to get started until we have a usable UI to try it out. The UI part, implementing script selection, is missing from this change. Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1194034 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589135}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 37ae5d1a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24162 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I49095b178555d204524cc2286910fad57c1b6166 Reviewed-on: https://chromium-review.googlesource.com/1208199 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589134}
-
Max Morin authored
Bug: 881224 Change-Id: Ic6f18c1a7b5164175a70c9ebaade6722244b02fa Reviewed-on: https://chromium-review.googlesource.com/1208271Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589133}
-
Marina Ciocea authored
This reverts commit 9624dedb. Reason for revert: breaking webrtc tests: https://ci.chromium.org/buildbot/chromium.webrtc/Linux%20Tester/42679 Original change's description: > Temporary check global histogram allocator in audio service output controller. > > Add a temporary check to investigate audio service experiment output controller > histograms count mismatch. If histogram persistent memory is not setup before > output controller metrics are reported, the check will fail > (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days > after gathering data from canary. > > Bug: 867827 > Change-Id: I1f18c12c2aa2741a27c0bf82f383de70e273fd24 > Reviewed-on: https://chromium-review.googlesource.com/1205606 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589117} TBR=olka@chromium.org,marinaciocea@chromium.org Change-Id: I238d02410407268ca30f06666d346181158624a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867827 Reviewed-on: https://chromium-review.googlesource.com/1209542Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589132}
-
Ivan Sandrk authored
Previously, in Public Sessions, activeTab API usage was causing a permission prompt to be shown to the user because it was deemed very powerful. This restriction now went away in Managed Sessions so adjust behaviour. Bug: 865947 Change-Id: I8651865bfa3652c594b54dcbd968bf6c35a1b9f2 Reviewed-on: https://chromium-review.googlesource.com/1202147 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589131}
-
Mythri Alle authored
URLLoaderClientImpl should check for both is_deferred flag and for any pending messages in the DeferredMessage queue (NeedsStoringMessages) when handling messages. We already use NeedsStoringMessages check when handling certain messages. This cl also adds this check for the remaining types: ResponseBody and TransferSizeUpdates. Change-Id: Iac710721f23a7bd60340956b03dcbeae8eee338d Reviewed-on: https://chromium-review.googlesource.com/1207251Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589130}
-
Friedrich Horschig authored
Before this CL, elements like Duet's bottom toolbar are drawn over the keyboard accessory sheet. Therefore (just as the accessory bar), move the accessory sheet to the front before showing it. That ensures that elements that don't treat the sheet as a keyboard (yet) are overlaid and hidden. The accessory isn't click-through and reduces the content area which effectively hides all elements below it as if they weren't there. Bug: 880253 Change-Id: I7fb201c6dcc9e15c3c31df8e0b9650225826873a Reviewed-on: https://chromium-review.googlesource.com/1209282Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589129}
-
Fredrik Söderquist authored
StyleFetchedImage and StyleFetchedImageSet needs to take the URL into consideration because it can contain a fragment that will require the image to change. Bug: 643716 Change-Id: If87d3583df0fcb37f872c1423a88f4bd33e8c38f Reviewed-on: https://chromium-review.googlesource.com/1207390Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589128}
-
Fredrik Söderquist authored
TBR=schenney@chromium.org Bug: 880983 Change-Id: Ic31f977a104c95d1896ec4855c7be2c37e1e68d1 Reviewed-on: https://chromium-review.googlesource.com/1209342 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589127}
-
Joel Hockey authored
Only show the 'Share with Linux' menu item for subfolders of downloads. Added getMetadata method to Linux files FakeEntry which is called when 'My files' is selected and 'Downloads' and 'Linux files' are shown in right hand files list. Tests verify that 'Share with Linux' menu is not shown for: * Downloads root * Folders in crostini * Folders in drive Bug: 878230 Tbr: lucmult@chromium.org Change-Id: I4afcaaa667d6cb7e5ec10ea3659819a937a2bedf Reviewed-on: https://chromium-review.googlesource.com/1209006 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#589126}
-
Matt Falkenhagen authored
Before this CL, we called DidEvaluateClassicScript() with false, but this doesn't actually terminate the thread and is counted as a successful startup by the browser. It's only terminated in when the script is being installed, by ServiceWorkerRegisterJob. Since M69, we'd get a process kill because the timing milestones wouldn't make sense, as script evaluate start would be null (zero). This CL makes startup fail, sends OnStopped to the browser process, and terminates the worker thread. Bug: 881100 Change-Id: I452986d8a51344a7ba465fd5c91861bf2443e15e Reviewed-on: https://chromium-review.googlesource.com/1208997 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589125}
-
Yuki Shiino authored
When I first implemented IDL callback function, there was no use case of [TreatNonObjectAsNull], and I didn't support it. However, now we're going to implement EventHandler of HTML, which uses [TreatNonObjectAsNull], based on IDL callback function. So, this patch supports [TreatNonObjectAsNull]. Bug: 872138 Change-Id: I2c4b7bd3b321e23cf27f4442ffa72ff76dc15e85 Reviewed-on: https://chromium-review.googlesource.com/1206790Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589124}
-
Olivier Robin authored
The Form activity observer is now isolated from ios/web. Move the FormActivityParams to the component. Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4a8b9184587214a4c57839440e5ef812557b917a Reviewed-on: https://chromium-review.googlesource.com/1193880Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589123}
-
Hiroki Nakagawa authored
This CL makes SharedWorkerServiceImpl increment the reference count for the renderer process keep alive before asynchronously creating a script loader. Before this CL, the reference count is incremented after the script loader is created. This crashes a test that forcibly terminates the shared worker during loader creation because the termination tries to decrement the refcount and hits the DCHECK to make sure the refcount is non-zero. Bug: 715632 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I322a5da1215da67e027005afb0544c3b95090113 Reviewed-on: https://chromium-review.googlesource.com/1205976 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#589122}
-
Chih-Yu Huang authored
Originally we calculate the output buffer size by this formula: (width * height + 32768), but we cannot guarantee it is enough. In this CL, the new formula is: min(2MB, width * height * 1.5) 2MB is empirically big enough for current usage, and (width * height * 1.5) is uncompressed buffer size. Both are feasible upper bound of the output buffer, so we choose the minimum one. BUG=b:113309237 TEST=pass testOtherH264FlexArbitraryH and testOtherH264FlexArbitraryW CTS at cyan device TEST=pass VEA unittest Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie53f79a9997420e1aad57168ad16f9e9718e4a54 Reviewed-on: https://chromium-review.googlesource.com/1195175 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589121}
-
HobeXD authored
I add a tracing tool in ChromeOS, and this is the Chrome side code to interact with the hal_adapter in ChromeOS through mojo. Also add the tracing of the camera capture request and get result. CQ-DEPEND=CL:1158095 BUG=b:109714458 TEST=Open about://tracing in Chrome, click Record, and choose CrosCamera. Open any camera app, and close it. Click Stop button in Chrome, and there will have some events show on the UI. In the process of camera service, and if you open the camera in chrome the browser process will also have some events. TEST=Pass capture_unittests Change-Id: I1ae67b8ca49d63679228eea5b579818b0b3d3686 Reviewed-on: https://chromium-review.googlesource.com/1158106 Commit-Queue: Jyun-jhe Chou <hobexd@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589120}
-
Vadym Doroshenko authored
These functions are used for allowing the user to change username and password in save prompt. Bug: 831123 Change-Id: I8fe155ab543db58f6bc893c2e9e3280c12ab1428 Reviewed-on: https://chromium-review.googlesource.com/1206331 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 26007adf. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24161 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I243449ebeb3e3e842f25a8d3cfc4e7716a13fb20 Reviewed-on: https://chromium-review.googlesource.com/1208198 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589118}
-
Marina Ciocea authored
Add a temporary check to investigate audio service experiment output controller histograms count mismatch. If histogram persistent memory is not setup before output controller metrics are reported, the check will fail (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days after gathering data from canary. Bug: 867827 Change-Id: I1f18c12c2aa2741a27c0bf82f383de70e273fd24 Reviewed-on: https://chromium-review.googlesource.com/1205606Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589117}
-
Vadym Doroshenko authored
When new parsing for saving enabled PasswordManager::MoveOwnedSubmittedManager tries to find submitted NewPasswordFormManager and if it's found it's moved. As result there is nullptr in |form_managers_|. That would crash this function if it's called twice. This CL makes this function behaves gracefully - to remove nullptr. Bug: 880229 Change-Id: I7f91a113dc33a6a2d0b483485a66657bec9e6d28 Reviewed-on: https://chromium-review.googlesource.com/1206591Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#589116}
-