- 19 Aug, 2020 3 commits
-
-
Sky Malice authored
This reverts commit b27232d7. Reason for revert: Test failures, see crbug.com/1117676 Original change's description: > [PwdCheckAndroid] Add redirect to Google Password Check on quota limit > > This CL adds the logic to redirect the user to the Google Password > Check on quota limit error. The redirect is called through > PasswordCheckBridge to avoid dependencies on chrome_java. > > IDS_PASSWORD_CHECK_STATUS_MESSAGE_ERROR_QUOTA_LIMIT_ACCOUNT_CHECK.png > https://storage.cloud.google.com/chromium-translation-screenshots/c4546cf199aa6314ead807fa1fc0e1ed8b779a83 > > Bug: 1092444 > Change-Id: I374ad088c305d299fea00f412f27dd6ab3d0e9b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362023 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Eleonora Rocchi <erocchi@google.com> > Cr-Commit-Position: refs/heads/master@{#799117} TBR=fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com Change-Id: I38a6779f2a9a278317ab5ce2be2edb0742e34f34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363444Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799397}
-
Eric Roman authored
This also moves udp_socket_test_util.cc into the test/ subdirectory, in order to satisfy existing DEPS rules. Bug: 1083278 Change-Id: I45fd4ceb8b46e0464ff0cd2a41a897efa294f64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360125Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799396}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/e1e5e502ea64..abf77f1b3891 $ git log e1e5e502e..abf77f1b3 --date=short --no-merges --format='%ad %ae %s' 2020-08-18 wub Internal QUICHE change 2020-08-18 fayang Add a stable enum for QuicFrameType for logging purpose. 2020-08-17 renjietang In QUIC, change OnOneRttKeysAvailable() to OnTlsHandshakeFinished(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iebc4860945ebbc443c531172a1cc234463c4568d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363807 Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799395}
-
- 18 Aug, 2020 37 commits
-
-
Tommy Li authored
This CL refactors ZeroSuggestProvider::TypeOfResultToRun to take an AutocompleteInput as a parameter instead of just the current page URL. We need this because differentiating the on-focus vs. on-clobber ZeroSuggest modes requires access to AutocompleteInput::focus_type(). This CL also makes the method 'static', for three reasons: 1. The function is more easily testable when it only depends on its parameters, rather than any state in the member variables. 2. The member variables store data that's also in the |input| parameter, and I didn't want to introduce ambiguity as to which is used. 3. We plan to split MostVisited into its own provider, and we will want to share some logic from TypeOfResultToRun. Making this method static is a step towards that future. For reviewability, this CL actually has no functional changes, and just moves things around. The followup CL will actually add the on-clobber vs. on-focus logic to TypeOfResultToRun. Bug: 1106096 Change-Id: I69c8f2f08a182796be9ce1c66611fe6788a6158a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360562Reviewed-by:Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799394}
-
Steven Bennetts authored
This is in preparation for adding UI to allow users to set a custom DHCP hostname. Currently the policy code is always setting the hostname, even if kDeviceHostnameTemplate is not set by policy, which overrides any other custom set hostname. Bug: 1103272 Change-Id: Ia99ee58c59ae1f38e8fe10ed693997dead861c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320991 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799393}
-
Sammie Quon authored
Original thought the dark ripple was for the dark background. Test: manual Bug: 1117203 Change-Id: I3221271f8bb1d1d32a8832c75a46c0b8f726426e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363997Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#799392}
-
John Palmer authored
Should be 8px, old number worked out to 16px BUG=1117379 Change-Id: Ic6cef89a6c9b93fab24b538f13d6c07fa4f06647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362062 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799391}
-
David Bokan authored
As part of splitting out input from LayerTreeHostImpl I found some issues in tests that use FakeLayerTreeHost. This class also initializes a FakeLayerTreeHostImpl which is used in some tests. However, some tests also call InitializeSingleThreaded to use the FakeLayerTreeHost with a Proxy. Initializing a Proxy will call LayerTreeHost::CreateLayerTreeHostImpl which currently creates a (real) LayerTreeHostImpl that's owned by the Proxy. These tests are incorrectly running with multiple LTHI objects. This CL overrides CreateLayerTreeHostImpl in the fake so that this method creates a fake Impl object. We also avoid manually creating a fake Impl inside the FakeLayerTreeHost and instead rely on the call to CreateLayerTreeHostImpl to store a pointer to the fake impl. For tests that don't use a Proxy, we now manually call a new CreateFakeLayerTreeHostImpl method that does the same thing and the FakeLayerTreeHost takes ownership of the Impl instead. Bug: 915926 Change-Id: I63202e1717d2eab026688d69c8d0ef75939c7c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363247Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799390}
-
Miguel Casas authored
ToT VaapiWrapper has a simple report-to-uma callback that clients have to implement and that usually just points to "error happened" in either the normal or the Vpp VaapiWrapper. This CL changes that: - VaapiWrapper provides a function for this: ReportVaapiErrorToUMA(). - Clients bind their histogram (eg. Media.VaapiVideoDecoder.VAAPIError) to that new ReportVaapiErrorToUMA() method. - A new VaapiFunctions enumeration (with a matching UMA enum) is added to vaapi_wrapper.cc to identify which concrete vaBla() function failed, and is logged to UMA. This forces ToT UMA histograms (and associated enums) to be marked as obsolete, namely: -Media.VAJDA.DecoderFailure -Media.VAJDA.VppFailure -Media.VAJDAWorker.DecoderFailure -Media.VAJEA.VppFailure -Media.VAVDA.DecoderFailure -Media.VAVEA.EncoderFailure New ones are landed instead (with associated VaapiFunctions enum): -Media.VaapiImageDecodeAcceleratorWorker.VAAPIError -Media.VaapiJpegEncodeAccelerator.VAAPIError -Media.VaapiJpegEncodeAccelerator.VAAPIVppError -Media.VaapiMjpegDecodeAccelerator.VAAPIError -Media.VaapiMjpegDecodeAccelerator.VAAPIVppError -Media.VaapiVideoDecodeAccelerator.VAAPIError -Media.VaapiVideoDecoder.VAAPIError -Media.VaapiVideoEncodeAccelerator.VAAPIError -Media.VaapiVideoEncodeAccelerator.VAAPIVppError This CL also adds two new boolean histograms for VaapiVideoDecoder, who had none. Bug: b:162962069 Change-Id: I561e48183f61de86247598fea4f3b10cd590c2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339787 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799389}
-
Becca Hughes authored
For normal images contentAttributes are optional in the spec but the converter requires them. This makes them optional. Change-Id: I4073de51009e6e7802667b2d79a7ad485d939978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363477 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#799388}
-
Evan Stade authored
Bug: 1110930 Change-Id: I20914d3f88ad98944e0f5525421bc666cc79eb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363696Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799387}
-
James Cook authored
Add support for image, list, and progress notifications. This involves serializing the RichNotificationData structure. Move some existing crosapi::Bitmap serialization code into a shared utility file. Add deserialization to SkBitmap. For now the image format is hard-coded. crbug.com/1116652 tracks more flexible image serialization. Add unit tests for both ash side and lacros side. Bug: 1113889 Test: unit_tests, manual with Notifications Galore chrome app Change-Id: I27b1c74f828751f35d845e625052386530de9722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357749 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799386}
-
Daniel Cheng authored
The current browser-side navigation code can ask the renderer to commit a MIME type that it cannot handle. When this happens, the renderer simply ignores the commit request, tripping the CHECKs added in https://crrev.com/796508. For now, allow these commits to silently fail and not commit a new document... Bug: 999255, 1115912, 1117282 Change-Id: I435831058db8e059b0389a8e2262f6bd72e875fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360602 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#799385}
-
Anupam Snigdha authored
Before this change we used to set the pointer type to touch only when DoDefaultAction was called. This led to issues as sometimes I don't see this API being called when narrator is active and the user double taps on the edit control to set the selection. VK should show up when caret starts blinking in the edit control, so we set the pointer type to touch when we receive focus from the narrator and then in blink we invoke a call to show the VK if the focus happened to be inside an edit control. FWIW, I discussed this with narrator team and it is hard to come up with a solution that is deterministic and reliable as narrator eats up all the gesture events and VK is controlled by a different component that relies on VK show call from Chromium when input modality is touch and input policy is set as manual(Chromium specific). This solution is just a heuristic. Bug: 1106556 Change-Id: I12fcfcda52ba058ed5377b0312e6652988dacced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361045Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799384}
-
Kenichi Ishibashi authored
crrev.com/c/2340417 replaced a C++ method call with a mojo method call. Apparently, the method, GetUserDataForAllRegistrations(), is called when a profile is created on weblayer. It seems we need to wait for the callback of GetUserDataForAllRegistrations() to be completed when a profile is created or updated. Bug: 1115172 Change-Id: I2b5f6614171b3502130127109bbe6822493f5497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352268Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1Xg4VKZ7YWNS4jUpxoXOWXP5yI8Gy7HzaUIBzplrDkOA Bug: 1112872 Change-Id: Ic78efa44cdd30350e6f82875b483807ae1baca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360230Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Meredith Lane authored
This CL is a follow up to https://crbug.com/1016615, and stores the users chosen font magnification size as a preference. AXRelnotes: N/A Bug: 1016615 Change-Id: I4a2331edf7d36fa12a5e260fef863cd495d90bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212222Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#799381}
-
Orin Jaworski authored
This CL fixes the translate Pedal behavior by relying on the translate manager to determine appropriate page translation, languages, etc., instead of driving the UI directly with info from client and language state. The new behavior is described in the translate manager comment: Initiate a manually triggered translation process for the current page. Collect source and target languages, and show translation UI. If |auto_translate| is true the page gets translated to the target language Bug: 1117542 Change-Id: I270d29f966646bbf4508c4e041383bcb47e5ed26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363907 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799380}
-
Akihiro Ota authored
This change: 1. Adds content for tab, shift + tab, enter, and using selects to the OOBE tutorial. 2. Makes lesson content reachable via tab and shift + tab. Bug: 1075752 Change-Id: I79ad352c15cf6483b12c43dd43611c891f93f669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358133Reviewed-by:
-
Dirk Pranke authored
This adds an optional --isolated=outdir=PATH flag to the test executable API; this gives the test runners a stable path to the output directory from a swarming task, so that we can key other files off of it without needing to pass them all explicitly via the command line. This also adds the arg to the isolated_script wrapper, so that we those types of tests can handle the flag (by ignoring it for now). We may need to work through the other cases (like gtest tests) individually, which will be done in subsequent CLs. Bug: 816629 Change-Id: Ibff6a47544bf94af5d7693a8446dfb669351cc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358604 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799378}
-
Christian Biesinger authored
This exposed a bug where we don't correctly compute the cross size in a column flexbox with aspect-ratio. R=ikilpatrick@chromium.org Bug: 1045668,1117279 Change-Id: Ic823ed349e2caf061834e116d5958832745cd63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358827 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799377}
-
Peter Kotwicz authored
This CL renames IDS_SHOW to IDS_SHOW_CONTENT in components/component_strings.grd so that it no longer conflicts with components/browser_ui/strings/android/browser_ui_strings.grd I renamed the string as opposed to deleting the copy because the two strings are used for different purposes. IDS_SHOW in //components/component_strings.grd is used to toggle hiding and showing content IDS_SHOW in components/browser_ui/strings/android/browser_ui_strings.grd is used as text in button in a dialog. BUG=1093825 Change-Id: If77186cd7c52c3cdb0002b05d9c91628421a5ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358770 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#799376}
-
Jonah Ryan-Davis authored
We should enable webgl testing on these bots: Optional CQ - Intel and AMD ANGLE CQ - Intel and AMD FYI - Intel, AMD, NVIDIA and ASAN Bug: angleproject:4846 Change-Id: I6368808a15afcd4588676892cb8bf47c0da6b085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302930 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799375}
-
David Black authored
Previously, a notification for a firing timer in v2 would have a "CANCEL" button. This is being relabeled to "STOP". Previously, a notification for a firing timer in v2 would only popup to the user if it hadn't already been marked as read. It would be marked as read if the user interacted with it. Now, we will cause the notification to be "renotified" to the user when the timer is firing. Bug: b:165306385, b:165306366 Change-Id: Ieaace3594fc5294abbd76a892f4df35d85c618ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363449 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799374}
-
Becca Hughes authored
Makes sure we don't load non-JS module code as modules and also updates the NTP so it can embed chrome-untrusted://kaleidoscope. Change-Id: I8027daec3a31bdc42d22fb40c1d733b7f3dd6cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360475 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799373}
-
Ahmed Mehfooz authored
Bug: 1106012 Change-Id: I58d4ec83d6367dd62d94c326f48118e81b1ddc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355830Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Extend expiry of: - OAuth2Login.PreMergeVerification - OAuth2Login.PostMergeVerification histograms till M88. Bug: 1089119 Change-Id: Ied8791647017ce19cba738ea57c269a97a756d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362787Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#799371}
-
John Delaney authored
What: Defer creation/opening of the sql database until there is a storage operation which needs it. Why: We unconditionally create the database for every storage partition whether the API is being used which is unnecessary. This has the added benefit of not forcing the database to be initialized in every browsertest once the feature is enabled by default. How: Use the presence of the database file as a signal for creation. If the file path doesn't exist, we can defer creation until an impression is stored. No other operations need to create the database as it is empty and would be a no-op regardless. If the database path does exist, we defer opening the database until any operation is called, as there may be conversions that need to be sent or impression to convert etc. Change-Id: I25446805a991f04fcbf9aa237195950d055558aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360471 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#799370}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1fdbb29361cc3d76d4b61a841ad107e906fb7a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5012a13f63ac..c24096ed3b5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1111893,chromium:912681 Tbr: tommycli@google.com,csharp@google.com Change-Id: I0fbaa31b1b0ba48c74a725b0231c381410233a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799368}
-
Robert Ma authored
Also re-organize the structure of the doc to make it a bit more logical. Bug: 1094512 Change-Id: I230de88902da3d4162af5f10332f7262a8465fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363303 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799367}
-
Sinan Sahin authored
Relands crrev.com/c/2246834 apart from the field trial testing entry and adds the command-line flag to more tests in test_suites.pyl. Benchmarks in tools/perf/benchmarks are run on offline devices, and this causes the offline indicator to show, affecting the stories being run. Showing the offline indicator isn't realistic when the test is simulating navigating webpages that would normally require the device to be online. Also, showing the offline indicator might cause flakiness in the results or dilute real regressions. We've investigated the reported regressions and confirmed that they're WAI when the indicator is showing. This CL adds a command-line switch to prevent the offline indicator from showing and adds the switch to related benchmarks. Bug: 1091491 Change-Id: I60a573a527b041ef986a7cddaf5d4705629fc8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358509 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Dan Harrington authored
Bug: 1044139 Change-Id: I31fea9098e29e0c0bc700a4ab646c402e55bf003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357621Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799365}
-
Peter Boström authored
This prevents dialogs from being instantly accepted on Mac if holding VKEY_RETURN as the dialog pops up. Specifically it addresses a security issue where people can be tricked into holding enter while the site pops up a folder-selector dialog. The attack worked as following. The attacker tricks the victim into holding VKEY_RETURN. While the key is being held, the attacker triggers folder upload, which the OS auto-accepts by holding VKEY_RETURN. Before this change, FolderUploadConfirmationView would trigger on Mac with this VKEY_RETURN. With this change, the victim at least has to re-press VKEY_RETURN, which they are presumably at least more likely to notice. This also adds initialization of the EF_IS_REPEAT flag on Mac from [NSEvent isARepeat]. Hopefully that doesn't have wider negative consequences where ui::Event and NSEvent disagrees on the definition of a repeat event. Bug: 1097724 Change-Id: I3bb0589867cbfa059a2406e73ef43e66b5326fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357520Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c2650ad..df143e8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I573a2c4de279a1db4890d6bd9050a7cec8f2804b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799363}
-
Alex Gough authored
Following https://phabricator.services.mozilla.com/D54699 we do not need to supply the handle for the shared memory IPC mechanism to the child until the IPC server has been initialized. Bug: 1092010 Change-Id: Id82f88513b77db159adf96dbac577ed80de1d37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337394 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799362}
-
Ankit Kumar 🌪️ authored
Migrate all instances of pp::Point to gfx::Point/gfx::Vector2d at PDFEngine interface. The internals still have pp::Point dependency but the interface is now independent of pp::Point. The internal dependency will be migrated in a subsequent CL. Bug: 1101101 Change-Id: Ib8a729314ec6101183281235d35afc697a243b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326512Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799361} -
Wei Lee authored
Since we are about to migrate CCA to SWA, we should avoid using chrome.* API so that we can have it work on SWA as well. Therefore, replacing chrome.system.display API by our own mojo API. Bug: 1114967, 980846 Test: Launch CCA without showing error messages Change-Id: I89aaf3f2700adfade8dd8eae32554ac095bb0ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354109Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799360}
-
Yuke Liao authored
This CL moves interactive_ui_tests out of experimental state so that it's sherrifed to prevent regressions. Bug: 1111979 Change-Id: Icb1f00acb09939b01b2946256bcf334611fba3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363024Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799359}
-
Olesia Marukhno authored
Bug: 1117550 Change-Id: I7ac6b9323174fa91f33471b7aa9202d2cec0de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362792Reviewed-by:
-
