- 22 Jul, 2020 40 commits
-
-
Boris Sazonov authored
No behavior change - remove redundant ChromeSigninController.java entry from components/signin/public/android/DEPS. Bug: 1046412 Change-Id: Iebceb3d52477755d28a6379d20a6998931b0941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310534 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790784}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/492e4daa3747..6e1eb168a544 2020-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 20eb9be55299 to f6659b3df028 (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1107884 Tbr: robertphillips@google.com Change-Id: I881b5dc9e893dd90fe3541d76aacdd9c36fb8bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790783}
-
Boris Sazonov authored
Cleans up GoogleServicesManager to simplify upcoming changes to this class. No behavior change. Bug: 1107942 Change-Id: I586ec4a9e8edffef6c4f50a39f541c562c9f90fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310669 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Pâris MEULEMAN authored
This adds the support for report-only COOP triggered Browsing context group switches. During navigation, besides computing whether COOP triggers a BCG switch, this also computes if any of the report-only policies would also trigger a switch if they were effective, the resulting values are stored in booleans within |CrossOriginOpenerPolicyStatus|. This booleans are then used to trigger the navigation reports, and in a follow up to trigger access reports. Explainer [WIP]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md Specification [WIP]: https://github.com/whatwg/html/pull/5518 Bug: 1099208 Change-Id: I2cb66ec5cdcd9d5b4658c28f0608bc6b52d0da6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241529 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790781}
-
Jason Lin authored
Terminal cannot start up if the user block cookies for all sites. This cl will exempt terminal from it. Bug: 1101060 Change-Id: I6c75dad423f5df9de4ac9d6e19469acc433f9fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310024Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#790780}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2675d65f6664..9dd9a4b88264 2020-07-22 jobay@google.com Roll Puppeteer from v4.0.0 to v5.2.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2fabeeb2a85312896d58366c03ba54c1e022ef42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311948Reviewed-by:
-
Mikel Astiz authored
TBR=dmurph@chromium.org Change-Id: I5e2e85f79906bd37fabab55b04c437adf03fcfbf Bug: 1108172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310336 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790778}
-
Victor Hugo Vianna Silva authored
The check is redundant as it's already implied by IsEngineInitialized(). It's also misleading since the introduction of TransportState::PAUSED in crrev.com/c/2302149. Bug: None Change-Id: I18325269b0a4eee8b011e63588d95e41b404a978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310335Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#790777}
-
Arthur Sonzogni authored
This reverts commit 5fec4b13. Reason for revert: Still crashing. Same bug. Original change's description: > [Paint Preview] Re-enable flaky test > > This re-enables PaintPreviewPlayerTest#overscrollRefreshTest. > The failure cannot be reproduces locally and the bot on which this test > was flaking has been killed recently [1]. > > [1]: https://chromium-swarm.appspot.com/bot?id=luci-chromium-ci-xenial-us-central1-b-8-76-mhb1 > > Bug: 1093083 > Change-Id: Ifacf72e3373fbcfa513d5f8bc87afec03c0c086e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252578 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779899} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093083 Change-Id: I840c3767fd305fb677824456834bfa2a2e506a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311580Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790776}
-
Mohamed Amir Yosef authored
This CL make sure that for account storage users, CredentialManagerPendingPreventSilentAccessTask runs against both the profile and account stores. It also introduced unit testing. Bug: 1093286 Change-Id: Id75bab28bad0b132470eaf4de53e472566dc9027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308422 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790775}
-
Yuki Shiino authored
In order to fill the gap between the old and new bindings generator, implements IDL sequence<enumeration> as Vector<V8GeneratedEnumClass> (was: Vector<String>). Bug: 839389 Change-Id: I3071406a8df088c70973b4069a778f8bdfa27660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068402 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790774}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id27998f08de4b128b3390642fe3b02d57ffe6464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311066Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790773}
-
Maria Kazinova authored
needed. When pending credentials for newly added credentials are created, some elements of a parsed PasswordForm structure must be reset. And they are reset, but the corresponding unique_renderer_id is not cleared, making it hard to rely on unqiue_renderer_id in some logic. Change-Id: I6881ed83410db9dc2ac6850e0c0317003a31647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308717Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790772}
-
Jose Dapena Paz authored
GCC: prevent clash of PageScheduler getter with PageScheduler type in scheduler affecting features test. Bug: 819294 Change-Id: I35924bdf9697d2fd4080dd4ff549bcb51d4eef1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310989Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#790771}
-
Benoit Lize authored
PartitionAlloc used to have a "generic" variant, and a specialized one. This is no longer the case, so remove needless "Generic" in the constants, and fix now-incorrect function/class names in comments. Bug: 998048 Change-Id: Icb72a60fee5fa005de9bd7b40c5cbbb1ce37ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310352Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/398319047f2c..14ddd018d942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: I8d8782c13541eab45c5936c018f280fb0e23b644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790769}
-
Friedrich Horschig authored
This CL replaces the image view with the default more button in Chrome. When clicked, it opens a menu that offers the delete option which ends up asking the bridge to remove the selected credential. Additionally, this CL fixes some enum declarations and provides a minimal implementation for the PasswordCheckObserver in order to set up and test the wiring for the event handling path. Bug: 1106726, 1092444 Change-Id: I2ef8cf1fa037fbbd6e83097f6bbbd07fdfe65e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306260Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790768}
-
arthursonzogni authored
MediaCanPlayTypeTest.CodecSupportTest_HLS MediaCanPlayTypeTest.CodecSupportTest_mp3 MediaCanPlayTypeTest.CodecSupportTest_mp4 TBR=dalecurtis Bug: 1090770 Change-Id: I484d9840b343386f696d563aab3182219a69822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310536Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates PageMsg_SetInsidePortal to the blink's PageBroadcast interface as InsidePortalChanged method name. Additionally, this CL adds |is_inside_portal| parameter to WebView::Create to remove SetInsidePortal in WebView because it is only called by RenderViewImpl::Initialize once. Bug: 1102426 Change-Id: I2d981efefb380d2e3d92f5eb862b939975564603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302974 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#790766}
-
Victor Hugo Vianna Silva authored
crrev.com/c/1478878 started exposing the web signout state as a DisableReason in the SyncService API. This caused a number of bugs when kStopSyncInPausedState was enabled, the main reason being that the presence of a DisableReason causes the class to consider sync-the-feature as disabled. The CL removes the DISABLE_REASON_PAUSED and adds a new transport state PAUSED. IsEngineAllowedToStart() now checks that a) no reason to disable sync-the-feature exists; b) sync is not in the paused state. The feature flag is still kept as DISABLED_BY_DEFAULT, pending experimentation on Canary/Dev. TBR=parastoog@google.com Bug: 906995 Change-Id: I533da440835330ffbbbaaf3862b9343f16149f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302149 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Kent Tamura authored
Also, add many #includes to *.cc files which relied on local_frame.h in the headers. This CL has no behavior changes. Bug: 242216 Change-Id: Id6ab1f10ef5444b3d99847aab4fd240a8f51a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311602 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790764}
-
dizg authored
Bug: 1105865 Change-Id: I6a2b6ef0ec3e73511be20be190f74de64a5a8b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302619Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#790763}
-
arthursonzogni authored
Same as in: https://chromium-review.googlesource.com/c/chromium/src/+/2306043 Disable failing MediaCapture tests on Lollipop and Marshmallow Tablet Tester bots. Tests: MediaCaptureTest#testMediaCapture_basic MediaCaptureTest#testMediaCapture_rememberPermission MediaCaptureTest#testMediaCapture_twoStreams MediaCaptureTest#testMediaCapture_twoStreamsNotification For unknown reasons, the previous patch was ineffective. This patch tries to disable based on the Android version. BUG=1107380 TBR=estade@chromium.org Change-Id: I471cbaa1b29f47c378c9fc03a394aa39f089944b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311579Reviewed-by:
-
Maksim Moskvitin authored
This file isn't even used in any build.gn files. Bug: 1105388 Change-Id: I4b4ab6c7c24b1f260b8a4cbb2c3c02697bba7574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296086 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibfe5317a1c300bd3628f66aac1d6cd3896b37a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311945Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 6b1e649d. Reason for revert: Fail to compile. https://crbug.com/1108238 Original change's description: > Merge blink::WritingDirection to mojom::TextDirection > > In this CL, WritingDirection {kNatural, kLeftToRight, kRightToLeft} is > replaced by TextDirection {UNKNOWN_DIRECTION, RIGHT_TO_LEFT, > LEFT_TO_RIGHT} and dependant files are ported to use |TextDirection| > enum. > > Bug: 1088377 > Change-Id: Iac185f2d34eddd78127c3f59b7dc90fe380b5f34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306127 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Cr-Commit-Position: refs/heads/master@{#790314} TBR=kojii@chromium.org,abhijeet@igalia.com Change-Id: If73ac51c1f0ed22c4a1962884c735d70eb9dd7b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310537Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595373454-95f078484e58a8592358a4d377034f6d1c7c30df.profdata to chrome-win32-master-1595383207-383ffdc8ec941b58d960256b6aec4daee6f9b86f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I01d3e318dad670a9b2a00d5d4ca41c7a44b0a14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311624Reviewed-by:
-
Jeremie Boulic authored
Add "need password" enumeration values for the CrosDisksClientMountError and CrosDisksMountTypeError metrics. Bug: 912236 Change-Id: I099c9801f5fd1651fae016c89472e084f06651cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303935 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#790757}
-
Mugdha Lakhani authored
Now that all prerender browsertests have been ported over, delete the class the unused methods. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I069ba05d37e11f40e82d867e32cea2e15e07cdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307336Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#790756}
-
Mugdha Lakhani authored
Componentize PrerenderObserver and PrerenderObserverList so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: I6012e2a5699d21dc695cad913772f072986cd8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308725Reviewed-by:
-
Richard Stotz authored
As a missing function gives a TypeError, one of the WPTs for renameSync would pass when renameSync is not implemented, which is counterintuitive. Bug: 914488 Change-Id: I4c16cf55723b772b0cba5c5c3acd376165e25591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310531Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790754}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I226faa90591b1564587ff33f00da203c93adf746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311937Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf6e84f91568..2675d65f6664 2020-07-22 szuend@chromium.org Migrate issues module to use devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e9e2f64afc4f01e1b8e2a82fc1749b6c521ad9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311727Reviewed-by:
-
Yuki Shiino authored
Prioritizes the receiver check in the new IDL interface implementation over [Measure], etc. Bug: 839389 Change-Id: Ib799685540fb4f4cad837c94648a45c278c6bcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305815 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595373454-79eaab8f620a7766eb9eee9c5fee25e0cd6be377.profdata to chrome-mac-master-1595397501-73227feb72e80d042b6cedd93932654832bac5dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I84f4db63e992d09a42578a55b8637fb3adb4ce38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311728Reviewed-by:
-
Hayato Ito authored
This reverts commit f56c8f8e. Reason for revert: win-asan is consistently failing See http://crbug.com/1108222 Original change's description: > Reland "Add test that verifies CFG loader config is generated correctly." > > This is a reland of c2b6797f > > Fixed to add CALLBACK in front of the callback function. > > Original change's description: > > Add test that verifies CFG loader config is generated correctly. > > > > This CL adds a test that creates a callback from operating system > > code to a module that has CFG enabled where the callback is not > > listed as a valid indirect target. > > > > Note: this test does not require dispatch guards to be present > > in chromium code, just for them to be present in OS code and > > for the CFG load config to be generated correctly. > > > > BUG=584575 > > > > Change-Id: Id6f5f4061f7237c23f08c8fe1b7471ea200f0628 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308854 > > Commit-Queue: Will Harris <wfh@chromium.org> > > Reviewed-by: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790587} > > Bug: 584575 > Cq-Include-Trybots: luci.chromium.try:win7-rel > Change-Id: Ie721a3f3aebcb3ff1eaae711e588ba1ec8a6e507 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311038 > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790690} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: Ifa2fd1bea09548f9993661a4bf0d08726c2b83c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 584575 Cq-Include-Trybots: luci.chromium.try:win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312036Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790749}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8ee8b15. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I38b13f6a9927043cb65eacfd8d600f1cddd6a7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311800Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790748}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96dc2c70cf5b..492e4daa3747 2020-07-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ibf60931d3136ada407b3e869333a5c44d24630e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311936Reviewed-by:
-
Jose Dapena Paz authored
GCC refuses to compile the recently added ConstructAndNotifyElementImpl Construct method, that gets a template specialization inside the struct namespace. This is not working in GCC. To avoid that, we avoid the template specialization using a new struct for when type is garbage collected, and select the struct with std::conditional. Bug: 819294 Change-Id: Ibd88999c2667b1130c0132864ec692b1e0a8fbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304575Reviewed-by:
-
Hayato Ito authored
Disable the failing test on Linux. Bug=1108205 TBR=miu@chromium.org Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271Reviewed-by:
-
