GitLab

According to Gerrit totals: shaves 510.7 KiB.

If you find specific images broken by this CL (in theory this shouldn't
happen, but...), I'd suggest reverting the specific image rather than
the entire set.  Many of these images are compressed safely (and
slightly).  Something that is more likely to break: animation.

R=agrieve@chromium.org
BUG=not running this script more often

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc1683fbd4a7402c700c946d75973c4804419623
Reviewed-on: https://chromium-review.googlesource.com/901961
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534934}

This is just a cleanup for ServiceWorkerVersion. As we do not expect
the connection error handler to do any extra work, we can just close the
Mojo binding of ServiceWorkerHost interface after reported a bad
message, rather than running the response callback with some nonsense
parameters.

BUG=772793

Change-Id: I42f5b29b6d4257ee958cb06b17277f0e0c85e8ab
Reviewed-on: https://chromium-review.googlesource.com/905752Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#534933}

Network traffic annotation tag is added to the Send functions of
HttpServer class.

Bug: 656607
Change-Id: I2951b4b120714f8b3522dfe5d73b128ef294f01c
Reviewed-on: https://chromium-review.googlesource.com/898985Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534932}

This patch moves "meter-element-with-child-crash.html" to "editing/execCommand"
because it verifies behavior of "justifyCenter" command for ease of maintenance.

This patch is a follow-up of the patch[1].

[1] http://crrev.com/c/903526 Rewrite
fast/dom/HTMLMeterElement/meter-element-with-child-crash.html to use
selection_test()

TBR=yosin@chromium.org

Change-Id: I608f5912830d02f3c9f1a262817033e927a1b1bc
Reviewed-on: https://chromium-review.googlesource.com/906162Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534931}

This new :matches() wpt does not require invalidation for testing.

Change-Id: If6d09353b967bf0486f9ecadb3f23d337b99a261
Reviewed-on: https://chromium-review.googlesource.com/905705
Commit-Queue: Victoria Su <victoriaytsu@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534930}

Ensure that device memory is initialized
when attaching it as a client hint header.

Bug: 735518
Change-Id: I8aa3c35e7f783e8dde3f3a0bba094e532cf3de6b
Reviewed-on: https://chromium-review.googlesource.com/903485Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534929}

This is a temporary workaround for https://crbug.com/809795 until we move
this logic out of this class. This doesn't affect Chromium app because
|_delegate| is always set in Chromium app.

Bug: 809795
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c46855a5f51d07fce71cae621c88b0b73e6bae8
Reviewed-on: https://chromium-review.googlesource.com/905872Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534928}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b51c930e009..6034966c95cf

$ git log 2b51c930e..6034966c9 --date=short --no-merges --format='%ad %ae %s'
2018-02-06 thomasanderson Add target_cpu and target_cpu_only to gclient base config

Created with:
  roll-dep src/third_party/depot_tools
BUG=807986


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ifb905d579212a3573ea1dd49419e258cc9d22801
Reviewed-on: https://chromium-review.googlesource.com/905690
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534927}

Using wpt-import in Chromium 2908abf5.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11983

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I64a4fbf446402f5cdb4598e40ce110b3f35dacd8
Reviewed-on: https://chromium-review.googlesource.com/905363
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534926}

Prior to this CL, when an OOPIF crashed, we kept the fallback surface
around. This caused a massive stream of missing surfaces to be reported
when the primary surface was set on ScreenInfo change or FrameRects change.

This CL addresses the problem in multiple ways:

1. We clear the fallback_surface_id_ in ChildFrameCompositingHelper when
   we report ChildFrameGone. This ensures that ChildFrameCompositingHelper
   does not re-embed the fallback surface that is now gone.
2. We track the crashed state of a child frame, and prevent updating
   the primary surface ID in ChildFrameCompositingHelper.
3. Instead (this is a tweak), we position the sad page icon as a function
   frame size and device scale factor.

Note, neither RenderFrameProxy nor ChildFrameCompositingHelper have unit
tests at the moment so no unit test is included yet. I'm going to try to
write a unit test for this change.

Change-Id: I1f25ed5e446612a7015c2717e6d2005241241942
Bug: 802809, 672962
Reviewed-on: https://chromium-review.googlesource.com/881831Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534925}

This CL adds the ability to check for host permission access to both the request
url and its initiator. WebRequestPermissions::REQUIRE_HOST_PERMISSION is renamed
to WebRequestPermissions::REQUIRE_HOST_PERMISSION_FOR_URL and
WebRequestPermissions::REQUIRE_HOST_PERMISSION_FOR_URL_AND_INITIATOR is
introduced. This will subsequently be used to check access for the Declarative
Net Request API.

BUG=777714, 696822

Change-Id: I8ec9b08be1e8eb240e28328b7c254055e63005f3
Reviewed-on: https://chromium-review.googlesource.com/905405
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534924}

Fixing  names of password_manager kEnableManualFallbacksFilling feature
as per the naming convention.

Bug: 785953
Change-Id: I4a4baa1649fe9f02c3783a5e4c40bc75e717cc03
Reviewed-on: https://chromium-review.googlesource.com/900566Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534923}

ContentViewCore is a public interface being used by
embedder, now relocatable to content_public. DEPS files are
updated as well.

Most of changes come from updates their import path accordingly.

TBR=sky@chromium.org,mthiesse@chromium.org

Bug: 807155
Change-Id: I0a564579e3b0e16b5210a7d0384896cbef231d23
Reviewed-on: https://chromium-review.googlesource.com/900884
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534922}

HTMLConstructionSite::InsertScriptElement() should use "create an
element" algorithm [1]. We call Document::CreateElement() only if
"is" attribute exists to avoid performance degradation.

[1] https://dom.spec.whatwg.org/#concept-create-element

Bug: 808311
Change-Id: If22355c3e8856f627d6b21fe3a5644fadd31b918
Reviewed-on: https://chromium-review.googlesource.com/903664Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534921}

Editor::SelectionStartCSSPropertyValue() is called by ValueStyle() in
EditorCommand.cpp. Move it to make |Editor| class simpler for improving
code health.

BUG=672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I221c9a73185b50d3c90e458810d545fd091e9df1
Reviewed-on: https://chromium-review.googlesource.com/903624Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534920}

Editor::ApplyStyleToSelection() is only called in EditorCommand.cpp.
Move it to make |Editor| class simpler for improving code health.

BUG=672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I9a9cafa0ffff7da560ee2bc7fcd2e5bf15059665
Reviewed-on: https://chromium-review.googlesource.com/905962
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534919}

Once upon a time, there was a transition state where the keyboard would
slowly change its visual appearance. These handlers would get fired when
that process began. Now, the window moves instantaneously and there are
system animations that give it the appearance that it is moving.

This means that the notification methods that were called at the
beginning of the animation are now called after the changes have been
applied, and so "Changed" is more appropriate rather than "Changing".

This is a followup on the TODO in crrev.com/c/816483

Change-Id: I0805a35a3d8587442411531d82b4e6943108c34d
Reviewed-on: https://chromium-review.googlesource.com/903023Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534918}

This CL updates bot config to move Leak Detection Linux from fyi to main waterfall.

Bug: 807520
Change-Id: I5ddfedcc968de1f949a95d432f0c6b788f662ec0
Reviewed-on: https://chromium-review.googlesource.com/905706Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534917}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/017935cf..1ac4c080

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I34c4c125627c2fdb4992bb5c6ffc582886ad8cef
Reviewed-on: https://chromium-review.googlesource.com/905598Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534916}

When the Developer Tools are undocked, it's easy to lose track of the
browser tab to which a given Developer Tools window is associated. To
mitigate this problem, add a Focus Debuggee command to the menu.

Change-Id: I0ab03aa45dd30226c1decfe2410be3fa030eaddf
Reviewed-on: https://chromium-review.googlesource.com/897732
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534915}

I prefer aria-pressed instead of aria-expanded because Windows screen readers report the button as a toggle button, which is what it actually is - look at the "toggle" attribute on the button.
R=dmazzoni@chromium.org

Tested: Manually with Jaws
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7dfe5bfb3b303893ae5b70126deb297e051c43a3
Reviewed-on: https://chromium-review.googlesource.com/905109
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534914}

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/674004

Patchset #1 is the original code from the previous attempt at this.

There's (at least) 2 issues in the previous attempt:
- A use-after-free caused by a misuse of a flat_map[1]:
   "existing_tabs_[new_contents] = existing_tabs_[old_contents];"
  is invalid because the references returned by operator [] on a
  flat_map are invalidated across mutations (which is the case here if
  the map has to grow because of the insertion of |new_contents|).
- A use-after-free caused by some bookkeeping issues with the
  |existing_tabs_| member in TabStatsDataStore. This is because I
  assumed that there'll be a call to
  TabStripModelObserver::TabClosingAt for every WebContents that get
  deleted, which is not the case as some WebContents might be freed
  directly.



[1] https://chromium-review.googlesource.com/c/chromium/src/+/867073/2/chrome/browser/metrics/tab_stats_data_store.cc#97


Change-Id: Id983ab0074379f8fce1b0e760e56263e2de80e07
BUG: 801887, 720131
Reviewed-on: https://chromium-review.googlesource.com/867073Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534913}

The crash happens in the following sequence:
1. A frame is throttled (CanThrottleRendering is true)
2. Without throttling enabled (ShouldThrottleRendering is false),
   lifecycle is updated to CompositingClean, thus GraphicsLayer for the
   throttled frame is created.
3. With throttling enabled (ShouldThrottleRendering is true),
   full lifecycle is updated. We skipped setting the GraphicsLayer's
   layer state because the containing frame is throttled.
4. During PaintTree, when painting the GraphicsLayer, layer state is
   unexpectedly null.

Now skip painting the GraphicsLayer if the containing frame is throttled.

Bug: 805049
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iec7ebbc0362b2353513bcd8f44f864307683eb28
Reviewed-on: https://chromium-review.googlesource.com/900262
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534912}

This allows calling code to be structured to take advantage of the call
being guaranteed never to return (e.g. by omitting unreachable 'return'
statements or switch 'break's), in contrast to the OS-native APIs the
call uses internally.

To support this, the IMMEDIATE_CRASH() macro definition under the
Windows/Clang build is updated to use the __builtin_unreachable()
intrinsic, and TerminateCurrentProcessImmediately() switched from using
CHECK(false) to IMMEDIATE_CRASH(), to match the [[noreturn]] promise.

Change-Id: I83734c3547ab75456bb60bda28a7207ccb493384
Reviewed-on: https://chromium-review.googlesource.com/898189
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534911}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: If89283218fe117b5bba2f1fc1412ed354105dfe6
Reviewed-on: https://chromium-review.googlesource.com/905364Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534910}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e117e46a6894..2b51c930e009

$ git log e117e46a6..2b51c930e --date=short --no-merges --format='%ad %ae %s'
2018-02-07 tandrii Revert "bot_update: allow rebasing the patch onto an older revision."
2018-02-06 iannucci [luci-auth] Add statically-linked luci-auth CLI tool.
2018-02-06 iannucci [prpc] Add pRPC CLI tool to depot_tools.
2018-02-06 tandrii bot_update: optimize checkout of solution's main repo.
2018-02-06 thomasanderson Add target_cpu builtin variable to gclient
2018-02-06 oprypin bot_update: allow rebasing the patch onto an older revision.
2018-02-05 mmoss Make flattened recursedeps inherit parent conditionals.

Created with:
  roll-dep src/third_party/depot_tools
BUG=807986,783607


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2db4866326042b36e2d166db3cfd0740dcb639ec
Reviewed-on: https://chromium-review.googlesource.com/905932
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534909}

There is potential race which end ups with two tab for mapped
UISourceCode. This CL fixes this race.

R=lushnikov@chromium.org

Bug: none
Change-Id: If1e5b5db6aea1ae2e69d64bf643971ec27ba34e4
Reviewed-on: https://chromium-review.googlesource.com/889900
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534908}

This patch introduces |FindNextWord{Backward,Forward}()| as replacement of
|FindNextWordFromIndex()| to avoid |bool| parameter |forward| since all call
sites pass constant value for improving code health.

Change-Id: Ife6fe6bc355b17985d3c16c8f4fa4f5605cfb7c6
Reviewed-on: https://chromium-review.googlesource.com/900565Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534907}

1. replace "DOMString or CSSVariableReferenceValue" with
 CSSUnparsedSegment using typedf keyword.
2. using sequence<> keyword instead of "..." in constructor

https://github.com/w3c/css-houdini-drafts/pull/619

Bug: 807525
Change-Id: I99c11c26dd2235e46e259e63991d0192a025bcb4
Reviewed-on: https://chromium-review.googlesource.com/904582Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534906}

This is a merge of internal change 184350463

Change-Id: Ifca239fb8f9941cb718baba9e01f3d22ba1c3918
Reviewed-on: https://chromium-review.googlesource.com/900486
Commit-Queue: Buck Krasic <ckrasic@chromium.org>
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534905}

The token is naturally UnguessableToken, but is plumbed as String
in multiple places for historical reasons. This patch makes it
consistent with navigation token and the rest of the code.

Also plumbed DevToolsWorkerToken to dedicated workers for the
same purpose. We already plumbed it through a side channel, now
it's a part of global scope.

Bug: none
Change-Id: I2b52f1945730950473aaed307baaf58b19c881a8
Reviewed-on: https://chromium-review.googlesource.com/905234Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534904}

- CreateCustomElement with three arguments calls CreateCustomElement
  with four arguments internally.

- Code cosmetic change in CreateCustomElement with four arguments.

This CL has no behavior changes.

Bug: 806641
Change-Id: I7ae0fa4452b665533c8e250ae0ce2cbf74bc244c
Reviewed-on: https://chromium-review.googlesource.com/905902Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534903}

Queuing delay can cause BeginFrames to arrive late in SurfaceDependencyDeadline.

Prior to this CL, SurfaceDependencyDeadline counted BeginFrames to determine
whether a deadline was hit. The problem is each BeginFrame could be delayed and
so 4+ BeginFrames could translate into hundreds of milliseconds even if the
system is intended to run at 60fps (67ms for 4 BeginFrames).

This CL converts SurfaceDependencyDeadline to measure wall time instead and uses
BeginFrames as a signal to check how much time is left until the deadline.

This CL mocks out base::TimeTicks::Now() through a base::TickClock object. This
allows this code to be unit-testable.

Bug: 808315, 672962
TBR: skyosil@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6f76d1f55ea9e7920d7872414618ec225c25d454
Reviewed-on: https://chromium-review.googlesource.com/902844
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534902}

This patch removes a redundant class specifier |LayoutObject::| for
|SetSelectionState()| call in |ResetOldSelectedLayoutObjects()| because
it is non-virtual member function for improving code health.

Change-Id: I684f6cc385adbfb172fb1020154e659a9f037977
Reviewed-on: https://chromium-review.googlesource.com/903024Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534901}

Add ios_web_view_inttests and ios_chrome_payments_egtests
as dependencies of gn_all to ensure they are build when
building "All" in Xcode hybrid project.

Bug: none
Change-Id: I972e095241d487561ce3d3afdcd4511284292b01
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/899246Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534900}

https://webrtc.googlesource.com/src.git/+log/dffead8835d1..03e5ce84dedc

$ git log dffead883..03e5ce84d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5018b3f1c2a4510865d5dde8c97f00de479c4a48
Reviewed-on: https://chromium-review.googlesource.com/905985
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534899}

Add DumpWithoutCrashing whenever we fail IOSurfaceLookupFromMachPort.
Remove the CHECKs, since this was frequent enough to affect stability.

Change anonymous image creation to not use mach ports, but add an
attempt to locally open via mach port for debugging purposes.

For non-anonymous image creation, where the image will be passed via a
mach port to the client process, attempt to open the mach port before
passing to the client. If this open fails, then do not send the mach
port to the client. This may determine if the problem is independent
of the process attempting to open.

Bug: IOSurfaceLookupFromMachPort
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d201ca2d370efac58a9a690100fbf63f0bc6a27
Reviewed-on: https://chromium-review.googlesource.com/905239
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534898}

This patch removes a redundant class specifier |LayoutObject::| for
|SetSelectionState()| call in |LayoutSelection::Commit()| because
it is non-virtual member function for improving code health.

Change-Id: I0a6c6b4f32b8689b0c5bfd0bd6487aa55075f9db
Reviewed-on: https://chromium-review.googlesource.com/902986Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534897}

This uses 'aria-alert' to read out SuggestBox items in StylesSidebar and
Console, and FilteredListWidget items in the CommandMenu.

Change-Id: I4126e2344ec585adb81f512156bc8506d0ebb70f
Reviewed-on: https://chromium-review.googlesource.com/867238Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534896}

https://skia.googlesource.com/skia.git/+log/5dd202dc9002..9ca602ae04a7

$ git log 5dd202dc9..9ca602ae0 --date=short --no-merges --format='%ad %ae %s'
2018-02-06 mtklein guard xml-using tests with SK_XML
2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ fbb1c7921..57dd97aaa (1 commit)
2018-02-06 mtklein remove SkCanvas::kIsOpaque_SaveLayerFlag
2018-02-06 bryct Add link annotation support to SkSVGDevice.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I77e0913f1a56ed0dca83b04a7b91519040bcb62d
Reviewed-on: https://chromium-review.googlesource.com/905812Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534895}