- 11 Jul, 2017 40 commits
-
-
cjgrant authored
On Android, pages may be shown from a downloaded offline cache. In this case, the security chip text and icon change. Reflect this in ToolbarModel. With this new ability, render the Offline security information in VR. BUG=735770 Review-Url: https://codereview.chromium.org/2968143003 Cr-Commit-Position: refs/heads/master@{#485520}
-
Thanh Pham authored
Currently Devtools uses widget to highlight elements, i.e., windows, widgets, and views. We instead can ui::layer for highlighting and to support future drawing/animation. Bug: 730828 Change-Id: Ic84a79c382e2e3a2bcf0b9cba421d2cb9a8e72bc Reviewed-on: https://chromium-review.googlesource.com/564036 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#485519}
-
jfernandez authored
The bug this CL intend to fix has a very specific root cause; we were wrongly assuming that we need to repeat the track sizing algorithm only if baseline alignment may change the grid container's intrinsic size. Actually, the spec states that we should run a new iteration of the sizing algorithm if any of the grid items has changed its min-content contribution. This affects to the grid item's container, hence the grid area, but not necessarily to the grid container. Since we were running the baseline alignment logic after the first run of the tracks sizing algorithm, we were relying on the extra run to adjust the grid areas' size based on the resulting baseline alignment offsets. This patch fixes the bug by comparing the grid areas's size with the baseline extent of their items, triggering the extra tracks sizing cycle when necessary. BUG=719445 Review-Url: https://codereview.chromium.org/2868283002 Cr-Commit-Position: refs/heads/master@{#485518}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d8c9af47..10d68afb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I36856d299ebcce7ab990297c59e3bff5834ced0a Reviewed-on: https://chromium-review.googlesource.com/566322Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485517}
-
Wez authored
Adds pass-through of some command-line options useful for debugging: --test-launcher-batch-limit to control tests-per-process. --test-launcher-jobs to control # of parallel test processes. --single-process-tests to run all tests in a single process. Also adds the OS_FUCHSIA tag to the test results output. Change-Id: I4ce99f2a33536ddd9fae4fcb6bf93eab6f38a612 Reviewed-on: https://chromium-review.googlesource.com/564738 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485516}
-
Darren Shen authored
As we introduce a hierarchical folder structure to Source/build/scripts, we will need to refer to Jinja templates by their full path. This patch changes existing generators to use full paths when referring to templates (see changes to template_expander.py). There are no changes to generated code. Bug: 732657 Change-Id: Id95a922587c0cbd858538e70c355d14d0dfa9ce5 Reviewed-on: https://chromium-review.googlesource.com/527851 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#485515}
-
calamity authored
BUG=739458 TBR=altimin@chromium.org Review-Url: https://codereview.chromium.org/2978473002 Cr-Commit-Position: refs/heads/master@{#485514}
-
calamity authored
BUG=740786 TBR=twellington@chromium.org Review-Url: https://codereview.chromium.org/2978563002 Cr-Commit-Position: refs/heads/master@{#485513}
-
suzyh authored
Move tests of animations being responsive to style changes under the existing animations/responsive test directory. The tests that are already there are testing responsiveness in interpolations, so they are moved to an interpolation/ subdirectory. The tests in the svg-attribute-responsive directory are also moved under responsive/interpolation/ in order to avoid creating a copy of the responsive-test.js with different relative path imports. BUG=623434 Review-Url: https://codereview.chromium.org/2973013002 Cr-Commit-Position: refs/heads/master@{#485512}
-
Lucas Garron authored
Right now, these just test that ConnectionInfoPopupTest.show() and PageInfoPopupTest.show() can be invoked without crashing. Bug: 657299 Change-Id: Ic075b86e7d12df9893173bb35692ecc8b7e3df6d Reviewed-on: https://chromium-review.googlesource.com/557450 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485511}
-
Daniel Cheng authored
The previous idiom was to define a subclass to wrap the type, and store a raw pointer to the subclass. Rather than doing that, just use WebPrivatePtr. Bonus fix: WebHTTPBody's assignment operator was accidentally changed to a no-op. Luckily it appears that this is never called... Change-Id: I6301f410513b4cd93ca1fcb537d46dd87359bb7a Reviewed-on: https://chromium-review.googlesource.com/565077 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485510}
-
Minh-Duc Nguyen authored
No code generated Bug: Change-Id: I516f2d1cecf0a32186b001a0be594c725d137d59 Reviewed-on: https://chromium-review.googlesource.com/560813Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#485509}
-
John Abd-El-Malek authored
Most of these are related to XHR being unimplemented. TBR=reillyg@chromium.org Change-Id: Iad4fbc259e8821e40e95ca42e03b4c174f0921cc Reviewed-on: https://chromium-review.googlesource.com/566072Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#485508}
-
Jon Napper authored
Added missing unit test for translate_service.cc Bug: 727459 Change-Id: Iae3cdded7bb934fd59a7248cf342bce85c44ee69 Reviewed-on: https://chromium-review.googlesource.com/564871Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Jon Napper <napper@chromium.org> Cr-Commit-Position: refs/heads/master@{#485507}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I9cfbc912fb68bbe0e12143482fcda533416a325f Reviewed-on: https://chromium-review.googlesource.com/566324Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#485506}
-
dominickn authored
Existing tests for this component don't work. The service worker registration is for a different browser context, so the tests never actuallly verify WebAPK-compatibility properly. This CL revamps the tests by mocking out InstallableManager instead of WebContents. This allows precise control over the data returned to the data fetcher so we can verify more scenarios more accurately. BUG=721881 Review-Url: https://codereview.chromium.org/2960103002 Cr-Commit-Position: refs/heads/master@{#485505}
-
Yash Malik authored
This is needed to support launching from Daydream 2D. Bug: Change-Id: Icde35d6dfd14e9b3f2432af843e5a2e302dcb944 Reviewed-on: https://chromium-review.googlesource.com/565466Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485504}
-
Hiroshige Hayashizaki authored
When a decode error occurs in a part of a multipart image, the state transition from kDecodeError to another finished state can occur when the next part of the multipart image is received. This CL relaxes the state transition restriction of ImageResourceContent to allow such state transitions. Bug: 737392 Change-Id: Icf07899d77994463e9aabedb64f704ef0a9e346d Reviewed-on: https://chromium-review.googlesource.com/562602Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#485503}
-
Hiroshige Hayashizaki authored
Because RemoveClient() can be called due to Oilpan GC in some places in ResourceFetcher::StartLoad(), and [1] originally intended to forbid Add/RemoveClient/Observer() only during NotifyStartLoad(). [1] https://codereview.chromium.org/2746343002 Bug: 726315 Change-Id: I30e56a193f06e07903d8227a680d556e01b71117 Reviewed-on: https://chromium-review.googlesource.com/560542Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#485502}
-
Jonathan authored
font_service::FontLoader makes a sync mojom call when attempting to load fonts. It is possible for this call to fail if the remote service manager shuts down before the call completes. This leaves the calling service in a bad state, where the mojom error has yet to be received, and where there are no font resources. In tests this has been exhibited by crashes in some services while they attempted to perform AuraInit. This change updates PlatformFont to provide a way to initialize the the static defaults, which returns the success state. AuraInit is updated to consider the lack of font as a failed init. Calling services are already set to shutdown on these failures. Allowing us to cleanly handle this shutdown ordering issue. TEST=mash_browser_tests Bug: 738441 Change-Id: I90efe768d5027885d51bc4ac8ba1de895c297f54 Reviewed-on: https://chromium-review.googlesource.com/565031Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#485501}
-
Justin Schuh authored
Splits the optimized builtins into their own file, which creates the interfaces for adding the optimized ARM versions in a follow-up CL. BUG=672489 Change-Id: I356fb4d166f4773b111f3c61c6206e3d4b4ccd40 Reviewed-on: https://chromium-review.googlesource.com/562754Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#485500}
-
Vladimir Levin authored
This patch changes the behavior of the code to not use high filter quality for upscales. It also refactors the code a bit to ensure that we don't use medium if we're not scaling, since that would result in an extra copy of the image memory. R=ericrk@chromium.org, pdr@chromium.org Bug: 735174 Change-Id: I30e75731a3f2f89570ef29c972e4b101ec5fe1fc Reviewed-on: https://chromium-review.googlesource.com/541609 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#485499}
-
palmer authored
This is nothing like what the ultimate, true solution should look like. It does seem to work for the narrow problem of calling history.pushState in a tight loop, however. BUG=394296 Review-Url: https://codereview.chromium.org/2972073002 Cr-Commit-Position: refs/heads/master@{#485498}
-
Yuki Awano authored
- Move zip archiver from ui/file_manager/zip_archiver to c/b/resources/chromeos/zip_archiver - zip_archiver is no longer loaded from resources.pak. zip_archiver will be located at /opt/google/chrome/resources/chromeos/zip_archiver on device. - Fix presubmit errors and warnings. - Fix zip archiver to be built with third_party/minizip. - Use polymer in chrome://resources. - Removed some unnecessary files which had presubmit errors or warnings. - Removed hacks to include module.nmf and pexe in resources.pak. BUG=359837 TEST=none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2c1a39d22b1e12b978d090375248e39961bf58a Reviewed-on: https://chromium-review.googlesource.com/544361Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@google.com> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#485497}
-
Adam Langley authored
This change adds some headers which are used directly and removes some headers which are no longer needed. Bug: none Change-Id: I9382fdc8d6d925e09b472fbbd5e24ef222d9b46d Reviewed-on: https://chromium-review.googlesource.com/562507Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#485496}
-
dpranke authored
Ozone is now on by default on all CrOS builds, and we don't need to test the old x11 config any more. This CL flips all of the CrOS builders to (implicitly) be building for Ozone, so that we can then remove the explicit Ozone builders in a follow-up CL. This builder also removes the linux_chromium_chromeos_ozone_rel_ng builder from the CQ since would otherwise be redundant with the linux_chromium_chromeos_rel_ng builder. This CL also removes a couple of commented-out CQ entries for builders that were removed as part of the work in bug 669297 (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng); at the time I had planned to re-add them once the capacity issues were resolved, but at this point it's unclear how important those configs are and we may want to use the capacity for other things, and so these comments were misleading. R=kylechar@chromium.org, kbr@chromium.org TBR=achuith@chromium.org, xdai@chromium.org BUG=671355 Review-Url: https://codereview.chromium.org/2949093004 Cr-Commit-Position: refs/heads/master@{#485495}
-
rdevlin.cronin authored
The web accessible resource determination in the renderer has an early-out for non-existent extensions. Unfortunately, this makes it possible to determine whether a user has a given extension installed through timing attacks - it takes longer to make a decision about whether to allow a resource to load when the extension is installed than when it isn't. This can be surprisingly accurate. Rejigger the web accessible resource determination in a few ways. Most importantly, keep a set of loaded extensions that have any accessible resources, and check this (rather than the full extension set) for whether to potentially allow the load. This way, an extension with no accessible resources and an uninstalled extension should take the same amount of time to reach a decision, which is the desired outcome. BUG=709464 BUG=611420 Review-Url: https://codereview.chromium.org/2958343002 Cr-Commit-Position: refs/heads/master@{#485494}
-
michaeln authored
Review-Url: https://codereview.chromium.org/2940023002 Cr-Commit-Position: refs/heads/master@{#485493}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5449aade6227..e401f2c718fc $ git log 5449aade6..e401f2c71 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 liyuqian Revert "Always enable Analytic AA for rects" 2017-07-10 reed Revert "remove flags for android" 2017-07-10 scroggo Revert "Remove support for decoding to kIndex_8" 2017-07-10 herb Blur gm. 2017-07-10 brianosman Correctly stroke zero length segments in multi-contour paths 2017-07-10 liyuqian Always enable Analytic AA for rects 2017-07-10 benjaminwagner Fix Google3 build after https://skia-review.googlesource.com/c/21524/ 2017-07-10 reed remove flags for android 2017-07-08 ccameron Make SkImage_Lazy::onMakeColorSpace return a SkImage_Lazy 2017-07-10 ethannicholas Revert "don't compose with (forced) opaque colors" 2017-07-10 fmalita Avoid unneeded SkPictureImageFilter color space transforms 2017-07-10 brianosman Skip GLPrograms test on D3D9 ANGLE to avoid NaN literals bug 2017-07-10 robertphillips Remove unused ctor in GrTextureDomain 2017-06-19 halcanary ICC: SkICCGetColorProfileTag supports special cases 2017-07-10 scroggo Remove support for decoding to kIndex_8 2017-07-10 scroggo Fixes for get_images_from_skps Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Idbbaa8ee05e9738156d292b187dba425b8bd8c6d Reviewed-on: https://chromium-review.googlesource.com/566039Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485492}
-
raymes authored
This adds deprecation warnings when the following APIs are used from cross origin iframes: -getCurrentPosition and watchPosition -requestMIDIAccess -requestMediaKeySystemAccess -getUserMedia A message is only logged if the feature would be disallowed by feature policy. BUG=689802 Review-Url: https://codereview.chromium.org/2945223002 Cr-Commit-Position: refs/heads/master@{#485491}
-
Hidehiko Abe authored
BUG=672829 TEST=Ran trybots. Change-Id: Ibd1533c26e9f5d24cecba80646bca274b7726fe4 Reviewed-on: https://chromium-review.googlesource.com/565579Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485490}
-
Bryan Henry authored
Additional buildflags that are declared here are needed for internal use. BUG=internal b/63080838 TEST=Builds. Change-Id: Ibc03adfe4063487c688d069b88880d3056c75a38 Reviewed-on: https://chromium-review.googlesource.com/562626Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bryan Henry <bryanhenry@google.com> Cr-Commit-Position: refs/heads/master@{#485489}
-
Reilly Grant authored
This change switches the Geolocation Mojo interface JS bindings to the new style and updates the LayoutTests accordingly. The Blink Mojo interfaces are switched to generating both styles of bindings as an temporary step while some code has not yet been updated. These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and so it is removed. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ie7001384afcdc812218d840c8fd0057360868354 Reviewed-on: https://chromium-review.googlesource.com/560544Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#485488}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15d0e7ca..d8c9af47 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I092380ecc74a46cb6b04d1bfc4d9977ebb4c0bfd Reviewed-on: https://chromium-review.googlesource.com/565629Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485487}
-
Ryan Landay authored
I am working on re-implementing the Android text edit widget's spell check menu in Chrome and the Android WebView. The buttons in the native Android spell check menu use the value of android:colorAccent set by the embedding app. To make the WebView spell check menu have the same behavior, we need to also make it use android:colorAccent. But to make the menu use the correct (according to hannahs@, our UX designer) blue color, and not the default green color, we need to set colorAccent in our MainTheme. This change does that. I'm assuming that we don't currently have anything that is relying on this being the existing green color (since that wouldn't match the color our designer said we're supposed to use for these UI elements anyway). We do currently have some themes (e.g. FullscreenWhite and PreferencesDialogTheme) that are already setting this color to other values for specific parts of the app though. Note: I've tested this change on Jelly Bean and the app seems to run OK, despite android:colorAccent having been added in a later API version. Bug: 715365 Change-Id: I2690c014d18211304ace6894f5a2cea0db72a1af Reviewed-on: https://chromium-review.googlesource.com/566031Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#485486}
-
Tim Sergeant authored
Bug: 732675 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1cb5f217d063c192d45d0ebeb2da07980f852e5f Reviewed-on: https://chromium-review.googlesource.com/562900Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#485485}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. This patch does the latter for a reference to CIDetectorTypeQRCode (which requires 10.10) in the constructor for BarcodeDetectionImplMac. A test relies on being able to construct this object even on pre-10.10 systems, so we cannot use the availability attribute or assert that we are 10.10 or higher. Bug: 735328 Change-Id: I64883a34911b95e624b6ccb0f638034920aef75d Reviewed-on: https://chromium-review.googlesource.com/565028 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#485484}
-
Sergey Ulanov authored
Fuchsia SDK doesn't yet provide access to Clipboard, so this is just a dummy implementation to make it possible to compile ui/base Bug: 740608 Change-Id: I3add17aad177787d2c7ee0f639ac9fc08286a54d Reviewed-on: https://chromium-review.googlesource.com/565220Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485483}
-
zijiehe authored
This change removes the constructor parameter of ClientSession, which is used to initialize DataChannelManager. Instead, a public function ClientSession::RegisterDataChannelManagerCallback() has been added to achieve the goal. The motion of this change is to avoid the base::Bind() to be kept in a secondary place in ChromotingHost other than ClientSession. And I think it's also reasonable to public the Register callback function from ClientSession. So we do not need to write all registering logic in ClientSession. BUG=650926 Review-Url: https://codereview.chromium.org/2967793002 Cr-Commit-Position: refs/heads/master@{#485482}
-
Quinten Yearsley authored
This CL changes an argument name from raw_input, which conflicts a builtin name. This is a minor clean-up CL. Bug: 643937 Change-Id: I88821d6537f9d24b3f78de9b21e0ff690f9c3491 Reviewed-on: https://chromium-review.googlesource.com/564699Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#485481}
-