- 05 Nov, 2020 40 commits
-
-
Sigurdur Asgeirsson authored
This is the first step in replacing ScopedObserver. The new class is functionally identical, but has slightly more descriptive member and class names. Now also with a test. Bug: 1145565 Change-Id: I5416d7873396238c829fcf31a55cfe0ef5bac1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519763 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#824539}
-
Andrew Grieve authored
Found this because a test run failed to fetch remote deps: https://ci.chromium.org/p/chrome/builders/ci/test-phone/19818 These tests are meant to use local versions of deps, but had forgotten to call devil_chromium.Initialize(), which enables this. Also consolidates sys.path initialization in the main runner. Bug: 1115604 Change-Id: Ia0f6e916c2b212d4d785ced72a07c6ec6b72101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518124Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824538}
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the HostContentSettingsMap. This CL does not include Observer and Providers. They will be cleaned separately. Bug: 1134547 Change-Id: I8147ea47d6947d9066280f6d61bfe0eb8abfc641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500161Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#824537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b4aa6d8ae29..26705ac9bdf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: smcgruer@google.com,xialinyan@google.com Change-Id: I1dc589174bd5a5d9da18b05612c00c5b32c9497e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521040Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824536}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac59b0e049f7..5689d6741bc4 2020-11-05 hjd@google.com Merge "ui: Fix iteration on empty queries and null queries" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id7f34848e3cd69c3be0ab0edfb923bb33c7869b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824535}
-
Elad Alon authored
This is the second step in implementing getCurrentBrowsingContextMedia behind a runtime flag. TL;DR: This is an API for capturing the current tab. Explainer: https://docs.google.com/document/d/1CIQH2ygvw7eTGO__Pcds_D46Gcn-iPAqESQqOsHHfkI Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Next steps: * Implement the confirmation-box. * Implement unit-tests that rely on the confirmation-box. Bug: 1136942 Change-Id: I8b25baa85565999ec44ed2f1b0bd1e19d6f148c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502628Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824534}
-
Morten Stenshorne authored
This introduces full PositionForPoint() support to NGPhysicalBoxFragment. Its behavior differs slightly from that in legacy PositionForPoint(): if the point isn't within any of the child fragments, we'll use the nearest one (*really* the nearest one). We kind of do something similar in LayoutBlock::PositionForPoint() too, but not very accurately. LayoutBlock is very block-offset centric (hardly cares about inline offsets at all), which is certainly fine there, but that won't work with e.g. multicol, table cells, or some flex items. Additionally, LayoutBlock::PositionForPoint() doesn't really pick the nearest child, but rather sort of the first child whose block-end border edge is past the point. Not sure if anyone depends on this behavior, or if what we do now in NGPhysicalBoxFragment is an improvement. HitTestResult stores the NGBoxFragment that we hit. This will be a NGBoxFragment that's generated from the inner node itself, unless the inner node is text or non-atomic inline content, in which case it will be the NGBoxFragment of the containing block of the inner node. For now, this functionality is gated on LayoutNGBlockFragmentation, because it causes at least one test to regress: editing/selection/selectstart-event-crash.html This fixes 6 caretRangeFromPoint tests, but I think it actually fixes more than that (looks like there are some deliberate changes regarding which character we hit when pointing above/below the first/last line in LayoutNG, which prevents additional tests from passing). Will look into that as a follow-up. Bug: 829028 Change-Id: I0cc86ecd7e89254c998218ea442944f991b36151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515399Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824533}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef10de40. With Chromium commits locally applied on WPT: a48c8c20 "[Critical-CH] Add check for unsafe HTTP methods" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7bbee8c9cf18823e8fd09af7e84050a1878df674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521490Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824532}
-
Leonard Grey authored
Now checks commander::IsEnabled before adding the accelerator in AcceleratorsCocoa This is a reland of ac3031b8 Original change's description: > Commander: make accessible via hotkey or Mac menu item > > Only enabled via the `--enable-commander` flag. Visuals still WIP, and > not many commands are hooked up. Hotkey (Ctrl-Space) is probably > temporary. > > Bug: 1014639 > Change-Id: Ibb9ae8ad61d18cbb1d7bb6f0e6df9d8e5135f64a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508331 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824156} Bug: 1014639 Change-Id: I77b77ce759b67c28658d3d6a3f9c9c9671eb7876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519606Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824531}
-
Devlin Cronin authored
s/render_view_id/render_frame_id Bug: None Change-Id: I2af5bb805e83df835e4cd011ae3f01f4092fb71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519928 Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824530}
-
Sebastien Marchand authored
This currently will affect the Windows and Linux builds. Mac isn't using LLD and is unaffected by this despite using PGO. This results in a ~3% perf gain on Speedometer. One side effect of this change is that we no longer use the explicit orderfile on Windows, since we now use the PGO profiles for binary layout. These orderfiles and the associated logic will be removed in a follow up CL. Bug: 1113282 Change-Id: I868cbe8202ec3a58bb5e56a534e51590caa07157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519756 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824529}
-
Andre Le authored
Update strings in ash and settings to match the finalized strings. Screenshot: https://screenshot.googleplex.com/9cL3Tgpcc32GCUK https://screenshot.googleplex.com/8Sh9naEynbxcsfJ https://screenshot.googleplex.com/36S9sebanwfmfZS https://screenshot.googleplex.com/4WLBHUFN8rmZbNE https://screenshot.googleplex.com/BuSim7d7cvQPFG6 https://screenshot.googleplex.com/9jAkWjLYmHEJyRp https://screenshot.googleplex.com/9JiPk3S7L7w2tjC https://screenshot.googleplex.com/862pdYr9XPuRRsL BUG=1106937,1126208,1144844 Change-Id: I5c03cd00cf6383ad67a8e9fc15a18b68cd50c1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518362 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824528}
-
Bo Liu authored
Remove SkiaOutputSurfaceDependency change to pass SkSurfaceCharacterization for secondary cb only. Instead use the new skia API to create the characterization directly from passed in info. Needed to add a OutputSurface::Capabilities for secondary cb, which will probably be useful in the future. Also need to fix in webview to ensure the SkSurfaceProps matches viz. Bug: 1144921 Change-Id: I948964a0caa82dba5ef671acafd8c776c403d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521196 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824527}
-
Moe Ahmadi authored
This Feature param controls the position, with respect to the NTP MV tiles, at which the repeatable queries must be inserted. The available variations are either at the start or at the end of the MV tiles. These two variations are added to about:flags entry for the repeatable queries. Fixed: 1138578 Change-Id: I65a5216ac77756027e7240d921abaa1ba9b96ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520420 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824526}
-
Peng Huang authored
Bug: 1135386 Change-Id: I6ec8af5ba5a56adccf45de5b4524e9039047c96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519593 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#824525}
-
Xiyuan Xia authored
Use ui::AnimationThroughputTracker for layer animations and ui::ThroughputTracker for non-layer animations and complex ones such as desk switching. Bug: 11434673 Change-Id: Iebc6065b92a211af1b3daf7513fdffec446a76ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518264Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824524}
-
Jeffrey Kardatzke authored
HEVC accelerated decoding will be used for Chrome OS protected media and we also want it built for fuzzer targets. BUG=b:153111783 TEST=H265Decoder built for volteer Change-Id: I2cdc484d7750eeb98a38a8e64093d98312bf48ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517646Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#824523}
-
Wenyu Fu authored
Today when object inside OneshotSupplierImpl is ready, the callback passed to #onAvailable(callback) will be put at the end of the handler queue. At times this will cause a delay when waiting is not necessary. By returning the object it supplies, the caller to supplier can decide whether to pick up the value instantly. Bug: 1144824 Change-Id: I0701534f2bdf28cf2d081cc58aec6d2ccebf90c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514802 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#824522}
-
Nohemi Fernandez authored
This patch introduces two strings which are being considered as the title for a new infobar notification that will display the existing user signed-in account when cookies are re-generated. Screenshots: https://drive.google.com/open?id=1qzxdFZg_gOQW8hUJg7MMQzJU8pmjUP42 https://drive.google.com/open?id=1dHopX_WVr45XMsdVaQ2HGtD9-5cgMXAc Bug: 1145592 Change-Id: I4c94522d50e278cfd151fc750f2888d17b0ee95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517456 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824521}
-
Malay Keshav authored
Due to some issue, it may happen that the computed gpu_composite time of 2 frames overlap each other. There should however be no overlap, and this happens only due to some bug or special condition that is being hit which causes this scenario. Using a unique id for gpu_composite_time trace would help identify the issue without breaking the trace file's validity. Change-Id: I4268bf16932a1ace498c000dfaac958f8e21d395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519862 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#824520}
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in ContentAnalysisDialog to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I07f4535e5556940aedc5d40a7419f6792f95f0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520248Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824519}
-
Martin Šrámek authored
Bug: 1015841 Change-Id: Iff38bdff3c77cc973978d6d069277677f627944d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521610Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#824518}
-
Erik Chen authored
Change-Id: I5988a844294347848a4d228b0a04233c31ed500c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517994Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824517}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/744b988ae1b0..ac59b0e049f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia1e17cc03834b666b806558831b6ec422ebbaf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824516}
-
ckitagawa authored
This CL fixes up some issues with memory pressure listeners and adds a check to avoid starting the compositior if under memory pressure. Bug: 1144768 Change-Id: Ifea868be5ed11ce5a5a3b05159098da4d272814f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518694 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824515}
-
Meilin Wang authored
- Removes unnecessary field and param. - Updates unittest. - Uses view IDs for tests instead of exposing getter functions. BUG=1106937 Change-Id: I73916d46c398dec97a6a85815392f0060e049e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519937Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824514}
-
Jazz Xu authored
This CL add a11y name for media controls dialog and media controls chip in quick settings. Change-Id: I49981447108e529e448d32be28b5b39c02390377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508204 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824513}
-
Nate Chapin authored
It's effecitvely per-window as is, and the current design might have problems in a case where the cache is used from multiple windows that were associated with the same frame. Change-Id: Idad13fa9ad91f77be3c0feae6370a0ea396db7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516975Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#824512}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/694ff1735711..e5e8e66e9b4f 2020-11-05 bsalomon@google.com MakeFromYUVATexturesCopyToExternal check texture valid before 2020-11-05 johnstiles@google.com Revert "Add memsets to the GrBlockAllocator unit tests." 2020-11-05 djsollen@google.com Revert "cull glyphs that have far out positions" 2020-11-05 djsollen@google.com Revert "move subrun instances and support to .cpp" 2020-11-05 djsollen@google.com Revert "move subrun code to anonymous namespace" 2020-11-05 johnstiles@google.com Migrate work from constructors to onOnceBeforeDraw. 2020-11-05 vigneshv@google.com Reland "heif: Add AVIF type and AVIF sniffing" 2020-11-05 egdaniel@google.com Rename msaa attachment usage to color usage. 2020-11-05 johnstiles@google.com Add memsets to the GrBlockAllocator unit tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I8a8ca4e4c0fab44931c00c995386b7974374dd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824511}
-
Trent Begin authored
This change modifies the network-diagnostics component to closely resemble the existing connectivity diagnostics app on Chrome OS. - Automatically run the routines when the app is launched - Remove the individual run routine buttons - Organize the routines in a list - Use icons to visually show the result of the routine. UI screenshot: https://screenshot.googleplex.com/ATH5mPSmUCzatEu Bug: chromium:1142857 Change-Id: I0ca5618fd3092bb194670001a021796c0a6664a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503009 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824510}
-
Paul Moy authored
Add new unit tests to cover the cases where the kGetNextImageMethod or kStartScan D-Bus calls encounter: * null responses * responses without valid protos * responses claiming the scan failed Bug: b:169573779 Change-Id: I47c19e91229ee7f0e1995b03cdeec28d20cd92ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518448 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#824509}
-
Satsuki Ueno authored
The zx_clock_get syscall will soon be removed from zircon as part of Fuchsia RFC-0008. This updates the base time library to instead retrieve time from the current thread object. Bug: fuchsia:61732 Change-Id: I675c7a9e07e6b0a84075d4dcbde4442cda6deeb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519925 Commit-Queue: Satsuki Ueno <satsukiu@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#824508}
-
John Chen authored
Stories disabled due to crbug.com/1128019 are no longer failing. Re-enable them. Bug: 1128019 Change-Id: I892c454054af45574c8149d73514e513e78e3d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505337 Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#824507}
-
Renjie Tang authored
Bug:1007792 Change-Id: I5d8f3167fcb4db996258f4e2ce91b29f45eb6737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518117 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824506}
-
Aleks Totic authored
Bug: 958381 Change-Id: Ife3decf9129a7035ec6113c78bb00d777e0e3d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519926 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#824505}
-
Wenbin Zhang authored
Updated the sharding time to reduce long pole on shard #14. Change-Id: I404e039305c4fd06aaaff11b84d6384adc77ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520538 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824504}
-
Nick Diego Yamane authored
Such code dates from when PlatformEvent was defined as XEvent in Desktop Linux builds. Back then, it did make sense to use XEvents directly to verify PlatformEvent => WebKeyboardEvent translation. Though now that PlatformEvent == ui::Event in both ozone and legacy code paths [1], it doesn't make sense anymore and XEvent => ui::Event translation is tested in another layer, eg: x11_translation_unittest.cc, events_x_unittest.cc. Bug: 1109112 Test: events_unittests --gtest_filter='*WebInputEventTest.TestMakeWebKeyboardEvent*' [1] https://chromium-review.googlesource.com/c/chromium/src/+/2022280 R=sadrul@chromium.org Change-Id: I9391ecbf6323776b64980ce003fd06b99b192a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517148 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#824503}
-
Omar Morsi authored
This is reland of CL:2479706 which was reverted in CL:2519333 because Code added by the original CL causes use-of-uninitialized-value on the Linux ChromiumOS MSan Tests bot. The bot failed for two reasons. The first reason was that some tests (indirectly triggering the code being relanded) change the ArcAppListPrefs pointer for a profile (for example, using ArcAppListPrefsFactory::RecreateServiceInstanceForTesting). The solution introduced by this CL is to always retrieve ArcAppListPrefs using ArcAppListPrefs::Get and to not save it. The second reason is that the profile pointer saved for the UserPrivateTokenKeyPermissionsManager was used in its destructor. That's a problem because the destructor is the second shutdown phase in case of browser context keyed services. The solution was to not use the profile pointer after the user private token KPM service Shutdown method is called. Original change's description: > KeyPermissions: Add ARC key permissions manager delegate > > This CL introduces ARC key permissions manager delegate which observes > changes that affect ARC usage allowance of corporate keys residing on a > specific token. If an ArcKpmDelegate observes a change in the state of > ARC usage allowance, it notifies all observers. ArcKpmDelegates are > utilized by key permissions managers to keep key permissions updated in > chaps. > > Bug: 1113115, 1127284 > Change-Id: Ib7636c83f313904c7d5a23f91baca6bf43907344 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479706 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Long Cheng <lgcheng@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823681} TBR=lgcheng@google.com Change-Id: I4dd2583de79da6c871eba9ac0b7eeffb9b244dbb Bug: 1113115, 1127284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517946 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824502}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/937e42d5..368dd750 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9c4ca01ffe68b1f098355d75b488e5144756b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824501}
-
Dave Tapuska authored
This API mirrors the content mojom Renderer interface for similar messages that the extension system needs to implement. It is an associated interface to support moving the messages without breaking the rest of the system. Move ExtensionMsg_ActivateExtension as the first message, others will be done in other commits. BUG=692120 Change-Id: Ib42d16abc864440303df1e87631937f7dfde08ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514724 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824500}
-