1. 06 Apr, 2011 40 commits
    • oliver@apple.com's avatar
      2011-04-06 Oliver Hunt <oliver@apple.com> · 1a208ddf
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Stop JSObject::isUsingInlineStorage() from using the structure
              https://bugs.webkit.org/show_bug.cgi?id=57986
      
              Make the isUsingInlineStorage() implementation just look at
              whether the property storage is inside the object.
      
              * runtime/JSObject.h:
              (JSC::JSObject::isUsingInlineStorage):
              (JSC::JSObject::JSObject):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1a208ddf
    • barraclough@apple.com's avatar
      Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations. · c6406642
      barraclough@apple.com authored
      Rubber stamped by Geoff Garen.
      
      * runtime/JSImmediate.h:
      * runtime/JSValue.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c6406642
    • commit-queue@webkit.org's avatar
      2011-04-06 Tyler Close <tjclose@chromium.org> · 36068d58
      commit-queue@webkit.org authored
              Reviewed by Nate Chapin.
      
              run-bindings-tests reference files out of sync with CodeGenerator*.pm
              https://bugs.webkit.org/show_bug.cgi?id=57967
      
              * bindings/scripts/test/V8/V8TestCallback.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      36068d58
    • mrowe@apple.com's avatar
      Expose the original URL of a WKBackForwardListItem. · 591b12c2
      mrowe@apple.com authored
      Reviewed by Darin Adler.
      
      Needed for <rdar://problem/9074651>.
      
      * UIProcess/API/C/WKBackForwardListItem.cpp:
      (WKBackForwardListItemCopyOriginalURL):
      * UIProcess/API/C/WKBackForwardListItem.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      591b12c2
    • scheib@chromium.org's avatar
      2011-04-06 Vincent Scheib <scheib@chromium.org> · 5c99ac26
      scheib@chromium.org authored
              Fixed GPU expectations for r80867
      
              * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
              * platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c99ac26
    • commit-queue@webkit.org's avatar
      2011-04-06 Asanka Herath <asanka@chromium.org> · bfe198fc
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              Add new TargetType: TargetIsFavicon
      
              https://bugs.webkit.org/show_bug.cgi?id=57659
      
              No new functionality added, so no additional tests.
      
              * platform/network/ResourceRequestBase.h:
      2011-04-06  Asanka Herath  <asanka@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Add new TargetType: TargetIsFavicon
      
              https://bugs.webkit.org/show_bug.cgi?id=57659
      
              * public/WebURLRequest.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bfe198fc
    • aroben@apple.com's avatar
      Add a "view leaks" link to builds on SnowLeopard Intel Leaks · 98cb06d5
      aroben@apple.com authored
      Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
      
      Reviewed by David Kilzer.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
      build's results directory here...
      (ExtractTestResults.finished): ...from here.
      (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
      (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
      leaks" link to point to Leaks Viewer for this build.
      (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
      but it seemed good to add for consistency with BuildAndTestFactory.
      (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
      (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
      that we'll get a "view leaks" link.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      98cb06d5
    • ossy@webkit.org's avatar
      [Qt] media tests are flakey · 10acfa3f
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57983
      
      * platform/qt/Skipped: Disable all media tests until fix.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      10acfa3f
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57981 · 1781a619
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      Update the column count and width computation algorithm for CSS3 multi-column layout 
      to match the revised pseudo-algorithm in the latest draft of the spec.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::calcColumnWidth):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1781a619
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · f26c03bf
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
              https://bugs.webkit.org/show_bug.cgi?id=57965
      
              Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
              from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
              instead of marginStartForChild and marginEndForChild respectively.
      
              Calling these two functions on RenderInline is okay because writing-mode cannot differ
              from that of the containing block.
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::borderPaddingMarginStart):
              (WebCore::borderPaddingMarginEnd):
              (WebCore::inlineLogicalWidth):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f26c03bf
    • commit-queue@webkit.org's avatar
      2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com> · cbadf16b
      commit-queue@webkit.org authored
              Unreviewed, rolling out r83039.
              http://trac.webkit.org/changeset/83039
              https://bugs.webkit.org/show_bug.cgi?id=57978
      
              introduced a new regression in conjunction to
              ReplaceSelectionCommand (Requested by rniwa on #webkit).
      
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Removed.
      2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r83039.
              http://trac.webkit.org/changeset/83039
              https://bugs.webkit.org/show_bug.cgi?id=57978
      
              introduced a new regression in conjunction to
              ReplaceSelectionCommand (Requested by rniwa on #webkit).
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83097 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cbadf16b
    • commit-queue@webkit.org's avatar
      2011-04-06 Naoki Takano <takano.naoki@gmail.com> · 7b35c703
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
              https://bugs.webkit.org/show_bug.cgi?id=27658
      
              * fast/events/select-element-expected.txt: Added to check PgUp/PgDown/Home/End keys are working correctly in SELECT tag.
              * fast/events/select-element.html: Added for expectation.
      2011-04-06  Naoki Takano  <takano.naoki@gmail.com>
      
              Reviewed by David Levin.
      
              Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
              https://bugs.webkit.org/show_bug.cgi?id=27658
      
              Test: fast/events/select-element.html
      
              * dom/SelectElement.cpp:
              (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines.
              (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index.
              (WebCore::nextSelectableListIndex): Implemented with nextValidIndex.
              And converted to a normal static function from a private function of SelectElement.
              (WebCore::previousSelectableListIndex): Implemented with nextValidIndex.
              And converted to a normal static function from a private function of SelectElement.
              (WebCore::firstSelectableListIndex): Returns the first selectable index.
              (WebCore::lastSelectableListIndex): Returns the last selectable index.
              (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast.
              (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.
      
              * dom/SelectElement.h:
              (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().
      
              * rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML.
              They can differ due to the minimum size imposed by RenderListBox.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7b35c703
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57975 · 75864ded
      hyatt@apple.com authored
      Reviewed by Dan Bernstein.
      
      The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
      to just look at the style, so that it can find the InlineTextBox and not care that it's a child
      of the link element and not the line box for the link element itself (since that line box got
      culled).
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::applyLineClamp):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83095 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75864ded
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · d12b925c
      enne@google.com authored
              Unreviewed, rebaseline Chromium Win tests after r83075.
      
              * platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
              * platform/chromium-win/fast/multicol/nested-columns-expected.png:
              * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
              * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
              * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
              * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
              * platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d12b925c
    • hyatt@apple.com's avatar
      Rebaseline text orientation layout test on Windows. · 11b13edc
      hyatt@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@83093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      11b13edc
    • ossy@webkit.org's avatar
      [Qt] Update platform specific expected results after r83075. · 565a8172
      ossy@webkit.org authored
      * platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
      * platform/qt/editing/pasteboard/paste-text-011-expected.png:
      * platform/qt/editing/pasteboard/paste-text-011-expected.txt:
      * platform/qt/fast/css-generated-content/014-expected.checksum:
      * platform/qt/fast/css-generated-content/014-expected.png:
      * platform/qt/fast/css-generated-content/014-expected.txt:
      * platform/qt/fast/css/word-space-extra-expected.checksum:
      * platform/qt/fast/css/word-space-extra-expected.png:
      * platform/qt/fast/css/word-space-extra-expected.txt:
      * platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
      * platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
      * platform/qt/tables/mozilla/bugs/bug2123-expected.png:
      * platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
      * platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
      * platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
      * platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
      * platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
      * platform/qt/tables/mozilla/bugs/bug4523-expected.png:
      * platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
      * platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
      * platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
      * platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
      * platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
      * platform/qt/tables/mozilla/core/bloomberg-expected.png:
      * platform/qt/tables/mozilla/core/bloomberg-expected.txt:
      * platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      565a8172
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973 · 92406445
      beidson@apple.com authored
      WK2 icon database should be able to get a CGImage of a specific size
      
      Reviewed by Anders Carlsson.
      
      ../WebCore: 
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/Image.h:
      (WebCore::Image::getFirstCGImageRefOfSize):
              
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
        first frame of the requested size.
      
      ../WebKit2: 
      
      * UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
      (WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching
        CGImage in the icon.
      * UIProcess/API/C/cg/WKIconDatabaseCG.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      92406445
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · f4c7c330
      kevino@webkit.org authored
      [wx] Fix cursor handling so that we always call the chrome to set it.
              
      https://bugs.webkit.org/show_bug.cgi?id=57972
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f4c7c330
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 357663cb
      enne@google.com authored
              Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
              https://bugs.webkit.org/show_bug.cgi?id=57975
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      357663cb
    • commit-queue@webkit.org's avatar
      2011-04-06 Alok Priyadarshi <alokp@chromium.org> · 7a371bb7
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Add settings API to enable accelerated drawing
              https://bugs.webkit.org/show_bug.cgi?id=57863
      
              If accelerated drawing is enabled we try to render content and
              root layers using GPU. Please note that this setting is ignored if
              accelerated compositing is disabled.
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
              * src/WebSettingsImpl.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83088 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a371bb7
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=41445 · d91afa27
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Visited links painting with black background. Make sure that if the visited style has
      the initial background color (transparent) set that we just use the unvisited color.
      
      Source/WebCore: 
      
      Added fast/history/visited-link-background-color.html
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::visitedDependentColor):
      
      LayoutTests: 
      
      Added fast/history/visited-link-background-color.html
      * fast/history/visited-link-background-color.html: Added.
      * platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
      * platform/mac/fast/history/visited-link-background-color-expected.png: Added.
      * platform/mac/fast/history/visited-link-background-color-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83087 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d91afa27
    • ossy@webkit.org's avatar
      Unreviewed Qt buildfix after r83079. · ae089a6d
      ossy@webkit.org authored
      * WebCore.pro:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ae089a6d
    • jberlin@webkit.org's avatar
      WebKit2: Implement TextChecker on Windows · e8ef39de
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57862
      
      Reviewed by Anders Carlsson.
      
      Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.
      
      * UIProcess/API/C/win/WKTextChecker.h:
      * UIProcess/win/TextCheckerWin.cpp:
      (WebKit::TextChecker::uniqueSpellDocumentTag):
      (WebKit::TextChecker::closeSpellDocumentWithTag):
      * UIProcess/win/WebTextCheckerClient.cpp:
      (WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
      (WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
      * UIProcess/win/WebTextCheckerClient.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8ef39de
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 2acdb578
      enne@google.com authored
             Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2acdb578
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · e36e203c
      enne@google.com authored
             Unreviewed, rebaseline Chromium linux tests after r83075.
      
              * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
              * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
              * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
              * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
              * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
              * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
              * platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83083 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e36e203c
    • dino@apple.com's avatar
      2011-04-06 Dean Jackson <dino@apple.com> · 35ef1b10
      dino@apple.com authored
              Reviewed by Chris Marrin.
      
              https://bugs.webkit.org/show_bug.cgi?id=56936
              Crash in ImplicitAnimation::~ImplicitAnimation
      
              Make sure the style and start time waiting lists
              are cleared in the CompositeAnimation destructor. This
              way, no running transitions can be left in a state
              where they are destroyed as the AnimationControllerPrivate
              cleans up.
      
              * page/animation/CompositeAnimation.cpp:
              (WebCore::CompositeAnimation::~CompositeAnimation):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83082 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      35ef1b10
    • commit-queue@webkit.org's avatar
      2011-04-06 Robert Sesek <rsesek@chromium.org> · ddf5259f
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
              https://bugs.webkit.org/show_bug.cgi?id=54969
      
              No change in behavior; no new tests.
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
              * editing/TextIterator.h:
              * page/Frame.cpp:
              (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
      2011-04-06  Robert Sesek  <rsesek@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
              https://bugs.webkit.org/show_bug.cgi?id=54969
      
              * WebView/WebFrame.mm:
              (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
              (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
      2011-04-06  Robert Sesek  <rsesek@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
              https://bugs.webkit.org/show_bug.cgi?id=54969
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
              * WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore
              (WebKit::WebPage::getMarkedRange):
              (WebKit::WebPage::getSelectedRange):
              (WebKit::WebPage::characterIndexForPoint):
              (WebKit::WebPage::performDictionaryLookupAtLocation):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83081 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ddf5259f
    • alexis.menard@openbossa.org's avatar
      2011-04-06 Alexis Menard <alexis.menard@openbossa.org> · 82bcbf10
      alexis.menard@openbossa.org authored
              Reviewed by Andreas Kling.
      
              Skip tests not passing in the Qt bot.
      
              * platform/qt/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83080 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82bcbf10
    • steveblock@google.com's avatar
      2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org> · 3f0b61e5
      steveblock@google.com authored
              Reviewed by Steve Block.
      
              Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
              https://bugs.webkit.org/show_bug.cgi?id=57770
      
              Create a template from an existing functionality in JSGeolocationCustom.cpp
              to be used by the custom bindings of both Geolocation and the Media Stream API.
              V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760
      
              No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/CallbackFunction.cpp: Added.
              (WebCore::checkFunctionOnlyCallback):
              * bindings/js/CallbackFunction.h: Added.
              (WebCore::createFunctionOnlyCallback):
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSGeolocationCustom.cpp:
              (WebCore::JSGeolocation::getCurrentPosition):
              (WebCore::JSGeolocation::watchPosition):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83079 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3f0b61e5
    • alexis.menard@openbossa.org's avatar
      2011-04-06 Alexis Menard <alexis.menard@openbossa.org> · d2800994
      alexis.menard@openbossa.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Implement fullscreen playback for the GStreamer backend.
              https://bugs.webkit.org/show_bug.cgi?id=56826
      
              Implement support for fullscreen playback when building the
              Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
              The implementation is done in FullScreenVideoQt alongside with
              the Qt Multimedia support.
      
              No new tests because layout tests cover it. They are not yet activated
              but will be any time soon.
      
              * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
              * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
              (FullScreenVideoWindow::FullScreenVideoWindow):
              (FullScreenVideoWindow::setVideoElement):
              (FullScreenVideoWindow::closeEvent):
              (FullScreenVideoWindow::keyPressEvent):
              (FullScreenVideoWindow::event):
              (FullScreenVideoWindow::showFullScreen):
              (FullScreenVideoWindow::hideCursor):
              (FullScreenVideoWindow::showCursor):
      2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Implement fullscreen playback for the GStreamer backend.
              https://bugs.webkit.org/show_bug.cgi?id=56826
      
              Implement support for fullscreen playback when building the
              Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
              The implementation is done in FullScreenVideoQt alongside with
              the Qt Multimedia support.
      
              No new tests because layout tests cover it. They are not yet activated
              but will be any time soon.
      
              * QtWebKit.pro:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::ChromeClientQt):
              (WebCore::ChromeClientQt::~ChromeClientQt):
              (WebCore::ChromeClientQt::enterFullscreenForNode):
              (WebCore::ChromeClientQt::exitFullscreenForNode):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/FullScreenVideoQt.cpp:
              (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
              (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
              (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
              (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
              (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
              (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
              (WebCore::FullScreenVideoQt::FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::enterFullScreenForNode):
              (WebCore::FullScreenVideoQt::exitFullScreenForNode):
              (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
              (WebCore::FullScreenVideoQt::isValid):
              * WebCoreSupport/FullScreenVideoQt.h:
              (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83078 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d2800994
    • commit-queue@webkit.org's avatar
      2011-04-06 Zan Dobersek <zandobersek@gmail.com> · 1c7b79be
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Gtk] plugins/set-status.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57844
      
              Unskip a newly-passing test.
      
              * platform/gtk/Skipped:
      2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
      
              Reviewed by Eric Seidel.
      
              [Gtk] plugins/set-status.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57844
      
              Allow an empty status text to be dumped.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (webViewStatusBarTextChanged):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83077 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1c7b79be
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 05a0763b
      rniwa@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Bundle lineLeftOffset and lineRightOffset as a class
              https://bugs.webkit.org/show_bug.cgi?id=57851
      
              Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
              The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
              and only the difference is used to compute the width.
      
              * rendering/RenderBlock.h:
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
              (WebCore::LineOffsets::LineOffsets): Added.
              (WebCore::LineOffsets::width): Added.
              (WebCore::LineOffsets::setLeft): Added.
              (WebCore::LineOffsets::setRight): Added.
              (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
              (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83076 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      05a0763b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57916 · 6728fbe3
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Implement an optimization to the line box tree to cull out most of the intermediate
      line boxes that can occur between the root line box and the leaves of the tree (images
      and text).
      
      Source/WebCore: 
      
      RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
      that starts off as false. Only if it gets flipped to true will there be any line boxes
      created for that RenderInline.
              
      * page/FocusController.cpp:
      (WebCore::FocusController::advanceFocusDirectionally):
      Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
      is up to date.
      
      * page/SpatialNavigation.cpp:
      (WebCore::hasOffscreenRect):
      (WebCore::nodeRectInAbsoluteCoordinates):
      Add asserts in spatial navigation code to catch any future bad queries that might be made
      for rectangles without layout being up to date.
      
      * platform/graphics/FloatRect.cpp:
      (WebCore::FloatRect::uniteIfNonZero):
      * platform/graphics/FloatRect.h:
      * platform/graphics/IntRect.cpp:
      (WebCore::IntRect::uniteIfNonZero):
      * platform/graphics/IntRect.h:
      Add a new unite function that is useful for the render tree to FloatRect and IntRect.  This
      version allows rect unites to happen if either width or height is nonzero.
      
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
      if content inside those inlines is hit.
      
      * rendering/InlineBox.h:
      (WebCore::InlineBox::logicalFrameRect):
      Fix a bug in this function for obtaining the logical frame rect of an inline box.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::addToLine):
      addToLine now also checks line gap in the line box tree optimization checks.
          
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
      (WebCore::InlineFlowBox::computeOverflow):
      * rendering/InlineFlowBox.h:
      Rewritten to add the text box overflow to the text box itself.
      
       * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::destroy):
      Destroy has been changed to call a helper function to remove and destroy the line boxes that
      is now called from one additional spot.
      
      (WebCore::InlineTextBox::logicalOverflowRect):
      (WebCore::InlineTextBox::setLogicalOverflowRect):
      Text boxes now cache their own overflow in a global hash table.
      
      (WebCore::InlineTextBox::baselinePosition):
      (WebCore::InlineTextBox::lineHeight):
      Changed to not assume that the parent line box's renderer is the RenderText's immediate
      parent, since intermediate line boxes may have been culled.
      
      (WebCore::InlineTextBox::paint):
      Paint now properly checks only the text box overflow instead of the parent line box's overflow.
      
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::logicalTopVisualOverflow):
      (WebCore::InlineTextBox::logicalBottomVisualOverflow):
      (WebCore::InlineTextBox::logicalLeftVisualOverflow):
      (WebCore::InlineTextBox::logicalRightVisualOverflow):
      New accessors to obtain overflow for inline text boxes.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetter):
      updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
      text boxes may not have anything in between them and the block that contains the inline first letter
      container.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::createLineBoxes):
      The culling optimization is done here.  Only if the RenderInline says that boxes are allowed will they
      be created.
      
      (WebCore::RenderBlock::layoutInlineChildren):
      The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
      This is done before any lines are built.
      
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::RenderInline):
      The new m_alwaysCreateLineBoxes flag has been added to the constructor.
      
      (WebCore::RenderInline::styleDidChange):
      An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
      (like having a layer, borders, padding, margins or backgrounds).  Some checks that depend on examining
      the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.
      
      (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
      The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
      vertical alignment, line height, etc.).
      
      (WebCore::RenderInline::absoluteRects):
      (WebCore::RenderInline::culledInlineAbsoluteRects):
      absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::absoluteQuads):
      (WebCore::RenderInline::culledInlineAbsoluteQuads):
      absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::offsetLeft):
      (WebCore::RenderInline::offsetTop):
      offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::culledInlineBoundingBox):
      lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::culledInlineFirstLineBox):
      (WebCore::RenderInline::culledInlineLastLineBox):
      Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
      lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).
      
      (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
      (WebCore::RenderInline::linesVisualOverflowBoundingBox):
      linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.
      
      (WebCore::RenderInline::dirtyLineBoxes):
      dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
      m_alwaysCreateLineBoxes is false.
      
      (WebCore::RenderInline::createAndAppendInlineFlowBox):
      Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
      when line-box-contain is set to an unusual value.
      
      (WebCore::RenderInline::addFocusRingRects):
      Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.
      
      * rendering/RenderInline.h:
      (WebCore::RenderInline::firstLineBoxIncludingCulling):
      (WebCore::RenderInline::lastLineBoxIncludingCulling):
      Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
      is all that needs checking.
      
      (WebCore::RenderInline::alwaysCreateLineBoxes):
      (WebCore::RenderInline::setAlwaysCreateLineBoxes):
      Functions for getting and setting the m_alwaysCreateLineBoxes flag.
      
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
      Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
      lines get dirtied.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::removeAndDestroyTextBoxes):
      New helper invoked by destroy and also from updateFirstLetter.
      
      (WebCore::RenderText::destroy):
      Changed to call removeAndDestroyTextBoxes.
      
      (WebCore::RenderText::absoluteRects):
      Fixed to be properly physical instead of logical.
      
      (WebCore::RenderText::linesVisualOverflowBoundingBox):
      New implementation for RenderText that gives the bounding box of the text boxes including overflow from
      shadows, glyphs, text-stroke, etc.  Used by RenderInline::culledInlineVisualOverflowBoundingBox.
      
      * rendering/RenderText.h:
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::RenderSVGInline):
      RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.
      
      * rendering/svg/SVGRootInlineBox.cpp:
      (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
      (WebCore::SVGRootInlineBox::layoutChildBoxes):
      Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
      now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).
      
      LayoutTests: 
      
      RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
      that starts off as false. Only if it gets flipped to true will there be any line boxes
      created for that RenderInline.
      
      * platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
      * platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83075 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6728fbe3
    • morrita@google.com's avatar
      2011-04-06 MORITA Hajime <morrita@google.com> · 2a2f2042
      morrita@google.com authored
              Unreviewed expectations udpate for gtk port that follows r83065.
      
              * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
              * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83074 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a2f2042
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · d3f87429
      enne@google.com authored
             Unreviewed, modify Chromium test expectations from r83065.  They need
             rebaselines, but in the meantime they should fail more generally so as
             not to trip the bots.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83073 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d3f87429
    • alexis.menard@openbossa.org's avatar
      2011-04-06 Alexis Menard <alexis.menard@openbossa.org> · cffc38d2
      alexis.menard@openbossa.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt] Unskip some media LayoutTests.
              https://bugs.webkit.org/show_bug.cgi?id=57855
      
              Unskip some media tests for Qt.
      
              * platform/qt/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83072 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cffc38d2
    • commit-queue@webkit.org's avatar
      2011-04-06 Chang Shu <cshu@webkit.org> · d5d7cda9
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageNumberForElementById
              https://bugs.webkit.org/show_bug.cgi?id=42329
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageNumberForElementById
              https://bugs.webkit.org/show_bug.cgi?id=42329
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundlePageNumberForElementById):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::pageNumberForElementById):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageNumberForElementById
              https://bugs.webkit.org/show_bug.cgi?id=42329
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::pageNumberForElementById):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83071 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d5d7cda9
    • enrica@apple.com's avatar
      REGRESSION: Drag & Drop Gmail Attachments doesn't work. · b73b711c
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57909
      <rdar://problem/9103220>
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      In WebKit2 we cannot rely on the value returned by platformData() that
      on Mac returns an NSDraggingInfo object. This is available only in the UI
      process. Therefore we should use m_pasteboard instead.
      We cannot change what platformData() returns on Mac, since there are
      delegate methods that receive a NSDraggingInfo object (only in WebKit).
              
      * platform/DragData.h:
      (WebCore::DragData::pasteboard): Added.
      * platform/mac/ClipboardMac.mm:
      (WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
      (WebCore::DragData::asURL): Same as above.
      
      Source/WebKit2: 
      
      Added _hitTest method to support drag and drop when the drag types cannot be matched.
      This is the case for elements that do not place content
      in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).
                     
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _hitTest:dragTypes:]): Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b73b711c
    • commit-queue@webkit.org's avatar
      2011-04-06 Steve Lacey <sjl@chromium.org> · 602477f7
      commit-queue@webkit.org authored
              Reviewed by Eric Carlson.
      
              fast/layer/video_layer.html has the same text output for all chromium mac platforms.
      
              [chromium] Fix fast/layers/video_layer.html expectations
              https://bugs.webkit.org/show_bug.cgi?id=57386
      
              * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
              * platform/chromium-mac/fast/layers/video-layer-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      602477f7
    • sergio@webkit.org's avatar
      2011-04-06 Sergio Villar Senin <svillar@igalia.com> · 02202918
      sergio@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] DumpRenderTree: do not try to free NULL SoupURIs
              https://bugs.webkit.org/show_bug.cgi?id=57932
      
              Some Layout tests have invalid URIs that do not generate valid
              SoupURI instances. Do not try to free those NULL SoupURIs.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (willSendRequestCallback):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      02202918