- 12 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6067e9ce8bb3..62c10c170bb3 2020-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ca966cfb to a927c079 (518 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibedbee6a56e2fc08287d042e855ea0ae34606af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826718}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I3b6f490991001a9d8e5caafd5cb04d5f68651891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533967Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 1145565 Change-Id: Iecd38a26630d7a6565455c42942b4b61144f1d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532719 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#826716}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: Iadcb930d49e905dcf94511f3fb213e06f0cce547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505704Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#826715}
-
Vincent Boisselle authored
... card in Feed V2" This is a reland of 6fe88955 after fixing the issue of uninitialized notice_card_acknowledged Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=harringtond@chromium.org,vincb@google.com Bug: 1146458,1148208 Change-Id: Id35d072feee01609c21c82fcb46f698132df7ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532223Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#826714}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e48f06fb0cca..2b1513dc094d 2020-11-12 szuend@chromium.org TypeScript-ify profiler/ProfileView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I260b3ec17ec89eb2106278fe4cb75f5314edebd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533541Reviewed-by:
-
Jérôme Lebel authored
The SettingsImageDetailTextItem needs to set the detail text color each time the cell is configured. Fixed: 1145527 Change-Id: I1607709f02ce6703b9b74c93854f0f267db78871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527044 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74f0f62cef42..479bba705e88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mamir@google.com Change-Id: I5bef210508fea08d308b929e0eb585d2d0e4f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826711}
-
Ioana Pandele authored
Bug: 1141082 Change-Id: I95a97c34668f2e7eda78aa6a52f844dc6c73e590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529549Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#826710}
-
Bartek Nowierski authored
Direct map didn't have trailing guard page, yet it was subtracted when calculating |map_extent->map_size|, as if it was there. Clarify relationship between slot_size, map_size and reserved_size, while at it. Change-Id: I7845c63771014ad319ee41e7d523bbb145177e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532479 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826709}
-
dpapad authored
Instead, the "async" keyword is directly used on the functions that are passed to the testing framework. Bug: None Change-Id: Ife6c66a85cf60cf2bc3d9ec47a33d088c44b38ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531861 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826708}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605041937-c87b025ab4b9cd2fe14d3e7cb6f1c951afd90e7c.profdata to chrome-win32-master-1605139151-5e724661a0d96b85fc6a4800d483b70ce425d91c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I96f53517194b32ae3d128657f0e0e3dcc5ec04df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533963Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 1145565 Change-Id: I2cf67c8a4ba3ed66ff67b0e0809116e972a34269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532656 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826706}
-
Hiroki Nakagawa authored
This CL integrates multiple WebContents based (non-MPArch based) Prerender2 into navigation. The feature is used only when the runtime flag is enabled. Design Doc: https://docs.google.com/document/d/15N-HYdSnItZyDIqRFui5OVzYFcNwxtq7kYkKBx3J3xQ/edit#heading=h.88qfv92t9hg9 <Overview> The Prerender2 runs navigation code twice: navigation for prerendering a page and navigation for displaying the prerendered page. The first navigation is basically the same as the normal navigation: running regular navigation code and notifying PrerenderHost of navigation completion via WebContentsObserver. This part was already implemented by the previous CLs (see https://crbug.com/1132746). The second navigation known as "activation" is special. That needs to look up a prerendered page and activate it instead of fetching a page from network. Also, activation should run throttling as well as the normal navigation. This CL implements this part. <Implementation Details> This CL works as follows: - On navigation start, a navigation request finds an available prerendered page for a request URL. When it's found, the request creates a noop CachedNavigationURLLoader like the BFCache not to issue a network request. - On navigation commit, the navigation request activates the prerendered page and aborts remaining steps for navigation. This is a minimum change for running end-to-end prerendering tests. This doesn't implement some essential functionalities, for example, session history integration yet. Bug: 1132746, 1138711, 1138723 Change-Id: I0371de7ed01ede50a2c1887d8d558c3debdcd2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494291 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826705}
-
Roman Sorokin authored
Bug: 1115203 Change-Id: Id4671eb42ae66ab62d779d404b7a59ace583f8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526322 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#826704}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ie1e86a9e513a14f15414ffeaf95d8b30b49e175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490915 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826703}
-
Clemens Arbesser authored
This CL also allows the onboarding to reuse the previous bottom sheet content to allow for a smooth transition. Finally, this CL fixes a potential issue where the bottom bar delegate was not always correctly set for users who saw the onboarding. Bug: b/171776026 Change-Id: I747333d80c08860192eae7b8414b5c731bc792ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526068 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#826702}
-
Ella Ge authored
This CL adds a jni method to let QualityEnforcer notify native and send a console message for violations. We will move to use devtools issue tab instead in the near future. (TODO in quality_enforcer.cc) The warning together with the toast warning are behind a flag TRUSTED_WEB_ACTIVITY_QUALITY_ENFORCEMENT_WARNING, just in case we need to disabled them for any reason. The flag is *Enabled* for now since we have all approval on launch bug: crbug/1127892 To have a valid tab and WebContent to send the message to, moves the check of digital asset link violation to onDidFinishNavigation from onFinishNativeInitialization. This also moves the ViolationType enum to c++ part to be able to share between c++ and java. Bug: 1147479 Change-Id: If0f80fee412ea522a7202226a72b169092525cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530800 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826701}
-
Yuki Shiino authored
This reverts commit 6fe88955. Reason for revert: Suspicious about causing test failures: ProtoUtilTest.* https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26187 Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=vincb@google.com,harringtond@chromium.org Change-Id: Ia0515d8e3d2c1af678cbf5533c4e28ac5f46ed77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531812Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#826700}
-
Clemens Arbesser authored
This adds handling for when the user taps the back button or the feedback button. This CL also makes swipe-to-dismiss a configurable trigger script action. The corresponding metric enum was moved from |Finished| to |Shown|, since this may now happen more than once per run. Bug: b/171776026 Change-Id: I6d78c15ab1378c533eeafb41b59117ba241f17ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530329Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#826699}
-
Yuki Shiino authored
This reverts commit 23c810e8. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Original change's description: > removed unnecessary defderred PrepareTpmDeviceAndFinalizeProfile > > According to the current program flow, this to-be-removed branch seems a > useless special handling. > > This CL might affect how UserSessionManager utilitzes tpm manager client > in the near future. > > BUG=b:172748724 > TEST=unittests. > > Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#826319} TBR=alemate@chromium.org,rsorokin@chromium.org,khmel@chromium.org,cylai@google.com Change-Id: If82cbaa7a634a6a33667ea139f0ec8e6f5055716 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172748724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534273Reviewed-by:
-
Christian Dullweber authored
UrlFormatter.formatUrlForSecurityDisplay is too strict and displays some valid URLs in punycode. Add new url formatter with the difference that non-dangerous non-ascii characters are displayed correctly and www subdomains are omitted Bug: 1077766 Change-Id: I896fbf0a4d89df36c5fc882afaf09d1366f5423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532294Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#826697}
-
Dominik Röttsches authored
The FreeType-Testing GitHub repository is a project connected to the FreeType font rasterisation library which provides a set of fuzzing-harnesses for oss-fuzz. After issue 1139963 we want to build and run a fuzzing configuration that matches the FreeType build configuration that we use for Chromium. This CL achieves that for the first harness: truetype-render-fuzzer, the main glyph rasterisation harness. The CL adds the GPL-licensed FreeType-Testing repository to third-party as a non-shipping dependency in order to be able to build the same harnesses as part of Chromium and against Chromium's freetype-harfbuzz build target. It defines a fuzzer_test build target to build the TrueTypeRenderFuzzTarget and defines which seed_corpus directory to use from the freetype-testing set of corpora. Bug: 1140584 Cq-Include-Trybots: luci.chromium.try:linux-libfuzzer-asan-rel Change-Id: Icb2ab2d4ee65fd7d1d45ebfe9ca01ff0ef3628e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529104Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#826696}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I5ec5132b286ab2f67e971abca49c72f9117870bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494401 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826695}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 05227c04. With Chromium commits locally applied on WPT: 50d5488e "Revert "webauthn: move create credential tests for residentKey/credProps to WPT"" c0e73fce "[webcodecs] Make sure callbacks aren't called after encoder.reset()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I788499f71085d09be46aae3669f32da25627f810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532998Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826694}
-
Mason Freed authored
Per more feedback [1] on the issue thread, it would be preferred to remove the state from DOMParser and add it instead to the parseFromString method. [1] https://github.com/whatwg/dom/issues/912#issuecomment-725825635 Bug: 1042130 Change-Id: I316c008b80436bdacf7d0548e4ccd891a5c15411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533848 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#826693}
-
Kent Tamura authored
This CL removes DEFINE_LAYOUT_OBJECT_TYPE_CASTS for LayoutBoxModelObject. * Remove all remaining usages of old downcast helper for LayoutBoxModelObject * Remove LayoutBoxModelObjectTest::GetPaintLayerByElementId(). It's redundant because we have |RenderingTest:: GetPaintLayerByElementId()|. * Add LayoutBoxModelObjectTest::GetLayoutBoxModelObjectByElementId() to reduce the usage of ToLayoutBoxModelObject(). This CL has no behavior changes. Bug: 891908 Change-Id: I6cbad49a2b872d8571f466b4ec5c7b3c313616e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532139 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826692}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/034eac1e..f3414dbc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide877334cefffd534ddd7415ddb2e55861ca09d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534093Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826691}
-
John Palmer authored
Call setAssistiveWindowProperties only when needed. This stops breaking ChromeVox This reverts commit a7f6e1a1. Reason for revert: Adding a fix so that ChromeVox editing notifications still work Original change's description: > Revert "Make assistive window show with autocorrect manager" > > Fixed: 1146877 > TBR=jopalmer@chromium.org > > Reason for revert: > Breaks ChromeVox; found via bisect; see bug. > > This reverts commit 6cbffa8a. > > Dependent changes (also reverted): > 73bcb673 > 84c821b5 > b197149c > > Change-Id: I65bc46c273cd64555676073cf6cd172128cfe068 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529695 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825948} Change-Id: I3d4b08c6197f287dbf55fca2d377ce577c81a617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530953Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826690}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/36fdadd1a606..e48f06fb0cca 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia237f648e215de00a287198053ce677f8ef1b16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533997Reviewed-by:
-
Yuki Shiino authored
This reverts commit 30a60064. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4433 Original change's description: > [ozone/x11] Enabled user input monitor unit tests. > > This CL adds Ozone platform initialisation to the user input monitor tests > so they can now work with Ozone enabled. > > Bug: 1109112 > Change-Id: I31f9dabf2da9eed85cd05fe27017899b0247f4bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521144 > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826638} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: Ic8cd3da17dd5d2de01981aa9a8f33b6a55621c43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531810Reviewed-by:
-
Yuki Shiino authored
This reverts commit ca288e0c. Reason for revert: Suspicious about build breakage. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3020 Original change's description: > Offer to install Rosetta for Widevine if it's not already installed > > If a page wants a CDM and it's unavailable, show an infobar. If > the user agrees, install Rosetta for them. > > Bug: 1145792, 1142017 > Change-Id: I92f030c2dbb5d9b092b84252fddee6f7ad55a436 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527771 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826636} TBR=avi@chromium.org,pkasting@chromium.org,thakis@chromium.org,xhwang@chromium.org,ericde@google.com,rsesek@chromium.org,mark@chromium.org Change-Id: I7c7f88b0690f801cdfb990562f7938d73676bf23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145792 Bug: 1142017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534272Reviewed-by:
-
Yuki Shiino authored
This reverts commit 49dbb543. Reason for revert: Suspicious about making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29?limit=200 Original change's description: > [NTP][RQ] Makes deletion of queries from in-memory URL DB asynchronous > > Deletion from the in-memory URL DB can be slow: http://shortn/_eSkRG8RvpV > This CL makes the deletion of queries from the in-memory URL DB async > by posting the deletion task to a sequenced task runner on the UI thread. > > Fixed: 1110077 > Change-Id: Ia8099093eea6efde952bfbb58cd182b06174f8e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531654 > Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826399} TBR=mahmadi@chromium.org,ramyan@chromium.org Change-Id: I6377c865ef669849aa9f4fa484e80f3544531280 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532543Reviewed-by:
-
Xing Liu authored
Android R starts to restrict other apps to access app's private directory on R. Based on suggestion from Android engineer, we can use a few new APIs added in Q and R to move the storage path a non private directory. Old path: /storage/$volume_id/$app_private_directory/Download New path: /storage/&volume_id/Download Bug: 1116905 Change-Id: Iecb34a08648678dbd1ff986c7ee60f3a4647c725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826685}
-
Morten Stenshorne authored
AppendSingleFragmentIgnoringPagination() is called when fragmentation gets disabled because of transforms. This needs to be fixed; see crbug.com/1058792 - in the meantime, let's at least traverse the fragment tree, to avoid DCHECK failures. Note that things aren't going to look or behave right if such nodes break into multiple fragments - neither with nor without this fix. Bug: 1146975 Change-Id: I7ded8d094185e69e39ce115b256661dee48f7e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529099Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826684}
-
Rakina Zata Amni authored
Currently we only track visibilitychange on document, but the event might bubble up to window. It's possible for web developers to add the event listener on window instead, and we should still disable sudden terminations if that's the case. Bug: 1135582 Change-Id: Iae7f783b9e1713b3409b6f385148388932f0087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526883Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28f538d7ea5a..74f0f62cef42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: I13b7009cf0a7396233caed00a471400da63e509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533895Reviewed-by:
-
Glen Robertson authored
Trying to match the restrictions in the Payment Request API spec [1] (DG isn't spec'd yet). We require that the "payment" feature policy is enabled. Secure context is already ensured by the IDL. Also add some logging of errors so developers can figure out what is going wrong. [1]: https://w3c.github.io/payment-request/#dfn-payment-relevant-browsing-context Bug: 1061503 Change-Id: I2c13663148ad8736a4d9ab3ea124d96038d8e878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526872Reviewed-by:
-
Yao Xiao authored
Why: we don't want floc to change more often than the intended scheduled update cadence. What: - For each history-delete notification, if it's all-history or the time-range overlaps with the time range of the history used to compute the floc, we invalidate the floc. Otherwise, we keep using the current floc. - Remove the mechanism caching the swaa_nac_account_enabled status. It's no longer needed as we don't need to query more often than the scheduled update rate (% rare race condition). How: Store history_begin_time_/history_end_time_ fields to FlocId. Compare these fields with the history delete info. Bug: 1143597 Change-Id: I685fd1a10cbc8044e799d7a644dfa2b7bb82ddd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507454 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3f0d0cc3810..53d3c085a784 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I83d83edb52833daf49e9c25be8df478e191a5a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533728Reviewed-by:
-
