GitLab

LocationBarModel is a much more accurate name for this class than
ToolbarModel.

We didn't use OmniboxModel because it may be confused with
OmniboxEditModel.

TBR=sky@chromium.org

Bug: 898347
Change-Id: I845e36fc58e4f8f4b951b83379bb355a4d718e9d
Reviewed-on: https://chromium-review.googlesource.com/c/1306837
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603977}

//third_party/abseil-cpp is currently excluded from
gn check because of a couple of dependency fails. This patch
tries to fix those.

Most complicated is the dependency to gmock. The code does
include "gmock/gmock.h" which gn will see as a dependency on
//third_party/googletest:gmock.

Bug: 898837
Change-Id: I2c1d33935511e790e1343cb59db11908cf4fab15
Reviewed-on: https://chromium-review.googlesource.com/c/1307497
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603976}

Change-Id: I2e8fc39df1a4a94a59e19cdab6ff1e96bcf292a9
Reviewed-on: https://chromium-review.googlesource.com/c/1306473
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603975}

This CL updates the SelectVideoTrackAdapterSettings() function to allow
configuring VideoTrackAdapters with rescaling disabled.

This is in preparation for supporting the resizeMode constrainable
property in getUserMedia().

Drive-by: Fix CONTENT_EXPORT style in header.

Bug: 854980
Change-Id: Ib9c0d33d14d45382ac38af091b0bc3f59b6f90f9
Reviewed-on: https://chromium-review.googlesource.com/c/1286817
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603974}

Bug: 879261
Change-Id: I5513a889df874bef4157245d7ad7454e79777cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1211669Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603973}

Change-Id: I60d5a327f7f0ad22dccdbdcbe15dbfaf89f98918
Reviewed-on: https://chromium-review.googlesource.com/c/1302493Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603972}

This is a precursor to have AR and VR be in separate dynamic feature
modules.

Bug: 837965
Change-Id: I0fb15971db49b858d808f78d93b77a72819cad8c
Reviewed-on: https://chromium-review.googlesource.com/c/1298238
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603971}

This CL was reverted since it depends on a CL that introduced MSAN issues.
Relanding as it is after the MSAN issues have been addressed.

Origianal description:
crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

Bug: 897369
Change-Id: Id56368bbdb18b9e7ec3a284e79ab76c04ec3bf8e
TBR: oshima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308036Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603970}

So that in Payments server side logging/metrics we know which source
the request comes from. For normal Chrome Upstream, we default this
field to UNKNOWN.

Bug: 897998
Change-Id: I39e614fe0cd8747fb26e41e8da77dab574cd0f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1306776Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603969}

Known issues:
 * Browser and renderer main threads are still using GLES2Interface instead
   of RasterInterface.
 * RasterDecoder still needs GLContext when --enable-vulkan flag is used.

Bug: 838899
Change-Id: Id70bb41995b357846c15bc106cd3addfe527ad53
Reviewed-on: https://chromium-review.googlesource.com/c/1298336
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603968}

When network service runs out of process, it uses a privileged
process similar to the GPU process. The network process needs
access to AndroidNetworkLibrary, which was not in the main dex.
This was causing many failures when running tests with network
service turned on on KitKat devices, see example failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/113359

The failures are throwing a ClassNotFoundException for
AndroidNetworkLibrary.

Bug: 827531
Change-Id: I9003a8469719e06cb5a05482d5b7cf24980a32b0
Reviewed-on: https://chromium-review.googlesource.com/c/1306344Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603967}

Notable changes:
 - Removed NavigationManager usage from SadTabView
 - Removed Dispatcher usage from SadTabView
 - Reload the page via dispatcher instead of navigation manager
 - Renamed SadTabView's delegate from actionDelegate to delegate
   (because there is just one delegate)
 - Updated delegate names to match Coding Guidelines for Cocoa

This refactoring will allow to create SadTabViewController to be
presented from SadTabCoordinator. SadTabCoordinator will be a new
class owned by BVC, and created with BrowserContainerViewController
as baseViewController. All new code will be written behind the flag.

The refactoring is needed, because in New Architecture view
controllers are not suppose to have model code.

Change-Id: If98f6d4af9c87a0274b717b266f94f71956b79a0
Reviewed-on: https://chromium-review.googlesource.com/c/1306351Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603966}

resource_map_source generates a map looking like

  { "IDR_FOO", IDR_FOO }

while resource_file_map_source generations a map looking like

  { "path/to/resource", IDR_FOO }

The latter currently doesn't work for files that contain variable references
in their name (e.g. ${root_gen_dir}).

The mojo code just needs any unique string identifier, so just use
resource_map_source instead.

No intended behavior change.

Bug: 899437
Change-Id: Ifc72086bd3b26997fb29d7d43306ba790a2c4e73
Reviewed-on: https://chromium-review.googlesource.com/c/1307937Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603965}

Bug: 898676
Change-Id: Id2c15af3c517ceffe919d5baa1955c00392c9307
Reviewed-on: https://chromium-review.googlesource.com/c/1298302Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Bruno Santos <brunoad@google.com>
Cr-Commit-Position: refs/heads/master@{#603964}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15a8883b4d7d..f8b5a7154479


Created with:
  gclient setdep -r src-internal@f8b5a7154479

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibab164d2b57577c5339f346d679d8946cb75eb74
Reviewed-on: https://chromium-review.googlesource.com/c/1307880Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603963}

We don't need to expose a MessageLoop from base::Thread --
task_runner() is enough to post tasks and other functionality
can be accessed via base::MessageLoopCurrent::Get when on the

R=gab@chromium.org
TBR=gab@chromium.org
BUG=891670,668707

Change-Id: I88996daa956f4a5e2dffda6fe31a9ee8102746eb
Reviewed-on: https://chromium-review.googlesource.com/c/1301437Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603962}

https://pdfium.googlesource.com/pdfium.git/+log/05e43638cd37..98bc0ce5c15f


git log 05e43638cd37..98bc0ce5c15f --date=short --no-merges --format='%ad %ae %s'
2018-10-30 tsepez@chromium.org Test util.scand() from javascript


Created with:
  gclient setdep -r src/third_party/pdfium@98bc0ce5c15f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0615f754dc180e14a186cd364e06318522c43c68
Reviewed-on: https://chromium-review.googlesource.com/c/1307878Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603961}

When network service is enabled, it is possible for ServiceManager
to launch network service without the browser process. This will cause
a crash in ChromeContentBrowserClient::OnNetworkServiceDataUseUpdate().
This CL fixes the issue by making ChromeDataUsemeasurement a singleton
for network service. Also it fixes a bunch of BrowserThread checks
as BrowserThread will not be available when browser process isn't created.

BUG=898970

Change-Id: I8638239c62a852374f52d5832d86558f4c4bef19
Reviewed-on: https://chromium-review.googlesource.com/c/1303180Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603960}

crrev.com/c/1099564 disabled the Pixel_OffscreenCanvasAccelerated2D*
tests, correctly increasing the version in pixel_test_pages.py.
These tests seem to be passing according to [1], so let's try
and reenable them.

[1] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry

CQ-DEPEND=CL:1303097

Bug: 805031
Change-Id: Ie6b48fde0a03fefbbff185de1818e3105192f5f3
Reviewed-on: https://chromium-review.googlesource.com/c/1303097Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603959}

This is a folow-up for the rename of TaskPriority::BACKGROUND to
TaskPriority::BEST_EFFORT in
https://chromium-review.googlesource.com/1153461.

Bug: 831835
Change-Id: Ia99f3a923622de37cb92490879d2a7b9b6b4f153
Reviewed-on: https://chromium-review.googlesource.com/c/1307673Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603958}

Currently, temporary files in the FileAnalyzer unit tests are written
wherever the tests were invoked from. This CL writes them to a temporary
directory so that 1) we have write permission, and 2) we clean up after
ourselves.

Bug: 900021
Change-Id: Ia5390c6444c96a70e736f33b3091c73e3ad97516
Reviewed-on: https://chromium-review.googlesource.com/c/1306661Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603957}

Bug: 899324
Test: none
Change-Id: I9f632473636f6a6df3e2528a957adadda006a176
Reviewed-on: https://chromium-review.googlesource.com/c/1307236Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603956}

Bug: none
Change-Id: Ie647879a8dbd6d7b0f90f71234488ae36d133e4f
Reviewed-on: https://chromium-review.googlesource.com/c/1307936Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603955}

https://chromium.googlesource.com/catapult.git/+log/d15a3be3ab45..5e1c1c293b07


git log d15a3be3ab45..5e1c1c293b07 --date=short --no-merges --format='%ad %ae %s'
2018-10-30 erikchen@chromium.org ADB commands should only retry errors, not exceptions.


Created with:
  gclient setdep -r src/third_party/catapult@5e1c1c293b07

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:895027
TBR=sullivan@chromium.org

Change-Id: Ifa4ab1888a5a3fd36652fbda11af4e269463b18c
Reviewed-on: https://chromium-review.googlesource.com/c/1307753Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603954}

Change-Id: Id19d1e7c7dc9caebad2ba25d8c4bd653e5828757
Reviewed-on: https://chromium-review.googlesource.com/c/1301518Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603953}

The active media controller follows the last played
media session. This changes the logic to ignore
temporary media sessions by only following kGain
sessions.

BUG=893296

Change-Id: I6f7fbdbc52d9c6120888501060dce94befaaacbe
Reviewed-on: https://chromium-review.googlesource.com/c/1306784Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603952}

The padding in divider elements hasn't had any effect which is fixed by
using the margin instead which shows the desired spacing.
Additionally, the line height wouldn't affect the height of the title
label and negate any existing padding which is fixed by using the
correct lineSpacingMultiplier.

Bug: 856180, 900178
Change-Id: Ie4e9e1df1081da9fa5dc5e6aeb1bcb578f22d7d0
Reviewed-on: https://chromium-review.googlesource.com/c/1307399Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603951}

This CL is inspired by https://crrev.com/c/1299235 and also aims to make
the BUILD.gn file pass GN's checks. This is accomplished by correctly
layering the targets to reflect include dependencies.

A side benefit of this CL is that the crc32c target now only exposes the
library's public header.

TESTED=gn check out/Default/ "//third_party/crc32c/*"

Change-Id: Ie0bde3d4c1ae55a6323e0184fcbcf0c01fe0cbb3
Reviewed-on: https://chromium-review.googlesource.com/c/1301557Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603950}

We'd like to eventually remove the caching of LocalSurfaceIds everywhere. As a
step along the way, this updates ParentLocalSurfaceIdAllocator::GenerateId to
be a void method.

The rest is a mechanical refactor of the callsites, switching them to the
pre-existing ParentLocalSurfaceIdAllocator::GetCurrentLocalSurfaceId to cache.
We'll update each area separately in follow ups to remove the caches.

TBR=sky@chromium.org
TBR=yfriedman@chromium.org
TBR=boliu@chromium.org

Bug: 655231
Change-Id: I706e66b9d4a9a594f9a61eb15d2a1505fc0e9ead
Reviewed-on: https://chromium-review.googlesource.com/c/1307693
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603949}

If VpnConfigAllowed is false, it should not be possible to disconnect
VPN connections.

We need to modify the "Connect" and "Disconnect" button that appears on the
network settings page, but only for VPNs. For this, the |controlled-button|
element gets modified such that it can accept a null pref, which indicates
that it should not be controlled.

BUG=b:72861260
BUG=873123
TEST=browser_tests --gtest_filter=*CrControlledButtonTest*
TEST=browser_tests --gtest_filter=*CrSettingsInternetDetailPageTest*

Change-Id: I199e56b0eb21f926389192e9150912c2990d4a9b
Reviewed-on: https://chromium-review.googlesource.com/c/1278215Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603948}

Disable the following test on Linux and Win
virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html
virtual/user-activation-v2/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html


Bug: 899222
Change-Id: I03e67f08807a04ad364ed3ba7657a88d9514590e
Tbr: sahel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1307583
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603947}

TBR=mastiz@chromium.org

Bug: 899989
Change-Id: Ic839d6c9e02caf9f7d74cfd9fadedb7f144d2901
Reviewed-on: https://chromium-review.googlesource.com/c/1307446Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603946}

Also changes existing test targets to use base::BindOnce instead of the
deprecated base::Bind, and removes some unused includes.

R=kbr@chromium.org

BUG=chromium:870747

Change-Id: Ib94ffd228a6057a7010e8581ccb3392ae700c357
Reviewed-on: https://chromium-review.googlesource.com/c/1307510Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603945}

This CL creates a new GPU channel IPC message type,
GpuChannelMsg_ScheduleImageDecode, which a renderer will eventually be
able to use to request hardware-accelerated image decodes. Two classes
are added and plumbed into the existing GPU channel architecture to
help deal with this new message:

1) On the service side (GPU process), an ImageDecodeAcceleratorStub
   processes incoming messages. There is one such stub per GpuChannel,
   although it is owned by the GpuChannelMessageFilter because it
   expects to receive messages on the IO thread.

2) On the client side (renderer), an ImageDecodeAcceleratorProxy is
   associated with a GpuChannelHost. It's a thread-safe helper that
   allows components in the renderer to schedule image decodes and get
   back a SyncToken to synchronize on the completion of the decode.

The processing of the new IPC message is guarded by the
kVaapiJpegImageDecodeAcceleration feature flag: the stub refuses to
handle that message if the feature is disabled.

Bug: 868400
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5d24e661341b5744b30306aca22903f28a52d695
Reviewed-on: https://chromium-review.googlesource.com/c/1285610Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603944}

Last Image Paint and Largest Image Paint concern about the load time of images
because they are highly relevant to user experiences. Initially, the metrics
only take <image> into account. As video image and svg image are equally
important, we should consider video poster image and SVG image as well.

Video image example:
<video poster="http://example.com/nonexistant.gif"></video>

SVG image example:
<svg id='svg'>
  <image xlink:href="http://example.com/nonexistant.jpg"/>
</svg>

Bug: 869924
Change-Id: Id414d236296829c4423e1f69dc140f54cb91444f
Reviewed-on: https://chromium-review.googlesource.com/c/1305753
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603943}

This is a reland of 7b97163e, which was reverted
because it still referenced some device builders still compiling 32-bit arm.

Bug: 894099
Change-Id: Ib1dbcb172aa26c9b0fb2d8af7655971f6f549578
Reviewed-on: https://chromium-review.googlesource.com/c/1307587Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603942}

Why remove DoesSiteRequireDedicatedProcess
==========================================

This CL removes
HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess.  We plan
to remove 2 other overrides of this ContentBrowserClient method in
follow-up CLs.  We want to remove this ContentBrowserClient method
altogether, because
1) it is currently the only reason SiteInstanceImpl::GetSiteForURL needs
   to take BrowserContext* as an argument (and therefore is problematic
   on threads other than UI thread)
2) the method was initially introduced to support --isolate-extensions
   which has been obsolete since shipping --site-per-process in M67.

Additionally, site-per-process mode was always set globally (i.e. see
ContentBrowserClient::ShouldEnableStrictSiteIsolation) and therefore
controlling this mode via
HeadlessContentBrowserClient::ShouldEnableStrictSiteIsolation is more
consistent with how the rest of the code is structured.


Removal mechanics
=================

Removal of HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess
means that HeadlessBrowserContextOptions::site_per_process() doesn't
have any callers and therefore it can be removed (together with
HeadlessBrowserContext::Builder::SetSitePerProcess).

HeadlessProtocolBrowserTest needs to force site-per-process mode.
Before this CL this was done via
HeadlessBrowserContext::Builder::SetSitePerProcess.  After this CL this
is done by having the test inject --site-per-process into the cmdline.


Bug: 898281
Change-Id: I2cccd896eb6ac70a97ceae293aa4450a0f005d51
Reviewed-on: https://chromium-review.googlesource.com/c/1306842Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603941}

The finch result of VizHitTest v2 shows that we have 1% of possible
incorrect hit test targets. The data may be noisy because the async
verification may get answer after the page layout changes. This CL
added a new bucket for unreliable result, it counts in that bucket
when the results do not match and another synchronous hit test finds
a different target.

Bug: 896786
Change-Id: I287359251670d4d33297dced42014d03271424d3
Reviewed-on: https://chromium-review.googlesource.com/c/1289163Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603940}

This reverts commit 3b214250.

Reason for revert: components_unittests/PaymentsClientTest.* failing on Linux ChromiumOS MSan Tests.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests

Original change's description:
> Reland "[base] Harden base::JSONWriter::BuildJSONString"
> 
> This is a reland of bbe71c7f
> 
> Original change's description:
> > [base] Harden base::JSONWriter::BuildJSONString
> >
> > This change simplifies and hardens base::JSONWriter::BuildJSONString().
> > It replaces the old base::Value API with the new one, thus implicitly
> > replacing DCHECKs with CHECKs.
> >
> > Bug: 859477
> > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#603508}
> 
> Bug: 859477, 900041
> Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233
> Reviewed-on: https://chromium-review.googlesource.com/c/1306356
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603889}

TBR=rsesek@chromium.org,jdoerrie@chromium.org

Change-Id: I9db48180d39e9aa4cfd7cb11af1df331d10df39d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859477, 900041
Reviewed-on: https://chromium-review.googlesource.com/c/1308153Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603939}

Resource names are being stripped from the apk. Output the R.txt files
to the apks directory for archiving during official builds.

Bug: 894208
Change-Id: Iba0499fb2ac6dccc22a8997b546955733d4e5e23
Reviewed-on: https://chromium-review.googlesource.com/c/1305813Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603938}