GitLab

Change the FIDL interface QueryableData::GetAllEntries() to GetChangedEntries(),
which is identical to the current implementation on the first
invocation but on, but for subsequent invocations it uses hanging
callbacks to send incremental changes to the client.

The change is necessary for allowing QueryableData values to change at
page runtime.

Implementation of support for incremental change events are reserved for
a followup CL.


Bug: 929291
Change-Id: I7af7e77130eff55699a90fd5aff0a581bf3e3dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500021
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637909}

- Associate the sync-setup row on the people page
  to the sync-controls page to make the sync controls
  searchable.
- Hide the sync controls when not available, so
  they don't show up during a search.

Additional:
 - Fix syncStatus update for settings-sync-controls
   when unified consent is disabled. (syncStatus
   wasn't used before.)

Bug: 916988
Change-Id: I5cc73cc32a03fb3960fe57e9075a16a6b31d2afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498531
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637908}

Added calls to android DownloadManager (AddCompletedDownload and
RemoveCompletedDownload) from native offline content provider.
Also added a feature to selectively disable the native path for now.

Bug: 933854
Change-Id: I178ab17063f6914b523219c308a6abaa3133452c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1422747
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637907}

Temporary workaround for avoiding crash reporting when
BlobURLStoreImpl::Revoke() is called after the RPHI associated with the
object has already been destroyed. This is similar to the behavior
allowed before http://crrev.com/c/1409732 and is intended to be a
minimal fix that can be merged to M73.


Bug: 933089
Change-Id: I734d752f1fb10a882361c7e6af0716df08ac00f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501494
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637906}

<asm/ptrace-abi.h> doesn't exist in the arm sysroots, and <sys/ptrace.h>
defines PTRACE_GET_THREAD_AREA as an enum, not a #define:

  /* Get the thread pointer of a process.  */
  PTRACE_GET_THREAD_AREA = 22,

On aarch64, neither PT_GET_THREAD_AREA nor PTRACE_GET_THREAD_AREA are defined.

This changes the include trigger to check for !arm && !aarch64 as well as
defined(PTRACE_GET_THREAD_AREA) to catch the arm and aarch64 cases.

Change-Id: I9044d9f315cbb15011f397a06d03d4bec7396985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496448Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637905}

The spec says to use the target window, not the source window, but we have some bugs around
this targeting that may be breaking real websites. Temporary go back to the spec-violating
way, as the breakage appears to be smaller.

Bug: 935064
Change-Id: Ie1fd3030cbe8700820d1b8631bb3d318259e3380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504160
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637904}

This HSL shift effect is used to present disabled or grayed-out versions
of app icons and tab favicons.

Changing this (from 0.75) in two places:

chrome/browser/ui/app_list/arc/arc_app_icon_loader.cc:61
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:85

makes it consistent with four other places (which already used 0.6):

chrome/browser/extensions/chrome_app_icon.cc:83
chrome/browser/extensions/extension_icon_manager.cc:77
chrome/browser/favicon/favicon_utils.cc:26
chrome/browser/ui/app_list/chrome_app_list_item.cc:48

Change-Id: I67fbf5e0522ec17f8a248868091a8a624241e62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496131Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637903}

The MediaColorTest is failing on ChromeOS.

https://crbug.com/938618

Bug: 938618

TBR: timvolodine@chromium.org
Change-Id: I59db4abec0b91b0a3f93687b2face2babcd4b5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504260Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Auto-Submit: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637902}

It's a waste to call SpellCheckHost::DisconnectSessionBridge when
SpellCheckHost is not bound, as it initializes a SpellCheckHost and
then disables it immediately.

Therefore, this patch stops calling it when SpellCheckHost is not
bound yet. This gives a 12% performance improvement on test
blink_perf.css/FocusUpdate:

https://pinpoint-dot-chromeperf.appspot.com/job/15c3ea19740000

Bug: 814225
Change-Id: I0e00a7b31528db424f80cf89ec013751436ea88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500779
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637901}

Visual: https://screenshot.googleplex.com/tKWZLTSVCfv

Bug: 937331
Change-Id: Ife183ee3837820c3e9ba32b5c8e32a9cd17eb37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496307Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637900}

Since we need to load multiple kinds of protos, this CL adds a generic
storage interface and its implementation to load protobuffers from
leveldb and converts them to in-memory structs. Actual store will be
subclass of the generic store class, and implement proto entry
conversions.

TBR=peter@chromium.org

Bug: 930968
Change-Id: I9b87ad14aeecd321ff2eccd4c11350354aae9b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496527
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637899}

Workers are now sorted by target in the execution context selector

Bug: 848450
Change-Id: I90d3406befd880778fe04b61fa7b20fff679d6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502212
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637898}

This fixes problem where a malformed content URL is opened with chrome.
  * url::Parsed extracts scheme as a string preceding ':' to allow
    parsing URLs as scheme:target, scheme:\target, scheme://target
  * the IsContentURL() call checks explicitly for scheme://target

The crash can be triggered by supplying a content URL that is accepted
by url::Parsed, but not understood by GURL.

Bug: 882475

Change-Id: I64d15a827c2ff549843fa8857086b2c0f17ef641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503625Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#637897}

Based on logging (see earlier patchsets), it appears the existing data
base can cause the test update to be thrown out resulting in test
failures. It seems flakey whether the data base is persisted, so
purging it will likely fix many flakes.

Secondly, I am turning the tests off on chromeOS there are some dependencies
on file reads that seem to be flaky on ChromeOS, so it's easier to turn them
off.

Change-Id: I9535e7c6d855bdb7573a0c0e03868699dabcdf88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497368Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637896}

This reverts commit 6b8ca1f7.

Reason for revert: crbug/938162

Original change's description:
> device/fido/mac: add more specific check for TouchID availability
>
> Prior to macOS 10.13.2, the only way to check for TouchID was to check
> for the ability to evaluate the LAPolicyDeviceOwnerAuthenticationWithBiometrics
> policy. 10.13.2 introduced a more granular check for LABiometryTypeTouchID.
>
> This PR ensures on systems after macOS 10.13.2 that we check for this specific
> biometry, and fall back to to the old check if we do not have access to this new enum.
>
> R=​martinkr@google.com
>
> Bug: N/A
> Change-Id: I3a3d2d332547b09cf3c6e062709ed06b6e1a052d
> Reviewed-on: https://chromium-review.googlesource.com/c/1487811
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> Cr-Commit-Position: refs/heads/master@{#636651}

TBR=rsesek@chromium.org,martinkr@google.com,shelley.vohr@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 938162
Change-Id: Ieba6da8626b9021df029fc95a9345534a9a67d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504308
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#637895}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b56862dc292a..dd98a9a1520a


Created with:
  gclient setdep -r src-internal@dd98a9a1520a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:925042,chromium:932622
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: Iabe7ad3305157b55cf2b8cc002c3330328e1f1fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503941Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637894}

This is a contingency for the event that the annotation feature is
enabled but form saving is not.
* A new field hasUnsavedChanges is added to the save result, this
  is set when there are edits but form saving is not enabled.
* When this field is true, a dialog is shown to the user allowing
  a choice whether to continue to enter annotation mode or not.
* The annotation toggle event is made custom to avoid re-entrancy
  when entering anntation mode is aborted.

Bug: 902646
Change-Id: I885aa9ee76afb500a086097aed08422ececdf052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502255Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637893}

The script now assumes GN adds coverage flags to the cflags for each
source file. The script removes the flag if the file is in an exclusion
list, or if `--files-to-instrument` is set it will also remove flags if
the file is not listed in that argument.

The script supports multiple exclusion lists that can be selected with
the `--target-os` flag.

It's expected that GN will set these flags correctly and invoke the
script in all coverage builds. http://crrev.com/c/1496002 does that.


Bug: 918215
Change-Id: I4454f67067a083581f31a22cfef85368825789f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994
Commit-Queue: Sajjad Mirza <sajjadm@google.com>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637892}

Previously the input was physical pixels, so it scaled to DIP when not
using zoom-for-dsf. Now the input is DIP, so we must scale the other
way.

R=piman@chromium.org

Bug: 937602
Change-Id: If51e092ffe6e4e7e72da24315f6cc70b2330022a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504224Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637891}

I think we don't need this copy here introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1413214

Also this copy caused unnecessary build dependency serialization.

Bug: 937723
Change-Id: Ifa0e8466e83fbfe2278b880cb465b025fd22137e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498800Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637890}

Bug: 724491
Change-Id: I48c5e81f81a20a34974287cfbb67890f355db7a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497333Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Auto-Submit: Veranika Liaukevich <veranika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637889}

CrWinASanCov tests an old configuration, and ToTWinASanLibfuzzer is the
new configuration. Move it into the "Windows|ASan" category in place of
CrWinASanCov.

Also add ToTWinASanLibfuzzer to the luci.chromium.clang console. It
seems they are supposed to be in sync.

R=bpastene@chromium.org, hans@chromium.org, hinoka@chromium.org
NOTRY=True

Bug: 937465
Change-Id: Ib5d1389bb5dc06d85bdbae522603c42a4acf2d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497356
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637888}

All StreamSocket layers are now beneath the socket pools, so there's no
longer any reason for any of them to be on top of ClientSocketHandles
instead of other SocketStreams.

Bug: 472729
Change-Id: I1b0471c421181eee2c28388bc1b705011d0d3dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495596Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637887}

Replace deprecated RunLoop::QuitCurrentWhenIdleClosureDeprecated() for CloudPrintURLFetcher Unittest

This change replaces
base::RunLoop::QuitCurrentWhenIdleClosureDeprecated() call with a
call to loop.QuitWhenIdleClosure() call on a local RunLoop instance.

Bug: 922118
Change-Id: I44a545bde69b4558f97a29c0eeaafffdcae9420e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497177Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637886}

ComputePercentageLogicalHeight has the side-effect of calling
AddPercentHeightDescendant on the containing block; that is not great
when we just want to check if a size is definite, from
MainSizeIsDefiniteForPercentageResolution. Add a parameter to make it
optional.

Also change CrossAxisSizeIsDefinite over to this function. Here, we
do not have to worry about AddPercentHeightDescendant because we
will later resolve that size through normal mechanisms anyway.

Bug: 933931
Change-Id: Id44d15eb546c15bbdece99282550419eb0f8654e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492294
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637885}

https://skia.googlesource.com/skia.git/+log/2ca31f8de281..e6752606a395


git log 2ca31f8de281..e6752606a395 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 halcanary@google.com SkQP: from skqp_gn_args import SkqpGnArgs
2019-03-05 kjlubick@google.com [particles] Clean up build - remove test deps
2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b8cff9e9347c..55959b0bb19f (3 commits)
2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 7efede6c3d35..10736f2da359 (2 commits)
2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-03-05 reed@google.com array of unique verts
2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b7157d764389..7efede6c3d35 (1 commits)
2019-03-05 robertphillips@google.com Make SkImage_Base::asTextureProxyRef take a GrRecordingContext parameter
2019-03-05 bsalomon@google.com Distinguish between "flushed" and "finished" idle state callbacks on GrTexture.
2019-03-05 robertphillips@google.com Clean up logic in fontregen GM


Created with:
  gclient setdep -r src/third_party/skia@e6752606a395

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I6f61b5ec6def7cde12d3794a41137b3fec17eb52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504178Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637884}

arm_cpudetect.c is not included automatically.

BUG=aomedia:2294

Change-Id: Ia3cd70d050faed3ed88f94bb2b0f1e9eaf746a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502453Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#637883}

This an effort to support per frame encryption pattern.

1. Remove EncryptionScheme from mp2t.
2. Only ready EncryptionMode from CAT. The actual pattern is set in ES
parser.

Bug: 825041
Test: HLS stream, see per frame encryption pattern from log.
Change-Id: I6767937fd3ffd805c082852166b9fc7842ad2911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501334Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637882}

A small fix from CL
https://chromium-review.googlesource.com/c/chromium/src/+/1489416

Bug: 934525
Change-Id: Ied35119645b543678562248e2f4d533767b2ce41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504296Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637881}

Bug: 888733
Change-Id: I2b847b2a37f666a688336036f02ea08111f5f525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496523Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637880}

Reuse ByteString/ByteBuilder APIs for CT parsing and serialization.

Added boolean return arguments to EncodeTreeHeadSignature and
EncodeSignedCertificateTimestamp, and updated a couple of clients to check
return value and handle failure cases as appropriate.

Bug: 634570
Change-Id: Id309470e18d0bc7316623c2f5dd7aaf3854527cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1465984
Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637879}

These tests have now been moved and/or broken up into tests for the
elements actually responsible for the behaviors tested, with the
exception of presets and visiblity tests, which are validating the
behavior of print-preview-app itself. Move these tests into the
print_preview_app_test.js. Trim down PresetCopies and PresetDuplex
to test only behavior not already tested in other places, and combine
these two tests into one since they are both testing the same event
handler.

Change-Id: I1167776f437f60f7bd82c3407206331db84de86d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501999
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637878}

Clarify in a comment why the source is listed explicitly so future
readers are not tempted to remove it.

Bug: 933359
Test: none
Change-Id: I7f7b70bbe90853674e17c9a5b7ab5cc2016b2c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478877Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637877}

To fix following builders:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20cl.exe%20Goma%20Latest%20Client%20LocalOutputCache
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WinMSVC64%20Goma%20Latest%20Client

Change-Id: Ic6acb7b8a123165dcda0fc98d3c07c55bd7de38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498746
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637876}

The original name can easily be mistaken to imply the method only
applies to WebView, when it actually applies to all Android.

Use base::RandInt() to ensure a properly seeded generator is used.

Bug: 923475
Change-Id: I54a4165dca1cd723f304b16a95746adb08613d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503622Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637875}

Moving policy tests to new model_settings_policy_test.js, similar to
what was done with the availability tests, since almost all the logic
tested is in model.js.

Also adding 2 small tests verifying that the corresponding settings
sections disable their controls when the setting is set by policy.

Change-Id: Ife0563e517a002ddd29a3fa62031fcd7ec47136e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501948
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637874}

This is a reland of 86e7aa88

Revert was due to flaky test failures on MacOS 10.12.
The flakiness already existed before this CL.
The flaky test has been disabled.
https://chromium-review.googlesource.com/c/chromium/src/+/1501213

This reland is identical to the original attempt.

TBR=emircan@chromium.org, meacer@chromium.org

Original change's description:
> [Video Capture] Switch usage in Chromium Browser process to the new multi-client API
>
> The video capture service offers a new API for opening capture devices
> in a way that allows them to be shared by multiple clients. This CL
> switches one such client, i.e. the Chromium Browser process, over to
> that new API. This enables other clients to share access to capture
> devices with the Chromium Browser process.
>
> Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing
>
> Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.*
> Bug: 783442
> Change-Id: I9c236f03e315cdafdc07429f3213fa4d11b43b34
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1399454
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637405}

Bug: 783442
Change-Id: I7dca38334bc78e400daa311fa0444173add9548d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504230
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637873}

BUG=936080

Change-Id: Ic1b64913d0594841e7edb521aa0502235e1171fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498615
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637872}

This patch changes all VisiblePositionInFlatTree-typed local variables
into PositionInFlatTreeWithAffinity as a preparation to remove
unnecessary canonicalizations from SelectionController.

Bug: 657237
Change-Id: Ic5603a8fd090d3337c1eb58487e1a6ad1809ae6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501035Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637871}

Flake (https://analysis.chromium.org/p/chromium/flake-portal/flakes)
found the 4 web tests as flaky and may fail in all types (fail,
timeout, crash). Hence, this patch marks them so.

Bug: 894651
Tbr: xiaochengh@chromium.org
NoTry: True
Change-Id: I8dca99fef9c6babd173631259febe3b7af48c688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503942Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637870}