- 13 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c13ea848e6b5..fdd89469d681 2021-01-13 jzern@google.com update stale codereview.chromium.org links If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I41183926532ee2506b8072dbafddbfad4c7119c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842884}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/22eff1eb8c2f..7faa362ea9c2 2021-01-12 shrekshao@google.com Fix SamplerFilterAnisotropicTests mipmap 2021-01-12 dsinclair@chromium.org Convert WGSL comments to // If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic56b7d7ab7199e9e4e54348746cda08252c63eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626456Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610485069-629e2dfa0196177c8ad81665d7b0a927aebce730.profdata to chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If883530a91fd7799828ae6824d69cff7ad53a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626371Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d38b9f86ff8c..2ed9671a0ddd 2021-01-12 cnorthrop@google.com State: Provide reference to image unit binding vector 2021-01-12 jmadill@chromium.org Vulkan: Add YUV G8_B8_R8_3PLANE_420_UNORM format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Aztec Ruins MEC Change-Id: I4fe0c1c2a41b7105947fa8098cc12e9630118392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626093Reviewed-by:
-
Yuta Hijikata authored
This change renames deprecated macro IS_LACROS to IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I55fe9e33983a75f340d953b12c8c72d69b7eee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623733Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842880}
-
Theo Johnson-kanu authored
Screenshot: https://screenshot.googleplex.com/7sot2pkVRoKn5ci.png - Adds a new system tray icon - Adds icon as a button to system tray - No test where added because network_section_header.cc does not currently have a test. Test will be added in a subsequent CL Bug: 1163556 Change-Id: Ia965ec395b83f72b20350851a730f76a392f4669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622658Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#842879}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/002c03c4b6ed..2881d6b22d1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia1f472898714aae6b32bb322bf9cf2163ff4f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626359Reviewed-by:
-
Luciano Pacheco authored
Add JS modules for files in //ui/file_manager/file_manager/js/ui/ : - progress_center_panel.js - commandbutton.js - default_task_dialog.js - combobutton.js Bug: 1133186 Change-Id: I08267440b93e2c181a966824937f21db134be59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626669 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842877}
-
Jasmine Chen authored
Add entry to record the client type during OpenDevice(). This allows to determine the number of Chrome, Android camera users respectively. The client side CL is at crrev.com/c/2619449 2. emerge and deploy cros-camera 3. Verify that the metric is logged in chrome://histograms Bug: b/176787333 Test: 1. Build and deploy simple chrome. Change-Id: I8159eae088b83a99dba5657e04ac63e965d01f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621452Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#842876}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610474333-dd150f7e1f8853577c8d1e97bbf4737322a5d0b4.profdata to chrome-win64-master-1610495996-7189a1d14c9908600535ebce9352fe55a59722e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66965d7737f25a7fa9edc7a2bb59edb67d1980bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626455Reviewed-by:
-
Nancy Wang authored
AppService creates standard circle icons for all apps. However, there are a few cases that icons on shelf are not app icons, e.g.: 1. Task manager 2. A few extensions show icons when open a new window, e.g. google hangouts. This CL create standard circle icons for them when they are shown on shelf. Modify TaskManagerView to create standard icon when running in Chrome OS. Modify ChromeLauncherController::OnAppImageUpdated. If the icon is not loaded by AppServiceAppIconLoader (which loads the standard circle icons), create standard icons. BUG=1162514 BUG=1142373 Change-Id: Ibfe40c33944a1120ca9c991c4953d0da906ee2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624273 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Peter Kasting authored
If we pass a View* through a void*, we need to cast to View* on the other side before any casting to a View subclass, or the pointer will not be fixed up correctly. In this case, we can just pass as a View* directly, avoiding the void*, and the cast-to-derived Just Works. Found this while trying to add metadata to OmniboxViewViews, which inherits from views::Textfield but does not have that as the first base class. Bug: none Change-Id: I5abc3efc3abbbe470ab23b3579984767f9e51b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625752 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#842873}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Icfc56e5ea80edf8434748822d93c5f6c91922d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626768Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842872}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.86. R=rmhasan@google.com Bug: 1041619 Change-Id: I0120a8122986353bf85cf29319b623ad05fe9a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626372 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#842871}
-
Mike Jackson authored
This change extends support for running a PWA at OS login to MacOS. iOS is not supported with this change. The change adds MacOS to the support about:flags page, allowing users to control at both installation time, and from chrome://apps page if an application can run at login. Tested: Manually on MacOS 11.0 - Install extension from chrome/test/data/extensions/background_app/ - Chromium should be set to run at login for user - Remove extension - chromium should no longer be set to run at login Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I28a96de60479b6bf1627d6b0e39ef603f52d5658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521233 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
With this CL, most of Cros API starts to support multiple receivers. AshChromeService and LacrosChromeService are exceptions. Bug: 1148448 Test: Build and run Lacros on a DUT. Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#842869}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8149a9615c1b..c13ea848e6b5 2021-01-13 mandy.chen@microsoft.com Change to slash separator to fix a bug on Windows in owners.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I6ee75e49be9f11f97db6e84649b2dd3ab97ede65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626629Reviewed-by:
-
Rayan Kanso authored
Bug: 1125665 Change-Id: I0f3b9de05eb1b5f78912637d22836501a61d0057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624652 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842867}
-
Carlos IL authored
Bug: 1105210 Change-Id: If66e6ade4aefe2f147352093afe5ecc0eee074fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626110 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#842866}
-
Dominick Ng authored
Apps that are hidden in the launcher, but still able to be launched should be able to be shown in the shelf. One example of this is the four Android apps explicitly hidden from the launcher: Android Settings, Android Files, Android Contacts, and Android Clock. If the user manages to launch one of these (e.g. through Chrome OS settings or via Play Store), they should be pinnable on the Shelf. Currently, this doesn't work as the ARC publisher prevents apps which are hidden from the launcher from being shown in the shelf. Practically, this manifests as an inability to persist the pin state for these four apps. That is, the apps can be pinned, but logging out and logging back in loses the pin state. This CL addresses the bug by always allowing ARC apps to be shown in the shelf, independent of whether they are present in the launcher. This should only affect the four apps listed as they were the only four Android apps where the show_in_shelf value was false. A test is added to verify the behaviour - the test fails before this CL. BUG=1124865 Change-Id: Ie4ac89a929396e7ee4a40efd9386d4af00b532db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623610 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842865}
-
Callistus authored
Bug: b/170162419 Change-Id: I862f02fa7949d3c1e06b83c2389ddc63273f2188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617406 Commit-Queue: Callistus Tan <callistus@google.com> Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
-
Hayato Ito authored
It would be better to clarify an expected behavior how CORS behaves for WebBundle subresource loading in the current implementation. Note that - The expected behavior is a tentative decision, which might change in the future. The spec side issue is https://github.com/WICG/webpackage/issues/609. - A |crossorigin| attribute is not supported yet. BUG=1149816 Change-Id: Ic104ec039a07f864b6a60452ff42f2ec09a03c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617167Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842863}
-
Joel Riley authored
Based on feedback from UI review. Bug: 1165820 Change-Id: Ia8c40899676038a15a2a462696ea30be9167013b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625393 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
-
Bartek Nowierski authored
If GigaCage isn't enabled, this DCHECK will get triggered: {FreeNoHooksImmediate,PartitionAllocFreeForRefCounting}-> ->PartitionRefCountPointer->DCheckGetSlotOffsetIsZero-> ->PartitionAllocGetSlotOffset-> ->DCheckIfManagedByPartitionAllocNormalBuckets GigaCage isn't needed to set up PartitionRefCount. It's only needed to easily detect from BackupRefPtr code if PartitionRefCount is available, but this won't be an issue because BackupRefPtr is disabled when GigaCage isn't needed. Bug: 1073933 Change-Id: I78faea9427ca06643033d0025cdef6472131c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621855 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842861}
-
Yuki Shiino authored
This reverts commit 854d530c. Reason for revert: Suspicious about causing a test failure of SimpleURLLoaderTest.OnUploadProgressCallback specific to Fuchsia. https://ci.chromium.org/ui/p/chromium/builders/ci/Fuchsia%20ARM64/113096/overview Original change's description: > Roll Fuchsia SDK from 0.20210111.3.1 to 0.20210112.3.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast > Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com > Change-Id: I7d83d8a9d4fdfc9015e1b371fc4635b709fca37b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625688 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#842792} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I8c106070941443e3f25aeecb2b1acad73b4c80b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626694Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842860}
-
Yuta Hijikata authored
This change renames deprecated macro IS_LACROS to IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I68d71be23b2edc2eb1e005e585df938a921a4394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622690Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842859}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610474333-25cc4688b5885ba387e87620f7adfe156a967401.profdata to chrome-linux-master-1610495996-ac73e18e1b2efb1cd1bfbf2a2aaf90e9e3476b5a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id7f454e615fe5cd0425be3ddbce9053b6240f3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626452Reviewed-by:
-
Brandon Jones authored
Logs a deprecation warning to the console if the .type value is set for any given entry, but otherwise defers to Dawn for all disambiguation between the old and new syntax and related errors. Bug: 1165629 Change-Id: I547b622f3634e6a7e7fa26c51d4462ea840fb8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625810 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842857}
-
Fergus Dall authored
vmc needs a way to tell where to look for the termina image. Bug: 1128743 Change-Id: Iad8054ead04282f8a9861ddff71fa7528e6bba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622353 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#842856}
-
Michael Ludwig authored
Skia is consolidating its image filter classes into a single header of factory functions so that it can hide the per-filter implementation classes. These new factory functions have standardized on core skia enums instead of bespoke enums: 1. SkBlurImageFilter::TileMode and SkMatrixConvolutionImageFilter::TileMode are replaced with SkTileMode. 2. SkDisplacementMapEffect::ChannelSelectorType is replaced with SkColorChannel. 3. SkDropShadowImageFilter::ShadowMode will be removed from Skia, so has to be defined in PaintFilter. Additionally, SkImageFilter::CropRect (an SkRect + edge flags) is deprecated for removal (the edge flags are complex and no longer utilized by Blink's SVG rendering). It is simplified to just SkRect. This CL updates the public declarations of PaintFilters to use the appropriate new enums and crop rect type, and then updates the filter effects that wrap PaintFilters. A follow-up CL will update the paint filter implementations to actually use the new Skia image filter APIs. Bug: skia:9310 Change-Id: I85ac1199ad0ee038c7f5cb5cef716d7cd264965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527768Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#842855}
-
Hirokazu Honda authored
This CL addresses unresolved comments in crrev.com/c/2440230 and crrev.com/c/2440231. Bug: b:175895248 Test: video.DecodeCompliance.av1_test_vectors Change-Id: I5e7416da300f104fc73ed7112f99e31fd056956f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612678Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842854}
-
Andrew Xu authored
This CL records how many times the multipaste menu shows through the accelerator, render view's context menu and textfield's context menu respectively. Bug: 1164439 Change-Id: I7a9f8ab1efd21de951d353ae596536d44bb4ee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618540Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842853}
-
Hirokazu Honda authored
AV1Decoder checks if there is a new sequence header by basically finding a new sequence header in parsed OBU headers. libgav1::ObuParser provides sequence_header_changed() interface. This CL replaces AV1Decoder's check with a usage of libgav1's interface. Bug: b:175886969 Test: video.DecodeCompliance.av1_test_vectors Change-Id: Idb185a043adaedfaf0a36c754459a5017a44bf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612664 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is mainly for isolate cas upload optimization in https://crrev.com/c/2612794 Bug: 1157476 Change-Id: I9d1fe45388271fceb6485349f67c8de168faa2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626668Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#842851}
-
Shimi Zhang authored
This reverts commit 4a6ccde5. Reason for revert: Caused b/176427193, will have another change to resolve the strict mode violation. Original change's description: > Android: Fix StrictMode violation on Smart Selection icon loading > > We are calling Icon#loadDrawable on the UI thread previously, based on > the Android doc, we should use Icon#loadDrawableAsync instead. > > Previously, this is not enforced, but now we encountered a StrictMode > violation for this. > > Since now we are calling Icon#loadDrawableAsync, we need to pre-warm the > Drawable before we show the popup menu, otherwise the icon will be set > after the popup menu showed for the first time. > > Bug: 1129211 > Change-Id: Iac5127a307d1d2d124a4b2debb7b021a2be2da75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562059 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831948} TBR=boliu@chromium.org,torne@chromium.org,ctzsm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1129211 Change-Id: I6335c8eeec4b08b190a97fbea73eefc20fd280d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626195Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#842850}
-
Fergal Daly authored
It is only used for main frames: - the initial main frame of a WebContents. https://crrev.com/c/2617521/4 is a CQ run with an extra DCHECK to demonstrate this. - main frames that are being resurrected for javascript: URLs. Bug: 1161170 Change-Id: I49c60cae2c6be54a7b87b991dd77653ddfdc1006 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617521 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842849}
-
Arthur Eubanks authored
Bug: 1163310 Change-Id: Ie1132d7a288c39e324df4fc74187c2e144c85fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625777Reviewed-by:
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/1d3f901aa016..93b1b332cd60 $ git log 1d3f901aa..93b1b332c --date=short --no-merges --format='%ad %ae %s' 2021-01-12 fbarchard NV12 Bilinear upsampling bug fix Reenable InterpolateRow_AVX2 Created with: roll-dep src/third_party/libyuv Bug: libyuv:838, b/68638384, b/176195584 Change-Id: Ie25b5c77184085f48d3691e5b03dde692ce601a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625776Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842847}
-
Javier Fernández García-Boente authored
In r837379 we landed support for this feature in LayoutNG. This CL implements the feature for Legacy layout. Bug: 1155633 Change-Id: I2b974daad7a98d26fdc4d4468572840e30be5cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598843 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842846}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610474333-6e9ea86fde1168dfc05bd82ef581aacfe157db52.profdata to chrome-mac-master-1610495996-38f3d5c57ab4be3d52eaefe38d45ce16ec0addd8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f437e77504e02d63397aedb85313d017ad272f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625835Reviewed-by:
-
