- 16 Jul, 2020 25 commits
-
-
Andrew Xu authored
This CL ensures that the navigation widget's size constant to reduce repaints during transition between home launcher and in-app shelf. In order to show the correct appearance of navigation widget, a clip layer is applied in tablet mode. Bug: 1097807 Change-Id: I43f2460ac32cf3e6804fcf60de0f1b7ce3b46771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788822}
-
Scott Little authored
This CL updates the default distance-from-viewport loading thresholds used when determining when to start loading-in images and iframes that were deferred either by being marked with "loading=lazy" or by automatic lazy loading (which is currently specific to Lite Mode users on Android Chrome). These thresholds were determined by running experiments to tune them, and may be updated further in the future if better values are found (e.g. in response to new optimizations/improvements to lazy loading). Bug: 989246, 1005490 Change-Id: I949be351947f200ace68ef9916bb8afa1006e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159529 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#788821}
-
Jesse Schettler authored
The Document Scan API is only supported on Chrome OS, so ensure it is only built on Chrome OS. Additionally, remove the unnecessary DocumentScanInterface layer now that there doesn't have to be interface implementations for Chrome OS and non-Chrome OS builds. Bug: None Test: Perform a scan using the Scan extension Change-Id: Ie18d15cac752e9166be6ee538cae3a7e3c8fe4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296642 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788820}
-
Justin Cohen authored
Change-Id: I04d5a1c1d499109d73947fb5833fe1ad70249178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295225 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788819}
-
Alexander Cooper authored
Converts the SessionRestore::CallbackList to a RepeatingCallbackList and converts the Registration method to take a RepeatingCallback, due to usage. Converts quit_closure_for_sync_restore_ into a OnceClosure. Converts a bind in tab_loader whose receiving end had previously been converted. Also converts one session restore notification registration in chrome_browser_main_posix to base::BindRepeating, as part of ongoing efforts to convert the top-level chrome/browser files. Bug: 1007635 Change-Id: I5034a3f801e162f987becdbe9c64073a905bac5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300604 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#788818}
-
Lan Wei authored
Avoid testRunner.eventSender in paint/invalidation/table/ table-overflow-scroll-in-overflow-scroll-scrolled.html. Bug: 1047176 Change-Id: I0e9d6d35c1b5033f6c084867a23eeb1b6da1fe1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298115 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788817}
-
Gang Wu authored
This is a reland of be1e9636 Update the test to run on UI thread. Original change's description: > [Omnibox] Use ActivityState to check if we are in browser mode > > > In multi windows mode, check if we are in browser mode by WindowAndroid > is not working, should check ActivityState instead. > > Bug: 1102640 > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786636} Bug: 1102640 Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788816}
-
Xianzhu Wang authored
This allows us to calculate visual rect during painting for each display item, instead of calculating FragmentData::VisualRect() during PrePaint. Bug: 1104064 Change-Id: I80646991142c7407f921b92dde83123f745b4cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296485 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#788815}
-
Alan Cutter authored
This CL stores the background_color manifest field in the WebApp database for use by experimental tabbed web app windows. This CL has no user visible changes. Bug: 1104083 Change-Id: I69ad67c17b61161e721a4639340187550e0644b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291515Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788814}
-
Vincent Boisselle authored
We are planning on keeping that metric for a while to detect regressions in the feed. Bug: 1104930d Change-Id: Ibfdf3bf5dd9242dbeb476e0de67196ea6e9e4c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295949 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#788813}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1a82e68482aa..ddc86ef759d8 2020-07-15 fmayer@google.com Merge "In-tree build of static heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8cdb00e31e64f53a0748bccf3910947788457ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300719Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788812}
-
nancylingwang authored
Similar to the CL:2271958, modify the load icon interface for the intent picker, to load the new standard icons. Design doc: go/appservice-adaptive-icon BUG=1083331 Change-Id: Ie6b047961cd0a402595d30d734c33325a1e6f9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299684Reviewed-by:
-
Erik Chen authored
lacros-chrome is allowed to make synchronous mojo IPC calls to ash-chrome. To avoid deadlocks, the sequence responsible for handling lacros-chrome mojo IPC must never block. Prior to this CL, the class LacrosChromeServiceImpl was affine to the main-thread, which could and did block. See bug for a concrete example of a deadlock. This CL create a new private class LacrosChromeServiceNeverBlockingState. This class is affine to a never-blocking sequence. Most state has been moved from LacrosChromeServiceImpl to the private class. The exception is the public endpoint mojo::Remote<crosapi::mojom::SelectFile>, which is affine to the main thread. Bug: 1103765 Change-Id: I462311f7b2b68db5eeaab799a83d2bb6391dc575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293011 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788810}
-
Kristi Park authored
TBR=donnd@chromium.org Bug: 1105488 Change-Id: I342bd468a30caf5ff0da6779b969accc8e16bb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300829Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#788809}
-
Matt Menke authored
ur_request.h transitively includes a number of files that are not often included in headers - primarily net/net_buildflags.h, no_destructor.h, and command_line.h. url_request.h is also included in a number of the network service's traits files, which are used throughout a large potion of the code base. As a result, a lot of files are depending on those header files without including them. This CL fixes all of those include issues. In a followup CL, I'll remove the url_request.h includes from the traits files, which should help prevent this from happening again. It will also drastically cut the number of files that have to be rebuilt when modifying url_request.h, and may speed up builds times modestly. Bug: 110378, 1104380 Change-Id: I920acd605ce86d15ed604476c52513b38cdf7a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293078 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#788808}
-
John Williams authored
- Changed {,Cast,Mirroring}ActivityRecord to {Cast,App,Mirroring}ActivityRecord. - Removed "Record" suffix from names. - Updated all related names. Change-Id: I47326cd87820ad32d166c3f7a51c3dcf989f9065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288478 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#788807}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/212c5bd9b2f0..82961129b054 2020-07-15 kainino@chromium.org Use canned CheckPatchFormatted instead of our own linting 2020-07-15 tommek@google.com Adding TextureZeroInitTests for WriteTexture 2020-07-15 kainino@chromium.org Add .clang-format files and format more files 2020-07-15 natlee@microsoft.com [D3D12] Add DXGIAdapter to AdapterDiscoveryOptions 2020-07-15 tommek@google.com Implementing Queue::WriteTexture in Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036711 Tbr: cwallez@google.com Change-Id: Ia103d1efcc9ad2ced809d3a712a5d03293f99756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300862Reviewed-by:
-
Christoph Schwering authored
This CL makes Autofill not fill fields whose fields have been user-edited, except if their value is empty and the initial value is empty as well. The rationale behind the exception is that if the user removed a non-empty field value, Autofill should honour this. There is an issue with TriggerRefill() causing fills with FormData with empty values. These FormDatas are the result of cached FormStructures converted back to FormData. This is addressed in a follow-up CL. Bug: 966873, 949094, 1075533 Change-Id: I7ab80dfa6edc85bf00b16ef5e99e777d032a9b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289410Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#788805}
-
Jun Kokatsu authored
Link tag modification that was moved down to body tag in crrev.com/c/2239707, which caused a blink when opening incognito NTP. This change move the code on top of head tag so that the blink won't happen. Bug: 1105744 Change-Id: I1bfb583208767e86058f77fd1757e4bd2eaad26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300278 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788804}
-
Christopher Cameron authored
Specify a 0.005-1,000 nit luminance by default. This is a temporary measure in two ways: - We should plumb this through video and the compositor, and thereby get the correct values. - The default tonemapping affects the SDR range, which is undesirable. We should roll our own tonemapping that doesn't have this property. This will make HDR look less washed out on barely-HDR-capable monitors, such as the built-in Macbook Pro screens. Bug: 1101041 Change-Id: I4db344d35f5259dbeb4191e4901e9798882a06d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300979Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifc93d758802005dd99de07e254d2f81f159cd735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300819Reviewed-by:
-
Yue Zhang authored
http://crrev.com/c/2119188 exposes two bugs in the setup introduced in http://crrev.com/c/2143671, which jointly lead to a corner case where the dialog animation is not setup correctly. This CL fixes this issue by 1) restoring dialog view size and position after animation 2) restoring the animation view alpha in the correct position. This CL also revives a disabled test that could have caught this issue by removing the flaky parts and add some bug-specific checkings. Bug: 1075677, 1099563 Change-Id: Ie722d77f806dd556f69cb2df6b758500739cdc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278923Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788801}
-
Orin Jaworski authored
Now that the submatch mechanism is eliminated, this CL removes several related functions and collapses logic at call sites. The flag omnibox-tab-switch-suggestions-dedicated-row is also removed because the omnibox-tab-switch-suggestions and omnibox-suggestion-button-row flags are sufficient, and there are no dedicated tab switch suggestions. Bug: 1102619 Change-Id: Iaa0b86601b1968a182af74b5478ec8bc312d8bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300627Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788800}
-
Siye Liu authored
Some IMEs may start and complete composition within same edit session. Therefore, we should still fire composition events at the moment where we commit the text to blink. This change also contains several refactors: 1. Refactor code in |CommitTextAndEndCompositionIfAny|. 2. Moves logic to set |new_text_inserted_| from |TSFTextStore::SetText| to |TSFTextStore::InsertTextAtSelection| since IMEs may directly invoke the latter method. We need to correctly set the |new_text_inserted_| flag in order to push text states to blink. 3. |TSFTextStore::InsertTextAtSelection| may be called several times in single edit session. Therefore, we need to aggregate all replacement ranges into single |replace_text_range_|. 4. In |TSFTextStore::RequestLock|, we should also reset all caches such as |new_text_inserted_| even when the function early returns. 5. In |TSFTextStore::RequestLock|, use the replace text end pos instead of the cached |composition_start_| as the |new_composition_start|. Bug: 1099125 Change-Id: Ibfa2ff284a183939596d9ea2a5e7105e8139b099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274245Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788799}
-
Martin Kreichgauer authored
WebAuthn GetAssertion requests originating from the cryptotoken extension, which implements Chrome's U2F API, currently may result in a CTAP2 request if the selected authenticator supports CTAP2. This hasn't really caused issues in the past: Lenient authenticators accept an appId as the makeCredential request's rp_id parameter and let us challenge the U2F credential that way. Or if the authenticator indicates over CTAP2 that the credential doesn't exist, GetAssertionTask would then automatically retry over the U2F interface based on the presence of the appId extension. Responses for both cases are equivalent. But sending CTAP2 GetAssertion requests in order to respond to a request to the U2F API is unexpected and inefficient. It may also cause issues with future authenticators that decide to treat user verification as non-optional for all requests arriving on the CTAP2 interface. Instead, change GetAssertionTask to never try its CTAP2 path for these requests. Bug: 1099782 Change-Id: Ice54122bf3b9f63814d594074a39b9b46279ded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298541 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#788798}
-
- 15 Jul, 2020 15 commits
-
-
Andrew Grieve authored
Mostly left instances in feed since that will probably go away one day anyways. TBR=agrieve Bug: 1041930 Change-Id: I8191fe4f9b90f5eee2c46bfe2e5923fddf40bf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298040Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788797}
-
yilkal authored
This cl renames kEnableSecondaryAccountsForChildExperiment feature flag to kEnableSecondaryAccountsForChild. This is because the flag is now being used for a feature. Bug: 1101622 Change-Id: I981cd16fc0a9fa0ce993221f77c4eab7f7838f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300635 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#788796}
-
Peter Wen authored
Rather than using direct deps for javac compilation, use it only for turbine header compilation. The javac compilation process requires many potential transitive deps that will take a more comprehensive approach, perhaps similar to bazel's reduced java classpath. Turbine using direct deps would only affect annotation processors. In particular, possibly Dagger. Building chrome_java with only turbine's direct deps seems to have worked, but only removing more of the dirs in the allowlist can determine if this works for the entire codebase. Bug: 1092528 Change-Id: Ifc745d269ce8850a6c675458fcff25c46ca39937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299531 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL turns AutofillAgent::submitted_forms_ from a std::set<FormData> with custom comparator into a set of renderer IDs. The sole purpose of this set is to avoid duplicate submission events per form. Unique renderer IDs suffice for this. And since the comparator used before this CL was generally not sound (false positives), this at least theoretically solves some missing form-submission bugs. Bug: 896689, 1007974 Change-Id: I8fab1ee692c26c26b2cc061b0045b9757820b553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297527Reviewed-by:
-
Sushma Venkatesh Reddy authored
iHD v20.1.1 is unable to support Y800 format on gen 12 devices yet - https://github.com/intel/media-driver/issues/941. As we only care about NV12 and I420 images currently, this workaround should be acceptable. Bug: b:159896972 Test: On TGL tast run <IP_ADDR> graphics.VAAPIUnittest.jpeg_decoder Signed-off-by:
Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com> Change-Id: Ic26f57f547b0a127c40cbe2a007068e57243feae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294345Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788793}
-
Allen Webb authored
The system logs command to retrieve a list of system files is broken by a seccomp violation and is leading to crashes. Since it has been broken for a while and there haven't been complaints about the missing data, this change removes the broken command. Bug: 1021425 Change-Id: Ia8c5ab094bd1e97bb2996d31c458a00657c8b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298707 Auto-Submit: Allen Webb <allenwebb@google.com> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#788792}
-
Peter Kasting authored
Whether operator/() does integer or floating-point division is not necessarily obvious to the reader (and will hopefully be changing in the future). Where it's at least as simple to get the same result without using it, do so. In many cases the code was effectively snapping to a multiple of some time, which can be done in a shorter form using operator%(). Bug: 1104532 Change-Id: Id6614bfa91636bcf14568bb05212354b5a68c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296859 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#788791}
-
Nina Satragno authored
This is a reland of 98450e6f The original change uncovered a bug by changing the timing of requests. If <cr-lottie> was detached while the animation request was in-flight, the worker would be terminated but the onreadystatus change callback would still fire and try to send a message to the terminated worker. Fix this by aborting the request when detaching. The reland also fixes a similar racy issue when changing the animation URL. If the URL changes before the first one had a chance to load, then whichever request comes last would be the one shown. This fixes that issue by cancelling the first request before starting the new one. Added tests for both issues. Bug: 1104105 Original change's description: > [webauthn] Port fingerprint enrollment assets to lottie > > Replace the fingerprint enrollment APNGs on the webauthn fingerprint > enrollment page by lottie versions. This shaves ~200kb and adds a > transparent background to the fingerprint animation that partially fixes > issue 1041877. > > Also, add "hidden" and "singleLoop" attributes to lottie to match the > APNG img tag behaviour; and update the wrapper to allow dynamically > loading another animation into the same element. > > Finally, this updates the settings UI worker CSP to allow the lottie > worker. > > Fixed: 1082312 > Change-Id: I0c92663ec6e1bfd76c03f995b6e96d210f26173f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116557 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786933} Change-Id: I6686e11295d7c0154659ae5c97cdf1cb773344f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290847Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#788790}
-
Renjie Tang authored
Change-Id: Ifee5f2ad4c323e3ca2d3e3ad289e7888e93c81d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300630 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788789}
-
Kyle Milka authored
Wrap the contents of the share tab (QrCode + Download button) in a scroll view so everything can be seen on smaller devices. Bug: 1105809 Change-Id: Iba3b85c5a6ef31beb24bb080a7b12942298a79cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300232Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#788788}
-
Dana Fried authored
Before the separator was rendered as a border, which had all sorts of odd interactions with the focus ring (including being rendered at the wrong time, causing it to not refresh immediately after the focus ring disappears - see associated bug). Now it is rendered as part of the background, which means it is behind all other elements. This provides the same effect with less code and is robust to focus ring changes. Bug: 1049546 Change-Id: I472067bd28569fac8ef00a6d6b6335d5935b6e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294342Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788787}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I86d163536815e90517099286f247fafe9dcea1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300722Reviewed-by:
-
Kristi Park authored
Multiple flakes in linux-chromeos-chrome (e.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7058) TBR=reillyg@chromium.org Bug: 1069695 Change-Id: Ib783ef93bbb2d005aa6f49446343f6786bd89a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300663 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Add STACK_ALLOCATED to LayoutObject referencing structs in anticipation of oilpanization of LayoutObjects. Bug: 1030176 Change-Id: I81bc2a6db7b6ce891885ed106311299dd6c26b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298884Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788784}
-
Eliot Courtney authored
Previous code may pass nullptr if cached_promise_texture_ already exists. This CL also explicitly checks GrContextIsGL rather than !GrContextIsMetal. Bug: 1105698 Test: Youtube works in lacros chrome Change-Id: I19c468d8d007f0156e85996fd5b43cd13e9e6e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299680 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788783}
-
